• Kristofer Pettersson's avatar
    Bug#38692 concurrent inserts cause valgrind errors in Query_cache::invalidate · 85ca9837
    Kristofer Pettersson authored
    Concurrent inserts produce valgrind error messages.
    The reason is that the query cache is invalidated after the target table object
    is closed.
    
    Since the delayed insert thread already takes care of invalidating the query
    cache there is no need to try to synchronize an extra cache invalidation call.
    
    The fix is to remove the query_cache_invalidate3 call altogether.
    
    sql/sql_insert.cc:
      When end_delayed_insert is called, the table_list items will be invalidated
      by the concurrent insert thread. Further more there is no need to call
      query_cache_invalidate here since the delayed insert thread takes care of
      this already.
    85ca9837
sql_insert.cc 122 KB