• Davi Arnaut's avatar
    Bug#53445: Build with -Wall and fix warnings that it generates · 93fb8bb2
    Davi Arnaut authored
    Apart strict-aliasing warnings, fix the remaining warnings
    generated by GCC 4.4.4 -Wall and -Wextra flags.
    
    One major source of warnings was the in-house function my_bcmp
    which (unconventionally) took pointers to unsigned characters
    as the byte sequences to be compared. Since my_bcmp and bcmp
    are deprecated functions whose only difference with memcmp is
    the return value, every use of the function is replaced with
    memcmp as the special return value wasn't actually being used
    by any caller.
    
    There were also various other warnings, mostly due to type
    mismatches, missing return values, missing prototypes, dead
    code (unreachable) and ignored return values.
    93fb8bb2
Makefile.shared 4.73 KB