• Sergey Petrunya's avatar
    MWL#36: Add a mysqlbinlog option to change the used database · b027072e
    Sergey Petrunya authored
    - Review fixes
    
    client/Makefile.am:
      - Make it build on Linux
    client/mysqlbinlog.cc:
      - Coding style fixes
      - Better/more comments
      - Use client/sql_string.*, not server's sql/sql_string.*.
      - Don't declare a dummy TABLE_LIST structure in the client.
    client/sql_string.h:
      - Use client/sql_string.*, not server's sql/sql_string.*.
    sql/log_event.cc:
      = Fix coding style
      = Introduce Log_event::event_owns_temp_buf which tells whether Log_event::temp_buf is 'owned' by the Log_event object and should be my_free'd on return. 
      This is needed because rewrite_db() needs to dispose of the buffer, and 
      - when mysqlbinlog is reading directly from binlog file, the buffer 
        should be freed
      - when mysqlbinlog is reading from a server, the buffer is a part of network
        buffer and shouldn't be freed.
    sql/log_event.h:
      Introduce Log_event::event_owns_temp_buf which tells whether Log_event::temp_buf is 'owned' by the Log_event object and should be my_free'd on return. 
      This is needed because rewrite_db() needs to dispose of the buffer, and 
      - when mysqlbinlog is reading directly from binlog file, the buffer 
        should be freed
      - when mysqlbinlog is reading from a server, the buffer is a part of network
        buffer and shouldn't be freed.
    sql/mysqld.cc:
      - Better/more comments
    sql/rpl_filter.cc:
      - #ifdef-out Rpl_filter::tables_ok from the client. This allows not 
        to define dummy TABLE_LIST on the client
    sql/rpl_filter.h:
      - #ifdef-out Rpl_filter::tables_ok from the client. This allows not 
        to define dummy TABLE_LIST on the client
    sql/sql_string.cc:
      - Use client/sql_string.*, not server's sql/sql_string.*.
    sql/sql_string.h:
      - Use client/sql_string.*, not server's sql/sql_string.*.
    b027072e
sql_string.h 10.3 KB