• Praveenkumar Hulakund's avatar
    Bug#14757009: WHEN THE GENERAL_LOG IS A SOCKET AND THE READER · cd4fb2ae
    Praveenkumar Hulakund authored
                  GOES AWAY, MYSQL QUITS WORKING.
    
    Analysis:
    -----------------
    Issue in this bug and in bug 11907705 is, the socket file or
    fifo file is set for general log at command line while starting
    the server. But currently, only regular file can be set for the 
    general log. Instead of reporting any error, the provided files
    are opened for writing and continued. Because of this issues
    mentioned in the bug reports are seen.
    
    As mentioned, only when any non-regular file is set for general
    log at command line while starting the server, these issues are
    seen. If general log file is set to non-regular file from CLI
    using system variable general_log_file then error is reported.
    
    These issues can also be faced with slow query log file, if it is
    set to non-regular file.
    
    Fix:
    -----------------
    Currently while starting the server if we fail to open log file
    then we report an error, disable logging to file and continue.
    To fix issue reported code is modified to check whether file
    is regular file or not before opening it. If file is not a 
    regular file then error is logged to error log and logging to 
    file is disabled.
    cd4fb2ae
log_errchk.test 2.1 KB