• unknown's avatar
    Bug#18775 - Temporary table from alter table visible to other threads · ef976d20
    unknown authored
    Continued implementation of WL#1324 (table name to filename encoding)
    
    The intermediate (not temporary) files of the new table
    during ALTER TABLE was visible for SHOW TABLES. These
    intermediate files are copies of the original table with
    the changes done by ALTER TABLE. After all the data is
    copied over from the original table, these files are renamed 
    to the original tables file names. So they are not temporary 
    files. They persist after ALTER TABLE, but just with another 
    name.
    
    In 5.0 the intermediate files are invisible for SHOW TABLES
    because all file names beginning with "#sql" were suppressed.
    
    This failed since 5.1.6 because even temporary table names were
    converted when making file names from them. The prefix became
    converted to "@0023sql". Converting the prefix during SHOW TABLES
    would suppress the listing of user tables that start with "#sql".
    
    The solution of the problem is to continue the implementation of
    the table name to file name conversion feature. One requirement
    is to suppress the conversion for temporary table names.
    
    This change is straightforward for real temporary tables as there
    is a function that creates temporary file names.
    
    But the generated path names are located in TMPDIR and have no
    relation to the internal table name. This cannot be used for
    ALTER TABLE. Its intermediate files need to be in the same
    directory as the old table files. And it is necessary to be
    able to deduce the same path from the same table name repeatedly.
    
    Consequently the intermediate table files must be handled like normal
    tables. Their internal names shall start with tmp_file_prefix
    (#sql) and they shall not be converted like normal table names.
    
    I added a flags parameter to all relevant functions that are
    called from ALTER TABLE. It is used to suppress the conversion
    for the intermediate table files.
    
    The outcome is that the suppression of #sql in SHOW TABLES
    works again. It does not suppress user tables as these are
    converted to @0023sql on file level.
    
    This patch does also fix ALTER TABLE ... RENAME, which could not 
    rename a table with non-ASCII characters in its name.
    
    It does also fix the problem that a user could create a table like
    `#sql-xxxx-yyyy`, where xxxx is mysqld's pid and yyyy is the thread
    ID of some other thread, which prevented this thread from running 
    ALTER TABLE.
    
    Some of the above problems are mentioned in Bug 1405, which can
    be closed with this patch.
    
    This patch does also contain some minor fixes for other forgotten
    conversions. Still known problems are reported as bugs 21370,
    21373, and 21387.
    
    
    mysql-test/r/alter_table.result:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added test results.
    mysql-test/r/backup.result:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added test results.
    mysql-test/r/repair.result:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added test results.
    mysql-test/t/alter_table.test:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added test cases.
    mysql-test/t/backup.test:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added test cases.
    mysql-test/t/repair.test:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added a test case.
    sql/ha_myisam.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added missing table name mapping calls to backup() and restore().
    sql/ha_myisammrg.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/ha_ndbcluster.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/ha_ndbcluster_binlog.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/ha_ndbcluster_binlog.h:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Removed unnecessary check for wrong temp file prefix.
    sql/mysql_priv.h:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Extended quick_rm_table(), mysql_rename_table(), and
      build_table_filename() by an flags argument, which can indicate
      temporary table names that should not be converted.
      Added symbolic flag values.
    sql/sql_acl.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_base.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Fixed a comment.
      Added DBUG calls.
    sql/sql_db.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_delete.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_insert.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_partition.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_rename.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_show.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Reverted the former fix for this bug. tmp_file_prefix is now used
      verbatim in the comparison of file names.
    sql/sql_table.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added a check for a tmp_file_prefix file name to
      filename_to_tablename(). These names are now accepted without
      conversion.
      Extended quick_rm_table(), mysql_rename_table(), and
      build_table_filename() by an flags argument, which can indicate
      temporary table names that should not be converted.
      Removed the table to file name conversion from
      build_tmptable_filename().
      Disabled REPAIR TABLE ... USE_FRM for temporary tables.
      Added the forgotten conversion to mysql_alter_table() for the case
      of ALTER TABLE ... RENAME.
      Added comments and DBUG calls.
    sql/sql_trigger.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/sql_view.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Added an zero argument for the new 'flags' parameter.
    sql/table.cc:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Replaced a literal ".frm" by reg_ext.
      Added DBUG calls.
    storage/innobase/row/row0mysql.c:
      Bug#18775 - Temporary table from alter table visible to other threads
      Continued implementation of WL#1324 (table name to filename encoding)
      Changed back the encoded temp file prefix to #sql.
    ef976d20
alter_table.result 23.6 KB