Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
124fc93d
Commit
124fc93d
authored
Aug 11, 2010
by
Guilhem Bichot
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix for Bug #55672 "mysql_upgrade dies with internal error":
it couldn't parse the --ssl option.
parent
5c85a938
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
76 additions
and
28 deletions
+76
-28
client/mysql_upgrade.c
client/mysql_upgrade.c
+3
-0
mysql-test/include/mysql_upgrade_preparation.inc
mysql-test/include/mysql_upgrade_preparation.inc
+30
-0
mysql-test/r/mysql_upgrade_ssl.result
mysql-test/r/mysql_upgrade_ssl.result
+32
-0
mysql-test/t/mysql_upgrade.test
mysql-test/t/mysql_upgrade.test
+1
-28
mysql-test/t/mysql_upgrade_ssl.test
mysql-test/t/mysql_upgrade_ssl.test
+10
-0
No files found.
client/mysql_upgrade.c
View file @
124fc93d
...
...
@@ -209,6 +209,9 @@ static void add_one_option(DYNAMIC_STRING* ds,
case
GET_STR
:
arg
=
argument
;
break
;
case
GET_BOOL
:
arg
=
(
*
(
my_bool
*
)
opt
->
value
)
?
"1"
:
"0"
;
break
;
default:
die
(
"internal error at %s: %d"
,
__FILE__
,
__LINE__
);
}
...
...
mysql-test/include/mysql_upgrade_preparation.inc
0 → 100644
View file @
124fc93d
# Include this in any test using mysql_upgrade
# Can't run test of external client with embedded server
--
source
include
/
not_embedded
.
inc
# Only run test if "mysql_upgrade" is found
--
require
r
/
have_mysql_upgrade
.
result
--
disable_query_log
select
LENGTH
(
"
$MYSQL_UPGRADE
"
)
>
0
as
have_mysql_upgrade
;
--
enable_query_log
#
# Hack:
#
# If running with Valgrind ($VALGRIND_TEST <> 0) then the resource
# consumption (CPU) for upgrading a large log table will be intense.
# Therefore, truncate the log table in advance and issue a statement
# that should be logged.
#
if
(
`SELECT $VALGRIND_TEST`
)
{
--
disable_query_log
--
disable_result_log
--
disable_abort_on_error
TRUNCATE
TABLE
mysql
.
general_log
;
SELECT
1
;
--
enable_abort_on_error
--
enable_result_log
--
enable_query_log
}
mysql-test/r/mysql_upgrade_ssl.result
0 → 100644
View file @
124fc93d
#
# Bug#55672 mysql_upgrade dies with internal error
#
mtr.global_suppressions OK
mtr.test_suppressions OK
mysql.columns_priv OK
mysql.db OK
mysql.event OK
mysql.func OK
mysql.general_log
Error : You can't use locks with log tables.
status : OK
mysql.help_category OK
mysql.help_keyword OK
mysql.help_relation OK
mysql.help_topic OK
mysql.host OK
mysql.ndb_binlog_index OK
mysql.plugin OK
mysql.proc OK
mysql.procs_priv OK
mysql.servers OK
mysql.slow_log
Error : You can't use locks with log tables.
status : OK
mysql.tables_priv OK
mysql.time_zone OK
mysql.time_zone_leap_second OK
mysql.time_zone_name OK
mysql.time_zone_transition OK
mysql.time_zone_transition_type OK
mysql.user OK
mysql-test/t/mysql_upgrade.test
View file @
124fc93d
# Can't run test of external client with embedded server
--
source
include
/
not_embedded
.
inc
# Only run test if "mysql_upgrade" is found
--
require
r
/
have_mysql_upgrade
.
result
--
disable_query_log
select
LENGTH
(
"
$MYSQL_UPGRADE
"
)
>
0
as
have_mysql_upgrade
;
--
enable_query_log
#
# Hack:
#
# If running with Valgrind ($VALGRIND_TEST <> 0) then the resource
# consumption (CPU) for upgrading a large log table will be intense.
# Therefore, truncate the log table in advance and issue a statement
# that should be logged.
#
if
(
`SELECT $VALGRIND_TEST`
)
{
--
disable_query_log
--
disable_result_log
--
disable_abort_on_error
TRUNCATE
TABLE
mysql
.
general_log
;
SELECT
1
;
--
enable_abort_on_error
--
enable_result_log
--
enable_query_log
}
--
source
include
/
mysql_upgrade_preparation
.
inc
#
# Basic test that we can run mysql_upgrde and that it finds the
...
...
mysql-test/t/mysql_upgrade_ssl.test
0 → 100644
View file @
124fc93d
# mysql_upgrade tests requiring SSL support
--
source
include
/
have_ssl_communication
.
inc
--
source
include
/
mysql_upgrade_preparation
.
inc
--
echo
#
--
echo
# Bug#55672 mysql_upgrade dies with internal error
--
echo
#
--
exec
$MYSQL_UPGRADE
--
skip
-
verbose
--
ssl
--
force
2
>&
1
--
exit
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment