Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
59c00340
Commit
59c00340
authored
Jun 13, 2006
by
mikael@c-0409e253.1238-1-64736c10.cust.bredbandsbolaget.se
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
BUG#19307: CSV engine can cause crashes in partitioned tables (due to its conversion of NULLs to 0)
parent
2e6b5157
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
26 additions
and
7 deletions
+26
-7
mysql-test/r/partition.result
mysql-test/r/partition.result
+5
-0
mysql-test/t/partition.test
mysql-test/t/partition.test
+12
-0
sql/partition_info.cc
sql/partition_info.cc
+4
-2
sql/share/errmsg.txt
sql/share/errmsg.txt
+2
-2
sql/sql_partition.cc
sql/sql_partition.cc
+3
-3
No files found.
mysql-test/r/partition.result
View file @
59c00340
drop table if exists t1;
drop table if exists t1;
create table t1 (a int)
create table t1 (a int)
engine = csv
partition by list (a)
(partition p0 values in (null));
ERROR HY000: CSV handler cannot be used in partitioned tables
create table t1 (a int)
partition by key(a)
partition by key(a)
(partition p0 engine = MEMORY);
(partition p0 engine = MEMORY);
drop table t1;
drop table t1;
...
...
mysql-test/t/partition.test
View file @
59c00340
...
@@ -9,6 +9,17 @@
...
@@ -9,6 +9,17 @@
drop
table
if
exists
t1
;
drop
table
if
exists
t1
;
--
enable_warnings
--
enable_warnings
#
# Bug 19307: CSV engine crashes
#
--
error
ER_PARTITION_MERGE_ERROR
create
table
t1
(
a
int
)
engine
=
csv
partition
by
list
(
a
)
(
partition
p0
values
in
(
null
));
#
#
create
table
t1
(
a
int
)
create
table
t1
(
a
int
)
partition
by
key
(
a
)
partition
by
key
(
a
)
(
partition
p0
engine
=
MEMORY
);
(
partition
p0
engine
=
MEMORY
);
...
@@ -1077,4 +1088,5 @@ OPTIMIZE TABLE t1;
...
@@ -1077,4 +1088,5 @@ OPTIMIZE TABLE t1;
drop
table
t1
;
drop
table
t1
;
--
echo
End
of
5.1
tests
--
echo
End
of
5.1
tests
sql/partition_info.cc
View file @
59c00340
...
@@ -442,9 +442,11 @@ bool partition_info::check_engine_mix(handlerton **engine_array, uint no_parts)
...
@@ -442,9 +442,11 @@ bool partition_info::check_engine_mix(handlerton **engine_array, uint no_parts)
DBUG_RETURN
(
TRUE
);
DBUG_RETURN
(
TRUE
);
}
}
}
while
(
++
i
<
no_parts
);
}
while
(
++
i
<
no_parts
);
if
(
engine_array
[
0
]
==
&
myisammrg_hton
)
if
(
engine_array
[
0
]
==
&
myisammrg_hton
||
engine_array
[
0
]
==
&
tina_hton
)
{
{
my_error
(
ER_PARTITION_MERGE_ERROR
,
MYF
(
0
));
my_error
(
ER_PARTITION_MERGE_ERROR
,
MYF
(
0
),
engine_array
[
0
]
==
&
myisammrg_hton
?
"MyISAM Merge"
:
"CSV"
);
DBUG_RETURN
(
TRUE
);
DBUG_RETURN
(
TRUE
);
}
}
DBUG_RETURN
(
FALSE
);
DBUG_RETURN
(
FALSE
);
...
...
sql/share/errmsg.txt
View file @
59c00340
...
@@ -5849,5 +5849,5 @@ ER_EVENT_MODIFY_QUEUE_ERROR
...
@@ -5849,5 +5849,5 @@ ER_EVENT_MODIFY_QUEUE_ERROR
ER_EVENT_SET_VAR_ERROR
ER_EVENT_SET_VAR_ERROR
eng "Error during starting/stopping of the scheduler. Error code %u"
eng "Error during starting/stopping of the scheduler. Error code %u"
ER_PARTITION_MERGE_ERROR
ER_PARTITION_MERGE_ERROR
eng "
MyISAM Merge
handler cannot be used in partitioned tables"
eng "
%s
handler cannot be used in partitioned tables"
swe "
MyISAM Merge kan inte an
ndas i en partitionerad tabell"
swe "
%s kan inte anv
ndas i en partitionerad tabell"
sql/sql_partition.cc
View file @
59c00340
/* Copyright (C) 2005 MySQL AB
/* Copyright (C) 2005
, 2006
MySQL AB
This program is free software; you can redistribute it and/or modify
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
it under the terms of the GNU General Public License as published by
...
@@ -238,8 +238,8 @@ bool partition_default_handling(TABLE *table, partition_info *part_info,
...
@@ -238,8 +238,8 @@ bool partition_default_handling(TABLE *table, partition_info *part_info,
check_reorganise_list()
check_reorganise_list()
new_part_info New partition info
new_part_info New partition info
old_part_info Old partition info
old_part_info Old partition info
list_part_names The list of partition names that will go away and
can be reused in the
list_part_names The list of partition names that will go away and
new table.
can be reused in the
new table.
RETURN VALUES
RETURN VALUES
TRUE Inacceptable name conflict detected.
TRUE Inacceptable name conflict detected.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment