Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
937db4bf
Commit
937db4bf
authored
Aug 14, 2010
by
Sergey Petrunya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
- Remove out-of-date comments
- Make testcase stable
parent
c964cb1b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
13 deletions
+5
-13
mysql-test/suite/vcol/r/vcol_misc.result
mysql-test/suite/vcol/r/vcol_misc.result
+1
-1
mysql-test/suite/vcol/t/vcol_misc.test
mysql-test/suite/vcol/t/vcol_misc.test
+2
-1
sql/multi_range_read.h
sql/multi_range_read.h
+2
-11
No files found.
mysql-test/suite/vcol/r/vcol_misc.result
View file @
937db4bf
...
@@ -13,8 +13,8 @@ id select_type table type possible_keys key key_len ref rows Extra
...
@@ -13,8 +13,8 @@ id select_type table type possible_keys key key_len ref rows Extra
1 SIMPLE t2 ref idx idx 5 test.t1.b 2 Using where; Using join buffer
1 SIMPLE t2 ref idx idx 5 test.t1.b 2 Using where; Using join buffer
select * from t1,t2 where t1.b=t2.c and d <= 100;
select * from t1,t2 where t1.b=t2.c and d <= 100;
a b c d v
a b c d v
4 20 20 100 101
1 20 20 100 101
1 20 20 100 101
3 30 30 100 101
3 30 30 100 101
4 20 20 100 101
set join_cache_level=default;
set join_cache_level=default;
drop table t1, t2;
drop table t1, t2;
mysql-test/suite/vcol/t/vcol_misc.test
View file @
937db4bf
...
@@ -17,7 +17,8 @@ set join_cache_level=6;
...
@@ -17,7 +17,8 @@ set join_cache_level=6;
explain
explain
select
*
from
t1
,
t2
where
t1
.
b
=
t2
.
c
and
d
<=
100
;
select
*
from
t1
,
t2
where
t1
.
b
=
t2
.
c
and
d
<=
100
;
--
sorted_result
select
*
from
t1
,
t2
where
t1
.
b
=
t2
.
c
and
d
<=
100
;
select
*
from
t1
,
t2
where
t1
.
b
=
t2
.
c
and
d
<=
100
;
set
join_cache_level
=
default
;
set
join_cache_level
=
default
;
drop
table
t1
,
t2
;
drop
table
t1
,
t2
;
\ No newline at end of file
sql/multi_range_read.h
View file @
937db4bf
...
@@ -47,12 +47,6 @@
...
@@ -47,12 +47,6 @@
When reading, there is current position pointing at start (for reverse
When reading, there is current position pointing at start (for reverse
buffer, end) of the element that will be read next.
buffer, end) of the element that will be read next.
^^ why end for reverse? it's more logical to point at start
^^ why end for reverse? it's more logical to point at start
One can peek at what's behind that element by using advance_ptr function.
TODO: will the reverse buffer store {tuple; rowid} or {rowid; tuple} pairs?
(why does it matter??? Read and write in the same order and then it
shouldn't matter.)
*/
*/
class
SimpleBuffer
class
SimpleBuffer
...
@@ -63,7 +57,7 @@ class SimpleBuffer
...
@@ -63,7 +57,7 @@ class SimpleBuffer
uchar
*
write_pos
;
uchar
*
write_pos
;
/*
/*
1 <=> buffer grows/is filled/is read
from start to end
1 <=> buffer grows/is filled/is read from start to end
-1 <=> everthing is done from end to start instead.
-1 <=> everthing is done from end to start instead.
*/
*/
int
direction
;
int
direction
;
...
@@ -141,10 +135,7 @@ public:
...
@@ -141,10 +135,7 @@ public:
DBUG_ASSERT
(
0
);
/* Attempt to grow buffer in wrong direction */
DBUG_ASSERT
(
0
);
/* Attempt to grow buffer in wrong direction */
}
}
/* */
//friend class PeekIterator;
void
grow
();
friend
class
PeekIterator
;
class
PeekIterator
class
PeekIterator
{
{
// if direction==1 : pointer to what to return next
// if direction==1 : pointer to what to return next
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment