Commit 937db4bf authored by Sergey Petrunya's avatar Sergey Petrunya

- Remove out-of-date comments

- Make testcase stable 
parent c964cb1b
...@@ -13,8 +13,8 @@ id select_type table type possible_keys key key_len ref rows Extra ...@@ -13,8 +13,8 @@ id select_type table type possible_keys key key_len ref rows Extra
1 SIMPLE t2 ref idx idx 5 test.t1.b 2 Using where; Using join buffer 1 SIMPLE t2 ref idx idx 5 test.t1.b 2 Using where; Using join buffer
select * from t1,t2 where t1.b=t2.c and d <= 100; select * from t1,t2 where t1.b=t2.c and d <= 100;
a b c d v a b c d v
4 20 20 100 101
1 20 20 100 101 1 20 20 100 101
3 30 30 100 101 3 30 30 100 101
4 20 20 100 101
set join_cache_level=default; set join_cache_level=default;
drop table t1, t2; drop table t1, t2;
...@@ -17,7 +17,8 @@ set join_cache_level=6; ...@@ -17,7 +17,8 @@ set join_cache_level=6;
explain explain
select * from t1,t2 where t1.b=t2.c and d <= 100; select * from t1,t2 where t1.b=t2.c and d <= 100;
--sorted_result
select * from t1,t2 where t1.b=t2.c and d <= 100; select * from t1,t2 where t1.b=t2.c and d <= 100;
set join_cache_level=default; set join_cache_level=default;
drop table t1, t2; drop table t1, t2;
\ No newline at end of file
...@@ -47,12 +47,6 @@ ...@@ -47,12 +47,6 @@
When reading, there is current position pointing at start (for reverse When reading, there is current position pointing at start (for reverse
buffer, end) of the element that will be read next. buffer, end) of the element that will be read next.
^^ why end for reverse? it's more logical to point at start ^^ why end for reverse? it's more logical to point at start
One can peek at what's behind that element by using advance_ptr function.
TODO: will the reverse buffer store {tuple; rowid} or {rowid; tuple} pairs?
(why does it matter??? Read and write in the same order and then it
shouldn't matter.)
*/ */
class SimpleBuffer class SimpleBuffer
...@@ -63,7 +57,7 @@ class SimpleBuffer ...@@ -63,7 +57,7 @@ class SimpleBuffer
uchar *write_pos; uchar *write_pos;
/* /*
1 <=> buffer grows/is filled/is read from start to end 1 <=> buffer grows/is filled/is read from start to end
-1 <=> everthing is done from end to start instead. -1 <=> everthing is done from end to start instead.
*/ */
int direction; int direction;
...@@ -141,10 +135,7 @@ public: ...@@ -141,10 +135,7 @@ public:
DBUG_ASSERT(0); /* Attempt to grow buffer in wrong direction */ DBUG_ASSERT(0); /* Attempt to grow buffer in wrong direction */
} }
/* */ //friend class PeekIterator;
void grow();
friend class PeekIterator;
class PeekIterator class PeekIterator
{ {
// if direction==1 : pointer to what to return next // if direction==1 : pointer to what to return next
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment