Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
M
mariadb
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
mariadb
Commits
a78cc269
Commit
a78cc269
authored
Jun 14, 2005
by
bell@sanja.is.com.ua
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
prohibit opening Query cache for SP cursors (BUG#9715)
parent
f183b1be
Changes
5
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
77 additions
and
5 deletions
+77
-5
mysql-test/r/query_cache.result
mysql-test/r/query_cache.result
+29
-0
mysql-test/t/query_cache.test
mysql-test/t/query_cache.test
+32
-0
sql/sp_head.h
sql/sp_head.h
+4
-0
sql/sp_rcontext.cc
sql/sp_rcontext.cc
+11
-0
sql/sp_rcontext.h
sql/sp_rcontext.h
+1
-5
No files found.
mysql-test/r/query_cache.result
View file @
a78cc269
This diff is collapsed.
Click to expand it.
mysql-test/t/query_cache.test
View file @
a78cc269
...
...
@@ -756,4 +756,36 @@ flush query cache;
drop
table
t1
,
t2
;
#
# SP cursors and selects with query cache (BUG#9715)
#
create
table
t1
(
a
int
);
insert
into
t1
values
(
1
),(
2
);
delimiter
//;
CREATE
PROCEDURE
`p1`
()
begin
Declare
c1
cursor
for
select
a
from
t1
;
open
c1
;
select
*
from
t1
;
end
//
call
p1
()
//
drop
procedure
p1
;
create
function
f1
()
returns
int
begin
Declare
var1
int
;
select
max
(
a
)
from
t1
into
var1
;
return
var1
;
end
//
create
procedure
`p1`
()
begin
select
a
,
f1
()
from
t1
;
end
//
call
p1
()
//
drop
procedure
p1
//
drop
table
t1
//
delimiter
;
//
set
GLOBAL
query_cache_size
=
0
;
sql/sp_head.h
View file @
a78cc269
...
...
@@ -377,6 +377,10 @@ public:
return
(
uint
)
m_lex
->
sql_command
;
}
void
disable_query_cache
()
{
m_lex
->
safe_to_cache_query
=
0
;
}
private:
LEX
*
m_lex
;
...
...
sql/sp_rcontext.cc
View file @
a78cc269
...
...
@@ -169,6 +169,17 @@ sp_rcontext::pop_cursors(uint count)
*
*/
sp_cursor
::
sp_cursor
(
sp_lex_keeper
*
lex_keeper
)
:
m_lex_keeper
(
lex_keeper
),
m_prot
(
NULL
),
m_isopen
(
0
),
m_current_row
(
NULL
)
{
/*
currsor can't be stored in QC, so we should prevent opening QC for
try to write results which are absent.
*/
lex_keeper
->
disable_query_cache
();
}
/*
pre_open cursor
...
...
sql/sp_rcontext.h
View file @
a78cc269
...
...
@@ -203,11 +203,7 @@ class sp_cursor : public Sql_alloc
{
public:
sp_cursor
(
sp_lex_keeper
*
lex_keeper
)
:
m_lex_keeper
(
lex_keeper
),
m_prot
(
NULL
),
m_isopen
(
0
),
m_current_row
(
NULL
)
{
/* Empty */
}
sp_cursor
(
sp_lex_keeper
*
lex_keeper
);
virtual
~
sp_cursor
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment