An error occurred fetching the project authors.
  1. 29 Sep, 2006 1 commit
  2. 22 Aug, 2006 1 commit
    • unknown's avatar
      Fixed bug#16861: User defined variable can have a wrong value if a tmp table was · c623e54f
      unknown authored
      used.
      
      Sorting by RAND() uses a temporary table in order to get a correct results.
      User defined variable was set during filling the temporary table and later
      on it is substituted for its value from the temporary table. Due to this
      it contains the last value stored in the temporary table.
      
      Now if the result_field is set for the Item_func_set_user_var object it 
      updates variable from the result_field value when being sent to a client.
      
      The Item_func_set_user_var::check() now accepts a use_result_field
      parameter. Depending on its value the result_field or the args[0] is used
      to get current value.
      
      
      mysql-test/r/user_var.result:
        Added a test case for bug#16861: User defined variable can have a wrong value if a tmp table was used.
      mysql-test/t/user_var.test:
        Added a test case for bug#16861: User defined variable can have a wrong value if a tmp table was used.
      sql/item_func.cc:
        Fixed bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Now if the result_field is set for the Item_func_set_user_var object it 
        updates variable from the result_field value when being sent to a client.
        
        The Item_func_set_user_var::check() now accepts a use_result_field
        parameter. Depending on its value the result_field or the args[0] is used
        to get current value.
      sql/item_func.h:
        Fixed bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Added a new SUSERVAR_FUNC function type.
        Updated the Item_func_set_user_var::check() function declaration.
        Added the Item_func_set_user_var::send() member function.
      sql/set_var.cc:
        Fixed bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Modified to use updated Item_func_set_user_var::check() function.
      sql/sql_class.cc:
        Fixed bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Modified to use updated Item_func_set_user_var::check() function.
      sql/sql_select.cc:
        Fixed bug#16861: User defined variable can have a wrong value if a tmp table was used.
        Now an Item_func_set_user_var object isn't substituted for an Item_field object after filling a temporary table.
      c623e54f
  3. 17 Aug, 2006 1 commit
    • unknown's avatar
      Bug #2717: include/my_global.h mis-defines __attribute__ · 915bdfbe
      unknown authored
        Fix when __attribute__() is stubbed out, add ATTRIBUTE_FORMAT() for specifying
        __attribute__((format(...))) safely, make more use of the format attribute,
        and fix some of the warnings that this turns up (plus a bonus unrelated one).
      
      
      include/m_ctype.h:
        Add ATTRIBUTE_FORMAT to printf-like functions.
      include/m_string.h:
        Add ATTRIBUTE_FORMAT to my_snprintf() declaration.
      include/my_global.h:
        Fix neutering of __attribute__() on old versions of GCC and non-GCC compilers.
        Add ATTRIBUTE_FORMAT() macro for setting __attribute_((format(...)), since it
        is available from different versions of gcc and g++.
      include/my_sys.h:
        Add ATTRIBUTE_FORMAT() to my_printf_error declaration
      sql/item_subselect.cc:
        Silence warning about members being initialized out-of-order
      sql/item_timefunc.cc:
        Fix format specifier in snprintf() calls with milliseconds
      sql/mysql_priv.h:
        Add ATTRIBUTE_FORMAT to printf-like functions.
      sql/mysqld.cc:
        Fix various format specifiers
        Make sure that method_conv is always set by myisam_stats_method
      sql/opt_range.cc:
        Cast pointers to correct type for %lx
      sql/set_var.cc:
        Fix __attribute__((unused)) (missing inner set of parens)
      sql/slave.cc:
        Fix format specifier
      sql/slave.h:
        Add ATTRIBUTE_FORMAT to slave_print_error() declaration.
      sql/sql_acl.cc:
        Fix number of  arguments passed for formatting, and fix acl_host_or_ip being
        passed instead of just the hostname.
      sql/sql_class.h:
        Add ATTRIBUTE_FORMAT to MYSQL_LOG::write().
      915bdfbe
  4. 14 Aug, 2006 1 commit
  5. 21 Jul, 2006 1 commit
  6. 14 Jul, 2006 1 commit
  7. 04 Jul, 2006 1 commit
    • unknown's avatar
      WL#2928 Date Translation NRE · 184ff212
      unknown authored
      (implemented by by Josh Chamas)
      
      
      libmysqld/Makefile.am:
        Adding new source file
      mysql-test/r/date_formats.result:
        Adding test case
      mysql-test/t/date_formats.test:
        Adding test case
      sql/Makefile.am:
        Adding new source file
      BitKeeper/etc/ignore:
        Added libmysqld/sql_locale.cc to the ignore list
      sql/item_timefunc.cc:
        Using current locale data, instead of hard coded English names.
      sql/mysql_priv.h:
        Adding new type MY_LOCALE, and declaring new global variables.
      sql/set_var.cc:
        Adding "lc_time_names" system variable.
      sql/set_var.h:
        Adding "lc_time_names" system variable.
      sql/sql_cache.cc:
        Adding lc_time_names as a query cache flag.
      sql/sql_class.cc:
        Setting default locale to en_US
      sql/sql_class.h:
        Adding locale variable into system_variables.
      sql/sql_locale.cc:
        Adding new file with locale data for various languages
      184ff212
  8. 28 Jun, 2006 1 commit
  9. 27 Jun, 2006 1 commit
    • unknown's avatar
      Fix compilation failures on Windows caused by the patch for Bug#17199. · e3ef15ea
      unknown authored
      Fix a minor issue with Bug#16206 (bdb.test failed if the tree is compiled 
      without blackhole).
      
      
      include/my_sys.h:
        Change declaration of my_strdup_with_length to accept const char *,
        not const byte *: in 5 places out of 6 where this function is used,
        it's being passed char *, not byte *
      mysql-test/r/bdb.result:
        Remove dependency on an optional engine (updated test results).
      mysql-test/t/bdb.test:
        Remove dependency on an optional engine.
      mysys/my_malloc.c:
        my_strdup_with_length: const byte * -> const char *
      mysys/safemalloc.c:
        my_strdup_with_length: const byte * -> const char *
      sql/ha_federated.cc:
        my_strdup_with_length: const byte * -> const char *
      sql/log_event.cc:
        my_strdup_with_length: const byte * -> const char *
      sql/set_var.cc:
        my_strdup_with_length: const byte * -> const char *
      sql/sql_class.h:
        Change db_length type to uint from uint32 (see also table.h)
      sql/table.h:
        Change the type of db_length to uint from uint32: LEX_STRING uses uint for 
        length, we need a small and consistent set of types to store length to 
        minimize cast and compile failures.
      e3ef15ea
  10. 22 Jun, 2006 1 commit
    • unknown's avatar
      Bugs#20392: INSERT_ID session variable has weird value · 4af5e597
      unknown authored
      sys_var_insert_id returned LAST_INSERT_ID instead of INSERT_ID.
      
      
      mysql-test/r/variables.result:
        Adding test case
      mysql-test/t/variables.test:
        Adding test case
      sql/set_var.cc:
        Fixed that sys_var_insert_id returned last_indert_id instead of insert_id.
      4af5e597
  11. 08 May, 2006 1 commit
    • unknown's avatar
      Bug #1039: tmpdir and datadir not available via @@ system variable syntax · c06972bf
      unknown authored
      Bug #19606: ssl variables are not displayed in show variables
      Bug #19616: log_queries_not_using_indexes  is not listed in show variables
      
        Make basedir, datadir, tmpdir, log_queries_not_using_indexes, ssl_ca,
        ssl_capath, ssl_cert, ssl_cipher, and ssl_key all available both from
        SHOW VARIABLES and as @@variables.
      
        As a side-effect of this change, log_queries_not_using_indexes can
        be changed at runtime (but only globally, not per-connection).
      
      
      include/sslopt-longopts.h:
        Put options in alphabetical order
      include/sslopt-vars.h:
        Allow define of SSL_VARS_NOT_STATIC to prevent variables from not being
        made static.
      mysql-test/r/variables.result:
        Add new results
      mysql-test/t/variables.test:
        Add new regression tests
      sql/mysql_priv.h:
        Add extern for opt_log_queries_not_using_indexes
      sql/mysqld.cc:
        Handle opt_log_queries_not_using_indexes as extern, and define
        SSL_VARS_NO_STATIC so they can be accessed outside of mysqld.cc
      sql/set_var.cc:
        Handle basedir, datadir, tmpdir, log_queries_not_using_indexes, and
        various ssl settings so that they are accessible as server variables
        and listed in SHOW VARIABLES.
      sql/set_var.h:
        Add new sys_var_constr_str_ptr class, for when we have a system variable
        that is only set via the command-line that is a pointer to a string.
      c06972bf
  12. 30 Apr, 2006 1 commit
    • unknown's avatar
      Fix for Bug#14515. · a8e6eb89
      unknown authored
      sql/set_var.cc:
        Fix for Bug#14515. These modes do not need restrictions, they're handled
        separately in sql_show.cc
      a8e6eb89
  13. 27 Apr, 2006 1 commit
    • unknown's avatar
      set_var.cc: · f0e7abfc
      unknown authored
        System variable was added out of lexical order.
      
      
      sql/set_var.cc:
        System variable was added out of lexical order.
      f0e7abfc
  14. 26 Apr, 2006 2 commits
  15. 21 Apr, 2006 2 commits
    • unknown's avatar
      Bug #12792: @@system_time_zone is not SELECTable · 4e5bed78
      unknown authored
      Bug #15684: @@version_* are not all SELECTable
      
        Added the appropriate information as read-only system variables, and
        also removed some special-case handling of @@version along the way.
      
        @@version_bdb was added, but isn't included in the test because it
        depends on the presence of BDB.
      
      
      mysql-test/r/variables.result:
        Update results
      mysql-test/t/variables.test:
        Fix error from setting @@version, reset sql_select_limit to avoid confusion
        in later tests, and add new regression tests.
      sql/item_func.cc:
        Remove special-case handling of VERSION, it's just a read-only server
        variable like the others now.
      sql/set_var.cc:
        Add system_time_zone and various version-related system variables
      4e5bed78
    • unknown's avatar
      Bug #16195: SHOW VARIABLES doesn't report correctly sql_warnings and sql_notes values · a4b042c1
      unknown authored
        SQL_WARNINGS and SQL_NOTES were being displayed with SHOW_BOOL, but they
        are system variables that need SHOW_SYS to be used.
      
      
      mysql-test/r/variables.result:
        Add new results
      mysql-test/t/variables.test:
        Add new regression test
      sql/set_var.cc:
        Fix display of sql_notes and sql_warnings in SHOW VARIABLES.
      a4b042c1
  16. 13 Apr, 2006 2 commits
    • unknown's avatar
      foo2 · 365f6f6f
      unknown authored
      sql/ha_innodb.cc:
        Import patch foo2
      sql/ha_innodb.h:
        Import patch foo2
      sql/handler.cc:
        Import patch foo2
      sql/handler.h:
        Import patch foo2
      sql/mysqld.cc:
        Import patch foo2
      sql/set_var.cc:
        Import patch foo2
      sql/sql_class.h:
        Import patch foo2
      sql/sql_repl.cc:
        Import patch foo2
      365f6f6f
    • unknown's avatar
      foo1 · ce335550
      unknown authored
      sql/ha_innodb.cc:
        Import patch foo1
      sql/ha_innodb.h:
        Import patch foo1
      sql/handler.cc:
        Import patch foo1
      sql/handler.h:
        Import patch foo1
      sql/mysqld.cc:
        Import patch foo1
      sql/set_var.cc:
        Import patch foo1
      sql/sql_class.h:
        Import patch foo1
      sql/sql_repl.cc:
        Import patch foo1
      ce335550
  17. 12 Apr, 2006 1 commit
    • unknown's avatar
      Bug#18564 Test failure due to test not checking preconditions · 0a8d876d
      unknown authored
       - Add variable "have_dynamic_loading" and use it to check if the udf test should be run.
      
      
      mysql-test/include/have_udf.inc:
        Use variable "have_dynamic_loading" to to determine if there is support for udf's
      mysql-test/r/have_udf.require:
        Use variable "have_dynamic_loading" to to determine if there is support for udf's
      mysql-test/t/disabled.def:
        Remove udf from disabled
      sql/mysql_priv.h:
        Add have_dlopen variable
      sql/mysqld.cc:
        Add have_dlopen variable
      sql/set_var.cc:
        Add have_dlopen variable and name it "have_dynamic_loading" in "SHOW VARIABLES"
      0a8d876d
  18. 07 Apr, 2006 1 commit
    • unknown's avatar
      A fix and a test case for Bug#16365 "Prepared Statements: DoS with · 5b5530da
      unknown authored
      too many open statements". The patch adds a new global variable
      @@max_prepared_stmt_count. This variable limits the total number
      of prepared statements in the server. The default value of
      @@max_prepared_stmt_count is 16382. 16382 small statements
      (a select against 3 tables with GROUP, ORDER and LIMIT) consume 
      100MB of RAM. Once this limit has been reached, the server will 
      refuse to prepare a new statement and return ER_UNKNOWN_ERROR 
      (unfortunately, we can't add new errors to 4.1 without breaking 5.0). The limit is changeable after startup
      and can accept any value from 0 to 1 million. In case
      the new value of the limit is less than the current
      statement count, no new statements can be added, while the old
      still can be used. Additionally, the current count of prepared 
      statements is now available through a global read-only variable 
      @@prepared_stmt_count.
      
      
      mysql-test/r/ps.result:
        Test results fixed (a test case for Bug#16365)
      mysql-test/t/ps.test:
        A test case for Bug#16365 "Prepared Statements: DoS with too many 
        open statements". Also fix statement leaks in other tests.
      sql/mysql_priv.h:
        Add declarations for new global variables.
      sql/mysqld.cc:
        Add definitions of max_prepared_stmt_count, prepared_stmt_count.
      sql/set_var.cc:
        Implement support for @@prepared_stmt_count and 
        @@max_prepared_stmt_count. Currently these variables are queried
        without acquiring LOCK_prepared_stmt_count due to limitations of
        the set_var/sys_var class design. Updates are, however, protected 
        with a lock.
      sql/set_var.h:
        New declarations to add support for @@max_prepared_stmt_count.
        Implement a new class, where the lock to be used when updating
        a variable is a parameter.
      sql/sql_class.cc:
        Add accounting of the total number of prepared statements in the
        server to the methods of Statement_map.
      sql/sql_class.h:
        Add accounting of the total number of prepared statements in the
        server to the methods of Statement_map.
      sql/sql_prepare.cc:
        Statement_map::insert will now send a message in case of an
        error.
      5b5530da
  19. 18 Feb, 2006 1 commit
    • unknown's avatar
      Fix for BUG#13897 "failure to do SET SQL_MODE=N where N is a number > 31" (the... · 8dc567db
      unknown authored
      Fix for BUG#13897 "failure to do SET SQL_MODE=N where N is a number > 31" (the original bug's title isn't the simplest
      symptom). sys_var::check_set() was wrong. mysqlbinlog makes use of such SET SQL_MODE=N
      (where N is interpreted like if SQL_MODE was a field of type SET), so
      this bug affected recovery from binlogs if the server was running with certain SQL_MODE values,
      for example the default values on Windows (STRICT_TRANS_TABLES); to work around this bug people
      had to edit mysqlbinlog's output.
      
      
      mysql-test/r/sql_mode.result:
        result update
      mysql-test/t/sql_mode.test:
        test for various numeric SQL_MODE values
      sql/set_var.cc:
        For a set, it does not make sense to test if the supplied argument exceeds the number of elements in the set
        (such test would make sense for an enum), but rather to check if it exceeds 2^this (to verify
        that only reasonable bits are set).
      8dc567db
  20. 14 Feb, 2006 1 commit
    • unknown's avatar
      Many files: · 7ce3b2a3
      unknown authored
        Backporting character_set_filesystem from 5.0 to 5.1.
      
      
      sql/mysqld.cc:
        Backporting character_set_filesystem from 5.0 to 5.1.
      sql/set_var.cc:
        Backporting character_set_filesystem from 5.0 to 5.1.
      sql/set_var.h:
        Backporting character_set_filesystem from 5.0 to 5.1.
      sql/sql_class.cc:
        Backporting character_set_filesystem from 5.0 to 5.1.
      sql/sql_class.h:
        Backporting character_set_filesystem from 5.0 to 5.1.
      sql/sql_yacc.yy:
        Backporting character_set_filesystem from 5.0 to 5.1.
      mysql-test/t/variables.test:
        Backporting character_set_filesystem from 5.0 to 5.1.
      mysql-test/r/variables.result:
        Backporting character_set_filesystem from 5.0 to 5.1.
      7ce3b2a3
  21. 13 Feb, 2006 1 commit
    • unknown's avatar
      set_var.cc: · 01e880ed
      unknown authored
        Fix out-of-order system variable.
      
      
      sql/set_var.cc:
        Fix out-of-order system variable.
      01e880ed
  22. 18 Jan, 2006 1 commit
    • unknown's avatar
      Applied patch recieved from Marko: · 74f499fa
      unknown authored
       Make innodb_flush_log_at_trx_commit a settable global variable.
      
      
      innobase/include/srv0srv.h:
        Change the type of srv_flush_log_at_trx_commit.
      innobase/srv/srv0srv.c:
        Change the type of srv_flush_log_at_trx_commit.
      sql/ha_innodb.cc:
        Remove innobase_flush_log_at_trx_commit.
         (Set srv_flush_log_at_trx_commit directly).
      sql/ha_innodb.h:
        Remove innobase_flush_log_at_trx_commit.
         (Set srv_flush_log_at_trx_commit directly).
      sql/mysqld.cc:
        Bypass the variable innobase innobase_flush_log_at_trx_commit.
      sql/set_var.cc:
        Make innodb_flush_log_at_trx_commit a settable global variable.
      74f499fa
  23. 03 Jan, 2006 1 commit
    • unknown's avatar
      many warnings (practically safe but annoying) corrected · 307c0b77
      unknown authored
      client/mysqladmin.cc:
        don't use the handler after it's closed
      client/mysqlbinlog.cc:
        memory leak
      client/mysqldump.c:
        many "ignore return value" warnings, one "NULL dereference"
      cmd-line-utils/libedit/history.c:
        memory leak
      include/my_base.h:
        cleanup
      libmysql/libmysql.c:
        "return value ignored" warning
      myisam/mi_delete.c:
        "return value ignored" warning
      myisam/myisampack.c:
        "out-of-bound access" warning
      myisam/sort.c:
        "double free" warning
      mysys/default_modify.c:
        "double free" warning
      mysys/mf_iocache2.c:
        "return value ignored" warnings
      mysys/my_bitmap.c:
        s/return/DBUG_RETURN/
      mysys/my_error.c:
        memory leak
      server-tools/instance-manager/parse.cc:
        "NULL dereference" warning
      sql-common/client.c:
        "NULL dereference" warning
      sql/field.cc:
        deadcode, "NULL dereference", "uninitialized" warnings
      sql/field.h:
        unused parameters removed from constructor
      sql/ha_myisam.cc:
        "return value ignored" warnings
      sql/item.cc:
        "return value ignored" warnings
        changed constructor
      sql/item_func.cc:
        "return value ignored" warnings
      sql/log_event.cc:
        uninitialized warning
      sql/opt_range.cc:
        "double free" and uninitialized warnings
      sql/opt_range.h:
        "return value ignored" warning
      sql/repl_failsafe.cc:
        "return value ignored" warning
      sql/set_var.cc:
        "return value ignored" warning
      sql/slave.cc:
        "return value ignored" warnings
      sql/slave.h:
        new prototype
      sql/sql_acl.cc:
        deadcode and "NULL dereference" warnings
      sql/sql_db.cc:
        "return value ignored" warning
      sql/sql_handler.cc:
        "NULL dereference" warning
      sql/sql_help.cc:
        "NULL dereference" warning
      sql/sql_insert.cc:
        "return value ignored" warning
      sql/sql_parse.cc:
        "return value ignored" warning
        one more DBUG_ASSERT
      sql/sql_repl.cc:
        "return value ignored" and memory leak warnings
      sql/sql_show.cc:
        "return value ignored" and "NULL dereference"  warnings
      sql/sql_test.cc:
        "return value ignored" warning
      sql/table.cc:
        memory leak
      sql/uniques.cc:
        "return value ignored" warning
        endspaces deleted
      307c0b77
  24. 22 Nov, 2005 1 commit
    • unknown's avatar
      Recursion support made for SP (BUG#10100). · 164ce4c5
      unknown authored
      client/mysqltest.c:
        An expected error messages hiding from the log if disable_result_log is in force.
      mysql-test/r/sp-dynamic.result:
        The test expanded for case of allowed/disalowed recursion.
      mysql-test/r/sp-error.result:
        Error messages changed.
        Test of bug11394() made with allowed recursion.
      mysql-test/r/sp.result:
        Tests for recursion.
      mysql-test/r/trigger.result:
        Check that triggers are not affected by this patch.
      mysql-test/r/variables.result:
        Test of max_sp_recursion_depth variable.
      mysql-test/t/sp-dynamic.test:
        The test expanded for case of allowed/disalowed recursion.
      mysql-test/t/sp-error.test:
        Error messages changed.
        Test of bug11394() made with allowed recursion.
      mysql-test/t/sp.test:
        Tests for recursion.
      mysql-test/t/trigger.test:
        Check that triggers are not affected by this patch.
      mysql-test/t/variables.test:
        Test of max_sp_recursion_depth variable.
      sql/item_func.cc:
        sp_find_function() and sp_find_procedure() joined to sp_find_routine()
          function as it was mentioned in TODO.
      sql/mysqld.cc:
        max_sp_recursion_depth variable added.
      sql/set_var.cc:
        max_sp_recursion_depth variable added.
      sql/share/errmsg.txt:
        An error message changed.
        An error message added.
      sql/sp.cc:
        sp_find_function() and sp_find_procedure() joined to sp_find_routine()
          function as it was mentioned in TODO.
        Temory LEX is allocated on a stack, not on a heap.
        Recursion support added for stored procedures.
      sql/sp.h:
        sp_find_function() and sp_find_procedure() joined to sp_find_routine()
          function as it was mentioned in TODO.
      sql/sp_head.cc:
        Initialization of new sp_head fields to get correct list of instances
          contained one instance only.
        Stack requirement for SP instruction is increased.
        Stack free space is checked before mem root initialisation to avoid
          memory leak.
        Pointer to the free instance management added before and after
          SP execution.
      sql/sp_head.h:
        New sp_head variables added to support inst of instances of SP
          for recursion and pointer on ths first free to use instance.
      sql/sql_base.cc:
        open_table() consume a lot of stack space so we check free stack space before it.
      sql/sql_class.h:
        max_sp_recursion_depth variable added.
      sql/sql_parse.cc:
        sp_find_function() and sp_find_procedure() joined to sp_find_routine()
          function as it was mentioned in TODO.
      164ce4c5
  25. 17 Nov, 2005 1 commit
    • unknown's avatar
      set_var.cc, mysqld.cc, ha_innodb.h: · 30df60fa
      unknown authored
        BUG#12701: SHOW VARIABLES does not show correct size of buffer pool.
      ha_innodb.cc:
        BUG#12701: SHOW VARIABLES does not show correct size of buffer pool
      
      
      sql/ha_innodb.cc:
        BUG#12701: SHOW VARIABLES does not show correct size of buffer pool
      sql/ha_innodb.h:
        BUG#12701: SHOW VARIABLES does not show correct size of buffer pool.
      sql/mysqld.cc:
        BUG#12701: SHOW VARIABLES does not show correct size of buffer pool.
      sql/set_var.cc:
        BUG#12701: SHOW VARIABLES does not show correct size of buffer pool.
      30df60fa
  26. 10 Nov, 2005 1 commit
    • unknown's avatar
      WL#2971 "change log-bin-trust-routine-creators=0 to apply only to functions". · 5d9c8e95
      unknown authored
      Indeed now that stored procedures CALL is not binlogged, but instead the invoked substatements are,
      the restrictions applied by log-bin-trust-routine-creators=0 are superfluous for procedures.
      They still need to apply to functions where function calls are written to the binlog (for example as "DO myfunc(3)").
      We rename the variable to log-bin-trust-function-creators but allow the old name until some future version (and issue a warning if old name is used).
      
      
      mysql-test/mysql-test-run.pl:
        update to new option name
      mysql-test/mysql-test-run.sh:
        update to new option name
      mysql-test/mysql_test_run_new.c:
        update to new option name
      mysql-test/r/rpl_sp.result:
        result update
      mysql-test/t/rpl_sp-slave.opt:
        we need to skip this error to not hit BUG#14769
      mysql-test/t/rpl_sp.test:
        Test update:
        1) as log-bin-trust-routine-creators now affects only functions, the testing of this option, which was
        mainly done on procedures, is moved to functions
        2) cleanup is simplified; and instead of many SHOW BINLOG EVENTS we do a big one in the end, which is more
        maintainable.
        3) we test a few more function and procedures cases to see how they replicate.
        4) removing out-of-date comments
      sql/item_func.cc:
        This warning is wrong since binlogging of functions was changed in August. If a function fails
        in the middle, it will be binlogged with its error code (i.e. properly).
      sql/mysql_priv.h:
        variable name changed
      sql/mysqld.cc:
        option name changes. A precision about --read-only.
      sql/set_var.cc:
        a new class sys_var_trust_routine_creators to be able to issue a "this is a deprecated variable" warning if used.
      sql/set_var.h:
        new class to be able to issue a "this is a deprecated variable" warning if used.
      sql/share/errmsg.txt:
        routine -> function
      sql/sp.cc:
        log-bin-trust-routine-creators now applies only to functions.
      sql/sql_parse.cc:
        1) sending ER_FAILED_ROUTINE_BREAK_BINLOG is wrong since August as we don't binlog CALL anymore but instead binlog the substatements;
        the clear_error() goes away too as it was necessary only when we created a binlog event from the "CALL" statement.
        2) log-bin-trust-routine-creators now applies only to functions.
      sql/sql_trigger.cc:
        comments.
      5d9c8e95
  27. 20 Sep, 2005 1 commit
    • unknown's avatar
      BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index · a2a8216b
      unknown authored
      statistics (like 4.0 did) (patch #3, with review #1 & #2 feedback addressed)
      
      
      include/myisam.h:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      myisam/mi_check.c:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      myisam/myisamchk.c:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      mysql-test/r/myisam.result:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      mysql-test/t/myisam.test:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      sql/ha_myisam.cc:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      sql/handler.h:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      sql/mysqld.cc:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      sql/set_var.cc:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      sql/sql_class.h:
        BUG#12232: Add a server option to treat NULL values as equal when calculating MyISAM index statistics
      a2a8216b
  28. 15 Sep, 2005 1 commit
    • unknown's avatar
      WL#2787 (part 2, ver 3 (merged)) changed securety context switching · 84f029a4
      unknown authored
      libmysqld/lib_sql.cc:
        changed securety context switching
      mysql-test/r/rpl_sp.result:
        now it show real information from changed security context of SP (checked)
      sql/ha_innodb.cc:
        changed securety context switching
      sql/item.cc:
        changed securety context switching
      sql/item_func.cc:
        changed securety context switching
      sql/item_strfunc.cc:
        changed securety context switching
      sql/log.cc:
        changed securety context switching
      sql/mysql_priv.h:
        changed securety context switching
      sql/mysqld.cc:
        changed securety context switching
      sql/repl_failsafe.cc:
        changed securety context switching
      sql/set_var.cc:
        changed securety context switching
      sql/slave.cc:
        changed securety context switching
      sql/sp.cc:
        changed securety context switching
      sql/sp_head.cc:
        changed securety context switching
        in case of inability to switch context  we return error now
      sql/sp_head.h:
        changed securety context switching
      sql/sql_acl.cc:
        changed securety context switching
      sql/sql_acl.h:
        changed securety context switching
      sql/sql_base.cc:
        changed securety context switching
      sql/sql_class.cc:
        changed securety context switching
      sql/sql_class.h:
        changed securety context switching
      sql/sql_db.cc:
        changed securety context switching
      sql/sql_insert.cc:
        changed securety context switching
      sql/sql_parse.cc:
        changed securety context switching
      sql/sql_show.cc:
        changed securety context switching
      sql/sql_trigger.cc:
        changed securety context switching
      sql/sql_view.cc:
        changed securety context switching
      sql/sql_yacc.yy:
        changed securety context switching
      84f029a4
  29. 13 Sep, 2005 1 commit
    • unknown's avatar
      Fixed BUG#12712: SET AUTOCOMMIT should fail within SP/functions/triggers · 065a9377
      unknown authored
        Second version after review. Allow 'set autocommit' in procedures, but not
        functions or triggers. Can return error in run-time (when a function calls
        a procedure).
      
      
      mysql-test/r/sp-error.result:
        New test case for BUG#12712.
      mysql-test/t/sp-error.test:
        New test case for BUG#12712.
      sql/set_var.cc:
        Made sys_autocommit external, to allow testing in sql_yacc.yy.
      sql/set_var.h:
        Made sys_autocommit external, to allow testing in sql_yacc.yy.
      sql/share/errmsg.txt:
        New error message for disallowing the setting of autocommit in stored functions and triggers.
      sql/sp_head.h:
        New flag: has 'set autocommit', and testing for this in is_not_allowed_in_function().
      sql/sql_yacc.yy:
        Disallow setting AUTOCOMMIT in stored function and triggers.
      065a9377
  30. 07 Sep, 2005 1 commit
    • unknown's avatar
      Fix for bug#11775 Variable character_set_system does not exist (sometimes). · a777907a
      unknown authored
        Variable character_set_system is selectable now
        More accurate error message results during 
        update of character_set_system and some other read only variables
      
      
      mysql-test/r/variables.result:
        Fix for bug#11775 Variable character_set_system does not exist (sometimes).
          test case
      mysql-test/t/variables.test:
        Fix for bug#11775 Variable character_set_system does not exist (sometimes).
          test case
      a777907a
  31. 30 Aug, 2005 2 commits
    • unknown's avatar
      set_var.cc: · 696a7bb3
      unknown authored
        Reorder out-of-order system variables
      
      
      sql/set_var.cc:
        Reorder out-of-order system variables
      696a7bb3
    • unknown's avatar
      Bug#12363 · bda02a17
      unknown authored
      character_set_results is nullable, but value_ptr returns string "NULL"
      
      set_var.cc:
        Create Item_null instead of Item_string for NULL values
      
      variables.result, variables.test:
        adding test case
      
      
      sql/set_var.cc:
        Bug#12363
        character_set_results is nullable, but value_ptr returns string "NULL"
        Create Item_null instead of Item_string for NULL values
      mysql-test/t/variables.test:
        fixing tests accordingly
      mysql-test/r/variables.result:
        fixing tests accordingly
      bda02a17
  32. 29 Aug, 2005 1 commit
    • unknown's avatar
      set_var.cc: · 472b002b
      unknown authored
        Reorder out-of-order system variables.
      
      
      sql/set_var.cc:
        Reorder out-of-order system variables.
      472b002b
  33. 28 Aug, 2005 2 commits
    • unknown's avatar
      set_var.cc: · 5aa1b53f
      unknown authored
        Reorder out-of-order system variables.
      
      
      sql/set_var.cc:
        Reorder out-of-order system variables.
      5aa1b53f
    • unknown's avatar
      set_var.cc: · d7ff622e
      unknown authored
        Reorder out-of-order system variables.
      
      
      sql/set_var.cc:
        Reorder out-of-order system variables.
      d7ff622e
  34. 26 Aug, 2005 1 commit
  35. 22 Aug, 2005 1 commit
    • unknown's avatar
      Use the hostname with which the user authenticated when determining which · d40acb4d
      unknown authored
      user to update with 'SET PASSWORD = ...'. (Bug #12302)
      
      
      mysql-test/r/grant2.result:
        Add new results
      mysql-test/t/grant2.test:
        Add new tests
      sql/set_var.cc:
        Pass priv_host into check_change_password().
      sql/sql_acl.cc:
        Add exact flag for find_acl_user, so we can specify that we want
        an exact match on the hostname.
      d40acb4d