- 06 Feb, 2005 1 commit
-
-
patg@krsna.patg.net authored
This patch contains all that my previous patch (1.1814) contained, with the addition of using cli_fetch_lengths for handling binary data (Bar noted this on the review of 1.1814, Guilhem suggested using cli_fetch_lenghts by making available via removal of static in method definition and declaration in mysql.h, but Konstantin had some reservations, but he said to commit the patch using this anyway, and I suppose this can be discussed. I abandoned 1.1814 because Monty made a couple fixes to my code as well as formatting changes, and I thought it would just be easier to hand-edit my changes into a fresh clone and then make a patch. The reason for using cli_fetch_lengths is so that I can correctly get the length of the field I am setting into the field. I was previously using 'strlen' but Bar pointed out this won't correctly get the length of binary data and is also less effecient. Upon testing, it was in fact verified that binary data in a blob table was being inserted correctly, but not being retrieved correctly, all due to not having the correct value for the field: (*field)->store(row[x], strlen(row[x]), &my_charset_bin); was changed to: (*field)->store(row[x], lengths[x], &my_charset_bin); lengths being a unsigned long pointer to the values of the field lengths from a MYSQL_ROW. Since the server doesn't have the function "mysql_fetch_lengths" available, I tried to use "result->lengths", but this isn't set, so I finally successfully used cli_fetch_lenghts, which does give the correct lengths, and now the binary data gets retrieved correctly. I've also run the code through indent-ex and am using Brian's vimrc to ensure correct formatting! This code passes the entire test suite, without any errors or warning on both my workstation and build.mysql.com
-
- 05 Feb, 2005 11 commits
-
-
guilhem@mysql.com authored
-
guilhem@mysql.com authored
-
jimw@mysql.com authored
-
jimw@mysql.com authored
into mysql.com:/home/jimw/my/mysql-5.0-clean
-
sergefp@mysql.com authored
into mysql.com:/home/psergey/mysql-5.0-outer-joins-cleanup
-
sergefp@mysql.com authored
Outer joins cleanup: Remove TABLE::outer_join and use TABLE::maybe_null only (2nd patch after Monty's comments).
-
mskold@mysql.com authored
into mysql.com:/usr/local/home/marty/MySQL/mysql-5.0
-
mskold@mysql.com authored
-
guilhem@mysql.com authored
into mysql.com:/home/mysql_src/mysql-4.1-clean
-
monty@mysql.com authored
into mysql.com:/home/my/mysql-5.0
-
monty@mysql.com authored
Cleanup during reviews of new pushed code
-
- 04 Feb, 2005 28 commits
-
-
sergefp@mysql.com authored
into mysql.com:/home/psergey/mysql-4.1-bug7816
-
sergefp@mysql.com authored
into mysql.com:/home/psergey/mysql-5.0-bug7716
-
konstantin@mysql.com authored
CLIENT_LIBS in mysql_config as CLIENT_LIBS point to builddir when we use the bundled zlib.
-
guilhem@mysql.com authored
Proposal to fix this problem: when using libmysqlclient, you must call mysql_server_end() to nicely free memory at the end of your program; it however sounds weird to call a function named *SERVER_end* when you're the CLIENT (you're not ending the server, you're ending your ability to talk to servers). So here I add two defines which should be more generic names. Our manual mentions these functions only for libmysqld API so needs some fixing, and then we can close BUG#8099 and BUG#6149.
-
guilhem@mysql.com authored
when we close the session's temp tables at session end, we automatically write to binlog *one* DROP TEMPORARY TABLE *per tmp table*.
-
jimw@mysql.com authored
-
jimw@mysql.com authored
-
jimw@mysql.com authored
-
jimw@mysql.com authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
jimw@mysql.com authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
jimw@mysql.com authored
into mysql.com:/home/jimw/my/mysql-4.1-clean
-
mysqldev@mysql.com authored
into mysql.com:/home/mysqldev/tulin/mysql-4.1
-
acurtis@pcgem.rdg.cyberkinetica.com authored
-
tulin@mysql.com authored
into mysql.com:/home/mysqldev/tulin/mysql-5.0
-
kent@mysql.com authored
USE_RUNNING_SERVER should be set to 0 or 1
-
serg@serg.mylan authored
into serg.mylan:/usr/home/serg/Abk/mysql-4.1
-
hf@deer.(none) authored
-
serg@serg.mylan authored
into serg.mylan:/usr/home/serg/Abk/mysql-4.1
-
serg@serg.mylan authored
ftbw->off wasn't cleared on reinit - Bug#8234
-
marko@hundin.mysql.fi authored
into hundin.mysql.fi:/home/marko/mysql-5.0
-
msvensson@neptunus.homeip.net authored
into neptunus.homeip.net:/home/msvensson/mysql/mysql-5.0-cluster-extra
-
msvensson@neptunus.homeip.net authored
-
marko@hundin.mysql.fi authored
-
tulin@mysql.com authored
fixed change in struct in 4.1->5.0 merge
-
mysqldev@mysql.com authored
into mysql.com:/home/mysqldev/tulin/mysql-4.1
-
mysqldev@mysql.com authored
into mysql.com:/home/mysqldev/tulin/mysql-5.0
-
mysqldev@mysql.com authored
-
tomas@poseidon.ndb.mysql.com authored
into poseidon.ndb.mysql.com:/home/tomas/mysql-4.1
-