1. 22 Oct, 2009 1 commit
  2. 21 Oct, 2009 1 commit
    • Konstantin Osipov's avatar
      Backport of revno 2630.28.10, 2630.28.31, 2630.28.26, 2630.33.1, · d4632dff
      Konstantin Osipov authored
      2630.39.1, 2630.28.29, 2630.34.3, 2630.34.2, 2630.34.1, 2630.29.29,
      2630.29.28, 2630.31.1, 2630.28.13, 2630.28.10, 2617.23.14 and
      some other minor revisions.
      
      This patch implements: 
      
      WL#4264 "Backup: Stabilize Service Interface" -- all the
      server prerequisites except si_objects.{h,cc} themselves (they can
      be just copied over, when needed).
      
      WL#4435: Support OUT-parameters in prepared statements.
      
      (and all issues in the initial patches for these two
      tasks, that were discovered in pushbuild and during testing).
      
      Bug#39519: mysql_stmt_close() should flush all data
      associated with the statement.
      
      After execution of a prepared statement, send OUT parameters of the invoked
      stored procedure, if any, to the client.
      
      When using the binary protocol, send the parameters in an additional result
      set over the wire.  When using the text protocol, assign out parameters to
      the user variables from the CALL(@var1, @var2, ...) specification.
      
      The following refactoring has been made:
        - Protocol::send_fields() was renamed to Protocol::send_result_set_metadata();
        - A new Protocol::send_result_set_row() was introduced to incapsulate
          common functionality for sending row data.
        - Signature of Protocol::prepare_for_send() was changed: this operation
          does not need a list of items, the number of items is fully sufficient.
      
      The following backward incompatible changes have been made:
        - CLIENT_MULTI_RESULTS is now enabled by default in the client;
        - CLIENT_PS_MULTI_RESUTLS is now enabled by default in the client.
      d4632dff
  3. 20 Oct, 2009 1 commit
  4. 19 Oct, 2009 2 commits
    • Kristofer Pettersson's avatar
      Automerge · 4a494eeb
      Kristofer Pettersson authored
      4a494eeb
    • Kristofer Pettersson's avatar
      Bug#27145 EXTRA_ACL troubles · b5559f53
      Kristofer Pettersson authored
      The flag EXTRA_ACL is used in conjugation with our access checks, yet it is
      not clear what impact this flag has.
      This is a code clean up which replaces use of EXTRA_ACL with an explicit
      function parameter.
      The patch also fixes privilege checks for:
      - SHOW CREATE TABLE: The new privilege requirement is any privilege on
        the table-level.
      - CHECKSUM TABLE: Requires SELECT on the table level.
      - SHOW CREATE VIEW: Requires SHOW_VIEW and SELECT on the table level
        (just as the manual claims)
      - SHOW INDEX: Requires any privilege on any column combination.
      b5559f53
  5. 16 Oct, 2009 9 commits
    • Alexander Nozdrin's avatar
      Pull from mysql-next-mr-runtime. · 519f1aee
      Alexander Nozdrin authored
      519f1aee
    • Alexander Nozdrin's avatar
      Backporting a patch for Bug#47421 from 6.0: · 27adfa07
      Alexander Nozdrin authored
      revno: 2617.68.41
      committer: Alexander Nozdrin <alik@sun.com>
      branch nick: mysql-6.0-codebase-bugfixing-bug47421
      timestamp: Wed 2009-09-23 17:48:11 +0400
      message:
        A patch for Bug#47421 (Server crash from -
        SELECT SUM ( DISTINCT <char_column>) in azalea).
        
        The problem was that DBUG_RETURN() macro should have been
        used instead the 'return' operator.
      27adfa07
    • Konstantin Osipov's avatar
      Backport of: · 2b91a639
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.22.11
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-records
      timestamp: Mon 2008-08-11 16:40:09 +0400
      message:
        Move read_record related functions to a new header - records.h
      2b91a639
    • Alexander Nozdrin's avatar
      Backporting revision from 6.0: · 1c7be450
      Alexander Nozdrin authored
      revno: 2617.56.25
      committer: Alexander Nozdrin <alik@sun.com>
      branch nick: azalea-bugfixing
      timestamp: Thu 2009-07-09 20:30:43 +0400
      message:
        Add a comment in the source (Bug#40358).
      1c7be450
    • Alexander Nozdrin's avatar
      Backporting patch for Bug#38992 from 6.0. · 4ebb631f
      Alexander Nozdrin authored
      Original revision:
      revno: 2617.55.2
      committer: Alexander Nozdrin <alik@sun.com>
      branch nick: azalea-bf-bug38992
      timestamp: Fri 2009-06-19 16:41:16 +0400
      message:
        Fix for Bug#38992: Server crashes sporadically with
        'waiting for initial ...' msg on windows.
        
        The problem is that connection timeout is too small
        for busy windows box.
        
        The fix is to
          - add support for connect_timeout command line argument
            to mysqltest;
          - set default value of the connect_timeout option to
            120 seconds.
      4ebb631f
    • Konstantin Osipov's avatar
      Backport of: · 2ae359db
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.13.6
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-3288
      timestamp: Fri 2008-07-11 20:22:44 +0400
      message:
        WL#3288, step 1: ensure that the SQL layer always closes an open
        cursor (rnd or index read) before closing a handler.
      2ae359db
    • Konstantin Osipov's avatar
      Backport of 2617.65.4 from 6.0-codebase. · 8441517b
      Konstantin Osipov authored
      A fix and a test case for Bug#34898 "mysql_info() reports 0 warnings
      while mysql_warning_count() reports 1"
      
      Review the patch by Chad Miller, implement review comments
      (since Chad left) and push the patch.
      
      This bug is actually not a bug. At least according to Monty.
      See Bug#841 "wrong number of warnings" reported back in July 2003
      and closed as "not a bug".
      mysql_info() was printing the number of truncated columns, not
      the number of warnings.
      But since the message of mysql_info() was "Warnings: <number of truncated
      columns>", people would expect to get the number
      of warnings in it, not the number of truncated columns.
      
      So a possible fix would be to change the message of mysql_info()
      to say Rows changed: <n>, truncated: <m>.
      
      Instead, put the number of warnings there. That is, remove the
      feature that thd->cuted_fields (the number of truncated fields)
      is exposed to the client. The number of truncated columns can be
      calculated on the client, by analyzing SHOW WARNINGS output,
      and in future we may remove thd->cuted_fields altogether.
      So let's have one less thing to worry about.
      8441517b
    • Konstantin Osipov's avatar
      Merge with next-mr-runtime · efc27b5f
      Konstantin Osipov authored
      efc27b5f
    • Konstantin Osipov's avatar
      311fe126
  6. 15 Oct, 2009 10 commits
    • Konstantin Osipov's avatar
      Merge with next-mr-runtime · 66774f41
      Konstantin Osipov authored
      66774f41
    • Konstantin Osipov's avatar
      Backport of: · 88f7de57
      Konstantin Osipov authored
      ------------------------------------------------------------
      revno: 2476.657.208
      committer: anozdrin/alik@station.
      timestamp: Tue 2007-12-04 17:22:53 +0300
      message:
      Remove rpl_probe, enable_rpl_parse and disable_rpl_parse commands
      from mysqltest, the corresponding funtctions have been removed from
      MySQL C API
      88f7de57
    • Konstantin Osipov's avatar
      Backport of: · 16218fe5
      Konstantin Osipov authored
      ------------------------------------------------------------
      revno: 2476.981.1
      committer: msvensson@pilot.mysql.com
      timestamp: Mon 2007-11-26 19:03:23 +0100
      message:
        Bug#31952 Remove undocumented mysql_rpl_* functions.
        - Functions removed + variables in st_mysql and st_mysql_options 
          renamed to "unused".
        - Code updated to work without those functions and variables
      16218fe5
    • Konstantin Osipov's avatar
      Backport of: · 93ab04da
      Konstantin Osipov authored
      ---------------------------------------------------------------------
      revno: 2476.980.1
      committer: msvensson@pilot.mysql.com
      timestamp: Wed 2007-10-31 18:17:54 +0100
      message:
        Bug#31954 Remove undocumented mysql_manager_* C API functions and
        mysqlmanager (old)
          - Remove the mysql_manager* functions, struct and defines
      93ab04da
    • Alexander Nozdrin's avatar
      A backporting patch for the following revision from 6.0: · adc8d5ee
      Alexander Nozdrin authored
      revno: 2630.22.41
      committer: Alexander Nozdrin <alik@mysql.com>
      branch nick: 6.0-rt-bug39255
      timestamp: Thu 2008-10-16 16:39:30 +0400
      message:
        A patch for Bug#39255: Stored procedures: crash if function
        references nonexistent table.
        
        The problem is not reproduced in 6.0. Adding a test case.
      adc8d5ee
    • Alexander Nozdrin's avatar
      Adding funcs_1 into "make test" · eed8c7ab
      Alexander Nozdrin authored
      eed8c7ab
    • Magne Mahre's avatar
      Bug #43054 Assertion `!table->auto_increment_field_not_null' failed when · 673b530e
      Magne Mahre authored
                 redefining trigger
            
      The 'table->auto_increment_field_not_null' flag is only valid within
      processing of a single row, and should be set to FALSE before
      navigating to the next row, or exiting the operation.
            
      This bug was caused by an SQL error occuring while executing a trigger
      after the flag had been set, so the normal resetting was bypassed.
      The table object was then returned to the table share's cache in
      a dirty condition.   When the table object was reused, an assert
      caught that the flag was set.
            
      This patch explicitly clears the flag on error/abort.
      
      
      Backported from mysql-6.0-codebase  revid: 2617.52.1
      673b530e
    • Magne Mahre's avatar
      Bug #38124 (clean-up patch) · 0a92a344
      Magne Mahre authored
      The fix for Bug #38124 introuced a bug. If the value given 
      for a set_var exceeded the length of the temporary buffer,
      we would read behind the end of the buffer.  Using 
      c_ptr_safe(), instead of c_ptr(), ensures that we won't
      read beyond the buffer limit
      
      mysql-6.0-codebase revid: 2617.44.1
      0a92a344
    • Magne Mahre's avatar
      Bug #37433 Deadlock between open_table, close_open_tables, · 6b80cd91
      Magne Mahre authored
                      get_table_share, drop_open_table
                  
      In the partition handler code, LOCK_open and share->LOCK_ha_data
      are acquired in the wrong order in certain cases.  When doing a
      multi-row INSERT (i.e a INSERT..SELECT) in a table with auto-
      increment column(s). the increments must be in a monotonically
      continuous increasing sequence (i.e it can't have "holes"). To
      achieve this, a lock is held for the duration of the operation.
      share->LOCK_ha_data was used for this purpose.
                  
      Whenever there was a need to open a view _during_ the operation
      (views are not currently pre-opened the way tables are), and
      LOCK_open was grabbed, a deadlock could occur.  share->LOCK_ha_data
      is other places used _while_ holding LOCK_open.
                  
      A new mutex was introduced in the HA_DATA_PARTITION structure,
      for exclusive use of the autoincrement data fields, so we don't
      need to overload the use of LOCK_ha_data here.
                  
      A module test case has not been supplied, since the problem occurs
      as a result of a race condition, and testing for this condition 
      is thus not deterministic.   Testing for it could be done by
      setting up a test case as described in the bug report.
      6b80cd91
    • Magne Mahre's avatar
      Bug #38124 "general_log_file" variable silently unset when using expression · ebb0b02c
      Magne Mahre authored
                        
      When assigning the new string value to the variable, the
      Item::str_value member was used.  This is not according to
      the protocol.  str_value is an internal member used for
      temporary assignments, and is not consistently set for all
      string operations.  It is set for constant strings, so it would
      work in these cases, but not for string functions (concat,
      substr, etc.)
                        
      The correct approach is to use Item::val_str(..) to evaluate
      and retrieve the string.
      
      Backport from 6.0-codebase
      
      6.0-codebase revno: 2617.31.17
      ebb0b02c
  7. 14 Oct, 2009 6 commits
    • Konstantin Osipov's avatar
      Backport of: · 64dbe379
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2617.22.5
      committer: Konstantin Osipov <kostja@sun.com>
      branch nick: mysql-6.0-runtime
      timestamp: Tue 2009-01-27 05:08:48 +0300
      message:
        Remove non-prefixed use of HASH.
        Always use my_hash_init(), my_hash_inited(), my_hash_search(),
        my_hash_element(), my_hash_delete(), my_hash_free() rather
        than non-prefixed counterparts (hash_init(), etc).
        Remove the backward-compatible defines.
      64dbe379
    • Konstantin Osipov's avatar
      Backport of: · 902f99bc
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.28.1
      committer: Konstantin Osipov <kostja@sun.com>
      branch nick: mysql-6.0-runtime
      timestamp: Thu 2008-10-23 15:23:44 +0400
      message:
        Bug#32738 "mysqld: Two slow log option/variable descriptions are
        inaccurate"
        Update option description per suggestion from the documentation team.
      902f99bc
    • Konstantin Osipov's avatar
      Backport of: · a1fbd5e0
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.22.39
      committer: Konstantin Osipov <kostja@sun.com>
      branch nick: mysql-6.0-runtime
      timestamp: Wed 2008-10-08 23:44:34 +0400
      message:
        Bug #34481 A typo in HugeTLB error Message.
      a1fbd5e0
    • Jon Olav Hauglid's avatar
      Backport of revno: 2617.81.4 · 6438ca9f
      Jon Olav Hauglid authored
      Bug #47274 assert in open_table on CREATE TABLE <already existing>
      
      The problem was an assertion during execution of CREATE TABLES. 
      This assertion would occur if INSERT DELAYED or REPLACE DELAYED
      were used to update a table containing an AUTO_INCREMENT column
      and if the inserted row had a user-supplied value for that column.
      Any CREATE TABLE statement (including CREATE TABLE SELECT and
      CREATE TABLE LIKE) trying to create the same table and 
      which followed the INSERT/REPLACED would cause the assertion.
      
      The problem was only noticeable on debug builds of the server
      and not present in the mysql-5.1 tree.
      
      The cause of the problem was that the code for delayed insert did
      not properly reset the TABLE->auto_increment_if_null flag after 
      The flag is used to indicate that a non-null value of an auto_increment field
      has been provided by the user or retrieved from a current record.
      Open_tables() contains an assertion that tests this flag, and this
      was triggered by CREATE TABLE.
      
      This patch fixes the problem by resetting the auto_increment_if_null
      field to FALSE once INSERT/REPLACE DELAYED has updated the table, 
      similar to what is done already for regular INSERT statements.
      
      Test case added to delayed.test.
      6438ca9f
    • Konstantin Osipov's avatar
      Backport of: · 7fc88467
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.22.31
      committer: Konstantin Osipov <kostja@sun.com>
      branch nick: mysql-6.0-runtime
      timestamp: Thu 2008-10-02 19:08:09 +0400
      message:
        Bug #34818 --default-table-type option should be removed
        Remove the deprecated option.
      7fc88467
    • Konstantin Osipov's avatar
      Backport of: · 4db335dc
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.22.8
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-runtime
      timestamp: Sun 2008-08-10 18:49:52 +0400
      message:
        Get rid of typedef struct for the most commonly used types:
        TABLE, TABLE_SHARE, LEX. This simplifies use of tags
        and forward declarations.
      4db335dc
  8. 13 Oct, 2009 6 commits
    • Konstantin Osipov's avatar
      ---------------------------------------------------------- · 2f01aa97
      Konstantin Osipov authored
      revno: 2630.2.16
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-runtime
      timestamp: Fri 2008-06-27 13:26:03 +0400
      message:
        Fix max_user_connections_func failure on Solaris.
        A connection that failed to log in due to a resource limit could
        be returned to the thread pool with a dangling link to user_connect
        structure of an old user. Later on it could be authenticated
        to a user that doesn't have a resource limit, so this dangling
        link won't be reset. --pool-of-threads mode made the situation
        easy to reproduce, and thus highlighted a bug that has been
        around forever.
        Make sure there are no dangling links.
      2f01aa97
    • Konstantin Osipov's avatar
      Backport of: · fd6a1a07
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.7.1
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-lock-tables-new
      timestamp: Mon 2008-06-02 15:14:18 +0400
      message:
        Fix a test suite timeout in partition.test and partition_csv.test
      fd6a1a07
    • Konstantin Osipov's avatar
      Backport of: · 59c1746b
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2630.2.6
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-27430
      timestamp: Mon 2008-05-26 16:12:28 +0400
      message:
        Cover four special cases of WL#4166 with tests:
        - when the query cache is disabled at the time of prepared statement
        reprepare
        - when long data parameters are used
        - when character_set_connection != character_set_client, and a parameter
        conversion takes place
        - when parameter data is out of acceptable range, e.g. year 10000 is
        supplied as part of MYSQL_TYPE_DATETIME value. The server is supposed
        to warn in such case.
      59c1746b
    • Konstantin Osipov's avatar
      Backport of: · 4ce7c966
      Konstantin Osipov authored
      -----------------------------------------------------------
      revno: 2630.2.4
      committer: Konstantin Osipov <konstantin@mysql.com>
      branch nick: mysql-6.0-runtime
      timestamp: Fri 2008-05-23 02:42:32 +0400
      message:
        Bug#27430 "Crash in subquery code when in PS and table DDL changed after
        PREPARE"
        Add a test case for the situation with small TDC and many merge children.
      
      from 6.0-codebase.
      4ce7c966
    • Konstantin Osipov's avatar
      Backport of the following revision from 6.0-codebase: · 3dd1d598
      Konstantin Osipov authored
      ----------------------------------------------------------
      revno: 2617.1.12
      committer: kostja@bodhi.(none)
      timestamp: Sun 2008-04-20 11:18:52 +0400
      message:
        A fix for Bug#32771 "events_bugs.test fails randomly".
        In Event_scheduler::stop(), which may be called from destructor,
        wait synchronously for the parallel Event_scheduler::stop() to
        complete before returning. This fixes a race between
        MySQL shutdown thread and the scheduler thread who could call
        stop() in parallel.
      3dd1d598
    • Konstantin Osipov's avatar
      Introduce thd->query_cache_tls (thread · ea6a22bf
      Konstantin Osipov authored
      local storage for query cache). 
      We need more than one pointer in a thread to
      represent the query cache and net->query_cache_query can not be used
      any more (due to ABI compatibility issues and to different life
      time of NET and THD).
      This is a backport of the following patch from 6.0:
      ----------------------------------------------------------
      revno: 2476.1157.2
      committer: kostja@bodhi.(none)
      timestamp: Sat 2007-06-16 13:29:24 +0400
      ea6a22bf
  9. 12 Oct, 2009 3 commits
    • Magne Mahre's avatar
      Bug #33693 general log name and location depend on PID file, · 10390cec
      Magne Mahre authored
                 not on predefined values
      
      The default name of the PID file was constructed, as documented, 
      based on the hostname.  This name was subsequently used as the
      base for the general log file name.   If the name of the PID
      file was overridden in the configuration, and no explicit name
      was set for the general log file, the path location for the
      PID file was used also for the general log file.
                        
      A new variable, 'default_logfile_name', has been introduced.  This name
      is constructed based on the hostname, and is then used to
      construct both the PID file and the general log file.
                        
      The general log file will now, unless explicitly set, be
      located in the server data directory (as documentated in
      the server docs)
      10390cec
    • Jon Olav Hauglid's avatar
      Bug #35877 Update .. WHERE with function, constraint violation, crash · 0e852eba
      Jon Olav Hauglid authored
      Unable to reproduce crash with current version of the 5.5.0 codebase.
      Test case for MyISAM/InnoDB based on the bug rapport added to 
      sp_trans.test.
      
      Backport of revno: 2617.65.9.
      0e852eba
    • Jon Olav Hauglid's avatar
      Bug #34453 Can't change size of file (Errcode: 1224) · c75fa0be
      Jon Olav Hauglid authored
           
      Unable to reproduce error on current version of the 5.5.0
      codebase. Test case based on the bug report added to trigger.test.
      
      Backport of revno: 2617.52.11.
      c75fa0be
  10. 10 Oct, 2009 1 commit