An error occurred fetching the project authors.
  1. 01 Nov, 2007 1 commit
    • unknown's avatar
      Bug#30671 · aea5007d
      unknown authored
        "ALTER SERVER can cause server to crash"
        While retrieving values, it would erronously set the socket value
        to NULL and attempt to use it in strcmp().
        Ensure it is correctly set to "" so that strcmp may not crash.
      
      
      mysql-test/r/federated_server.result:
        results for bug30671
        fix inconsistent result
      mysql-test/t/federated_server.test:
        surplus semicolon
        test for bug30671
      sql/sql_servers.cc:
        bug30671
        inside function get_server_from_table_to_cache()
          server->socket was being set to NULL instead of empty string
      aea5007d
  2. 04 Apr, 2007 1 commit
  3. 24 Mar, 2007 2 commits
    • unknown's avatar
      BUG#26257 New Federated Server Functionality Doesn't support differently named tables · 99c5c28c
      unknown authored
      * Modified Federated memory allocation to use MEM_ROOT
      * Modified sql_servers and federated to allocate share connection
        parameters to use MEM_ROOT
      * Modified Federated to allow tablename in addition to server name
      * Implicit flushing of tables using altered/dropped server name
      * Added tests to prove new functionality works
      
      Contributors to this patch: Patrick Galbraith, Antony Curtis
      
      
      mysql-test/r/federated_server.result:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
          New test results
      mysql-test/t/federated_server.test:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        New test which ensures that one can use the new 'create server'
        functionality and have tables point to the correct table, using CONNECTION='server',
        CONNECTION="server/tablename" and CONNECTION="mysql://...url"
      sql/mysql_priv.h:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        new function: close_cached_connection_tables()
      sql/sql_base.cc:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        new function: close_cached_connection_tables()
          closes all open tables which match connection string
          provides functionality to allow flushing of altered/dropped server names.
      sql/sql_servers.cc:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * Added function clone_server() to allocate a new server for use by
          get_server_by_name() when creating a federated table
        
        * Now using MEM_ROOT allocation (mark and sweep) to account for meta
          data parameters being allocated properly, particularly with regards to
          to SERVER object. Also cleans up code allocating share.
        
        * Tables using the old definition of server name are now flushed on successful
          execution of ALTER/DROP SERVER.
        
        style: fixed some line-wrapping
      sql/sql_servers.h:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * change in prototype to get_server_by_name()
          caller can now provide mem_root which strings will be copied in to.
      storage/federated/ha_federated.cc:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * Simplified share and share member memory allocaton to use MEM_ROOT
        * Modified parse_url to parse table names along with server names
      storage/federated/ha_federated.h:
        BUG #26257 New Federated Server Functionality Doesn't support differently named tables
        
        * Added MEM_ROOT share member
      99c5c28c
    • unknown's avatar
      Bug#25721 · cb5b56c8
      unknown authored
        "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        Deadlock caused by inconsistant use of mutexes in sql_server.cc
        One mutex has been removed to resolve deadlock.
        Many functions were made private which should not be exported.
        Unused variables and function removed.
      
      
      mysql-test/r/federated_server.result:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        New test results
      mysql-test/t/federated_server.test:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        Test for bug by using stored procedure. Unpatched server would deadlock frequently.
      sql/sql_parse.cc:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        check for correct error code when dropping server
      sql/sql_servers.cc:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        Removed unneccessary mutex, only need THR_LOCK_servers rwlock to
        guard data structures against race conditions. Misuse of other mutex
        caused deadlock by inconsistant ordering of mutex lock operations.
        Alter order of some operations to hit memory before disk.
        Removed unused function.
        Removed servers_version and servers_cache_initialised variables.
        Made many internal functions static.
      sql/sql_servers.h:
        Bug 25721 "Concurrent ALTER/CREATE SERVER can lead to deadlock"
        
        remove internal functions from being exported.
      cb5b56c8
  4. 13 Mar, 2007 1 commit
    • unknown's avatar
      Bug#25671 · 6d98913b
      unknown authored
        "CREATE/DROP/ALTER SERVER should require privileges"
        Add check for SUPER privilege when executing CREATE/DROP/ALTER SERVER.
        Previously, any user even with only USAGE priv can execute those commands.
      
      
      mysql-test/r/federated_server.result:
        Bug25671 - CREATE/DROP/ALTER SERVER should require privileges
      mysql-test/t/federated_server.test:
        Bug25671 - CREATE/DROP/ALTER SERVER should require privileges
      sql/sql_parse.cc:
        Bug25671 - CREATE/DROP/ALTER SERVER should require privileges
          Add check for SUPER privilege when executing CREATE/DROP/ALTER SERVER
      6d98913b
  5. 28 Feb, 2007 1 commit
    • unknown's avatar
      Bug#20166 mysql-test-run.pl does not test system privilege tables creation · 40c7f723
      unknown authored
       - Additional fixes caused by running without anonymous users
      
      
      mysql-test/r/federated_server.result:
        There are no default server in mysql.servers anymore
        The test will create it's own test servers
      mysql-test/r/rpl_read_only.result:
        Update result
      mysql-test/r/rpl_row_USER.result:
        Update test result, it basically checks that the values
        return by USER() and CURRENT_USER() are the
        same on master and slave, so it's doing the correct
        thing. Since connection m_1 is logged in as ''@localhost%
        that is what will end up in the log.
      mysql-test/t/ndb_multi_row.test:
        Connect as root instead of '' which would pick currently logged in user
      mysql-test/t/rpl_read_only.test:
        Add user test with no privs(no anonymous by default anymore)
      40c7f723
  6. 13 Dec, 2006 1 commit
    • unknown's avatar
      WL# 3031 · 1a95fcff
      unknown authored
      Found that the results from select had to be fixed too.
      
      
      1a95fcff
  7. 12 Dec, 2006 2 commits
    • unknown's avatar
      WL #3031 · 3e560827
      unknown authored
      Trying again (!) to commit the fix containing replace-result to fix the problem
      with hard-coded ports in the result file of the federated_server test.
      
      
      3e560827
    • unknown's avatar
      WL# 3031 · fecde96a
      unknown authored
      Added --replace-result to avoid hard-coding of port
      
      
      fecde96a
  8. 02 Dec, 2006 1 commit
    • unknown's avatar
      WL# 3031 · 4e72191c
      unknown authored
      Backport of functionality in private 5.2 tree. 
      
      Added new language to parser, new mysql.servers table and associated code
      to be used by the federated storage engine to allow central connection information
      per WL entry.
      
      
      libmysqld/Makefile.am:
        WL# 3031
        
        Added sql_servers.cc to libmysqld Makefile.am
      mysql-test/lib/init_db.sql:
        WL# 3031
        
        Added mysql.servers creation to init_db.sql, which is in turn called by mysql-test-run.pl
      scripts/mysql_create_system_tables.sh:
        WL# 3031
        
        Added mysql.servers table creation to script called by non-perl mysql-test-run
      sql/Makefile.am:
        WL# 3031
        
        Added sql_servers source and headers to Makefile.am to be built
      sql/lex.h:
        WL# 3031
        
        Added tokens needed for SERVERS scheme
      sql/mysql_priv.h:
        WL #3031
        
        Added sql_servers.h to mysql_priv.h so mysqld.cc and other code can link with sql_servers code
      sql/mysqld.cc:
        WL# 3031
        
        Added servers_free and servers_init to mysqld
      sql/sql_lex.cc:
        WL# 3031
        
        Added lex->server_options parameter initialisation
      sql/sql_lex.h:
        WL #3031
        
        Added SQLCOM commands needed for sql_server actions
      sql/sql_parse.cc:
        WL# 3031
        
        Added switch actions for new SQLCOM sql_server actions
      sql/sql_yacc.yy:
        WL #3031
        
        Added tokens needed for sql_servers, CREATE/DROP/ALTER server functionality
      sql/share/errmsg.txt:
        WL# 3031
        
        Added two new errors to errormsg.sys
      storage/federated/ha_federated.cc:
        WL #3031
        
        Modified federated storage engine to use new connection scheme (servers 
        table) if connection string only specifies connection name vs. complete
        URL
      storage/federated/ha_federated.h:
        WL# 3031
        
        Added new share members needed for connection scheme
      sql/sql_servers.cc:
        WL #3031
        
        sql_servers.cc - all methods required for manipulating mysql.servers table
        to work with federated new connection scheme (CREATE/ALTER/DROP SERVER ...)
      sql/sql_servers.h:
        WL #3031
        
        New header file for sql_servers functionality
      mysql-test/r/federated_server.result:
        WL #3031
        
        New test results for testing new connection scheme
      sql/sql_yacc.yy.bak:
        WL #3031
        
        Added tokens and definitions required for new CREATE/ALTER/DROP SERVER
        for sql_servers functionality. See WL for details.
      mysql-test/t/federated_server.test:
        WL #3031
        
        New test for testing CREATE/ALTER/DROP SERVER, as well as testing that
        federated works with both tradition connection scheme as well as new
        connection scheme.
      4e72191c