- 23 Jan, 2007 1 commit
-
-
unknown authored
Before this fix, the command SHOW ENGINE <name> STATUS would: - print a warning if the engine name is unknown, - proceed and implement the same behavior as SHOW ENGINE ALL STATUS, and list the status of all the storage engines registered. In particular, this behavior caused confusion about the command : SHOW ENGINE MUTEX STATUS, which as a side effect would print the status of the innodb engine when that engine is registered. Also, before this fix, every time an unknown engine name was substituted by the default engine (which happen unless SQL_MODE NO_ENGINE_SUBSTITUTION is set), a malformed warning was raised. For example, the command ALTER TABLE T1 ENGINE = X would print : Warnings: Error 1286 Unknown table engine 'X' With this fix: SHOW ENGINE <name> STATUS|LOGS|MUTEX always fails with an error when the engine <name> is unknown. For other commands, warnings about unknown engines are raised as: Warnings: Warning 1286 Unknown table engine 'X' In other words, engine substitution never affect the SHOW ENGINE command, since this would lead to very confusing results. mysql-test/r/ndb_dd_basic.result: Warnings for unknown engines. mysql-test/r/partition_innodb.result: Warnings for unknown engines. mysql-test/r/ps_1general.result: Fixed SHOW ENGINE <name> STATUS|LOGS|MUTEX mysql-test/r/show_check.result: Fixed SHOW ENGINE <name> STATUS|LOGS|MUTEX mysql-test/t/ps_1general.test: Fixed SHOW ENGINE <name> STATUS|LOGS|MUTEX mysql-test/t/show_check.test: Fixed SHOW ENGINE <name> STATUS|LOGS|MUTEX sql/sql_yacc.yy: Fixed SHOW ENGINE <name> STATUS|LOGS|MUTEX
-
- 19 Jan, 2007 6 commits
-
-
unknown authored
into moonlight.home:/home/tomash/src/mysql_ab/mysql-5.1-bug25211
-
unknown authored
The problem was that the events_bugs test could randomly fail due to races in the test case. The solution is to replace fixed sleeps with reliable polling of a certain state to settle. For that, a new auxiliary script include/wait_condition.inc is used, that allows waiting for a given query to return true. mysql-test/include/wait_until_rows_count.inc: Script is rewritten using new include/wait_condition.inc. mysql-test/r/events_bugs.result: Update result: add missing quotation mark. mysql-test/t/events_bugs.test: Replace --sleep with the reliable waiting for a certain state. mysql-test/include/wait_condition.inc: New BitKeeper file ``mysql-test/include/wait_condition.inc''
-
unknown authored
-
unknown authored
into weblab.(none):/home/marcsql/TREE/mysql-5.1-24562-merge mysql-test/r/alter_table.result: Auto merged mysql-test/t/alter_table.test: Auto merged sql/sql_yacc.yy: Auto merged
-
unknown authored
-
unknown authored
into weblab.(none):/home/marcsql/TREE/mysql-5.0-24562-merge mysql-test/t/alter_table.test: Auto merged
-
- 18 Jan, 2007 5 commits
-
-
unknown authored
WL#3681 (ALTER TABLE ORDER BY) Before this fix, the ALTER TABLE statement implemented an ORDER BY option with the following characteristics : 1) The order by clause accepts a list of criteria, with optional ASC or DESC keywords 2) Each criteria can be a general expression, involving operators, native functions, stored functions, user defined functions, subselects ... With this fix : 1) has been left unchanged, since it's a de-facto existing feature, that was already present in the code base and partially covered in the test suite. Code coverage for ASC and DESC was missing and has been improved. 2) has been changed to limit the kind of criteria that are permissible: now only a column name is valid. mysql-test/r/alter_table.result: Prevent ALTER TABLE ORDER BY clauses to use general expressions. mysql-test/t/alter_table.test: Prevent ALTER TABLE ORDER BY clauses to use general expressions. sql/sql_yacc.yy: Prevent ALTER TABLE ORDER BY clauses to use general expressions.
-
unknown authored
into moonlight.home:/home/tomash/src/mysql_ab/mysql-5.1-bug24404 mysql-test/r/view_grant.result: Auto merged mysql-test/t/view_grant.test: Auto merged sql/sql_view.cc: Auto merged
-
unknown authored
into moonlight.home:/home/tomash/src/mysql_ab/mysql-5.0-bug24404 sql/sql_view.cc: Auto merged mysql-test/r/view_grant.result: Manual merge. mysql-test/t/view_grant.test: Manual merge.
-
unknown authored
into moonlight.home:/home/tomash/src/mysql_ab/mysql-5.1-bug24404 sql/sql_view.cc: Auto merged mysql-test/r/view_grant.result: Manual merge. mysql-test/t/view_grant.test: Manual merge.
-
unknown authored
The problem was that if a prepared statement accessed a view, the access to the tables listed in the query after that view was done in the security context of the view. The bug was in the assigning of the security context to the tables belonging to a view: we traversed the list of all query tables instead. It didn't show up in the normal (non-prepared) statements because of the different order of the steps of checking privileges and descending into a view for normal and prepared statements. The solution is to traverse the list and stop once the last table belonging to the view was processed. mysql-test/r/view_grant.result: Add result for bug#24404: strange bug with view+permission+prepared statement. mysql-test/t/view_grant.test: Add test case for bug#24404: strange bug with view+permission+prepared statement. sql/sql_view.cc: Remove dead line. When setting security context, we should traverse the list of tables belonging to a given view, not all query tables. We achieve that by stopping at the first table past view_tables_tail.
-
- 17 Jan, 2007 7 commits
-
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime sql/mysqld.cc: Auto merged
-
unknown authored
sql/mysqld.cc: Once again, disable symlink.test under valgrind builds. symlink.test fails deep in mi_repair - the result of this having been disabled for almost 5 years.
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime sql/sql_parse.cc: Use local.
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime-debug-max sql/sql_parse.cc: SCCS merged
-
unknown authored
by the patch for Bug#4968 sql/sql_parse.cc: Fix lowercase_tables2 test failure on powermacg5: table_case_name() function needed create_info.alias if lowercase_table_names=2, which was not set for the stack copy of HA_CREATE_INFO. Move the update of create_info.alias from create_table_precheck to mysql_execute_command, so that it is done on the right object.
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime sql/mysqld.cc: Auto merged mysql-test/r/ps.result: SCCS merged mysql-test/t/ps.test: Use local
-
unknown authored
mysql-test/r/ps.result: Update result files. mysql-test/t/ps.test: Disable result ouptut of SHOW CREATE TABLE: DATA DIRECTORY option may be present or absent from the output depending on the build otpions and the operating system, so the output is not consistent across supported platforms. sql/mysqld.cc: Remove a tricky #ifdef dependency of --use-symbolic-links on PURIFY added in 2002: DEBUG options should not influence server functionality. This backfired by producing different output of SHOW CREATE TABLE depending on the build options (see also Bug#25677 "With --skip-symbolic-links option on, DATA DIRECTORY clause is silently ignored".
-
- 16 Jan, 2007 8 commits
-
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime mysql-test/t/ps.test: Use local. mysql-test/t/backup.test: SCCS merged
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime mysql-test/t/backup.test: Auto merged mysql-test/t/ps.test: Manual merge.
-
unknown authored
mysql-test/t/backup.test: Backport a patch for sporadically failing myisam.test (and now ps.test) from 5.0. The cause was in backup.test not cleaning up tables in mysqltest-vardir/tmp after itself. mysql-test/t/ps.test: Add additional protection against possible failure in the middle of backup.test
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime sql/sql_select.cc: Auto merged
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime BitKeeper/deleted/.del-libmysqld.dsp~78dc6a589e5a4149: Auto merged BitKeeper/deleted/.del-mysql.dsw~7ea9e16395f139f4: Auto merged BitKeeper/deleted/.del-mysql_explain_log.sh~5ddc62808e16bd57: Auto merged BitKeeper/deleted/.del-mysqld.dsp~ffdbf2d234e23e56: Auto merged BitKeeper/deleted/.del-mysqldemb.dsp~1baf8c0e59ee9f7e: Auto merged BitKeeper/deleted/.del-mysqldmax.dsp~5d213fe1c204142e: Auto merged mysql-test/r/ps.result: Auto merged mysql-test/r/select.result: Auto merged mysql-test/r/sp.result: Auto merged mysql-test/t/select.test: Auto merged mysql-test/t/sp.test: Auto merged mysys/my_read.c: Auto merged scripts/make_binary_distribution.sh: Auto merged sql/mysql_priv.h: Auto merged sql/sql_class.h: Auto merged sql/sql_insert.cc: Auto merged sql/sql_lex.cc: Auto merged sql/sql_lex.h: Auto merged sql/sql_list.h: Auto merged sql/sql_show.cc: Auto merged sql/sql_yacc.yy: Auto merged storage/innobase/buf/buf0buf.c: Auto merged storage/innobase/dict/dict0dict.c: Auto merged storage/innobase/fil/fil0fil.c: Auto merged storage/innobase/ha/ha0ha.c: Auto merged storage/innobase/include/hash0hash.h: Auto merged storage/innobase/lock/lock0lock.c: Auto merged storage/innobase/log/log0recv.c: Auto merged support-files/MySQL-shared-compat.spec.sh: Auto merged configure.in: Use local sql/sql_parse.cc: Use local sql/sql_table.cc: Use local mysql-test/t/ps.test: SCCS merged
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime sql/sql_class.h: Auto merged sql/sql_lex.cc: Auto merged sql/sql_lex.h: Auto merged sql/sql_yacc.yy: Auto merged
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.0-bg20390-2
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.1-bg20390
-
- 15 Jan, 2007 13 commits
-
-
unknown authored
into weblab.(none):/home/marcsql/TREE/mysql-5.0-6298
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-root BitKeeper/deleted/.del-mysql.dsw~7ea9e16395f139f4: Auto merged mysql-test/r/view.result: Auto merged BitKeeper/deleted/.del-mysqld.dsp~ffdbf2d234e23e56: Auto merged BitKeeper/deleted/.del-mysqldemb.dsp~1baf8c0e59ee9f7e: Auto merged BitKeeper/deleted/.del-mysqldmax.dsp~5d213fe1c204142e: Auto merged mysys/my_read.c: Auto merged scripts/make_binary_distribution.sh: Auto merged server-tools/instance-manager/listener.cc: Auto merged sql/item_func.cc: Auto merged sql/sp_head.cc: Auto merged sql/sp_head.h: Auto merged sql/sql_class.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_lex.cc: Auto merged sql/sql_lex.h: Auto merged sql/sql_prepare.cc: Auto merged sql/sql_string.cc: Auto merged sql/sql_yacc.yy: Auto merged storage/heap/hp_block.c: Auto merged storage/heap/hp_write.c: Auto merged storage/innobase/buf/buf0buf.c: Auto merged storage/innobase/dict/dict0dict.c: Auto merged storage/innobase/fil/fil0fil.c: Auto merged storage/innobase/ha/ha0ha.c: Auto merged storage/innobase/include/hash0hash.h: Auto merged storage/innobase/lock/lock0lock.c: Auto merged storage/innobase/log/log0recv.c: Auto merged support-files/MySQL-shared-compat.spec.sh: Auto merged tests/mysql_client_test.c: Auto merged BitKeeper/deleted/.del-libmysqld.dsp~78dc6a589e5a4149: SCCS merged mysql-test/t/view.test: Manual merge.
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.1-runtime
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-runtime sql/sql_parse.cc: Auto merged
-
unknown authored
sql/sql_parse.cc: A post-merge fix (broken alter_table.test): restore Svoj's fix for Bug#23404 lost during merge.
-
unknown authored
-
unknown authored
into trift2.:/MySQL/M50/push-5.0 VC++Files/libmysqld/libmysqld.dsp: Auto merged VC++Files/mysql.dsw: Auto merged VC++Files/mysqldemb/mysqldemb.dsp: Auto merged VC++Files/sql/mysqld.dsp: Auto merged VC++Files/sql/mysqldmax.dsp: Auto merged innobase/buf/buf0buf.c: Auto merged innobase/dict/dict0dict.c: Auto merged innobase/fil/fil0fil.c: Auto merged innobase/ha/ha0ha.c: Auto merged innobase/include/hash0hash.h: Auto merged innobase/lock/lock0lock.c: Auto merged innobase/log/log0recv.c: Auto merged mysys/my_read.c: Auto merged scripts/make_binary_distribution.sh: Auto merged support-files/MySQL-shared-compat.spec.sh: Auto merged
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.1-bg20390
-
unknown authored
into mockturtle.local:/home/dlenev/src/mysql-5.0-bg20390-2 sql/sql_select.cc: Auto merged
-
unknown authored
into bodhi.local:/opt/local/work/mysql-5.0-4968-to-push sql/mysql_priv.h: Auto merged sql/sql_class.h: Auto merged sql/sql_insert.cc: Auto merged sql/sql_parse.cc: Auto merged sql/sql_table.cc: Use local
-
unknown authored
mysql-test/r/sp.result: Auto merged mysql-test/t/sp.test: Auto merged sql/mysql_priv.h: Auto merged sql/sql_class.h: Auto merged sql/sql_insert.cc: Auto merged sql/sql_lex.cc: Auto merged sql/sql_lex.h: Auto merged sql/sql_list.h: Auto merged sql/sql_show.cc: Auto merged sql/sql_yacc.yy: Auto merged
-
unknown authored
into bodhi.local:/opt/local/work/mysql-4.1-4968-to-push sql/mysql_priv.h: Auto merged sql/sql_class.h: Auto merged sql/sql_insert.cc: Auto merged sql/sql_parse.cc: Manual merge. sql/sql_table.cc: Manual merge.
-