An error occurred fetching the project authors.
  1. 11 Nov, 2010 1 commit
    • Tatiana A. Nurnberg's avatar
      Bug #49752: 2469.126.2 unintentionally breaks authentication against · 1c37eaaa
      Tatiana A. Nurnberg authored
                        MySQL 5.1 server
      
      Server used to clip overly long user-names. This was presumably lost
      when code was made UTF8-clean.
      
      Now we emulate the behaviour for backward compatibility, but UTF8-ly
      correct.
      
      
      mysql-test/r/connect.result:
        Show that user-names that are too long get clipped now.
      mysql-test/t/connect.test:
        Show that user-names that are too long get clipped now.
      sql/sql_connect.cc:
        Clip user-name to 16 characters (not bytes).
      strings/CHARSET_INFO.txt:
        Clarify in docs.
      1c37eaaa
  2. 17 Mar, 2008 1 commit
    • unknown's avatar
      Avoid races in connect.test. · c1e69a77
      unknown authored
      The problem was in a test case for Bug33507:
        - when the number of active connections reaches the limit,
          the server accepts only root connections. That's achieved by
          accepting a connection, negotiating with the client and
          checking user credentials. If it is not SUPER, the connection
          is dropped.
        - when the server accepts connection, it increases the counter;
        - when the server drops connection, it decreases the counter;
        - the race was in between of decreasing the counter and accepting
          new connection:
          - max_user_connections = 2;
          - 2 oridinary user connections accepted;
          - extra user connection is establishing;
          - server checked user credentials, and sent 'Too many connections'
            error;
          - the client receives the error and establishes extra SUPER user
            connection;
          - the server however didn't decrease the counter (the extra
            user connection still is "alive" in the server) -- so, the new
            SUPER-user connection, will be dropped, because it exceeds
            (max_user_connections + 1).
      
      The fix is to implement "safe connect", which makes several attempts
      to connect and use it in the test script.
      
      
      mysql-test/r/connect.result:
        Update test file.
      mysql-test/t/connect.test:
        Avoid races in connect.test.
      mysql-test/include/connect2.inc:
        Auxiliary routine to establish a connection reliably.
      c1e69a77
  3. 14 Mar, 2008 1 commit
    • unknown's avatar
      A fix for Bug#35289: Too many connections -- wrong SQL state · 2ebee313
      unknown authored
      in some case.
      
      ER_CON_COUNT_ERROR is defined with SQL state 08004. However, this SQL state is not always
      returned.
      
      This error can be thrown in two cases:
      
        1. when an ordinary user (a user w/o SUPER privilege) is connecting,
          and the number of active user connections is equal or greater than
          max_connections.
      
        2. when a user is connecting and the number of active user connections is
          already (max_connections + 1) -- that means that no more connections will
          be accepted regardless of the user credentials.
      
      In the 1-st case, SQL state is correct.
      
      The bug happens in the 2-nd case -- on UNIX the client gets 00000 SQL state, which is
      absolutely wrong (00000 means "not error SQL state); on Windows
      the client accidentally gets HY000 (which means "unknown SQL state).
      
      The cause of the problem is that the server rejects extra connection
      prior to read a packet with client capabilities. Thus, the server
      does not know if the client supports SQL states or not (if the client
      supports 4.1 protocol or not). So, the server supposes the worst and
      does not send SQL state at all.
      
      The difference in behavior on UNIX and Windows occurs because on Windows
      CLI_MYSQL_REAL_CONNECT() invokes create_shared_memory(), which returns
      an error (in default configuration, where shared memory is not configured).
      Then, the client does not reset this error, so when the connection is
      rejected, SQL state is HY000 (from the error from create_shared_memory()).
      
      The bug appeared after test case for Bug#33507 -- before that, this behavior
      just had not been tested.
      
      The fix is to 1) reset the error after create_shared_memory();
      2) set SQL state to 'unknown error' if it was not received from
      the server.
      
      A separate test case is not required, since the behavior is already
      tested in connect.test.
      
      Note for doc-team: the manual should be updated to say that under
      some circumstances, 'Too many connections' has HY000 SQL state.
      
      
      mysql-test/r/connect.result:
        Update result file.
      sql-common/client.c:
        1. Reset an error from create_shared_memory();
        2. Set SQL state to 'unknown error' if it was not received from
           the server.
      2ebee313
  4. 13 Mar, 2008 1 commit
    • unknown's avatar
      Fix for Bug#35074: max_used_connections is not correct. · c167501b
      unknown authored
      The problem was that number of threads was used to calculate
      max_used_connections.
      
      The fix is to use number of active connections.
      
      
      mysql-test/r/connect.result:
        Update result file.
      mysql-test/t/connect.test:
        - Add a test case for Bug#35074: max_used_connections is not correct;
        - Make a test case for Bug#33507 more stable.
      sql/mysqld.cc:
        Use number of connections insetad of threads
        to calculate max_used_connections.
      c167501b
  5. 12 Mar, 2008 1 commit
    • unknown's avatar
      Fix for Bug#33507: Event scheduler creates more threads · b279be38
      unknown authored
      than max_connections -- which results in user lockout.
      
      The problem was that the variable thread_count that contains
      the number of active threads was interpreted as a number of
      active connections.
      
      The fix is to introduce a new counter for active connections.
      
      
      mysql-test/r/connect.result:
        A test case for Bug#33507: Event scheduler creates more threads
        than max_connections -- which results in user lockout.
      mysql-test/t/connect.test:
        A test case for Bug#33507: Event scheduler creates more threads
        than max_connections -- which results in user lockout.
      sql/mysql_priv.h:
        1. Polishing: login_connection() and end_connection() need not
           to be public.
        
        2. Introduce connection_count -- a variable to contain the number
           of active connections. It is protected by LOCK_connection_count.
      sql/mysqld.cc:
        Use connection_count to count active connections.
      sql/sql_connect.cc:
        1. Use connection_count to count active connections.
        2. Make login_connection(), end_connection() private for the module
        as they had to be.
      b279be38
  6. 09 Dec, 2006 1 commit
    • unknown's avatar
      WL# 3031 · 715e63ae
      unknown authored
      Post-commit issues fixed
      * Test results for other tests fixed due to added error #s
      * Memory allocation/free issues found with running with valgrind
      * Fix to mysql-test-run shell script to run federated_server test (installs
      mysql.servers table properly)
      
      
      mysql-test/r/1st.result:
        WL #3031
        
        New result for 1st test
      mysql-test/r/backup.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/connect.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/information_schema.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/mysql.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/mysqlcheck.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/ndb_dd_basic.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/ndb_dd_ddl.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/select.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/show_check.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/sp.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/sp_gis.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/sp_trans.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/system_mysql_db.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/type_timestamp.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/warnings.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      mysql-test/r/xml.result:
        WL #3031
        
        Error codes differ due to addition of error codes for federated server errors (2)
        so all test results with hard-coded error #s will be off by two. New results generated.
      scripts/mysql_create_system_tables.sh:
        WL #3031
        
        Fixed old mysql-test-run.sh script to work with new mysql.servers table as reported
        by Cisco
      sql/sql_yacc.yy:
        WL# 3031
        
        OPTIONS/options must be usable as table or column name.
      storage/federated/ha_federated.cc:
        WL# 3031
        
        * Fixed allocation and free issues (warnings found with --valgrind)
        * Fixed cast issues
        * Made sure port was set accordingly
      715e63ae
  7. 01 Dec, 2006 1 commit
  8. 21 Nov, 2006 1 commit
    • unknown's avatar
      Added --debug-info to most clients to detect memory leaks in mysql-test-run · 85a590a2
      unknown authored
      Moved .progress files into the log directory
      Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name
      Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23
      Fixed some compiler warnings
      Fixed small memory leak in libmysql
      Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1
      
      
      client/client_priv.h:
        Added OPT_DEBUG_INFO and OPT_COLUMN_TYPES
      client/mysql.cc:
        Split --debug-info into --debug-info and --column-type-info
      client/mysql_upgrade.c:
        Give only error info at end if using --debug-info
      client/mysqladmin.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlbinlog.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlcheck.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlimport.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlshow.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqltest.c:
        Added --debug-info to detect memory leaks in mysqltest
        Added option --logdir to force .progress files in a specific directory
      libmysql/libmysql.c:
        Fixed memory leak
      mysql-test/include/ndb_setup_slave.inc:
        Moved cluster tables under 'mysql'
      mysql-test/include/query_cache.inc:
        Added more tests for query cache
      mysql-test/lib/init_db.sql:
        Move cluster.binlog_index -> mysql.binlog_index
      mysql-test/lib/mtr_report.pl:
        Find memory leaks
      mysql-test/mysql-test-run-shell.sh:
        Added --debug-info to programs to detect memory leaks
      mysql-test/mysql-test-run.pl:
        Added --debug-info to programs to detect memory leaks
        Force log files to var/log
        cluster tables moved under 'mysql'
      mysql-test/r/cache_innodb.result:
        New query cache test with innodb
      mysql-test/r/connect.result:
        binlog_index is now in mysql
      mysql-test/r/drop.result:
        Removed 'cluster' database
      mysql-test/r/information_schema.result:
        Removed 'cluster' database
      mysql-test/r/mysqlcheck.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_basic.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_ddl_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_discover.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_restore_compat.result:
        cluster -> mysql
      mysql-test/r/ps_1general.result:
        Removed cluster database
      mysql-test/r/rpl_create_database.result:
        Removed cluster database
      mysql-test/r/rpl_load_from_master.result:
        Removed cluster database
      mysql-test/r/rpl_loaddata_m.result:
        Removed cluster database
      mysql-test/r/rpl_ndb_bank.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_advance.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_basic.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_idempotent.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_log.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_multi.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_sync.result:
        cluster -> mysql
      mysql-test/r/rpl_row_basic_11bugs.result:
        Removed cluster database
      mysql-test/r/rpl_truncate_7ndb.result:
        Position have changed
      mysql-test/r/rpl_truncate_7ndb_2.result:
        cluster -> mysql
      mysql-test/r/schema.result:
        Removed cluster database
      mysql-test/r/show_check.result:
        Removed cluster database
      mysql-test/r/system_mysql_db.result:
        binlog_index moved under mysql
      mysql-test/r/upgrade.result:
        More tests
      mysql-test/t/information_schema.test:
        cluster -> mysql
      mysql-test/t/mysqldump.test:
        More test to detect memory leaks
      mysql-test/t/ndb_binlog_basic.test:
        cluster -> mysql
      mysql-test/t/ndb_binlog_multi.test:
        cluster -> mysql
      mysql-test/t/ndb_restore_compat.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_bank.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_dd_advance.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_idempotent.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_multi.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_sync.test:
        cluster -> mysql
      mysql-test/t/system_mysql_db_fix.test:
        Drop also binlog_index
      mysql-test/t/upgrade.test:
        Check that tables created with 3.23 works
      mysys/my_error.c:
        Remove all registered errors (to avoid memory leaks)
      mysys/my_init.c:
        call my_error_unregister_all() to avoid some possible memory leaks
      mysys/mysys_priv.h:
        Added prototype
      scripts/mysql_create_system_tables.sh:
        cluster -> mysql
      scripts/mysql_fix_privilege_tables.sql:
        Changed -- to #
        Create binlog_index table if it dosesn't exist
      sql/field.cc:
        Made offset() inline
      sql/field.h:
        Changed prototype of offset() to not make it depending on TABLE structure
      sql/field_conv.cc:
        Removed some usage of current_thd
      sql/ha_ndbcluster_tables.h:
        cluster -> mysql
      sql/item_sum.cc:
        Usage of new 'offset' parameters
      sql/key.cc:
        Changed 'find_ref_key' to not be dependent on field->table
        (This fixed a crash when using a table created in MySQL 3.23)
      sql/mysql_priv.h:
        Changed find_ref_key() to not use field->table
      sql/mysqld.cc:
        Fix that plugin_init() works properly on bootstrap
        (Previously we got warnings from plugin_init)
      sql/sql_class.cc:
        new 'field->offset()'
      sql/sql_select.cc:
        New field->offset()
      sql/table.cc:
        We don't need field->table to be set in find_ref_key() or find_field() anymore.
      storage/archive/ha_archive.cc:
        New field->offset()
      storage/federated/ha_federated.cc:
        New field->offset()
      storage/innobase/handler/ha_innodb.cc:
        Fixed compiler warnings
      storage/myisam/ha_myisam.cc:
        Fixed compiler warnings (Wrong paramter to sprintf())
        New field->offset()
      storage/myisam/ha_myisam.h:
        Fixed wrong type of table_flags
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warning
      mysql-test/r/1st.result:
        New BitKeeper file ``mysql-test/r/1st.result''
      mysql-test/std_data/old_table-323.frm:
        New BitKeeper file ``mysql-test/std_data/old_table-323.frm''
      mysql-test/t/1st.test:
        New BitKeeper file ``mysql-test/t/1st.test''
      85a590a2
  9. 03 Oct, 2006 1 commit
    • unknown's avatar
      Update mysqltest to latest version · 9368c7bc
      unknown authored
       - ie. backport from 5.1
       - also update testcase error dected by new version
      
      
      mysql-test/include/show_msg.inc:
        BitKeeper file /home/msvensson/mysql/same_tools/my41-same_tools/mysql-test/include/show_msg.inc
      mysql-test/include/show_msg80.inc:
        BitKeeper file /home/msvensson/mysql/same_tools/my41-same_tools/mysql-test/include/show_msg80.inc
      BitKeeper/deleted/.del-rpl_chain_temp_table.test:
        Delete: mysql-test/t/rpl_chain_temp_table.test
      BitKeeper/deleted/.del-rpl_chain_temp_table.result:
        Delete: mysql-test/r/rpl_chain_temp_table.result
      BitKeeper/deleted/.del-rpl_failsafe.result:
        Delete: mysql-test/r/rpl_failsafe.result
      BitKeeper/deleted/.del-rpl_failsafe.test:
        Delete: mysql-test/t/rpl_failsafe.test
      BitKeeper/deleted/.del-rpl_heap.test:
        Delete: mysql-test/t/rpl_heap.test
      BitKeeper/deleted/.del-rpl_heap.result:
        Delete: mysql-test/r/rpl_heap.result
      BitKeeper/deleted/.del-rpl000018.result:
        Delete: mysql-test/r/rpl000018.result
      BitKeeper/deleted/.del-rpl000018.test:
        Delete: mysql-test/t/rpl000018.test
      client/Makefile.am:
        Link mysqltest with mysys/my_copy.c
      client/mysqltest.c:
        Update mysqltest to latest version
      mysql-test/include/have_multi_ndb.inc:
        Remove old syntax "@filename" in favor of "--require filename"
      mysql-test/include/master-slave.inc:
        Remove old syntax "@filename" in favor of "--require filename"
      mysql-test/include/ps_query.inc:
        Remove the comment about no output now when it does.
      mysql-test/r/check.result:
        Update output from --send
      mysql-test/r/connect.result:
        Update result file for connect test after backport form 5.1
      mysql-test/r/flush.result:
        Update output from --send
      mysql-test/r/flush_block_commit.result:
        Update output from --send
      mysql-test/r/func_misc.result:
        Update output from --send
      mysql-test/r/grant2.result:
        Update output from --send
      mysql-test/r/handler.result:
        Update output from --send
      mysql-test/r/kill.result:
        Update output from --send
      mysql-test/r/lock_multi.result:
        Update output from --send
      mysql-test/r/mix_innodb_myisam_binlog.result:
        Update output from --send
      mysql-test/r/mysqltest.result:
        Update mysqltest.result after backport
      mysql-test/r/ps_2myisam.result:
        Update result as the output from query is now printed
      mysql-test/r/ps_3innodb.result:
        Update result as the output from query is now printed
      mysql-test/r/ps_4heap.result:
        Update result as the output from query is now printed
      mysql-test/r/ps_5merge.result:
        Update result as the output from query is now printed
      mysql-test/r/ps_6bdb.result:
        Update result as the output from query is now printed
      mysql-test/r/ps_7ndb.result:
        Update result as the output from query is now printed
      mysql-test/r/rename.result:
        Update output from --send
      mysql-test/r/rpl000001.result:
        Update output from --send
      mysql-test/r/rpl_error_ignored_table.result:
        Update output from --send
      mysql-test/r/rpl_master_pos_wait.result:
        Update output from --send
      mysql-test/r/subselect.result:
        Update result file after adding missing ;
      mysql-test/r/synchronization.result:
        Update output from --send
      mysql-test/r/type_blob.result:
        Update result file after adding missing ;
      mysql-test/t/connect.test:
        Backport test from 5.1
      mysql-test/t/init_file.test:
        Update test so something is printed
      mysql-test/t/mysql_client_test.test:
        Update test so result is sent to file and something is printed
      mysql-test/t/mysqltest.test:
        Backport latest mysqltest.test file
      mysql-test/t/ps.test:
        Move the --replace_column statement to just before the statetement it should replace
      mysql-test/t/ps_1general.test:
        Move the --replace_column statement to just before the statetement it should replace
      mysql-test/t/ps_grant.test:
        Remove the $DB, no other test uses it
      mysql-test/t/rpl_flush_tables.test:
        Fetch $SERVER_VERSION from the db server
      mysql-test/t/rpl_trunc_temp.test:
        Remove the selection of connection master after it's been disconnected already
      mysql-test/t/subselect.test:
        Add missing ;
      mysql-test/t/type_blob.test:
        Add missing ;
      9368c7bc
  10. 19 Jan, 2006 1 commit
    • unknown's avatar
      WL1019: complete patch. Reapplied patch to the clean · 41536fce
      unknown authored
      tree to get rid of multiple typos in CS comments and
      unify the patch.
      
      
      configure.in:
        CSV is compiled in by default now
      include/my_base.h:
        add new ha_extra flag for the log tables
      mysql-test/include/im_check_os.inc:
        we should only run im tests if csv is on for now: im relies
        on mysqld options available only in csv build.
      mysql-test/include/system_db_struct.inc:
        check log tables structure
      mysql-test/lib/init_db.sql:
        create log tables when running tests.
      mysql-test/mysql-test-run.pl:
        Add old logs flag to IM tests. As IM could only deal with
        old logs (this feature is not needed with log tables)
      mysql-test/r/connect.result:
        update result
      mysql-test/r/csv.result:
        update result
      mysql-test/r/im_utils.result:
        update result
      mysql-test/r/information_schema.result:
        update result
      mysql-test/r/mysqlcheck.result:
        update result
      mysql-test/r/show_check.result:
        update result
      mysql-test/r/system_mysql_db.result:
        update result
      mysql-test/t/connect.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/csv.test:
        add tests for concurrent insert (the functionality is added
        to CSV in this patch)
      mysql-test/t/information_schema.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/mysqlcheck.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/show_check.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/system_mysql_db.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      mysql-test/t/system_mysql_db_fix.test:
        disable test if CSV engine is not in: result depends on the
        presence of CSV-based log tables
      scripts/mysql_create_system_tables.sh:
        new system tables: slow_log and general_log
      scripts/mysql_fix_privilege_tables.sql:
        add new log tables: use an SP to create them for
        non-csv build to work fine.
      sql/ha_myisam.cc:
        move locking-related checks to the hanlder
      sql/ha_myisam.h:
        new function declared
      sql/handler.h:
        new virtual function is added: we should check for handler-related
        locking issues in the handler
      sql/lock.cc:
        from now on we check for handler-related locking issues
        in the handler itself rather then in lock.cc
      sql/log.cc:
        Add log tables support, refactoring: there are log event
        handlers with common interface. They are used by the LOGGER
        class, which is responsible for their initialization, cleanup
        and managment. Logging to the tables provided by one of the
        log event handler types.
      sql/log.h:
        declare new log classes
      sql/log_event.cc:
        convert old logging routines calls to use new API
      sql/mysql_priv.h:
        define common log routines and objects
      sql/mysqld.cc:
        Add support for the log tables. Their initalization, cleanup
        and specific options.
      sql/share/errmsg.txt:
        add new error messages for the log tables
      sql/slave.cc:
        convert old logging routines calls to use new API
      sql/sql_base.cc:
        TABLE objects used by the logger should be skipped
        during refreshes (as log tables are always opened
        and locked). fix table_is_used to skip them.  This
        is needed for FLUSH LOGS to work
      sql/sql_db.cc:
        convert old logging routines calls to use new API
      sql/sql_delete.cc:
        fix TRUNCATE to work with log tables
      sql/sql_parse.cc:
        command_name is now an array of LEX_STRINGs
      sql/sql_prepare.cc:
        convert old logging routines calls to use new API
      sql/sql_show.cc:
        convert old logging routines calls to use new API
      sql/sql_table.cc:
        don't reoped the log tables for admin purposes
      sql/table.cc:
        mark log tables as such during the open
      sql/table.h:
        add log-related info
      storage/csv/ha_tina.cc:
        add support for concurrent insert (see bk commit - 5.1 tree
        (petr:1.1910) for standalone patch), add log tables-specific
        csv table handling.
      storage/csv/ha_tina.h:
        enable concurrent insert for CSV, add log table flag
      mysql-test/r/log_tables.result:
        New BitKeeper file ``mysql-test/r/log_tables.result''
      mysql-test/t/log_tables.test:
        New BitKeeper file ``mysql-test/t/log_tables.test''
      41536fce
  11. 10 Jan, 2006 1 commit
    • unknown's avatar
      WL #1034 (Internal CRON) pre-push updates · 1ef97f1f
      unknown authored
      - fixed test results
      - fixed bug caught by information_schema.test . Bison temporal
        variables are very nice but extremely error-prone (Count one more
        time just to be sure).
      
      
      mysql-test/r/connect.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/r/events.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/r/grant.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/r/information_schema.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/r/lowercase_table_grant.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/r/ps.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/r/system_mysql_db.result:
        fix result for WL#1034 (internal CRON)
      mysql-test/t/events.test:
        fix result for WL#1034 (internal CRON)
      sql/sql_yacc.yy:
        - fix bug introduced by me when making usage of temporal
          bison variables. COUNT 7 times then write!
      1ef97f1f
  12. 07 Nov, 2005 1 commit
    • unknown's avatar
      mysql-test/r/connect.result + mysql-test/t/connect.test · af2e0dc4
      unknown authored
      Replace the full socket path name, not just a directory component. bug#14720
      
      
      mysql-test/r/connect.result:
        In cases where "--tmpdir=" is given to the test run, the socket file is not created below
        "$MYSQL_TEST_DIR" but rather within this directory. So the "--replace_result" should not 
        be done to a directory in the path but rather to the complete path name of the socket file. 
        bug#14720
      mysql-test/t/connect.test:
        In cases where "--tmpdir=" is given to the test run, the socket file is not created below
        "$MYSQL_TEST_DIR" but rather within this directory. So the "--replace_result" should not
        be done to a directory in the path but rather to the complete path name of the socket file.
        bug#14720
      af2e0dc4
  13. 06 Nov, 2005 1 commit
    • unknown's avatar
      WL#2575 - Fulltext: Parser plugin for FTS · 66002e45
      unknown authored
      WL#2763 - MySQL plugin interface: step 1
      Manual merge from CNET tree.
      
      
      include/ft_global.h:
        Default parser added.
      include/my_global.h:
        dlopen related code moved from sql_udf.cc into my_global.h
      include/myisam.h:
        Added fulltext parser to MI_KEYDEF
      libmysqld/Makefile.am:
        Added LIBDIR macro.
      mysql-test/r/connect.result:
        Test result fixed: added plugin table
      mysql-test/r/information_schema.result:
        Test result fixed: added plugin table.
      mysql-test/r/mysqlcheck.result:
        Test result fixed: added plugin table.
      mysql-test/r/system_mysql_db.result:
         Test fixed: added plugin table
      mysql-test/t/system_mysql_db_fix.test:
         Test fixed: added plugin table
      scripts/mysql_create_system_tables.sh:
        Added mysql.plugin table.
      scripts/mysql_fix_privilege_tables.sql:
        Added mysql.plugin table.
      sql/Makefile.am:
        Added LIBDIR macro.
      sql/ha_myisam.cc:
        Pass fulltext parser from sql to myisam layer.
      sql/lex.h:
        Plugin related symbols.
      sql/mysqld.cc:
        Initialize/deinitialize plugins, pass opt_plugin_dir.
        plugin-dir renamed to plugin_dir.
        plugin_dir is relative to mysql_home now.
      sql/set_var.cc:
        plugin_dir added to SHOW VARIABLES.
      sql/share/errmsg.txt:
        Plugin related error messages.
      sql/sql_class.h:
        Added parser to Key class.
        Hold parser_name instead of plugin in Key class.
      sql/sql_lex.h:
        INSTALL/UNINSTALL PLUGIN commands.
      sql/sql_parse.cc:
        INSTALL/UNINSTALL PLUGIN commands.
      sql/sql_show.cc:
        SHOW CREATE TABLE: output parser name if index was created WITH PARSER.
      sql/sql_table.cc:
        Pass fulltext parser from yacc to sql layer.
      sql/sql_udf.cc:
        dlopen related code moved into my_global.h.
        Implemented better check for UDF path.
        UDF loads libraries that are under plugin_dir now.
      sql/sql_yacc.yy:
        INSTALL/UNINSTALL PLUGIN syntax.
        Added WITH PARSER syntax to CREATE/ALTER TABLE/INDEX.
        opt_fulltext_parser must allocate memory, since it will be used afterwards.
      sql/table.cc:
        Save/restore fulltext parser in extra data segment.
        Added DBUG_PRINTs.
      storage/myisam/ft_boolean_search.c:
        Split functions so they can be used by fulltext parser.
        Use fulltext parser if specified.
      storage/myisam/ft_nlq_search.c:
        Use fulltext parser.
      storage/myisam/ft_parser.c:
        Split functions so they can be used by fulltext parser.
        Use fulltext parser if specified.
      storage/myisam/ft_static.c:
        Default fulltext parser added.
      storage/myisam/ft_update.c:
        Use fulltext parser.
      storage/myisam/ftdefs.h:
        FTB_PARAM moved into plugin.h and renamed to MYSQL_FTPARSER_BOOLEAN_INFO.
      storage/myisam/mi_open.c:
        Set default parser.
      66002e45
  14. 28 Oct, 2005 1 commit
  15. 12 Oct, 2005 1 commit
    • unknown's avatar
      Always test ssl and compress · 2bb0501d
      unknown authored
       - Updated after review
      
      
      client/mysqltest.c:
        Updated after review.
        Fix "connect" command to take SSL and/or COMPRESS as options instead of enable/disable_ssl and enable/disable_compress
        Commented do_connect, added test cases etc.
        Fix safe_get_param to make it possible to call it once for every argument without having any checks inbetween.
        Make a copy for query->first_argument  since safe_get_param will modify query string. Now connect works inside a while loop as well.
      mysql-test/mysql-test-run.pl:
        Updated after review
      mysql-test/r/connect.result:
        Enable test that was previolsy disabled because of "no error handling" in connect
      mysql-test/r/mysqltest.result:
        Added tests for "connect"
      mysql-test/t/compress.test:
        Updated after review, use the option argument to connect
      mysql-test/t/connect.test:
        Enable test that was previolsy disabled because of "no error handling" in connect
        Now it's possible to use "--error" before connect, so let's use it.
      mysql-test/t/information_schema.test:
        Connection user4 was already used
      mysql-test/t/myisam.test:
        Disconnect con1 so the name can be reused
      mysql-test/t/mysqltest.test:
        Added tests for "connect"
      mysql-test/t/openssl_1.test:
        Updated after review, use the option argument to connect
      mysql-test/t/sp-security.test:
        Disconnect user1 connection so the name can be reused
      mysql-test/t/ssl.test:
        Updated after review, use the option argument to connect
      mysql-test/t/ssl_compress.test:
        Updated after review, use the option argument to connect
      sql/mysqld.cc:
        Updated after review, Compression variable is always available
      sql/sql_show.cc:
        Updated after review, Compression variable is always available
      sql/structs.h:
        Updated after review, Compression variable is always available
      2bb0501d
  16. 08 Sep, 2005 1 commit
  17. 30 Aug, 2005 1 commit
    • unknown's avatar
      Fixes bug #12517. Clear user variables and replication events before · 1a170dc0
      unknown authored
      closing temp tables in thread cleanup.
      
      
      mysql-test/r/connect.result:
        added results for test of bug #12517
      mysql-test/t/connect.test:
        added test of bug #12517
      sql/sql_class.cc:
        Clear user variables and replication events before
        closing temp tables in thread cleanup.
      1a170dc0
  18. 23 Dec, 2004 1 commit
    • unknown's avatar
      WL#925 - Privileges for stored routines · 09ce0b33
      unknown authored
        Implement fine-grained control over access to stored procedures
        Privileges are cached (same way as existing table/column privs)
        
      
      
      mysql-test/include/system_db_struct.inc:
        WL#925 - Privileges for stored routines
          New system table: procs_priv
      mysql-test/r/connect.result:
        WL#925 - Privileges for stored routines
          New system table: procs_priv
      mysql-test/r/grant.result:
        WL#925 - Privileges for stored routines
          user table has additional privilege attributes
          SHOW PRIVILEGES amended
      mysql-test/r/grant2.result:
        Fix result
      mysql-test/r/information_schema.result:
        WL#925 - Privileges for stored routines
          New system table procs_priv
          New user privileges
      mysql-test/r/show_check.result:
        Fix result
      mysql-test/r/sp-security.result:
        WL#925 - Privileges for stored routines
          Fix existing tests to work with new privileges
          New tests for new privileges
      mysql-test/r/sp.result:
        WL#925 - Privileges for stored routines
          Fix SHOW PRIVILEGES results
      mysql-test/r/system_mysql_db.result:
        WL#925 - Privileges for stored routines
          New system table: procs_priv
          user and db tables have new privilege attributes
      mysql-test/t/grant2.test:
        Fix test
      mysql-test/t/show_check.test:
        Fix test
      mysql-test/t/sp-security.test:
        WL#925 - Privileges for stored routines
          Allow existing tests to run with new privilege checks
          New tests for privileges
      mysql-test/t/system_mysql_db_fix.test:
        WL#925 - Privileges for stored routines
          New system table: procs_priv
      scripts/mysql_create_system_tables.sh:
        WL#925 - Privileges for stored routines
          db and user has new privilege attributes
          new system table: procs_priv
      scripts/mysql_fix_privilege_tables.sql:
        WL#925 - Privileges for stored routines
          new system table: procs_priv
      scripts/mysql_install_db.sh:
        WL#925 - Privileges for stored routines
          Amend comment
      sql/item_func.cc:
        WL#925 - Privileges for stored routines
          Privilege check for stored FUNCTION routine
      sql/lex.h:
        WL#925 - Privileges for stored routines
          new token ROUTINE
      sql/mysql_priv.h:
        WL#925 - Privileges for stored routines
          New function: check_procedure_access()
      sql/mysqld.cc:
        WL#925 - Privileges for stored routines
          system option automatic-sp-privileges
      sql/set_var.cc:
        WL#925 - Privileges for stored routines
          system option automatic-sp-privileges
      sql/share/errmsg.txt:
        WL#925 - Privileges for stored routines
          rename errormessage to conform:
            ER_SP_ACCESS_DENIED_ERROR -> ER_PROCACCESS_DENIED_ERROR
          New error messages
            ER_NONEXISTING_PROC_GRANT, ER_PROC_AUTO_GRANT_FAIL, ER_PROC_AUTO_REVOKE_FAIL
      sql/sp.cc:
        WL#925 - Privileges for stored routines
          new function: sp_exists_routine()
      sql/sp.h:
        WL#925 - Privileges for stored routines
          new function: sp_exists_routine()
      sql/sql_acl.cc:
        WL#925 - Privileges for stored routines
          Implementation for SP privileges.
          Privileges are cached in memory hash.
          New functions:
            mysql_procedure_grant()
            check_grant_procedure()
            sp_revoke_privileges()
            sp_grant_privileges()
      sql/sql_acl.h:
        WL#925 - Privileges for stored routines
          New privilege bits: CREATE_PROC_ACL, ALTER_PROC_ACL
          Alter confusing bit-segments to be shifted
          New macros: fix_rights_for_procedure() get_rights_for_procedure()
          New functions:
            mysql_procedure_grant()
            check_grant_procedure()
            sp_grant_privileges()
            sp_revoke_privileges()
      sql/sql_lex.h:
        WL#925 - Privileges for stored routines
          new all_privileges attribute in LEX
      sql/sql_parse.cc:
        WL#925 - Privileges for stored routines
          Remove function: check_sp_definer_access()
          Add handling for SP grants/revokes
          Add privilege checks for stored procedure invocation
      sql/sql_show.cc:
        WL#925 - Privileges for stored routines
          update result for SHOW PRIVILEGES
      sql/sql_yacc.yy:
        WL#925 - Privileges for stored routines
          New token ROUTINE
          rename some rules
          handle CREATE ROUTINE / ALTER ROUTINE privileges
      09ce0b33
  19. 10 Oct, 2004 1 commit
    • unknown's avatar
      showing table type now is controled by new parameter 'FULL' of SHOW TABLES... · 8b026230
      unknown authored
      showing table type now is controled by new parameter 'FULL' of SHOW TABLES command (SHOW FULL TABLES) (as it was decided on last dev conf)
      
      
      mysql-test/r/connect.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/ctype_recoding.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/drop.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/lowercase_table.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/rename.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/rpl000009.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/rpl_error_ignored_table.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/select.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/sp.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/system_mysql_db.result:
        returned SHOW TABLES default behaviour
      mysql-test/r/view.result:
        test of new parameter od SHOW TABLES and default behaviour without parameter
      mysql-test/t/view.test:
        test of new parameter od SHOW TABLES and default behaviour without parameter
      sql/mysql_priv.h:
        parameter added to mysqld_show_tables
      sql/sql_parse.cc:
        parameter added to mysqld_show_tables
      sql/sql_show.cc:
        showing table type now is controled by new parameter 'FULL' of SHOW TABLES command (SHOW FULL TABLES)
      sql/sql_yacc.yy:
        showing table type now is controled by new parameter 'FULL' of SHOW TABLES command (SHOW FULL TABLES)
      8b026230
  20. 26 Aug, 2004 1 commit
    • unknown's avatar
      Portability fixes · 44b2807e
      unknown authored
      Fixed bug in end space handle for WHERE text_column="constant"
      
      
      heap/hp_hash.c:
        Optimzations (no change of logic)
      libmysql/libmysql.c:
        Added missing casts (portability fix)
      myisam/mi_key.c:
        Changed macro to take arguments and not depend on local variables
        Simple indentation fixes ?
      mysql-test/r/connect.result:
        Added test for setting empty password
      mysql-test/r/create_select_tmp.result:
        TYPE -> ENGINE
      mysql-test/r/ctype_utf8.result:
        Combine drop's
      mysql-test/r/endspace.result:
        Added more tests to test end space behaviour
      mysql-test/r/having.result:
        Added missing DROP TABLE
      mysql-test/r/type_blob.result:
        Added more tests to ensure that fix for BLOB usage is correct
      mysql-test/r/type_timestamp.result:
        Add test from 4.0
      mysql-test/t/connect.test:
        Added test for setting empty password
      mysql-test/t/create_select_tmp.test:
        TYPE -> ENGINE
      mysql-test/t/ctype_utf8.test:
        Combine drop's
      mysql-test/t/endspace.test:
        Added more tests to test end space behaviour
      mysql-test/t/having.test:
        Added missing DROP TABLE
      mysql-test/t/type_blob.test:
        Added more tests to ensure that fix for BLOB usage is correct
      mysql-test/t/type_timestamp.test:
        Add test from 4.0
      sql/field.cc:
        Removed not used variable
        Portability fix (cast)
        Simplified Field_str::double()
        Simple indentation cleanups
      sql/field.h:
        Removed not needed class variable
      sql/item_cmpfunc.cc:
        Indentation fix
      sql/item_strfunc.cc:
        Use on stack variable for Item_str_func::val() instead of str_value.
        This makes it safe to use str_value inside the Item's val function.
        Cleaned up LEFT() usage, thanks to the above change
      sql/item_sum.cc:
        Indentation cleanups
      sql/protocol.cc:
        Added missing cast
      sql/sql_acl.cc:
        Indentatin cleanups.
        Added missing cast
        Simple optimization of get_sort()
      sql/sql_select.cc:
        Don't use 'ref' to search on text field that is not of type BINARY (use 'range' instead).
        The reson is that for 'ref' we use 'index_next_same' to read the next possible row. 
        For text fields, rows in a ref may not come in order, like for 'x', 'x\t' 'x ' (stored in this order) which causes a search for 'column='x ' to fail
      sql/tztime.cc:
        Simple cleanup
      strings/ctype-bin.c:
        Comment fixes
      strings/ctype-mb.c:
        Changed variable names for arguments
      44b2807e
  21. 30 Jul, 2004 1 commit
  22. 19 Jul, 2004 1 commit
    • unknown's avatar
      standard values for table type in SHOW TABLES (BUG#4603) · 10d0dca6
      unknown authored
      mysql-test/r/connect.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/ctype_recoding.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/drop.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/greedy_optimizer.result:
        fixed results
      mysql-test/r/lowercase_table.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/ps_1general.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/rename.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/rpl000009.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/rpl_error_ignored_table.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/select.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/system_mysql_db.result:
        standard values for table type in SHOW TABLES
      mysql-test/r/view.result:
        standard values for table type in SHOW TABLES
      sql/sql_show.cc:
        standard values for table type in SHOW TABLES
        debugging trap
      10d0dca6
  23. 15 Jul, 2004 1 commit
    • unknown's avatar
      VIEW · 8790b1e6
      unknown authored
      two TABLE_LIST copy eliminated
      
      
      include/mysqld_error.h:
        errors of view
      libmysqld/Makefile.am:
        new view file
      mysql-test/r/connect.result:
        SHOW TABLE show type of table
      mysql-test/r/ctype_recoding.result:
        SHOW TABLE show type of table
      mysql-test/r/drop.result:
        SHOW TABLE show type of table
      mysql-test/r/grant.result:
        new two privileges (CRETEA|SHOW VIEW)
      mysql-test/r/lowercase_table.result:
        SHOW TABLE show type of table
      mysql-test/r/ps_1general.result:
        SHOW TABLE show type of table
      mysql-test/r/rename.result:
        SHOW TABLE show type of table
      mysql-test/r/rpl000009.result:
        SHOW TABLE show type of table
      mysql-test/r/rpl_error_ignored_table.result:
        SHOW TABLE show type of table
      mysql-test/r/select.result:
        SHOW TABLE show type of table
      mysql-test/r/system_mysql_db.result:
        SHOW TABLE show type of table
        new two privileges (CRETEA|SHOW VIEW)
      mysql-test/t/system_mysql_db_fix.test:
        removing all system tables
      scripts/mysql_fix_privilege_tables.sql:
        new two privileges (CRETEA|SHOW VIEW)
      sql/Makefile.am:
        new VIEW related file
      sql/ha_myisammrg.cc:
        two TABLE_LIST copy eliminated
      sql/item.cc:
        VIEW
      sql/item.h:
        VIEW
      sql/item_subselect.cc:
        VIEW
      sql/item_subselect.h:
        VIEW
      sql/lex.h:
        VIEW
      sql/lock.cc:
        VIEW
      sql/mysql_priv.h:
        VIEW
      sql/mysqld.cc:
        VIEW
        new parameter - sql_updatable_view_key
      sql/opt_sum.cc:
        two TABLE_LIST copy eliminated
      sql/set_var.cc:
        new parameter - sql_updatable_view_key
      sql/share/czech/errmsg.txt:
        errors messages of views
      sql/share/danish/errmsg.txt:
        errors messages of views
      sql/share/dutch/errmsg.txt:
        errors messages of views
      sql/share/english/errmsg.txt:
        errors messages of views
      sql/share/estonian/errmsg.txt:
        errors messages of views
      sql/share/french/errmsg.txt:
        errors messages of views
      sql/share/german/errmsg.txt:
        errors messages of views
      sql/share/greek/errmsg.txt:
        errors messages of views
      sql/share/hungarian/errmsg.txt:
        errors messages of views
      sql/share/italian/errmsg.txt:
        errors messages of views
      sql/share/japanese/errmsg.txt:
        errors messages of views
      sql/share/korean/errmsg.txt:
        errors messages of views
      sql/share/norwegian-ny/errmsg.txt:
        errors messages of views
      sql/share/norwegian/errmsg.txt:
        errors messages of views
      sql/share/polish/errmsg.txt:
        errors messages of views
      sql/share/portuguese/errmsg.txt:
        errors messages of views
      sql/share/romanian/errmsg.txt:
        errors messages of views
      sql/share/russian/errmsg.txt:
        errors messages of views
      sql/share/serbian/errmsg.txt:
        errors messages of views
      sql/share/slovak/errmsg.txt:
        errors messages of views
      sql/share/spanish/errmsg.txt:
        errors messages of views
      sql/share/swedish/errmsg.txt:
        errors messages of views
      sql/share/ukrainian/errmsg.txt:
        errors messages of views
      sql/slave.cc:
        two TABLE_LIST copy eliminated
      sql/sp.cc:
        VIEW
      sql/sql_acl.cc:
        VIEW
      sql/sql_acl.h:
        VIEW
      sql/sql_base.cc:
        VIEW
      sql/sql_cache.cc:
        two TABLE_LIST copy eliminated
      sql/sql_class.h:
        VIEW
      sql/sql_db.cc:
        two TABLE_LIST copy eliminated
      sql/sql_delete.cc:
        VIEW
      sql/sql_derived.cc:
        VIEW
      sql/sql_handler.cc:
        two TABLE_LIST copy eliminated
      sql/sql_help.cc:
        two TABLE_LIST copy eliminated
      sql/sql_insert.cc:
        VIEW
      sql/sql_lex.cc:
        VIEW
      sql/sql_lex.h:
        VIEW
      sql/sql_load.cc:
        VIEW
      sql/sql_olap.cc:
        VIEW
      sql/sql_parse.cc:
        two TABLE_LIST copy eliminated
        VIEW
      sql/sql_prepare.cc:
        VIEW
      sql/sql_rename.cc:
        two TABLE_LIST copy eliminated
      sql/sql_select.cc:
        VIEW
      sql/sql_show.cc:
        VIEW
      sql/sql_table.cc:
        VIEW
      sql/sql_union.cc:
        VIEW
      sql/sql_update.cc:
        VIEW
      sql/sql_yacc.yy:
        VIEW
      sql/table.cc:
        VIEW
      sql/table.h:
        VIEW
      sql/tztime.cc:
        two TABLE_LIST copy eliminated
      sql/unireg.h:
        VIEW
      tests/client_test.c:
        VIEW
      8790b1e6
  24. 08 Jul, 2004 1 commit
  25. 18 Jun, 2004 1 commit
    • unknown's avatar
      WL#1264 "Per-thread time zone support infrastructure". · 6aaccbcb
      unknown authored
      Added basic per-thread time zone functionality (based on public
      domain elsie-code). Now user can select current time zone
      (from the list of time zones described in system tables).
      All NOW-like functions honor this time zone, values of TIMESTAMP
      type are interpreted as values in this time zone, so now
      our TIMESTAMP type behaves similar to Oracle's TIMESTAMP WITH
      LOCAL TIME ZONE (or proper PostgresSQL type).
        
      WL#1266 "CONVERT_TZ() - basic time with time zone conversion 
      function".
        
      Fixed problems described in Bug #2336 (Different number of warnings 
      when inserting bad datetime as string or as number). This required
      reworking of datetime realted warning hadling (they now generated 
      at Field object level not in conversion functions).
        
      Optimization: Now Field class descendants use table->in_use member
      instead of current_thd macro.
      
      
      include/my_global.h:
        Added macro for reading of 32-bit ints stored in network order from
        unaligned memory location.
      include/mysqld_error.h:
        Added error-code for invalid timestamp warning and error-code
        for wrong or unknown time zone specification.
      libmysqld/Makefile.am:
        Added main per-thread time zone support file to libmysqld
      libmysqld/lib_sql.cc:
        Added initialization of time zones infrastructure to embedded server.
      mysql-test/r/connect.result:
        Updated test result since now mysql database contains more
        system tables.
      mysql-test/r/date_formats.result:
        Now when truncation occurs during conversion to datetime value we are producing Warnings 
        instead of Notes. Also we are giving more clear warnings about this in some cases.
      mysql-test/r/func_sapdb.result:
        New warnings about truncation occured during conversion to datetime value added due
        their better handling.
      mysql-test/r/func_time.result:
        New warnings about truncation occured during conversion to datetime value added due
        their better handling.
      mysql-test/r/select.result:
        New warnings about truncation occured during conversion to datetime value added due
        their better handling. Also tweaked test a bit to made it less ambigious for reader.
      mysql-test/r/system_mysql_db.result:
        Updated test result because new system tables holding time zone descriptions were 
        added.
      mysql-test/r/timezone.result:
        Updated timezone.test to use new system variable which shows system time zone.
        Added test of warning which is produced if someone tries to store non-existing (due 
        falling into spring time-gap) datetime value into TIMESTAMP field.
      mysql-test/r/type_datetime.result:
        Separated and extended test of values and warnings produced for bad values stored in 
        DATETTIME fields.
      mysql-test/r/type_time.result:
        Now we are producing more consistent warning when we are truncating datetime value while
        storing it in TIME field.
      mysql-test/r/type_timestamp.result:
        Separated and extended test of values and warnings produced for bad
        values stored in TIMESTAMP fields.
      mysql-test/t/select.test:
        Updated test to make it less ambigous for reader.
      mysql-test/t/timezone.test:
        Updated timezone.test to use new system variable which shows system time zone.
        Added test of warning which is produced if someone tries to store non-existing (due 
        falling into spring time-gap) datetime value into TIMESTAMP field.
      mysql-test/t/type_datetime.test:
        Separated and extended test of values and warnings produced for bad
        values stored in DATETTIME fields.
      mysql-test/t/type_timestamp.test:
        Separated and extended test of values and warnings produced for bad
        values stored in TIMESTAMP fields.
      scripts/mysql_create_system_tables.sh:
        Added creation of tables with time zone descriptions.
        Also added descriptions of time zones used in tests.
      scripts/mysql_fix_privilege_tables.sql:
        Added mysql.time_zone* tables family.
      sql/Makefile.am:
        Added files implementing time zone support to server, also added
        rules for building of mysql_tzinfo_to_sql converter and test_time
        test.
      sql/field.cc:
        Now we are using per-thread time zone for TIMESTAMP <-> whatever conversion.
        Fixed generation of warnings for datetime types (DATETIME/TIMESTAMP/DATE/...) and
        any other Field to datetime conversion (now we are generating warnings no in lower
        level functions like in str_to_TIME() but in Field methods. This allows generate
        better and more consistent warnings and to reuse code of str_to_TIME() outside of
        server).
        
        Added 3rd parameter to set_warning() method to be able to not increment cut fields
        but still produce a warning. Also added set_datetime_warning() family of auxiliary 
        methods which allow easier generate datetime related warnings.
        Also replaced occurences of current_thd with table->in_use member, added
        asserts for catching all places there we need to set table->in_use
        accordingly. Renamed fix_datetime() function to number_to_TIME() and
        moved it to sql/time.cc there it fits better.
      sql/field.h:
        Added comment about places where we can use table->in_use member
        instead of current_thd.
        Added 3rd parameter to Field::set_warning() method and set_datetime_warning()
        family of methods.
      sql/field_conv.cc:
        Field::set_warning() method with 2 arguments was replaced with more 
        generic set_warning() method with 3 arguments.
      sql/ha_berkeley.cc:
        Now we set table->in_use for temporary tables so we have to use
        table->tmp_table for checking if table is temporary.
      sql/item.cc:
        Replaced calls to str_to_time() and str_to_TIME() funcs with their warning
        generating analogs.
      sql/item_create.cc:
        Added creation of CONVERT_TZ function as FUNC_ARG3.
      sql/item_create.h:
        Added creation of CONVERT_TZ function as FUNC_ARG3.
      sql/item_timefunc.cc:
        Added support of per-thread time zone to NOW-like and FROM_UNIXTIME,
        UNIX_TIMESTAMP functions. 
        Added support for CONVERT_TZ function.
        Removed call to str_to_timestamp function which caused non-optimal
        behavior in certain cases. Replaced calls to str_to_time() function 
        with its warning generating analog.
      sql/item_timefunc.h:
        Added support of per-thread time zone to NOW-like and
        FROM_UNIXTIME, UNIX_TIMESTAMP functions.
        Added support of CONVERT_TZ function.
      sql/lex.h:
        Added support of CONVERT_TZ function.
      sql/log.cc:
        Added support for replication of statements depending on time zone.
      sql/mysql_priv.h:
        Now including headers with per-thread time zone support functions
        and classes. Added portable replacement of time_t - my_time_t type. 
        Added time zone as one of query distinguishing parameters for
        query cache. 
        Fixed declarations of str_to_TIME, str_to_time and 
        my_system_gmt_sec (former my_gmt_sec) since now they have one more
        out parameter which informs about wrong datetime value or data 
        truncation during conversion.
        Added warning generating version of str_to_TIME() and str_to_time()
        functions.
        Thrown away str_to_datetime/timestamp functions since they are not
        needed any longer. Added number_to_TIME function.
      sql/mysqld.cc:
        Added per-thread time zone support initialization.
        Added new startup parameter --default-time-zone.
      sql/set_var.cc:
        Added support for per-thread time_zone variable.
        Renamed old timezone variable to system_time_zone.
      sql/set_var.h:
        Added support for per-thread time_zone variable.
      sql/share/czech/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/danish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/dutch/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/english/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/estonian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/french/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/german/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/greek/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/hungarian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/italian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/japanese/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/korean/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/norwegian-ny/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/norwegian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/polish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/portuguese/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/romanian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/russian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/serbian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/slovak/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/spanish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/swedish/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/share/ukrainian/errmsg.txt:
        Added error message for barking when incorrect time zone name or
        specifiaction is provided and for warning about invalid TIMESTAMP
        values (e.g. falling into the spring time-gap).
      sql/slave.cc:
        In order to support replication of statements using time zones in 4.1 we should 
        ensure that both master and slave have same default time zone.
      sql/sql_base.cc:
        Now we are setting TABLE::in_use member for all tables (which assume
        calls to Field::store or val_ methods).
      sql/sql_cache.cc:
        Added time zone as one more query distinguishing parameter
        for query cache.
      sql/sql_class.cc:
        Added THD::time_zone_used variable indicating that this query
        uses per thread time zone.
      sql/sql_class.h:
        Added per-thread time zone variable. Added THD::time_zone_used
        variable indicating that this query uses per thread time zone
        so if this is updating query the time zone should be logged to 
        binlog.
      sql/sql_insert.cc:
        We should set TABLE::in_use member pointing to thread which is called
        INSERT DELAYED and not to worker thread.
      sql/sql_load.cc:
        Field::set_warning() now has one more argument now.
      sql/sql_parse.cc:
        Resetting THD::time_zone_used variable in the end of query
        processing.
      sql/sql_select.cc:
        Now we are setting TABLE::in_use member for all tables (which assume
        calls to Field::store or val_ methods).
      sql/sql_show.cc:
        Now using per thread time zone for extended show tables.
      sql/time.cc:
        Added support for per-thread time zones for TIMESTAMP type and
        reworked generation of warnings for TIMESTAMP and DATETIME types.
        (Introduced new TIME_to_timestamp() function. Removed hours 
        normalisation from former my_gmt_sec() since it was not working 
        and not used anywhere now, but breaks parameter constness, added
        to this function generation of warning if we are falling in spring 
        time-gap. Removed str_to_timestamp and str_to_datetime functions 
        which are no longer used. Moved fix_datetime function from
        sql/field.cc to this file as number_to_TIME() function. Added
        out parameter for str_to_TIME and str_to_time functions which
        indicates if value was truncated during conversion, removed direct 
        generation of warnings from this functions.)
      sql/unireg.cc:
        Now we are setting TABLE::in_use member for all tables (which assume
          calls to Field::store or val_ methods).
      BitKeeper/etc/ignore:
        Added sql/test_time sql/mysql_tzinfo_to_sql libmysqld/tztime.cc to the ignore list
      6aaccbcb
  26. 07 Jul, 2003 1 commit
    • unknown's avatar
      Preliminary support for options --secure-auth, · 78c3d968
      unknown authored
      --old-passwords
      Support for option --old-protocol was removed.
      Some test performed.
      Tests for SSL and replication are pending.
      More strict following to specification for --old-passwords
      is in the TODO.
      
      
      include/mysql_com.h:
        support for 3.20 passwords removed from
        scramble_323
      include/mysqld_error.h:
        added error code for --secure-auth mode
      libmysql/libmysql.c:
        removed support for 3.20 password and protocol
        version 9
      mysql-test/r/connect.result:
        added check for new syntax of 
        set password
      mysql-test/r/func_crypt.result:
        tests for two-argument of password() were removed.
        Instead added tests for cooperation of password() and
        old_passwords session/global variable, passwords() and spaces 
        in argument string
      mysql-test/t/connect.test:
        added check for new syntax of
        set password
      mysql-test/t/func_crypt.test:
        tests for two-argument of password() were removed.
        Instead added tests for cooperation of password() and
        old_passwords session/global variable, passwords() and spaces 
        in argument string
      sql-common/client.c:
        removed support for 3.20 servers and 
        protocol version 9
      sql/item_strfunc.h:
        fixed comment
      sql/mysql_priv.h:
        added declarartion for option opt_secure_auth
      sql/mysqld.cc:
        added option opt_secure_auth
        option old-password placed according to
        sort order
      sql/password.c:
        removed support for 3.20 clients and 
        old scrambles
      sql/set_var.cc:
        added system variable 'secure_auth'
        added system/thread variable 'old_passwords'
      sql/set_var.h:
        sys_old_passwords needs to be exported 
        because sys_old_passwords.after_update is used
        in sql_acl.cc
      sql/sql_acl.cc:
        support for 3.20 passwords removed
        now acl_init honors options works properly with
        options/variables --secure-auth and --old-passwords
      sql/sql_acl.h:
        support for 3.20 clients removed
      sql/sql_class.h:
        added system/thread variable old_passwords
      sql/sql_parse.cc:
        support for 3.20 clients removed
        now check_user takes into account option
        secure_auth
      sql/sql_yacc.yy:
        global variable use_old_passwords 
        replaced with thread-specific variable 
        old_passwords
      sql/share/czech/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/danish/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/dutch/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/english/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/estonian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/french/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/german/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/greek/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/hungarian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/italian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/japanese/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/korean/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/norwegian-ny/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/norwegian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/polish/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/portuguese/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/romanian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/russian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/serbian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/slovak/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/spanish/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/swedish/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      sql/share/ukrainian/errmsg.txt:
        error message for --secure-auth added
        (as suggested by Paul)
      78c3d968
  27. 13 Jun, 2003 1 commit
  28. 29 May, 2003 1 commit
  29. 12 Feb, 2003 1 commit
    • unknown's avatar
      Fixed a lot of wrong memory references as reported by valgrind · fcb61f59
      unknown authored
      Portability fixes
      Added new client function: mysql_get_server_version()
      New server help code (From Victor Vagin)
      Fixed wrong usage of binary()
      Disabled RTREE usage for now.
      
      
      
      BitKeeper/etc/ignore:
        added scripts/fill_help_tables.sql
      client/mysql.cc:
        Some fixes when using 'help'
      cmd-line-utils/libedit/compat.h:
        Portability fix
      cmd-line-utils/libedit/fgetln.c:
        Portability fix
      include/mysql.h:
        Added new client function: mysql_get_server_version()
      libmysql/libmysql.c:
        Added new client function: mysql_get_server_version()
      libmysqld/libmysqld.c:
        Fixed prototype
      mysql-test/install_test_db.sh:
        Added creation of help tables
      mysql-test/r/connect.result:
        Added help tables
      mysql-test/r/myisam.result:
        Test of RTREE index
      mysql-test/r/type_ranges.result:
        updated results
      mysql-test/t/myisam.test:
        Test of RTREE index
      mysql-test/t/type_ranges.test:
        Updated test
      mysys/charset.c:
        Indentation change
      mysys/my_symlink.c:
        Removed compiler warning
      scripts/fill_help_tables.sh:
        Update for new help tables
      sql/field.cc:
        Indentation changes
      sql/filesort.cc:
        Optimized character set usage
      sql/item_cmpfunc.cc:
        Fix wrong usage of binary()
      sql/item_cmpfunc.h:
        Fix wrong usage of binary()
      sql/item_func.cc:
        Fix wrong usage of binary()
      sql/item_func.h:
        Fix wrong usage of binary()
      sql/item_strfunc.cc:
        Fix wrong usage of binary()
      sql/item_sum.cc:
        Fix wrong usage of binary()
      sql/item_sum.h:
        Fix wrong usage of binary()
      sql/key.cc:
        Indentation change
      sql/lex.h:
        HELP -> HELP_SYM
      sql/mysql_priv.h:
        Make get_field() more general
      sql/password.c:
        Indentation change + variable initialisation moved
      sql/sql_acl.cc:
        Make get_field() more general
      sql/sql_base.cc:
        Added comments + assertion for double call to mysql_lock_tables
      sql/sql_cache.cc:
        Indentation changes
      sql/sql_class.h:
        Added need_strxnfrm to SORT_FIELD to be able to optimise character set handling in filesort
      sql/sql_derived.cc:
        Renamed variables
      sql/sql_help.cc:
        New help functions (from Victor Vagin)
      sql/sql_lex.cc:
        Removed variables that doesn't have to be initialized for each query
      sql/sql_lex.h:
        Removed not used variable (olap)
      sql/sql_parse.cc:
        Fixed (not fatal) access of unitialized memory
        Indentation / code cleanup
      sql/sql_prepare.cc:
        Indentaion cleanup
      sql/sql_table.cc:
        Disabled RTREE until 5.0
      sql/sql_udf.cc:
        Make get_field() more general
      sql/sql_yacc.yy:
        Removed access to uninitialized memory
        Always set offset_limit and select_limit when using LIMIT (removed warnings)
        Allow usage of 'help week'
      sql/table.cc:
        Make get_field() more general
        More comments
      sql/table.h:
        Fixded type of TABLE_LIST->derived
      sql/time.cc:
        Stricter date / datetime handling (to be able to handle timestamps with days and microseconds)
      strings/ctype-bin.c:
        Added cha
      fcb61f59
  30. 17 Jan, 2003 1 commit
    • unknown's avatar
      Make the CLI client (client/mysql.cc) work with multi-line SPs. · e7ffc215
      unknown authored
      Make the mysqltest program (client/mysqltest.c) work with multi-line SPs.
      
      
      client/mysql.cc:
        Added 'delimiter' command
      client/mysqltest.c:
        Added 'delimiter' command
      mysql-test/install_test_db.sh:
        Fix for install 'proc' table
      mysql-test/r/connect.result:
        Fix for 'proc' table
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      e7ffc215
  31. 05 Dec, 2002 1 commit