1. 12 Nov, 2011 1 commit
    • unknown's avatar
      Fix MySQL BUG#12329653 · 1d721d01
      unknown authored
      In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
      the server produced in incorrect error message that there
      is an aggregate function without GROUP BY, for artificially
      created MIN/MAX functions during subquery MIN/MAX optimization.
      
      The fix introduces a way to distinguish between artifially
      created MIN/MAX functions as a result of a rewrite, and normal
      ones present in the query. The test for ONLY_FULL_GROUP_BY violation
      now tests in addition if a MIN/MAX function was part of a MIN/MAX
      subquery rewrite.
      
      In order to be able to distinguish these MIN/MAX functions, the
      patch introduces an additional flag in Item_in_subselect::in_strategy -
      SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
      final choice of a subuqery strategy. In order to make the choice
      consistent, access to Item_in_subselect::in_strategy is provided
      via new class methods.
      ******
      Fix MySQL BUG#12329653
      
      In MariaDB, when running in ONLY_FULL_GROUP_BY mode,
      the server produced in incorrect error message that there
      is an aggregate function without GROUP BY, for artificially
      created MIN/MAX functions during subquery MIN/MAX optimization.
      
      The fix introduces a way to distinguish between artifially
      created MIN/MAX functions as a result of a rewrite, and normal
      ones present in the query. The test for ONLY_FULL_GROUP_BY violation
      now tests in addition if a MIN/MAX function was part of a MIN/MAX
      subquery rewrite.
      
      In order to be able to distinguish these MIN/MAX functions, the
      patch introduces an additional flag in Item_in_subselect::in_strategy -
      SUBS_STRATEGY_CHOSEN. This flag is set when the optimizer makes its
      final choice of a subuqery strategy. In order to make the choice
      consistent, access to Item_in_subselect::in_strategy is provided
      via new class methods.
      1d721d01
  2. 11 Nov, 2011 1 commit
    • Igor Babaev's avatar
      Fixed LP bug #879871. · b91a6bd8
      Igor Babaev authored
      The function add_ref_to_table_cond missed updating the value of
      join_tab->pre_idx_push_select_cond after having updated the value
      of join_tab->select->pre_idx_push_select_cond.
      b91a6bd8
  3. 10 Nov, 2011 1 commit
  4. 08 Nov, 2011 1 commit
  5. 07 Nov, 2011 2 commits
  6. 06 Nov, 2011 2 commits
    • Igor Babaev's avatar
      Merge. · e0500dbc
      Igor Babaev authored
      e0500dbc
    • Igor Babaev's avatar
      Fixed LP bug #886145. · e0c1b3f2
      Igor Babaev authored
      The bug happened because in some cases the function JOIN::exec
      did not save the value of TABLE::pre_idx_push_select_cond in
      TABLE::select->pre_idx_push_select_cond for the sort table.
      
      Noticed and fixed a bug in the function make_cond_remainder
      that builds the remainder condition after extraction of an index
      pushdown condition from the where condition. The code
      erroneously assumed that the function make_cond_for_table left
      the value of ICP_COND_USES_INDEX_ONLY in sub-condition markers.
      Adjusted many result files from the regression test suite
      after this fix .
      e0c1b3f2
  7. 04 Nov, 2011 3 commits
  8. 03 Nov, 2011 2 commits
  9. 02 Nov, 2011 10 commits
  10. 01 Nov, 2011 5 commits
    • unknown's avatar
      Fix bug lp:833702 · 64986873
      unknown authored
      Analysis:
      Equality propagation propagated the constant '7' into
      args[0] of the Item_in_optimizer that stands for the
      "< ANY" predicate. At the same the min/max subquery
      rewrite swapped the order of the left and right operands
      of the "<" predicate, but used Item_in_subselect::left_expr.
      
      As a result, when the <ANY predicate is executed early in the
      execution phase as a contant condition, instead of a constant
      right (swapped) argument of the < predicate, there was a field
      (t3.a). This field had no data, since the whole predicate is
      considered constant, and it is evaluated before any tables are
      read. Having junk in the field row buffer produced wrong result
      
      Solution:
      Fix create_swap to pick the correct Item_in_optimizer left
      argument.
      64986873
    • unknown's avatar
      Fix of LP BUG#872775. · b40bc2b3
      unknown authored
      The problem was that merged views has its own nest_level numbering =>
      when we compare nest levels we should take into considiration basis (i.e. 0 level),
      if it is different then nest levels are not comparable.
      b40bc2b3
    • Igor Babaev's avatar
      Backported the fix and the test case for bug 12822678 from the mysql-5.6 code line. · a70f7aa5
      Igor Babaev authored
      Fixed a bug in select_describe.
      Adjusted results for affected test cases.
      a70f7aa5
    • unknown's avatar
      Fix of typo. · 9c5644e6
      unknown authored
      9c5644e6
    • Sergey Petrunya's avatar
      BUG#884631: Table elimination works 5.3 release builds even if turned off · acb2d4aa
      Sergey Petrunya authored
      - Make table elimination to actually switch itself on/off in release builds.
      acb2d4aa
  11. 31 Oct, 2011 3 commits
  12. 30 Oct, 2011 4 commits
  13. 29 Oct, 2011 1 commit
  14. 28 Oct, 2011 4 commits