An error occurred fetching the project authors.
  1. 03 May, 2006 1 commit
    • unknown's avatar
      Added code to remove closing comment code from event text, as would be · 1db5a360
      unknown authored
      supplied inside a  /*!VERSION event-text */  segment.  (Fixes Bug#18078
      
      
      mysql-test/t/disabled.def:
        Enabling 'mysqldump' test because events should load normally now.
      mysql-test/t/mysqldump.test:
        Add spaces and tabs to the end of statements, to prove trimming of 
        whitespace.
      sql/event_timed.cc:
        Remove  */  close-comment characters at the end, just as sp_head does.
            
        The parser should be smarter about not giving us text that jumps semantic 
        levels, but that's an issue for another day.
      1db5a360
  2. 18 Apr, 2006 1 commit
    • unknown's avatar
      fix for bug #19170 (Event creation leads to 100% CPU usage) · 185a3192
      unknown authored
      sql/event_timed.cc:
        - fix 100% cpu usage problem. If time_now==last_exec then don't schedule
          the event for time_now but increase the multiplier
        - if time_now is between STARTS and ENDS (the latter is set) or after STARTS
          (ENDS is not set) and there was no previous execution (imagine disabled
          scheduler being started) then don't schedule for time_now but for STARTS
          and then get_next_time() will find the correct time.
      185a3192
  3. 07 Apr, 2006 1 commit
    • unknown's avatar
      fix for bug #17494 (The algorithm for calculating execution times is not fully correct) · 7c596993
      unknown authored
      This also should fix 17493 and 17346, and probably 16397 (not tested).
      WL#1034 (Internal CRON)
      (post-review commit)
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/t/events.test:
        update test
      sql/event.cc:
        seems we get a crash if we compile it this way. better let the worker thread do it,
        this increases the stability.
      sql/event_executor.cc:
        kick in more often
      sql/event_timed.cc:
        - don't NULLify last_executed
        - implement (fix) better get_next_time() which does not use last_executed as basis
          but STARTS. STARTS is used as basis and the next point of time which is before ENDS,
          if set, is being found. The point > now and (point-starts) % interval_expression == 0.
      sql/item_timefunc.cc:
        move calc_time_diff to time.cc as it can be reused in other parts of the 
        server code (see event_timed.cc)
      sql/mysql_priv.h:
        export calc_time_diff() moved to time.cc from item_timefunc.cc
      sql/sql_show.cc:
        - fix presenting of LAST_EXECUTED
        - cleanup a bit
      sql/time.cc:
        - move calc_time_diff() from item_timefunc.cc to here
      7c596993
  4. 16 Mar, 2006 1 commit
    • unknown's avatar
      fix for bug 16408 (Events: crash for an event in a procedure) · 06dd9764
      unknown authored
      (one patch)
      
      
      mysql-test/r/events_bugs.result:
        fix for bug 16408
      mysql-test/t/events_bugs.test:
        fix for bug 16408
      sql/event.h:
        fix for bug 16408
      sql/event_timed.cc:
        fix for bug 16408
      sql/sql_parse.cc:
        fix for bug 16408
      sql/sql_yacc.yy:
        fix for bug 16408
      06dd9764
  5. 10 Mar, 2006 1 commit
  6. 09 Mar, 2006 1 commit
    • unknown's avatar
      Added code to mysqldump to dump timed events when instructed to do so, with · 38407743
      unknown authored
      the '-E' or '--events' flag.  (Closes Bug#16853 and Bug#17714.)
      
      
      WARNING:
      
      At present, these tests fail due to b*g number 18078.
      
      
      client/mysqldump.c:
        Added code to dump events, when asked to do so via the --events parameter.
        
        Also cleaned up some surrounding code.
      mysql-test/r/mysqldump.result:
        Added a test to create an event, dump it, restore it, add more events, dump
        all of them, and restore all of them.
      mysql-test/t/mysqldump.test:
        Added a test to create an event, dump it, restore it, add more events, dump
        all of them, and restore all of them.
      sql/event_timed.cc:
        No longer qualify SHOW CREATE EVENT names with the database name.
      BitKeeper/etc/ignore:
        Removing accidentally 'ignored' bogus file entry.
      38407743
  7. 03 Mar, 2006 1 commit
  8. 01 Mar, 2006 3 commits
    • unknown's avatar
      fix for bug #16413 (Events: statements don't appear in the general query log) · 265df624
      unknown authored
      WL#1034
      
      
      mysql-test/t/events_logs_tests-master.opt:
        Rename: mysql-test/t/events_slow_query-master.opt -> mysql-test/t/events_logs_tests-master.opt
      sql/event_timed.cc:
        ask the anonymous SP to log general statements
      sql/sp_head.cc:
        save the OPTION_LOG_OFF and restore it after execution
      sql/sp_head.h:
        add a new flag for general log
      mysql-test/r/events_logs_tests.result:
        update result file
      mysql-test/t/events_logs_tests.test:
        add test for general log
      265df624
    • unknown's avatar
      fix for bug #16426 · d576ca18
      unknown authored
      Events: Event-caused statements don't appear in the slow query log
      WL#1034
      
      
      sql/event_executor.cc:
        enable slow logging
      sql/event_timed.cc:
        enable slow logging for the anonymous SP
      sql/sp_head.cc:
        allow thd->enable_slow_log to be TRUE if only
        m_flags & sp_head::LOG_SLOW_STATEMENTS
        Because usually enable_slow_log is 1 in user mode, this second
        check is needed backup the mode otherwise.
      sql/sp_head.h:
        add a new constant for slow queries. SP by default does not log slow queries in the
        body just the whole CALL could be considered as slow if taking too much time and
        called directly from the user
      sql/sql_parse.cc:
        let us see in the the trace log
      d576ca18
    • unknown's avatar
      fix problem · d8bd689d
      unknown authored
      Error: Freeing unallocated data at line 900, 'sql_db.cc'
      (
       DROP DATABASE frees thd->db for everything but thd->slave_thread=1
       however we are not slave thread and more bugs could appear if we 
       pretend to be, then we will be good boys and just strdup the value.
       If not DROP DATABASE then THD::~THD() will free the value.
      )
      
      
      sql/event_timed.cc:
        fix problem 
        Error: Freeing unallocated data at line 900, 'sql_db.cc'
        (
         DROP DATABASE frees thd->db for everything but thd->slave_thread=1
         however we are not slave thread and more bugs could appear if we 
         pretend to be, then we will be good boys and just strdup the value.
         If not DROP DATABASE then THD::~THD() will free the value.
        )
        - fix also a bad message
      d8bd689d
  9. 28 Feb, 2006 4 commits
    • unknown's avatar
      fix compiler warnings: precision loses, unused vars · 11c7dbd3
      unknown authored
      the warnings came from MSFT compiler (output of pushbuild)
      
      
      sql/event.cc:
        fix compiler warnings: precision loses, unused vars
      sql/event_executor.cc:
        fix compiler warnings: precision loses, unused vars
      sql/event_timed.cc:
        fix compiler warnings: precision loses, unused vars
      11c7dbd3
    • unknown's avatar
      class event_timed -> Event_timed · 58a6d96c
      unknown authored
      fix for bug#17793 (Scheduler uses class event_timed should be Event_timed)
      
      
      sql/event.cc:
        class event_timed -> Event_timed
      sql/event.h:
        class event_timed -> Event_timed
      sql/event_executor.cc:
        class event_timed -> Event_timed
      sql/event_priv.h:
        class event_timed -> Event_timed
      sql/event_timed.cc:
        class event_timed -> Event_timed
      sql/sql_lex.h:
        class event_timed -> Event_timed
      sql/sql_show.cc:
        class event_timed -> Event_timed
      sql/sql_yacc.yy:
        class event_timed -> Event_timed
      58a6d96c
    • unknown's avatar
      fix for bug#16537 · b934539d
      unknown authored
      (post-review pre-push changes)
      coding style (mostly trailing spaces removed)
      
      
      mysql-test/r/events.result:
        fix result file
      sql/event.cc:
        - remove trailing spaces
        - add a missing initializer (gcc warning)
        - C++ to C comments
      sql/event_executor.cc:
        - fix coding style (C++ to C comments, remove trailing spaces)
        - fix wrong indexing buggie not found till now (queue indexing is 0 based,
          not 1 based)
      sql/event_timed.cc:
        - fix coding style
      b934539d
    • unknown's avatar
      fix for bug#16537 (Events: mysql.event.starts is null) · 317c6851
      unknown authored
      - now when the event is created and STARTS is omitted then STARTS is implicitly
        CURRENT_TIMESTAMP
      - This CS also fixed incorrect presentation of STARTS/ENDS in I_S.EVENTS
      (incorporated review changes)
      
      
      mysql-test/r/events.result:
        results of new test cases
      mysql-test/t/events.test:
        new test cases for bug #16537 (Events: mysql.event.starts is null)
      sql/event.cc:
        - check whether event_timed::starts_null only in case
          event_timed::expression is set, so for recurring events only
        - disable binlogging of CREATE EVENT statement. It should not be
          replicated but the result of the execution. Still the replication is
          untouched topic.
      sql/event.h:
        - add flags whether starts, ends and execute_at are null or not
      sql/event_executor.cc:
        - check whether xxx_null instead of !xxxx.year
      sql/event_timed.cc:
        - introduce xxx_null and change the usage of xxx.year to !xxx_null
      sql/sql_show.cc:
        - don't show 0000-00-00 in I_S.EVENTS when the value is NULL
      sql/sql_yacc.yy:
        - if STARTS is omitted default to current_timestamp
      317c6851
  10. 24 Feb, 2006 1 commit
  11. 21 Feb, 2006 1 commit
    • unknown's avatar
      fix for bug#16407 (EVENTS: sql_mode) · ae48f5fd
      unknown authored
      post-review fixes
      
      
      mysql-test/r/events_bugs.result:
        fix result
      sql/event.cc:
        fix compilation problem on windows
      sql/event_executor.cc:
        show the right host in show processlist (should be event_scheduler@localhost)
      sql/event_timed.cc:
        a bit more debug infor
        fix a problem introduced with previous push :( . clean everything that's whitespace.
        found because of new test cases which were crashing.
      sql/sql_show.cc:
        fix compile problem on windows
      ae48f5fd
  12. 20 Feb, 2006 2 commits
    • unknown's avatar
      fix for bug#16407 (Events: Changes in sql_mode won't be taken into account) · 203b37ef
      unknown authored
      WL#1032
      sql_mode setting was disregarded during create/alter event and wasn't set during
      event execution.
      (post-review small fixes)
      
      
      sql/event.cc:
        store the sql_mode when the body is stored
        - always on create event
        - during alter event if the user changes the body
      sql/event.h:
        add sql_mode as member variable
      sql/event_timed.cc:
        - exchange thd->variables.sql_mode before and after execution
        - set the sql_mode of the anonymous SP -> event_timed::sphead
      sql/sql_show.cc:
        - show real content in I_S.EVENTS.SQL_MODE , disallow NULL
      203b37ef
    • unknown's avatar
      fix for bug #16411 Events: Microsecond intervals are allowed · 17fb7f96
      unknown authored
      WL#1034
      
      
      mysql-test/r/events.result:
        output fix
      sql/event.cc:
        - handle also INTERVAL_MICROSECOND, was missing.
        - use renamed ER_ code which is generic
      sql/event.h:
        add new error code
      sql/event_executor.cc:
        - use new ER_ code name
        - handle EVEX_MICROSECOND_UNSUP error code
      sql/event_timed.cc:
        forbid MICROSECOND intervals for events
      sql/share/errmsg.txt:
        rename error code, it's generic
      sql/sql_show.cc:
        use new error code name
      sql/sql_yacc.yy:
        bail out if any MICROSECOND interval is specified
      17fb7f96
  13. 16 Feb, 2006 3 commits
    • unknown's avatar
      fix for bug#17543 Creating Event crash the server · f39aca3f
      unknown authored
      this problem affects only debug builds
      
      
      mysql-test/r/events.result:
        update results
      mysql-test/t/events.test:
        tests for bug#17543 Creating Event crash the server
      sql/event_timed.cc:
        the delimiter between DO and the body could be not only a space
        but any other recognized white space, so use proper macro.
      f39aca3f
    • unknown's avatar
      fix bug in show events which shows · c80a0d71
      unknown authored
      | INTERVAL_VALUE | INTERVAL_FIELD |
      | 20             | 20 MINUTE      |
      the second one should be without the value
      
      
      mysql-test/r/events.result:
        update test result to be as they should be
      sql/event_timed.cc:
        manually append the name of the interval because it's no more appended
        by reconstruct_value
      c80a0d71
    • unknown's avatar
      small post-merge fixes for bug#16406 · 89f598ee
      unknown authored
      (pre-push)
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/t/events.test:
        few more tests
      sql/event.cc:
        fix compilation failure after big merge
      sql/event.h:
        initialize s_ctx to be the context to be used.
        don't use sphead->m_security_ctx but we will copy 
        the initted ctx to there
      sql/event_timed.cc:
        -initialize s_ctx to be the context to be used.
        don't use sphead->m_security_ctx but we will copy 
        the initted ctx to there
        
        - first init the context
        - then compile the event
        - and then copy the context
        - don't use mysql_change_db() for now change_security_context() gets the
          right context info
      89f598ee
  14. 15 Feb, 2006 4 commits
    • unknown's avatar
      fix for bug#16406 (Events: DROP DATABASE doesn't automatically drop events) · fea4742d
      unknown authored
      WL#1034
      - This changeset also changes the executor so its quite more stable now.
        Stressing test case added that executes ~800 events per second and dropping
        hundreds of events at once using DROP DATABASE.
      (with fixes after review of JimW)
      (with fixes after review of Serg)
      
      
      mysql-test/r/events.result:
        update results after TRIGGER_ACL was added
      mysql-test/t/events.test:
        -redundant line
      sql/event.cc:
        Implemented evex_db_drop_events() which drops all events
        from a specific database. Needed for SQLCOM_DROP_DATABASE
      sql/event.h:
        - protect the event better (see the changes to event_executor.cc
          and event.cc). An event object could be used in a spawned thread
          before it's executed but till now the object is marked as being
          executed when the anonymous sp_head is executed. However, there are
          timeframes before and after that during which the event is not marked
          as executed and other thread may delete the object -> so we end with
          a nirvana pointer.
      sql/event_executor.cc:
        - extract some of the code executed in the main thread to a function. Too long
          functions are bad for the overview.
        - prepend all information/error messages to the console with "SCHEDULER:" for
          better overview, and easied searching in the log tables.
      sql/event_priv.h:
        - change the name, of evex_db_find_event_by_name() and don't
          used C++ features like function overloading
        - define consts for result returned from event_timed::spawn_now()
      sql/event_timed.cc:
        - add few methods related to event execution.
          now the event spawns the worker thread and
          passes itself as parameter. This way it locks itself for exectution
          first and then spawning -> no race condition. When the worker thread
          has finished working with the reference it calls back
          event_timed::spawn_thread_finish() to unlock itself.
      sql/sql_db.cc:
        - call evex_drop_db_events() on DROP DATABASE
      fea4742d
    • unknown's avatar
      build fixes · ea8a26c6
      unknown authored
      sql/event.cc:
        - make this not unsigned. gcc complains
      sql/event_timed.cc:
        acl_getroot_no_password() is not there in libmysqld, disable it's usage
        in this case.
      sql/set_var.cc:
        fix for the broken build of Serg. gcc seems to be pretty happy without
        the return and returns the value of the last statement
      ea8a26c6
    • unknown's avatar
      more cosmetic before push of fix for bug#17289 · 4e2b90b1
      unknown authored
      sql/event_timed.cc:
        - fix comment
        - use mysql_change_db() this will check for us
      4e2b90b1
    • unknown's avatar
      Fix the coding style in a few new files. · 9d5bf35d
      unknown authored
      9d5bf35d
  15. 14 Feb, 2006 1 commit
    • unknown's avatar
      - final fixes for bug#16431 (Events: An event which alters itself disappears) · 8d4f74be
      unknown authored
      - fix for bug#16423 (Events: SHOW CREATE EVENT doesn't work)
      - this Changeset commits makes CREATE/UPDATE/DELETE EVENT real DDL statements
        by committing the currently open transaction before they are executed.
      - this Changeset also fixes a trailing space problem since the very early days
        of the internal cron
      - adds sophisticated checking of whether mysql.event was tampered accidentally
        or with purpose by an user.
      - adds a lot of inline function documentation - documents everything left
        uncodumented
      - INTERVAL_XXXX to XXX in I_S.EVENTS.INTERVAL_FIELD
      
      WL#1034 (Internal CRON)
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/t/events.test:
        add test cases for SHOW CREATE EVENT
        add test cases where the structure of mysql.event is changed and error reporting in this case
      sql/event.cc:
        - do a lot more checking on mysql.event whether it's valid
          introduced generic function table_check_intact() which can be used also
          for checking whether a system table (mysql.*) has been tampered by user
          and report an error in this case. The checking is quite strict, thus
          maybe some mechanism can be added later that loosens this like some
          session variable, for instance, i_am_aware_that_i_can_damage_my_data
          so the table will be opened nevertheless we think that it's not valid.
        - add evex_show_create_event(THD *thd, sp_name *spn, LEX_STRING definer)
        - document a loooot. not a single function left undocumented.
      sql/event.h:
        - add evex_show_create_event(THD *thd, sp_name *spn, LEX_STRING definer)
        - change get_show_create_event() to get_create_event()
        - add TABLE_FIELD_W_TYPE used by table_check_intact()
        - add event_timed::sql_mode so it can be used by show create event. currently
          always 0, will be fixed by a patch for another bug. At least makes the code
          of show create event complete.
      sql/event_executor.cc:
        - add evex_check_system_tables() that checks on boot and event
          main thread startup that mysql.db and mysql.user tables are correct.
        - document everything!
      sql/event_priv.h:
        remove a line
      sql/event_timed.cc:
        - implement SHOW CREATE EVENT
        - document undocumented functions!
      sql/share/errmsg.txt:
        - fix an error message and add two new
      sql/sql_acl.cc:
        - add mysql.db table definition to use by table_check_intact()
        - exchange some of the positions by numbers from mysql.db to enum names (see sql_acl.h)
      sql/sql_acl.h:
        - define the structure of mysql.db table
      sql/sql_parse.cc:
        - handle SQLCOM_SHOW_CREATE_EVENT
        - end the current transaction becase CREATE/UPDATE/DELETE EVENT is a DDL
          statement
      sql/sql_show.cc:
        - remove interval_type_to_name
        - use common function event_reconstruct_interval_expression()
          that reconstructs the expression given at create/alter, to some
          extent - interval of 2:62 MINUTE_SECOND will be reconstructed as
          interval of 3:02 MINUTE_SECOND!
      sql/sql_yacc.yy:
        init the definer of event_timed also when doing SHOW CREATE EVENT
        because it's needed for checking into mysql.event
      sql/table.cc:
        - remove stale code. only mysql.event should be a 'system_table'
        - add table_check_intact() to check the consistency of a table.
          mostly usable with mysql.xxx tables.
      sql/table.h:
        - export TABLE_FIELD_W_TYPE and table_check_intact() which are used for 
          checking the structure of a table. mostly usable for mysql.xxx tables.
      8d4f74be
  16. 10 Feb, 2006 1 commit
    • unknown's avatar
      fix for bug #17289 Events: missing privilege check for drop database · 5b497b16
      unknown authored
      Events were executed with all privileges possible on planet Earth :(
      WL#1034
      
      
      mysql-test/r/events.result:
        update test results
      mysql-test/t/events.test:
        test for bug#17289 Events: missing privilege check for drop database
      sql/event.h:
        -add two new methods to event_timed to change and restore
         the security context
      sql/event_executor.cc:
        - move code regarding privilieges checking to event_timed::execute()
        - add a new function evex_print_warnings() which prints the notes/warnings/errors
          to the console (easily capturable with logs-into-tables) so one can see what
          has happened if there was an error of some sort!
      sql/event_timed.cc:
        - fix documentation
        - add a new error code -99, EVENT was revoked from the user on the DB
        - set_sec_ctx, execute, restore_sex_ctx
      sql/sql_error.cc:
        - make warning_level_names public to be used in event_executor.cc
        - change from 2 arrays to a LEX_STRING array
      5b497b16
  17. 07 Feb, 2006 1 commit
    • unknown's avatar
      - fix for bug #16414 (Events: Crash or hang if event drops itself) · 99eb6eb6
      unknown authored
      WL#1034 (Internal CRON)
      (with post-review fix)
      
      
      mysql-test/r/events.result:
        update the result
      mysql-test/t/events.test:
        use --sleep instead of select sleep()
        enable some scheduler related tests. They were disabled because of a hang that
        happened. The hang is fixed with this bugfix.
      sql/event.cc:
        - evex_remove_from_cache reports back whether the in_memory
          object was deleted or was scheduled. In case scheduling then
          don't delete it from outside but let it do it itself
        - move out db interaction code out of evex_drop_event to db_drop_event
          so it can be called from outter space :)
      sql/event_priv.h:
        - export the new function db_drop_event()
      sql/event_timed.cc:
        - use db_drop_event() and don't implement the dropping ourselves
      sql/sql_parse.cc:
        - some debug info about the status code returned.
      99eb6eb6
  18. 30 Jan, 2006 3 commits
    • unknown's avatar
      post-merge fixes of fix for bug#16642 (No I_S.EVENTS table) · e5eea47c
      unknown authored
      WL#1034 (Internal CRON)
      
      
      mysql-test/r/events.result:
        fix result of t/events (post-merge fix of bug #16642)
      mysql-test/r/system_mysql_db.result:
        fix result(post-merge fix of bug #16642)
      mysql-test/t/events.test:
        fix test, use --echo instead of select, fix failing create event statement
      sql/event_timed.cc:
        add a bit more debug information
      e5eea47c
    • unknown's avatar
      fix for bug#16642 (Events: No INFORMATION_SCHEMA.EVENTS table) · c3542ceb
      unknown authored
      post-review change - use pointer instead of copy on the stack.
      WL#1034 (Internal CRON)
       This patch adds INFORMATION_SCHEMA.EVENTS table with the following format:
        EVENT_CATALOG  - MYSQL_TYPE_STRING  (Always NULL)
        EVENT_SCHEMA   - MYSQL_TYPE_STRING  (the database)
        EVENT_NAME     - MYSQL_TYPE_STRING  (the name)
        DEFINER        - MYSQL_TYPE_STRING  (user@host)
        EVENT_BODY     - MYSQL_TYPE_STRING  (the body from mysql.event)
        EVENT_TYPE     - MYSQL_TYPE_STRING  ("ONE TIME" | "RECURRING")
        EXECUTE_AT     - MYSQL_TYPE_TIMESTAMP (set for "ONE TIME" otherwise NULL)
        INTERVAL_VALUE - MYSQL_TYPE_LONG    (set for RECURRING otherwise NULL)
        INTERVAL_FIELD - MYSQL_TYPE_STRING  (set for RECURRING otherwise NULL)
        SQL_MODE       - MYSQL_TYPE_STRING  (for now NULL)
        STARTS         - MYSQL_TYPE_TIMESTAMP (starts from mysql.event)
        ENDS           - MYSQL_TYPE_TIMESTAMP (ends from mysql.event)
        STATUS         - MYSQL_TYPE_STRING  (ENABLED | DISABLED)
        ON_COMPLETION  - MYSQL_TYPE_STRING  (NOT PRESERVE | PRESERVE)
        CREATED        - MYSQL_TYPE_TIMESTAMP
        LAST_ALTERED   - MYSQL_TYPE_TIMESTAMP
        LAST_EXECUTED  - MYSQL_TYPE_TIMESTAMP
        EVENT_COMMENT  - MYSQL_TYPE_STRING
      
        SQL_MODE is NULL for now, because the value is still not stored in mysql.event .
      Support will be added as a fix for another bug.
      
       This patch also adds SHOW [FULL] EVENTS [FROM db] [LIKE pattern]
      1. SHOW EVENTS shows always only the events on the same user,
         because the PK of mysql.event is (definer, db, name) several 
         users may have event with the same name -> no information disclosure.
      2. SHOW FULL EVENTS - shows the events (in the current db as SHOW EVENTS)
         of all users. The user has to have PROCESS privilege, if not then
         SHOW FULL EVENTS behave like SHOW EVENTS.
      3. If [FROM db] is specified then this db is considered.
      4. Event names can be filtered with LIKE pattern.
        SHOW EVENTS returns table with the following columns, which are subset of
        the data which is returned by SELECT * FROM I_S.EVENTS
         Db
         Name
         Definer 
         Type
         Execute at
         Interval value
         Interval field 
         Starts 
         Ends
         Status
      
      
      mysql-test/lib/init_db.sql:
        change the PK - (definer, db, name)
        quicker searches when SHOW EVENTS;
        allow also different users to have events with the same name -> 
        no information disclosure
      mysql-test/r/events.result:
        result of new tests
      mysql-test/r/information_schema.result:
        result of new tests
      mysql-test/r/information_schema_db.result:
        result of new tests
      mysql-test/r/system_mysql_db.result:
        result of new tests
      mysql-test/t/events.test:
        new tests for information_schema.events
      scripts/mysql_create_system_tables.sh:
        change the PK of mysql.event to (definer, db, name)
      scripts/mysql_fix_privilege_tables.sql:
        change the PK of mysql.event to (definer, db, name)
      sql/event.cc:
        pass around the definer of the event because of the new PK
        which is (definer, db, name). It's needed for index searching.
      sql/event.h:
        - make enum evex_table_field again public so it can be used
        in sql_show.cc
        - make created and modified ulonglong, because they should be such
        - make public evex_open_event_table so it can be used in sql_show.cc
      sql/event_executor.cc:
        - cosmetics
      sql/event_priv.h:
        - moved enum evex_table_field and evex_open_event_table()
          to event.h (made them therefore public)
      sql/event_timed.cc:
        - in event_timed::init_definer() always fill this.definer with
          the concatenated value of definer_user@definer_host. Makes
          later the work easier.
        - pass around the definer wherever is needed for searching 
          (new prototype of evex_db_find_evex_aux)
      sql/mysqld.cc:
        - add counter for SHOW EVENTS
      sql/sql_lex.h:
        - register SHOW EVENTS as command
      sql/sql_parse.cc:
        - handle SCH_EVENTS (I_S.EVENTS like SCH_TRIGGERS)
        - make additional check in case of SHOW EVENTS (check for EVENT on
          the current database. if it is null check_access() gives appropriate
          message back.
      sql/sql_show.cc:
        - add INFORMATION_SCHEMA.EVENTS and SHOW EVENTS
        - I_S.EVENTS.SQL_MODE is NULL for now -> not implemented. Trudy
          asked to be added so bug #16642 can be completely closed. There
          is another bug report which will fix the lack of storage of
          SQL_MODE during event creation.
      sql/sql_yacc.yy:
        - always call event_timed::init_definer() when CREATE/ALTER/DROP
          EVENT but not when just compiling the body of the event because
          in this case this operation is not needed, it takes memory and
          CPU time and at the end the result is not used. event_timed::definer
          is used only on SQLCOM_CREATE/ALTER/DROP_EVENT execution not on
          statement compilation.
        - add SHOW [FULL] EVENTS [FROM db] [LIKE pattern]
          in case of FULL and the user has PROCESS privilege then he will see
          also others' events in the current database, otherwise the output
          is the same as of SHOW EVENTS. Because the events are per DB only
          the events from the current database are shown. pattern is applied
          against event name. FROM db is self explanatory.
      sql/table.h:
        add SCH_EVENTS as part of INFORMATION_SCHEMA
      c3542ceb
    • unknown's avatar
      Windows compile fixes in preparation for 5.1.6 beta. · ab88a598
      unknown authored
      VC++Files/client/mysqldump.vcproj:
        Add missing source file.
      VC++Files/mysql.sln:
        Fix configuration mismatch.
      VC++Files/sql/mysqld.vcproj:
        Enable row-based replication.
        Add missing source files.
      scripts/make_win_src_distribution.sh:
        Add copying of missing directory.
      sql/event.h:
        Fix type conflict only visible on Windows.
      sql/event_executor.cc:
        Fix non-portable thread stuff.
      sql/event_timed.cc:
        Fix type conflict only visible on Windows.
      sql/ha_archive.cc:
        Add cast needed for Windows.
      sql/handler.h:
        Fix Windows byte * <-> char * mismatch.
      sql/opt_range.cc:
        Fix Windows byte * <-> char * mismatch.
      sql/set_var.cc:
        BUG#16811
        Fix Windows compilation by making the cast-away of volatile implicit
        (Windows linker does not like volatile <-> non-volatile mismatch, in
        contrast to Unix)
      sql/sql_partition.cc:
        Fix Windows byte * <-> char * mismatch.
      ab88a598
  19. 26 Jan, 2006 2 commits
    • unknown's avatar
      fix for bug#16434 (Events: Illegal dates don't cause errors) · 8b3b76c6
      unknown authored
      (post-review commit)
      WL#1034 (Internal CRON)
      
      
      sql/event_timed.cc:
        remove bogus check
      sql/share/errmsg.txt:
        change error messages
      sql/sql_yacc.yy:
        handle error code returned by event_timed::init_starts()
      8b3b76c6
    • unknown's avatar
      fix for bug#16419 (Events: can't use timestamp in the schedule) · 3881218d
      unknown authored
      WL #1034 (Internal CRON)
      
      
      mysql-test/r/events.result:
        update test result
      mysql-test/t/events.test:
        add tests
      sql/event_timed.cc:
        - remove stupid check of val_int()
        - fix for bug #16419 (Events: can't use timestamp in the schedule)
          => don't use val_int() but only get_date() and use the date!
      sql/share/errmsg.txt:
        - fix an error message, one more "einen"
      sql/sql_yacc.yy:
        - handle new return value of event_timed::init_execute_at()
      3881218d
  20. 20 Jan, 2006 1 commit
    • unknown's avatar
      fix for bug#16431 (Events: An event which alters itself disappears) · 3a8e50e0
      unknown authored
      WL#1034 (Internal CRON)
      
      
      mysql-test/r/events.result:
        add a test for to test bug #16431
      mysql-test/t/events.test:
        results of new tests
      sql/event.cc:
        - more debug info
        - pass info to evex_remove_from_cache() whether the operation 
          was drop or alter. this fixes possible bug that may lead to dropping
          of an event when it's altered. also fix for bug#16431
      sql/event_executor.cc:
        be more verbose and throw more errors
      sql/event_timed.cc:
        - add ` around the names of the db and the event_name and not
        their concatenation. remove ; from the end - unneeded. this fixes bug #16431,
        which was failing because after some recursion the query was ending on ;;
        which is normally an error in the parser because that's the delimiter
        
        - more debug info
        - don't execute lex_end() two times when there's a parse error or thd->is_fatal_error
      3a8e50e0
  21. 18 Jan, 2006 1 commit
    • unknown's avatar
      - fix bug #16435 (Weekly events execute every second) (WL#1034 Internal CRON) · 6bd58a2a
      unknown authored
      Before the interval expression was considered to be in seconds, now it is
      just a number and the type of interval is considered.
      
      - this changeset introduces also fix for bug#16432 (Events: error re interval
        misrepresents the facts)
        the code of event_timed::set_interval() was refactored anyway so it is meaningful to
        fix the bug in the same changeset.
      
      
      include/my_time.h:
        - move enum interval_type to include/my_time.h so it can be used by functions
          in the whole server
      sql/event.cc:
        - don't use second_part
        - fix small problem with create event xyz, when xyz exists -> make it error
          instead of warning if create_if_not is false.
      sql/event.h:
        pass thd to mark_last_executed() to be able to call thd->end_time()
      sql/event_executor.cc:
        - pass thd to event_timed::compute_next_execution_time()
        - a bit more DBUG info in the server log
        - handle error returned by event_timed::compute_next_execution_time()
      sql/event_priv.h:
        - define the maximal possible value for interval_value
      sql/event_timed.cc:
        - more docs
        - add static get_next_time() which sums a TIME with an interval
        - fix bug #16435 (Weekly events execute every second)
        Before the interval expression was considered to be in seconds, now it is
        just a number and the type of interval is considered.
        - fix for bug#16432 (Events: error re interval misrepresents the facts)
          (return an error if a value is too big or is negative - errmsg changed)
      sql/item_timefunc.cc:
        - export get_interval_date()
        - refactor Item_date_add_interval::get_date() and extract the core
          to date_add_interval() in time.cc so it can be reused by the
          scheduler code in event_timed.cc
      sql/item_timefunc.h:
        - export get_interval_value() so it can be reused in event_timed.cc in
          function static get_next_time()
        - move enum interval_type to include/my_time.h so it can be used by functions
          in the whole server
      sql/mysql_priv.h:
        export the new function date_add_interval() added to time.cc
      sql/share/errmsg.txt:
        - change error message to be appropriate as fix for bug#16432
          (Events: error re interval misrepresents the facts)
      sql/sql_yacc.yy:
        - change error message to be appropriate as fix for bug#16432
          (Events: error re interval misrepresents the facts)
      sql/time.cc:
        extract the core of Item_date_add_interval::get_date()
        to a function per Serg's request. The code can be reused
        to add und substract interval from a date.
      6bd58a2a
  22. 12 Jan, 2006 1 commit
    • unknown's avatar
      WL #1034 (Internal CRON) post-push update · eb201203
      unknown authored
      - fix compile failure on QNX and FreeBSD
      
      
      sql/event_executor.cc:
        time_t and my_time_t seem have the same length so cast
        in tztime.cc it's already done this way.
        Precautionary check at runtime about the sizes of my_time_t and time_t
      sql/event_timed.cc:
        do time_t* cast to satisfy compilers on various platforms
        (QNX, FreeBSD)
      eb201203
  23. 11 Jan, 2006 1 commit
    • unknown's avatar
      WL #1034 (Internal CRON) pre-push fixes · b8ce8ad1
      unknown authored
      after another merge fixes.
      
      
      mysql-test/r/information_schema.result:
        WL #1034 (Internal CRON)
        fix result
      mysql-test/r/mysqlcheck.result:
        WL #1034 (Internal CRON)
        fix result
      mysql-test/r/sp.result:
        WL #1034 (Internal CRON)
        fix result
      sql/event.cc:
        after fixes for WL1012 fix these to be able to compile
      sql/event_timed.cc:
        after fixes for WL1012 fix these to be able to compile
      sql/share/errmsg.txt:
        readd error messages removed during manual update
      sql/sql_yacc.yy:
        fix sql_yacc.yy for WL#1034 (Internal CRON) after the manual
        merge. The merge wasn't good :(
      b8ce8ad1
  24. 20 Dec, 2005 1 commit
    • unknown's avatar
      WL #1034 update · 9b323387
      unknown authored
      - fix one bug found by PeterG, namely bug #51
      
      #there is a major problem currently after removing the specialised DYNAMIC_ARRAY as 
        storage for the events. I have to reintroduce similar storage, this time probably some
        linked list or maybe some API on top of DYNAMIC_ARRAY.
      
      
      sql/event.cc:
        close the table
      sql/event.h:
        change definition
      sql/event_executor.cc:
        don't start the thread in advance
      sql/event_timed.cc:
        - don't call evex_drop_event
        - quote the name during compilation to make create event `the rain in spain goes into the drain` not fail.
      9b323387
  25. 16 Dec, 2005 1 commit
    • unknown's avatar
      WL #1034 update · 7634f7d6
      unknown authored
      - handle crashes where the table definition has been changed
        (different number of fields)
      
      
      sql/event.cc:
        change the way table is opened
        check whether the number of fields is exact, otherwise report damaged table
      sql/event_executor.cc:
        - move around some code
        - use the new way of table opening
      sql/event_priv.h:
        - new declaration
      sql/event_timed.cc:
        - now 0 is ok
      7634f7d6
  26. 15 Dec, 2005 1 commit
    • unknown's avatar
      WL#1034 update · 48405ec7
      unknown authored
      - fix EVENT_ACL problem that GRANT ALL on some_db.* to someone@somewhere did not get to mysql.db
      - fix crash when the following is executed :
        CREATE EVENT P() CREATE EVENT E ON SCHEDULER 1 SECOND DO ROLLBACK;
        (creation works as well as calling P() which creates the event).
      
      
      mysql-test/lib/init_db.sql:
        - fix init_db.sql so add Event_priv to the database privs, many tests failed because of that
          ommision
        - remove the quotes from the column names
      mysql-test/t/events.test:
        - fix the small test, don't create own db
      scripts/mysql_fix_privilege_tables.sql:
        - fix that
      sql/event.cc:
        - be defensive and don't crash if outside has already has opened some table
      sql/event_executor.cc:
        - show in SHOW PROCESSLIST - "event_scheduler" as name of the user of the main thread
        - use "localhost" as the host where event_scheduler comes from
        - comment out some debug info, fix other debug info
      sql/event_timed.cc:
        - enable EVENT creation inside SP. sphead from lex->sphead goes to et->sphead. it's there only
          if we compile the event. OTOH when doing 
          CREATE PROCEDURE PROC() CREATE EVENT SOME_EV ON SCHEDULE EVERY 1 SECOND DO ROLLBACK;
          I have only to get the body of the event which is anonymous SP. Before it being "compiled"
          but then freed without being used because a bit later it is compiled one more time before
          being put in the events cache. So it was good that the memory structures weren't reused but
          scrapped out. Now lex->sphead is not needed during event creation but only where the event's
          body starts and where it ends so to be able at later stage to compile this anonymous SP (the
          body of the event).
      sql/sp_head.cc:
        - copy over a fix to a crash
      sql/sql_acl.h:
        - fix privileges.
          There was _NO_ documentation about that. Another CHUNK had to be created to so EVENT_ACL gets shifted to
          it's place in the db table. So how this is calculated? EVENT_ACL is 1 << 26. Remember 26, see which poistion
          in the db table is EVENT_ACL, it's 17, counted from 0. 26 - 17 = 9, then shift it with 9.
          CHUNKS are created because in some cases some privileges are in chunks and they are shifted at once. There are
          few chunks of such privileges which has to be shifted to get to exactly the structure of mysql.db table.
      sql/sql_parse.cc:
        - ok, we don't care anymore about lex->sphead because our sphead is lex->et->sphead
      sql/sql_yacc.yy:
        - bail out if new event_timed returns 0x0
        - enable creation of an event inside a SP
          CREATE PROCEDURE P() CREATE EVENT E ON SCHEDULE EVERY 1 SECOND DO SELECT 1;
      48405ec7