1. 23 Jun, 2007 3 commits
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt · 26b526dc
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.1-opt
      
      
      libmysql/libmysql.c:
        Merge with 5.0-opt.
      mysql-test/r/insert_select.result:
        Merge with 5.0-opt.
      mysql-test/r/mysqlbinlog.result:
        Merge with 5.0-opt.
      mysql-test/r/rpl_change_master.result:
        Merge with 5.0-opt.
      mysql-test/r/view.result:
        Merge with 5.0-opt.
      mysql-test/t/insert_select.test:
        Merge with 5.0-opt.
      mysql-test/t/mysqlbinlog.test:
        Merge with 5.0-opt.
      mysql-test/t/rpl_change_master.test:
        Merge with 5.0-opt.
      mysql-test/t/view.test:
        Merge with 5.0-opt.
      sql/item.cc:
        Merge with 5.0-opt.
      sql/item.h:
        Merge with 5.0-opt.
      sql/log_event.cc:
        Merge with 5.0-opt.
      sql/sql_select.cc:
        Merge with 5.0-opt.
      26b526dc
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-29095 · d37471b4
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      d37471b4
    • unknown's avatar
      Fixed bug #29095. · 1bab1ddc
      unknown authored
      INSERT into table from SELECT from the same table
      with ORDER BY and LIMIT was inserting other data
      than sole SELECT ... ORDER BY ... LIMIT returns.
      
      One part of the patch for bug #9676 improperly pushed
      LIMIT to temporary table in the presence of the ORDER BY
      clause.
      That part has been removed.
      
      
      sql/sql_select.cc:
        Fixed bug #29095.
        One part of the patch for bug #9676 improperly pushed
        LIMIT to temporary table in the presence of the ORDER BY
        clause.
        That part has been removed.
      mysql-test/t/insert_select.test:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      mysql-test/r/insert_select.result:
        Expanded the test case for bug #9676.
        Created a test case for bug #29095.
      1bab1ddc
  2. 22 Jun, 2007 6 commits
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · f3940eba
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B28400-5.0-opt
      
      
      f3940eba
    • unknown's avatar
      Bug #27383: Crash in test "mysql_client_test" · fe036d98
      unknown authored
      The C optimizer may decide that data access operations
      through pointer of different type are not related to 
      the original data (strict aliasing).
      This is what happens in fetch_long_with_conversion(),
      when called as part of mysql_stmt_fetch() : it tries 
      to check for truncation errors by first storing float
      (and other types of data) into a char * buffer and then 
      accesses them through a float pointer.
      This is done to prevent the effects of excess precision
      when using FPU registers.
      However the doublestore() macro converts a double pointer
      to an union pointer. This violates the strict aliasing rule.
      Fixed by making the intermediary variables volatile (
      to not re-introduce the excess precision bug) and using
      the intermediary value instead of the char * buffer.
      Note that there can be loss of precision for both signed
      and unsigned 64 bit integers converted to double and back,
      so the check must stay there (even for compatibility 
      reasons).
      Based on the excellent analysis in bug 28400.
      
      
      libmysql/libmysql.c:
        Bug #27383: avoid pointer aliasing problems while 
        not re-violating the Intel FPU gcc bug.
      fe036d98
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0-opt · e434a5ca
      unknown authored
      into  mysql.com:/home/hf/work/28839/my50-28839
      
      
      e434a5ca
    • unknown's avatar
      merging fix · fdbefa8d
      unknown authored
      fdbefa8d
    • unknown's avatar
      Merge mysql.com:/home/hf/work/28839/my50-28839 · dcb5ede1
      unknown authored
      into  mysql.com:/home/hf/work/28839/my51-28839
      
      
      mysql-test/t/rpl_skip_error.test:
        Auto merged
      mysql-test/r/rpl_skip_error.result:
        merging
      dcb5ede1
    • unknown's avatar
      rpl_skip_error.test fixed · cb606a66
      unknown authored
      
      mysql-test/r/rpl_skip_error.result:
        test result fixed
      mysql-test/t/rpl_skip_error.test:
        inconsistent column results hidden
      cb606a66
  3. 21 Jun, 2007 7 commits
  4. 20 Jun, 2007 13 commits
    • unknown's avatar
      Fixed bug #28293. · b5eb3fcb
      unknown authored
      Occasionally mysqlbinlog --hexdump failed with error:
        ERROR 1064 (42000) at line ...: You have an error in your
        SQL syntax; check the manual that corresponds to your MySQL
        server version for the right syntax to use near
        'Query thread_id=... exec_time=... error_code=...
      
      When the length of hexadecimal dump of binlog header was
      divisible by 16, commentary sign '#' after header was lost.
      The Log_event::print_header function has been modified to always
      finish hexadecimal binlog header with "\n# ".
      
      
      sql/log_event.cc:
        Fixed bug #28293.
        The Log_event::print_header function has been modified to always
        finish hexadecimal binlog header with "\n# ".
      mysql-test/r/mysqlbinlog.result:
        Updated test case for bug #28293.
      mysql-test/t/mysqlbinlog.test:
        Updated test case for bug #28293.
      b5eb3fcb
    • unknown's avatar
      Fixed bug #29104: assertion abort for grouping queries using views. · 39bf2b96
      unknown authored
      The abort happened when a query contained a conjunctive predicate
      of the form 'view column = constant' in the WHERE condition and 
      the grouping list also contained a reference to a view column yet
      a different one.
      
      Removed the failing assertion as invalid in a general case.
      
      Also fixed a bug that prevented applying some optimization for grouping
      queries using views. If the WHERE condition of such a query contains
      a conjunctive condition of the form 'view column = constant' and
      this view column is used in the grouping list then grouping by this
      column can be eliminated. The bug blocked performing this elimination.
      
      
      mysql-test/r/view.result:
        Added a test case for bug #29104.
      mysql-test/t/view.test:
        Added a test case for bug #29104.
      sql/item.cc:
        Fixed bug #29104: assertion abort for grouping queries using views.
        The abort happened when a query contained a conjunctive predicate
        of the form 'view column = constant' in the WHERE condition and 
        the grouping list also contained a reference to a view column yet
        a different one.
        
        Removed the failing assertion as invalid in a general case.
        
        Also fixed a bug that prevented applying some optimization for grouping
        queries using views. If the WHERE condition of such a query contains
        a conjunctive condition of the form 'view column = constant' and
        this view column is used in the grouping list then grouping by this
        column can be eliminated. The bug blocked performing this elimination.
        This bug was in the function Item_field::eq while the failing
        assertion was in the function Item_direct_view_ref::eq.
      39bf2b96
    • unknown's avatar
      fixed a (merge?) problem running the tests: · fbf0af06
      unknown authored
      now the cluster related commands have 'use db'
      in the binlog.
      
      
      fbf0af06
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1 · e83ee8ce
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/failed_rpl_test-5.1-opt
      
      
      e83ee8ce
    • unknown's avatar
      port of the fix for bug 19116 4.1-opt -> 5.0-opt · d8512831
      unknown authored
      d8512831
    • unknown's avatar
      Merge magare.gmz:/home/kgeorge/mysql/work/B29116-4.1-opt · e0ab3523
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/work/B29116-5.0-opt
      
      
      mysql-test/t/rpl_change_master.test:
        Auto merged
      e0ab3523
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-28898 · 4310ceb0
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      4310ceb0
    • unknown's avatar
      metadata.test, metadata.result: · 8e35de2a
      unknown authored
        Updated test case for bug #28898. Additional cleanup.
      
      
      mysql-test/t/metadata.test:
        Updated test case for bug #28898. Additional cleanup.
      mysql-test/r/metadata.result:
        Updated test case for bug #28898. Additional cleanup.
      8e35de2a
    • unknown's avatar
      Merge mysql.com:/home/hf/work/28839/my50-28839 · e49e9d57
      unknown authored
      into  mysql.com:/home/hf/work/28839/my51-28839
      
      
      mysql-test/r/rpl_skip_error.result:
        Auto merged
      mysql-test/t/rpl_skip_error.test:
        Auto merged
      sql/log_event.cc:
        merging
      e49e9d57
    • unknown's avatar
      Bug #28839 Errors in strict mode silently stop SQL thread if --slave-skip-errors exists. · d5cc204e
      unknown authored
      slave_sql thread calls thd->clear_error() to force error to be ignored,
      though this method didn't clear thd->killed state, what causes
      slave_sql thread to stop.
      
      clear thd->killed state if we ignore an error
      
      
      mysql-test/r/rpl_skip_error.result:
        Bug #28839 Errors in strict mode silently stop SQL thread if --slave-skip-errors exists.
        
        test result
      mysql-test/t/rpl_skip_error.test:
        Bug #28839 Errors in strict mode silently stop SQL thread if --slave-skip-errors exists.
        
        test case
      sql/log_event.cc:
        Bug #28839 Errors in strict mode silently stop SQL thread if --slave-skip-errors exists.
        
        clear thd->killed state if we ignore the error
      d5cc204e
    • unknown's avatar
      Merge gleb.loc:/home/uchum/work/bk/5.0-opt-28898 · e2aa6ee1
      unknown authored
      into  gleb.loc:/home/uchum/work/bk/5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      e2aa6ee1
    • unknown's avatar
      Fixed bug #28898. · e855bf33
      unknown authored
      For a join query with GROUP BY and/or ORDER BY and a view reference
      in the FROM list the metadata erroneously showed empty table aliases
      and database names for the view columns.
      
      
      
      sql/item.h:
        Fixed bug #28898.
        Body of Item_ref::get_tmp_table_item method has been moved
        to item.cc file.
      mysql-test/t/metadata.test:
        Updated test case for bug #28898.
      sql/item.cc:
        Fixed bug #28898.
        The Item_ref::get_tmp_table_item method has been modified
        to copy pointers to the table alias and database name to the new
        Item_field object created for a field stored in the temporary
        table.
      mysql-test/r/metadata.result:
        Updated test case for bug #28898.
      sql/sql_select.cc:
        Fixed bug #28898.
        The change_to_use_tmp_fields function has been modified to
        to copy pointers to the table alias and database name from
        the Item_ref objects to the new Item_field objects created
        for fields stored in the temporary table.
      e855bf33
    • unknown's avatar
      removed undeterministic tests introduced by the fix for bug 26418 · fe3bd78e
      unknown authored
      
      mysql-test/r/rpl_innodb.result:
        removed undeterministic tests
      mysql-test/t/rpl_innodb.test:
        removed undeterministic tests
      fe3bd78e
  5. 19 Jun, 2007 11 commits
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.1-opt · dc22a429
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26418-5.1-opt
      
      
      sql/sql_acl.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      dc22a429
    • unknown's avatar
      Bug #26418: Slave out of sync after · fe593bf1
      unknown authored
       CREATE/DROP TEMPORARY TABLE + ROLLBACK on master
      
      The transaction ability of the storage engines of
      the tables on the replication master and the replication
      slave must generally be the same.
      When the storage engine type of the slave is 
      non-transactional then transactions on the master that 
      mix update of transactional and non-transactional tables
      should be avoided because they will cause inconsistency of
      the data between the master's transactional table and the
      slave's non-transactional table.
      
      The effect described by this bug is actually expected.
      A detailed test case is added (to be merged later to
      the updated rpl_ddl.test), as there was no coverage 
      by the existing tests. 
      Some code cleanup is also added by this change.
      
      
      mysql-test/r/rpl_innodb.result:
        Bug #26418: test case
      mysql-test/t/rpl_innodb.test:
        Bug #26418: test case
      sql/events.cc:
        Bug #26418: replace repeating code with a function call
      sql/sp.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_acl.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_class.cc:
        Bug #26418: remove dead code
      sql/sql_class.h:
        Bug #26418: remove dead code
      sql/sql_delete.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_parse.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_rename.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_tablespace.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_trigger.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_udf.cc:
        Bug #26418: replace repeating code with a function call
      sql/sql_view.cc:
        Bug #26418: replace repeating code with a function call
      fe593bf1
    • unknown's avatar
      Bug #29116: Test "rpl_change_master" returns different · f0d59bf4
      unknown authored
       counters from relay
      
      Updated the test to return columns vertically.
      
      
      mysql-test/r/rpl_change_master.result:
        Bug #29116: test updated
      mysql-test/t/rpl_change_master.test:
        Bug #29116: test updated
      f0d59bf4
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 · 7d16183b
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      configure.in:
        Auto merged
      7d16183b
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.1 · f6ae8e76
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      configure.in:
        Auto merged
      f6ae8e76
    • unknown's avatar
      Merge dfischer@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8f24e822
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0
      
      
      configure.in:
        Auto merged
      8f24e822
    • unknown's avatar
      Merge pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.0 · 37d6aba9
      unknown authored
      into  pippilotta.erinye.com:/shared/home/df/mysql/build/mysql-5.1
      
      
      37d6aba9
    • unknown's avatar
      try again. · 32b6fbe5
      unknown authored
      
      configure.in:
        Raise version number after cloning 5.0.44
      32b6fbe5
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29117/my50-29117 · d616511e
      unknown authored
      into  mysql.com:/home/hf/work/29117/my51-29117
      
      
      sql/net_serv.cc:
        Auto merged
      d616511e
    • unknown's avatar
      Merge mysql.com:/home/hf/work/29117/my41-29117 · fcacd0b2
      unknown authored
      into  mysql.com:/home/hf/work/29117/my50-29117
      
      
      sql/net_serv.cc:
        Auto merged
      fcacd0b2
    • unknown's avatar
      Bug #29117 (init_file test crashes with embedded server) · c1cf6e61
      unknown authored
      we use net->vio in my_net_local_init, but in the my_net_init
      implementation we set it after the call, so work with unspecified
      net->vio value
      
      
      sql/net_serv.cc:
        Bug #29117 (init_file test crashes with embedded server)
        
        as we started using net->vio in my_net_local_init, we should set
        it before the call
      c1cf6e61