1. 12 Feb, 2009 2 commits
  2. 11 Feb, 2009 1 commit
  3. 10 Feb, 2009 6 commits
    • vasil's avatar
      branches/zip: · 3c6d9917
      vasil authored
      (followup to r4145) Non-functional change:
      
      Change the os_atomic_increment() and os_compare_and_swap() functions
      to macros to avoid artificial limitations on the types of those
      functions' arguments. As a consequence typecasts from the source
      code can be removed.
      
      Also remove Google's copyright from os0sync.ic because that file no longer
      contains code from Google.
      
      Approved by:	Marko (rb://88), also ok from Inaam via IM
      3c6d9917
    • marko's avatar
      branches/zip: When innodb_use_sys_malloc is set, ignore · a805ee5f
      marko authored
      innodb_additional_mem_pool_size, because nothing will
      be allocated from mem_comm_pool.
      
      mem_pool_create(): Remove the assertion about size.  The function will
      work with any size.  However, an assertion would fail in ut_malloc_low()
      when size==0.
      
      mem_init(): When srv_use_sys_malloc is set, pass size=1 to mem_pool_create().
      
      mem0mem.c: Add #include "srv0srv.h" that is needed by mem0dbg.c.
      a805ee5f
    • marko's avatar
      branches/zip: get_share(), free_share(): Make table locking case sensitive. · ecda78f0
      marko authored
      If lower_case_table_names=1, MySQL will pass the table names in lower case.
      Thus, we can use a binary comparison (strcmp) in the hash table.
      
      rb://87 approved by Heikki Tuuri, to address Bug #41676 and Issue #167.
      ecda78f0
    • marko's avatar
      branches/zip: ChangeLog: Document recent changes. · da9083a0
      marko authored
      da9083a0
    • marko's avatar
      branches/zip: Map ut_malloc(), ut_realloc(), ut_free() to · f4cccb1f
      marko authored
      malloc(), realloc(), free() when innodb_use_sys_malloc is set.
      
      ut_free_all_mem(): If innodb_use_sys_malloc is set, do nothing,
      because then ut_mem_block_list_inited will never be set.
      
      log_init(): Use mem_alloc() instead of ut_malloc(), so that the
      memory will be freed.  (Tested with Valgrind, although it is not
      clear why the memory would be freed.)
      
      rb://86 approved by Heikki Tuuri and Ken Jacobs.  This addresses Issue #168.
      f4cccb1f
    • vasil's avatar
      branches/zip: · 51bc19d7
      vasil authored
      Non-functional change: Fix a compilation warning introduced in r4144:
      
      gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -I../../regex -I../../storage/innobase/include -I../../sql -I.   -Werror 	 -Wall -g   -MT libinnobase_a-sync0arr.o -MD -MP -MF .deps/libinnobase_a-sync0arr.Tpo -c -o libinnobase_a-sync0arr.o `test -f 'sync/sync0arr.c' || echo './'`sync/sync0arr.c
      cc1: warnings being treated as errors
      sync/sync0arr.c: In function 'sync_array_object_signalled':
      sync/sync0arr.c:869: warning: pointer targets in passing argument 1 of 'os_atomic_increment' differ in signedness
      51bc19d7
  4. 09 Feb, 2009 3 commits
    • inaam's avatar
      branches/zip rb://30 · a1bb700f
      inaam authored
      This patch changes the innodb mutexes and rw_locks implementation.
      On supported platforms it uses GCC builtin atomics. These changes
      are based on the patch sent by Mark Callaghan of Google under BSD
      license. More technical discussion can be found at rb://30
      
      Approved by: Heikki
      a1bb700f
    • marko's avatar
    • vasil's avatar
      branches/zip: · 6ee11219
      vasil authored
      Remove mysql-test/patches/bug35261.diff because that bug has been fixed
      in the MySQL repository.
      6ee11219
  5. 04 Feb, 2009 1 commit
  6. 03 Feb, 2009 2 commits
  7. 02 Feb, 2009 5 commits
    • vasil's avatar
      branches/zip: · b21c3e9c
      vasil authored
      Fix the failing innodb-zip test to restore the environment as it was before
      the test execution because a newly added feature in the mysql-test framework
      does check for this.
      b21c3e9c
    • vasil's avatar
      branches/zip: · fbc7f952
      vasil authored
      Fix a mysql-test failure in innodb-zip:
      
      main.innodb-zip                          [ fail ]
              Test ended at 2009-02-02 18:13:25
      
      CURRENT_TEST: main.innodb-zip
      mysqltest: At line 160: Found line beginning with --  that didn't contain a valid mysqltest command, check your syntax or use # if you intended to write a comment
      fbc7f952
    • marko's avatar
      branches/zip: Enclose some backup functions in #ifdef UNIV_HOTBACKUP. · e97b5d3e
      marko authored
      recv_read_cp_info_for_backup(), recv_scan_log_seg_for_backup():
      These functions are only called by InnoDB Hot Backup.
      e97b5d3e
    • marko's avatar
      branches/zip: innobase_start_or_create_for_mysql(): Remove a factual error · 11d57d93
      marko authored
      in the function comment.  Parameters are not read from a file "srv_init".
      11d57d93
    • vasil's avatar
      branches/zip: · 5aa989e2
      vasil authored
      Add ChangeLog entry for the change in r4072.
      5aa989e2
  8. 31 Jan, 2009 1 commit
    • vasil's avatar
      branches/zip: · f2842a21
      vasil authored
      Adjust the failing patch patches/information_schema.diff.
      f2842a21
  9. 30 Jan, 2009 2 commits
    • marko's avatar
      branches/zip: Make innodb_adaptive_hash_index settable. · 6aab3916
      marko authored
      btr_search_disabled: Rename to btr_search_enabled and change the type
      to char, so that it can be directly linked to the MySQL parameters.
      Note that the variable is protected by btr_search_latch and
      btr_search_enabled_mutex, a new mutex introduced in this patch.
      
      btr_search_enabled_mutex: A new mutex, to protect btr_search_enabled
      together with btr_search_latch.
      
      buf_pool_drop_hash_index(): New function, to be called from
      btr_search_disable().
      
      btr_search_disable(), btr_search_enable(): Fix bugs.  These functions
      were previously unused.
      
      btr_search_guess_on_hash(), btr_search_build_page_hash_index():
      Check btr_search_enabled once more, while holding btr_search_latch.
      
      btr_cur_search_to_nth_level(): Note that the reads of btr_search_enabled
      may be dirty and explain why it should not be a problem.
      
      innobase_adaptive_hash_index: Remove. The variable btr_search_enabled will be used directly instead.
      
      innodb_adaptive_hash_index_update(): New function, an update callback for
      innodb_adaptive_hash_index.  This will call either btr_search_disable()
      or btr_search_enable() when the value is assigned.  The functions will
      be called even if the value does not appear to be changed, e.g., when
      setting from TRUE to TRUE or FALSE to FALSE.
      
      rb://85 approved by Heikki Tuuri.  This addresses Issue #163.
      6aab3916
    • marko's avatar
      branches/zip: ibuf_use_t: Add the constant IBUF_USE_COUNT, to eliminate · 635268b7
      marko authored
      a gcc warning about an assertion that trivially holds.
      The warning was introduced in r4061, in the merge of
      branches/innodb+ -r4053.
      
      ibuf_insert(): Let an assertion fail if ibuf_use is unknown.
      635268b7
  10. 29 Jan, 2009 3 commits
    • marko's avatar
      branches/zip: Port the applicable parts of r4053 from branches/innodb+: · 8b025adb
      marko authored
      Implement the global variable innodb_change_buffering, with the
      following values:
      
      none - buffer nothing
      inserts - buffer inserts (the default)
      
      Approved by Ken Jacobs.
      8b025adb
    • marko's avatar
    • calvin's avatar
      branches/zip: Merge revisions 4032:4035 from branches/5.1 · 533afa46
      calvin authored
      All InnoDB related tests passed on Windows, except
      known failure in partition_innodb_semi_consistent.
      
      The inadvertent change to btr0sea.c in this commit is reverted in r4060.
      
        ------------------------------------------------------------------------
        r4035 | vasil | 2009-01-26 09:26:25 -0600 (Mon, 26 Jan 2009) | 23 lines
      
        branches/5.1:
      
        Merge a change from MySQL:
      
          ------------------------------------------------------------
          revno: 2646.161.4
          committer: Tatiana A. Nurnberg <azundris@mysql.com>
          branch nick: 51-31177v2
          timestamp: Mon 2009-01-12 06:32:49 +0100
          message:
            Bug#31177: Server variables can't be set to their current values
      
            Bounds-checks and blocksize corrections were applied to user-input,
            but constants in the server were trusted implicitly. If these values
            did not actually meet the requirements, the user could not set change
            a variable, then set it back to the (wonky) factory default or maximum
            by explicitly specifying it (SET <var>=<value> vs SET <var>=DEFAULT).
      
            Now checks also apply to the server's presets. Wonky values and maxima
            get corrected at startup. Consequently all non-offsetted values the user
            sees are valid, and users can set the variable to that exact value if
            they so desire.
      533afa46
  11. 28 Jan, 2009 3 commits
  12. 27 Jan, 2009 5 commits
  13. 26 Jan, 2009 2 commits
    • marko's avatar
      branches/zip: In r988, the function buf_block_align() was enclosed · b707b2e3
      marko authored
      within UNIV_DEBUG. The two remaining callers in non-debug builds,
      btr_search_guess_on_hash() and btr_search_validate(), were rewritten
      to call buf_page_hash_get().
      
      To implement support for a resizeable buffer pool, the function
      buf_block_align() had been rewritten to perform a page hash lookup in
      the buffer pool. The caller was also made responsible for holding the
      buffer pool mutex.
      
      Because the page hash lookup is expensive and it has to be done while
      holding the buffer pool mutex, implement buf_block_align() by pointer
      arithmetics again, and make btr_search_guess_on_hash() call it. Note
      that this will have to be adjusted if the interface to the resizeable
      buffer pool is actually implemented.
      
      rb://83 approved by Heikki Tuuri, to address Issue #161.
      
      As a deviation from the approved patch, this patch also makes
      btr_search_validate() (invoked by CHECK TABLE) check that
      buf_pool->page_hash is consistent with buf_block_align().
      b707b2e3
    • marko's avatar
      branches/zip: buf_page_get_gen(): Fix a "possibly uninitialized" warning · 0dfed5a8
      marko authored
      that was introduced in r4030.
      0dfed5a8
  14. 23 Jan, 2009 4 commits
    • marko's avatar
      branches/zip: Merge revisions 4005:4032 from branches/5.1: · e75eaaba
      marko authored
        ------------------------------------------------------------------------
        r4032 | marko | 2009-01-23 15:43:51 +0200 (Fri, 23 Jan 2009) | 10 lines
      
        branches/5.1: Merge r4031 from branches/5.0:
      
        btr_search_drop_page_hash_when_freed(): Check if buf_page_get_gen()
        returns NULL.  The page may have been evicted from the buffer pool
        between buf_page_peek_if_search_hashed() and buf_page_get_gen(),
        because the buffer pool mutex will be released between these two calls.
        (Bug #42279, Issue #160)
      
        rb://82 approved by Heikki Tuuri
        ------------------------------------------------------------------------
      e75eaaba
    • marko's avatar
      branches/zip: buf_page_get_gen(): Remove the unused mode BUF_GET_NOWAIT. · 5dceabc9
      marko authored
      This was noticed while investigating Issue #160.
      5dceabc9
    • marko's avatar
      0bd67bdb
    • marko's avatar
      branches/zip: Enclose some more unused code in #ifdef UNIV_LOG_ARCHIVE. · 70ca1bee
      marko authored
      This will help trim the dependencies of InnoDB Hot Backup.
      
      recv_recovery_from_checkpoint_start(): Rename to
      recv_recovery_from_checkpoint_start_func(), and remove the two first
      parameters unless UNIV_LOG_ARCHIVE is defined.  Define and use
      the auxiliary macros TYPE_CHECKPOINT and LIMIT_LSN in the function.
      
      struct recv_sys_struct: Remove archive_group unless UNIV_LOG_ARCHIVE
      is defined.
      
      Do not define LOG_ARCHIVE unless UNIV_LOG_ARCHIVE is defined.
      70ca1bee