- 31 Jul, 2007 13 commits
-
-
unknown authored
mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result: Addendum to bug 27417: removed tests for another bug mysql-test/suite/binlog/t/binlog_stm_mix_innodb_myisam.test: Addendum to bug 27417: removed tests for another bug mysql-test/suite/rpl/r/rpl_row_create_table.result: Addendum to bug 27417: changes to non-transactional tables should be logged even on rollback.
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/autopush/B27417-5.1-opt sql/sp_head.cc: Auto merged
-
unknown authored
-
unknown authored
into magare.gmz:/home/kgeorge/mysql/work/B27417-5.1-opt sql/sql_update.cc: Auto merged
-
unknown authored
extend the assert so it will run the testsuite
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt
-
unknown authored
Post-merge fix. mysql-test/t/disabled.def: Post-merge fix. mysql-test/r/sp.result: Post-merge fix. sql/sql_yacc.yy: Post-merge fix.
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt sql/item.cc: Auto merged sql/item.h: Auto merged sql/sp_head.cc: Auto merged sql/sql_yacc.yy: Auto merged mysql-test/r/sp.result: Merge with 5.0-opt. mysql-test/t/sp.test: Merge with 5.0-opt.
-
unknown authored
into mysql.com:/home/hf/work/29717/my51-29717 mysql-test/r/group_by.result: Auto merged mysql-test/r/insert_select.result: Auto merged mysql-test/t/group_by.test: Auto merged mysql-test/t/insert_select.test: Auto merged sql/sql_select.cc: Auto merged sql/sql_select.h: Auto merged
-
unknown authored
-
unknown authored
into mysql.com:/home/hf/work/29717/my50-29717 mysql-test/t/insert_select.test: Auto merged sql/sql_select.cc: Auto merged mysql-test/r/group_by.result: merging mysql-test/r/insert_select.result: merging mysql-test/t/group_by.test: merging sql/sql_select.h: merging
-
unknown authored
into mysql.com:/home/hf/work/29717/my41-29717 sql/sql_select.cc: Auto merged
-
unknown authored
SELECT statement itself returns empty. As a result of this bug 'SELECT AGGREGATE_FUNCTION(fld) ... GROUP BY' can return one row instead of an empty result set. When GROUP BY only has fields of constant tables (with a single row), the optimizer deletes the group_list. After that we lose the information about whether we had an GROUP BY statement. Though it's important as SELECT min(x) from empty_table; and SELECT min(x) from empty_table GROUP BY y; have to return different results - the first query should return one row, second - an empty result set. So here we add the 'group_optimized_away' flag to remember this case when GROUP BY exists in the query and is removed by the optimizer, and check this flag in end_send_group() mysql-test/r/group_by.result: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. test result mysql-test/r/insert_select.result: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. test result mysql-test/t/group_by.test: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. This is additional testcase that is more basic than the original bug's testcase and has the same reason. mysql-test/t/insert_select.test: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. test case sql/sql_select.cc: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. Remember the 'GROUP BY was optimized away' case in the JOIN::group_optimized and check this in the end_send_group() sql/sql_select.h: Bug #29717 INSERT INTO SELECT inserts values even if SELECT statement itself returns empty. JOIN::group_optimized member added to remember the 'GROUP BY optimied away' case
-
- 30 Jul, 2007 5 commits
-
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/t/bigint.test: Auto merged
-
unknown authored
Fixing a typo in the test case. mysql-test/t/bigint.test: Fixing a typo in the test case.
-
unknown authored
Merge magare.gmz:/home/kgeorge/mysql/work/B27417-5.0-opt into magare.gmz:/home/kgeorge/mysql/work/B27417-5.1-opt mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result: Auto merged sql/ha_ndbcluster.cc: Auto merged sql/handler.cc: Auto merged sql/handler.h: Auto merged sql/sql_class.cc: Auto merged sql/sql_class.h: Auto merged sql/sql_table.cc: Auto merged mysql-test/extra/binlog_tests/mix_innodb_myisam_binlog.test: merge of bug 27471 from 5.0-opt to 5.1-opt sql/log.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/set_var.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/sp_head.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/sql_delete.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/sql_insert.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/sql_load.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/sql_parse.cc: merge of bug 27471 from 5.0-opt to 5.1-opt sql/sql_update.cc: merge of bug 27471 from 5.0-opt to 5.1-opt
-
unknown authored
Bug #27417 thd->no_trans_update.stmt lost value inside of SF-exec-stack Once had been set the flag might later got reset inside of a stored routine execution stack. The reason was in that there was no check if a new statement started at time of resetting. The artifact affects most of binlogable DML queries. Notice, that multi-update is wrapped up within bug@27716 fix, multi-delete bug@29136. Fixed with saving parent's statement flag of whether the statement modified non-transactional table, and unioning (merging) the value with that was gained in mysql_execute_command. Resettling thd->no_trans_update members into thd->transaction.`member`; Asserting code; Effectively the following properties are held. 1. At the end of a substatement thd->transaction.stmt.modified_non_trans_table reflects the fact if such a table got modified by the substatement. That also respects THD::really_abort_on_warnin() requirements. 2. Eventually thd->transaction.stmt.modified_non_trans_table will be computed as the union of the values of all invoked sub-statements. That fixes this bug#27417; Computing of thd->transaction.all.modified_non_trans_table is refined to base to the stmt's value for all the case including insert .. select statement which before the patch had an extra issue bug@28960. Minor issues are covered with mysql_load, mysql_delete, and binloggin of insert in to temp_table select. The supplied test verifies limitely, mostly asserts. The ultimate testing is defered for bug@13270, bug@23333. mysql-test/r/mix_innodb_myisam_binlog.result: results changed mysql-test/t/mix_innodb_myisam_binlog.test: regression test incl the related bug#28960. sql/ha_ndbcluster.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/handler.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/handler.h: new member added sql/log.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/set_var.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/sp_head.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} and saving and merging stmt's flag at the end of a substatement. sql/sql_class.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/sql_class.h: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/sql_delete.cc: correcting basic delete incl truncate branch and multi-delete queries to set stmt.modified_non_trans_table; optimization to set the flag at the end of per-row loop; multi-delete still has an extra issue similar to bug#27716 of multi-update - to be address with bug_29136 fix. sql/sql_insert.cc: thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/sql_load.cc: eliminating a separate issue where the stmt flag was saved and re-stored after write_record that actually could change it and the change would be lost but should remain permanent; thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt} sql/sql_parse.cc: initialization to transaction.stmt.modified_non_trans_table at the common part of all types of statements processing - mysql_execute_command(). sql/sql_table.cc: moving the reset up to the mysql_execute_command() caller sql/sql_update.cc: correcting update query case (multi-update part of the issues covered by other bug#27716 fix) thd->transaction.{all,stmt}.modified_non_trans_table instead of thd->no_trans_update.{all,stmt}
-
unknown authored
a place where it would not obstruct correct multithreading.
-
- 29 Jul, 2007 4 commits
-
-
unknown authored
SP with local variables with non-ASCII names crashed the server. The server replaces SP local variable names with NAME_CONST calls when putting statements into the binary log. It used UTF8-encoded item names as variable names for the replacement inside NAME_CONST calls. However, statement string may be encoded by any known character set by the SET NAMES statement. The server used byte length of UTF8-encoded names to increment the position in the query string that led to array index overrun. sql/item.cc: Fixed bug #30120. The Item_splocal class constructor has been modified to accept new parameter `len_in_q': the byte length of variable name in the query string. sql/item.h: Fixed bug #30120. The Item_splocal class has been modified to keep new field `len_in_query': the byte length of variable name in the query string. sql/sp_head.cc: Fixed bug #30120. The subst_spvars function has been modified to increment position in the query string by the lengths of not encoded variable names instead of byte length of names encoded to UTF-8. sql/sql_yacc.yy: Fixed bug #30120. The simple_ident rule action has been modified to pass the byte length of the local variable name token to the Item_splocal object constructor. mysql-test/t/sp.test: Updated test case for bug #30120. mysql-test/r/sp.result: Updated test case for bug #30120.
-
unknown authored
ddl_i18n_koi8r.test has been disabled to ignore bug #30120. mysql-test/t/disabled.def: ddl_i18n_koi8r.test has been disabled to ignore bug #30120.
-
unknown authored
Post-merge fix. sql/sp_head.cc: Post-merge fix.
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/query_cache.result: Auto merged mysql-test/r/view.result: Auto merged mysql-test/t/query_cache.test: Auto merged sql/sql_show.cc: Auto merged mysql-test/t/view.test: Merge with 5.0-opt. sql/sp_head.cc: Merge with 5.0-opt.
-
- 28 Jul, 2007 15 commits
-
-
unknown authored
into moonbone.local:/mnt/gentoo64/work/29856-bug-5.0-opt-mysql sql/sp_head.cc: Auto merged mysql-test/r/query_cache.result: SCCS merged mysql-test/t/query_cache.test: SCCS merged
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt mysql-test/r/sp.result: Auto merged mysql-test/t/sp.test: Auto merged sql/sql_base.cc: Merge with 5.0-opt.
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt sql/sql_base.cc: Auto merged mysql-test/r/sp.result: Merge with local tree. mysql-test/t/sp.test: Merge with local tree.
-
unknown authored
Using view columns by their names during an execution of a prepared SELECT statement or a SELECT statement inside a SP caused a memory leak. sql/sql_base.cc: Fixed bug #29834. The find_field_in_view function has been modified to use the execution memory root for the Item_direct_view_ref objects allocation at non-first executions of a PS/SP instead of the statement memory. mysql-test/t/sp.test: Updated test case for bug #29834. mysql-test/r/sp.result: Updated test case for bug #29834.
-
unknown authored
into moonbone.local:/mnt/gentoo64/work/30020-bug-5.0-opt-mysql
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.0-opt
-
unknown authored
into gleb.loc:/home/uchum/work/bk/5.1-opt
-
unknown authored
information schema table. The get_schema_views_record() function fills records in the view table of the informations schema with data about given views. Among other info the is_updatable flag is set. But the check whether the view is updatable or not wasn't covering all cases thus sometimes providing wrong info. This might led to a user confusion. Now the get_schema_views_record function additionally calls to the view->can_be_merge() function to find out whether the view can be updated or not. mysql-test/t/view.test: Added a test case for the bug#30020: Insufficient check led to a wrong info provided by the information schema table. mysql-test/r/view.result: Added a test case for the bug#30020: Insufficient check led to a wrong info provided by the information schema table. sql/sql_show.cc: Bug#30020: Insufficient check led to a wrong info provided by the information schema table. Now the get_schema_views_record function additionally calls to the view->can_be_merge() function to find out whether the view can be updated or not.
-
unknown authored
The subst_spvars function is used to create query string with SP variables substituted with their values. This string is used later for the binary log and for the query cache. The problem is that the query_cache_send_result_to_client function requires some additional space after the query to store database name and query cache flags. This space wasn't reserved by the subst_spvars function which led to a memory corruption and crash. Now the subst_spvars function reserves additional space for the query cache. mysql-test/t/query_cache.test: Added a test case for the bug#29856: Insufficient buffer space led to a server crash. mysql-test/r/query_cache.result: Added a test case for the bug#29856: Insufficient buffer space led to a server crash. sql/sp_head.cc: Bug#29856: Insufficient buffer space led to a server crash. Now the subst_spvars function reserves additional space for the query cache.
-
unknown authored
into mysql.com:/home/hf/work/29878/my51-29878
-
unknown authored
mysql-test/suite/rpl/r/rpl_session_var.result: result fixed mysql-test/suite/rpl/t/rpl_session_var.test: test fixed
-
unknown authored
Addendum to thr fix for bug 30000: show procedure/function code defined only in debug builds show_check.test: Addendum to thr fix for bug 30000: show procedure/function code defined only in debug builds mysql-test/t/show_check.test: Addendum to thr fix for bug 30000: show procedure/function code defined only in debug builds mysql-test/r/show_check.result: Addendum to thr fix for bug 30000: show procedure/function code defined only in debug builds
-
- 27 Jul, 2007 3 commits
-
-
unknown authored
into mysql.com:/home/hf/work/29878/my50-29878
-
unknown authored
into mysql.com:/home/hf/work/29878/my51-29878
-
unknown authored
into mysql.com:/home/hf/work/29878/my51-29878 mysql-test/suite/rpl/r/rpl_session_var.result: Auto merged mysql-test/suite/rpl/t/rpl_session_var.test: Auto merged sql/item.cc: Auto merged sql/item.h: Auto merged sql/item_strfunc.h: Auto merged
-