An error occurred fetching the project authors.
  1. 24 Nov, 2004 1 commit
    • unknown's avatar
      Fixed bug related to lower case table names on Power Mac · 3392e317
      unknown authored
      'information_schema' test is splitted because of innodb  
      
      
      mysql-test/r/information_schema.result:
        Test is splitted because of innodb
      mysql-test/t/information_schema.test:
        Test is splitted because of innodb
      sql/sql_show.cc:
        Fixed bug related to lower case table names on Power Mac
      sql/table.h:
        Fixed bug related to lower case table names on Power Mac
      tests/client_test.c:
        Don't check field length for blob filed
      3392e317
  2. 23 Nov, 2004 1 commit
    • unknown's avatar
      More test cases are added · 3afa86dc
      unknown authored
      Fixed bug 'using of alias with information schema tables in views'
      removed compiler warnings
      
      
      mysql-test/r/information_schema.result:
        More test cases are added
      mysql-test/t/information_schema.test:
        More test cases are added
      sql/sql_select.cc:
        Fixed bug 'using of alias with information schema tables in views'
      sql/sql_show.cc:
        Fixed bug 'using of alias with information schema tables in views'
        Changed length of some columns
      sql/table.h:
        Fixed bug 'using of alias with information schema tables in views'
      tests/client_test.c:
        Changed length of some columns
      3afa86dc
  3. 19 Nov, 2004 1 commit
    • unknown's avatar
      changed field names, fields order according to WL description · 15092975
      unknown authored
      fixed bug: "create view v7 as select * from information_schema.tables;" failed
      
      
      mysql-test/r/information_schema.result:
        changed field names, fields order according to WL description
      mysql-test/t/information_schema.test:
        changed field names, fields order according to WL description
      sql/sql_show.cc:
        changed field names, fields order according to WL description
      sql/sql_view.cc:
        fixed bug: "create view v7 as select * from information_schema.tables;" failed
      tests/client_test.c:
        changed field names, fields order according to WL description
      15092975
  4. 18 Nov, 2004 2 commits
    • unknown's avatar
    • unknown's avatar
      remove unused parts of code · cd2edd17
      unknown authored
      fix for 'show create schema_table'
      fix for usage schema tables in subselect
      'wrong schema table charset' fix
      
      
      mysql-test/r/information_schema.result:
        'wrong schema table charset' fix
      mysql-test/t/information_schema.test:
        'wrong schema table charset' fix
      sql/mysql_priv.h:
        fix for 'show create schema_table'
      sql/sql_class.cc:
        'wrong schema table charset' fix
      sql/sql_class.h:
        'wrong schema table charset' fix
      sql/sql_parse.cc:
        fix for 'show create schema_table'
      sql/sql_select.cc:
        'wrong schema table charset' fix
      sql/sql_show.cc:
        remove unused parts of code
        fix for 'show create schema_table'
        fix for usage schema tables in subselect
      sql/table.h:
        remove unused parts of coed
      tests/client_test.c:
        'wrong schema table charset' fix
      cd2edd17
  5. 15 Nov, 2004 1 commit
    • unknown's avatar
      Fix for bug #6266 "Invalid DATETIME value is not handled properly". · 5d9f7edd
      unknown authored
      In server we assume that datetime values stored in MYSQL_TIME struct
      are normalized (and year is not greater than 9999), so we should 
      perform range checks in all places then we convert something to
      MYSQL_TIME. 
      
      
      include/my_time.h:
        Added one more argument to set_zero_time() function to make it more 
        convinient.
        Added comment clarifying why MAX_DATE_STRING_REP_LENGTH value is 30.
      include/mysql_time.h:
        Documented MySQL's internal assumptions for members of MYSQL_TIME
        structure.
      libmysql/libmysql.c:
        It does not make sense to set MYSQL_TIME::time_type twice in case of 
        errors.
      mysql-test/r/type_datetime.result:
        Added test for bug #6266 "Invalid DATETIME value not handled properly".
      mysql-test/t/type_datetime.test:
        Added test for bug #6266 "Invalid DATETIME value not handled properly".
      sql-common/my_time.c:
        str_to_datetime(): Added missing check for too big year values.
        set_zero_time(): added time_type argument, since MYSQL_TIMESTAMP_NONE
          is not the value that we want in most cases.
      sql/field.cc:
        Field_datetime::store_time():
          clarified why we don't perform any range checks here.
      sql/item.cc:
        Item_param::set_time():
         Added comment describing this method and range checking for TIME
         values.
      sql/sql_prepare.cc:
        Removed comments about range checking for TIME values in prepared 
        statements, which are no longer true.
        set_zero_time() has one more argument now.
      tests/client_test.c:
        Added test for bug #6266 "Invalid DATETIME value not handled properly"
      5d9f7edd
  6. 13 Nov, 2004 1 commit
  7. 12 Nov, 2004 2 commits
  8. 11 Nov, 2004 1 commit
  9. 10 Nov, 2004 1 commit
  10. 07 Nov, 2004 1 commit
    • unknown's avatar
      Simpler arena swapping code · 435b20aa
      unknown authored
      Now thd->mem_root is a pointer to thd->main_mem_root and THR_MALLOC is a pointer to thd->mem_root.
      This gives us the following benefits:
      - Allow us to easily detect if arena has already been swapped before (this fixes a bug in setup_conds() where arena was swaped twice in some cases)
      - Faster swaps of arenas (as we don't have to copy the whole MEM_ROOT)
      - We don't anymore have to call my_pthread_setspecific_ptr(THR_MALLOC,...) to change where memory is alloced. Now it's enough to set thd->mem_root
      
      
      
      client/mysqltest.c:
        Remove some not needed defines
        (Things like this should be done in config-win.h)
      include/config-win.h:
        Added popen() and pclose() compatibility macros
      mysql-test/t/rpl_failed_optimize-master.opt:
        Portability fix
      sql/ha_berkeley.cc:
        New thd->memroot handling
      sql/item_cmpfunc.cc:
        Simpler arena swapping code
      sql/item_func.cc:
        Simpler arena swapping code
      sql/item_subselect.cc:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/item_sum.cc:
        New thd->mem_root handling
      sql/item_timefunc.cc:
        Fixed not-initalized usage errors found by valgrind
      sql/log_event.cc:
        New thd->mem_root handling
      sql/mysql_priv.h:
        New thd->mem_root handling
      sql/mysqld.cc:
        New thd->mem_root handling
      sql/opt_range.cc:
        New thd->mem_root handling
      sql/repl_failsafe.cc:
        New thd->mem_root handling
      sql/set_var.cc:
        New thd->mem_root handling
      sql/sql_acl.cc:
        New thd->mem_root handling
      sql/sql_base.cc:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/sql_class.cc:
        New thd->mem_root handling
      sql/sql_class.h:
        Simpler arena swapping code
        New thd->mem_root handling
      sql/sql_db.cc:
        New thd->mem_root handling
      sql/sql_error.cc:
        New thd->mem_root handling
      sql/sql_help.cc:
        New thd->mem_root handling
      sql/sql_insert.cc:
        New thd->mem_root handling
      sql/sql_parse.cc:
        New thd->mem_root handling
        Added some extra checking of return value of new
      sql/sql_prepare.cc:
        New thd->mem_root handling
      sql/sql_select.cc:
        New thd->mem_root handling
      sql/sql_select.h:
        New thd->mem_root handling
      sql/sql_union.cc:
        Simpler arena swapping code
      sql/sql_yacc.yy:
        New thd->mem_root handling
      sql/table.cc:
        New thd->mem_root handling
      sql/thr_malloc.cc:
        New thd->mem_root handling
      tests/client_test.c:
        Added drop table to some tests
        Changed some table names to 't1'
      435b20aa
  11. 05 Nov, 2004 1 commit
    • unknown's avatar
      A fix and test case for the bug reported by Reggie: if character set · b3d84df1
      unknown authored
      of client equals to character set of connection, possibly required
      conversion to character set of column is not performed
      (prepared statements, data is supplied using placeholders).
      
      
      sql/item.cc:
        Fix for the bug reported by Reggie: if character_set_connection
        is equal to character_set_client, placeholder's value is not converted
        furhter to character set of column when it's different.
        This is because the original implementation left placeholder's character
        set intact (binary) if there were no need for client->connection conversion.
      tests/client_test.c:
        A test case for the conversion bug.
      b3d84df1
  12. 04 Nov, 2004 1 commit
    • unknown's avatar
      A test case for Bug#4172 "Floating point conversion looses precision · c7b5a8d7
      unknown authored
      (prepared staements)": adding the test case to close the bug
      (the bug was fixed along with other conversion incompatibilities 
      in 4.1.7)
      
      
      tests/client_test.c:
        A test case for Bug#4172: "Floating point conversion loses precision 
        (prepared staements)"
        Fix memleak.
      c7b5a8d7
  13. 02 Nov, 2004 2 commits
    • unknown's avatar
      bad automerge (?) fixed · 78c4faa2
      unknown authored
      78c4faa2
    • unknown's avatar
      Remove usage of !$ from mysql-tests · 505caa28
      unknown authored
      Added protocol::flush() for easier embedded-server code
      Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      Added option --silent to client_test
      
      
      client/mysqltest.c:
        Removed compiler warning
        Fixed identation & comments from earlier push
        Renamed variable 'disable_abort_on_error' to 'abort_on_error'
        Ensure that '$mysql_errno' also with --ps-protocol
      include/mysql_com.h:
        Removed special handling of net_flush for embedded server
      mysql-test/r/mysqltest.result:
        Remove usage of !$ in tests
      mysql-test/t/client_test.test:
        Use --silent
      mysql-test/t/comments.test:
        Remove usage of !$ in tests
      mysql-test/t/join_outer.test:
        Remove usage of !$ in tests
      mysql-test/t/key.test:
        Remove usage of !$ in tests
      mysql-test/t/mysqltest.test:
        Remove usage of !$ in tests
      mysql-test/t/show_check.test:
        Remove usage of !$ in tests
      mysql-test/t/temp_table.test:
        Remove usage of !$ in tests
      mysql-test/t/type_ranges.test:
        Remove usage of !$ in tests
      sql/mysqld.cc:
        Increase block allocation variables a bit as they where a bit too small for MySQL 4.1
      sql/net_serv.cc:
        Remove special usage of net_flush in embedded server
      sql/protocol.cc:
        Added protocol::flush() for easier embedded-server code
      sql/protocol.h:
        Added protocol::flush() for easier embedded-server code
      sql/sql_prepare.cc:
        Added protocol::flush() for easier embedded-server code
        Remove one extra flush() for prepared statements
      sql/sql_show.cc:
        Added protocol::flush() for easier embedded-server code
      tests/client_test.c:
        Added option --silent
      505caa28
  14. 27 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6096 "field.max_length is always zero for · 447fef48
      unknown authored
      numeric columns (stmt_resultset_metadata)"
      
      
      libmysql/libmysql.c:
        A fix for Bug#6096 "field.max_length is always zero for numeric columns
         (stmt_resultset_metadata)": set field->max_lenght for numeric
        columns when we set up skip_result functions. A minor drawback for this 
        approach is that field->max_length  can be not zero even if 
        STMT_ATTR_UPDATE_MAX_LENGTH is not set.
      sql-common/my_time.c:
        Fix valgrind warning.
      tests/client_test.c:
        A test case for Bug#6096 "field.max_length is always zero for numeric 
        columns (stmt_resultset_metadata)
      447fef48
  15. 26 Oct, 2004 1 commit
  16. 22 Oct, 2004 1 commit
  17. 21 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for bug#6059 "mysql_stmt_field_count returns · 506f648b
      unknown authored
      positive numbers when no resultset is available": when sending
      result set metadata we need to use virtual select_result::send_fields, 
      and not address protocol directly, because select_result descendents may 
      intercept result set (it's the case for example for SELECT INTO OUTFILE).
      
      
      sql/sql_class.h:
        A fix for bug#6059 "mysql_stmt_field_count returns positive numbers 
        when no resultset is available": introducing select_result::field_count()
        method to report actual number of fields in a result set, if any result
        set is sent to client.
      sql/sql_prepare.cc:
        A fix for bug#6059 "mysql_stmt_field_count returns 
        positive numbers when no resultset is available": when sending
        result set metadata we need to use virtual select_result::send_fields, 
        and not address protocol directly, because select_result descendents may 
        intercept result set (it's the case for example for SELECT INTO OUTFILE).
        Now we need to always have lex->result set if we're in prepared statements.
      tests/client_test.c:
        A test case for Bug#6059 "mysql_stmt_field_count returns positive 
        numbers when no resultset is available"
      506f648b
  18. 20 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for bug#6058 "Prepared statements return '0000-00-00' · 8fe8912f
      unknown authored
      (date) as empty  string": preserve time type (date, time, or datetime) for
      zero dates, times, and datetimes.
      
      
      libmysql/libmysql.c:
        A fix for bug#6058 "Prepared statements return '0000-00-00' (date) as empty
         string": preserve time type (date, time, or datetime) for zero 
        dates, times, and datetimes.
      tests/client_test.c:
        A test case for Bug#6058, the existing tests required some adjustments too.
      8fe8912f
  19. 19 Oct, 2004 1 commit
    • unknown's avatar
      Review of all code pushed since last review · 4736d0fe
      unknown authored
      Simple optimzations and cleanups
      Removed compiler warnings and fixed portability issues
      Added client functions 'mysql_embedded()' to allow client to check if we are using embedded server
      Fixes for purify
      
      
      client/mysqlimport.c:
        Remove not used variable
      client/mysqltest.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
        Simplified code
        Remove usage of sprintf("%llu") as this is not portable
      include/mysql.h:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      innobase/srv/srv0start.c:
        Don't use memcmp() when using purify (to avoid false warnings)
      libmysql/libmysql.c:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      libmysql/libmysql.def:
        Added mysql_embedded() to be able to easily check if we are using the embedded server
      myisam/myisam_ftdump.c:
        Remove compiler warning
      myisam/myisamchk.c:
        Remove compiler warning
      myisam/rt_test.c:
        #ifdef not used code
      mysys/hash.c:
        Remove compiler warning (from last push)
      mysys/my_gethwaddr.c:
        Remove compiler warning
      ndb/src/ndbapi/ndberror.c:
        #ifdef not used code
      regex/regcomp.c:
        Remove not used code
      regex/regcomp.ih:
        Remove not used code (to remove compiler warnings)
      sql-common/client.c:
        Remove compiler warnings
      sql/field.cc:
        Simple optimization
      sql/ha_innodb.cc:
        Rename mysql_embedded -> mysqld_embedded
      sql/item.cc:
        Fix comments
        Move variables first on block
        Remove else after return
        Simple optimizations
        (no logic changes)
      sql/item_cmpfunc.cc:
        Added comment
      sql/mysql_priv.h:
        Rename mysql_embedded -> mysqld_embedded
      sql/mysqld.cc:
        Rename mysql_embedded -> mysqld_embedded
      sql/sql_acl.cc:
        Added comments
        simple optimization
        Fixed 'very unlikely' bug when doing REVOKE ALL PRIVILEGES
      sql/sql_select.cc:
        More comments
        Simple optimization
      sql/sql_show.cc:
        Simple changes to make similar code similar
        More comments
      sql/sql_string.cc:
        Trivial optimization and better code layout
      strings/Makefile.am:
        Change xml.c to use bcmp to avoid warnings from purify
      strings/xml.c:
        Change xml.c to use bcmp to avoid warnings from purify
      tests/client_test.c:
        Remove usage of MAXPATHLEN (all MySQL code uses FN_REFLEN)
      4736d0fe
  20. 17 Oct, 2004 1 commit
    • unknown's avatar
      Fix for bug #6081 "Call to deprecated mysql_create_db() function crashes · 07c7aadf
      unknown authored
      server".
      
      Altough mysql_create_db()/mysql_drop_db() API calls are deprecated
      since 4.0, they should not crash server and should not stall connection
      in case of errors. 
      
      
      sql/sql_parse.cc:
        Handling of COM_CREATE_DB, COM_DROP_DB:
          mysql_create_db() requires from its second parameter to be non-zero.
          We also should call send_error() if mysql_create_db or mysql_drop_db
          return error (like we do it for SQL versions of these commands).
      tests/client_test.c:
        Added test for bug #6081 "Execution of deprecated mysql_create_db()
        crashes server".
      07c7aadf
  21. 15 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6049 "Loss of sign when using prepared · 9aefc403
      unknown authored
      statements and negative time/date values". 
      The bug was in wrong sprintf format used in the client library.
      The fix moves TIME -> string conversion functions to sql-common and
      utilized them in the client library.
      
      
      include/my_time.h:
        Declarations for new functions shared between the client and server.
      libmysql/libmysql.c:
        Fix for Bug#6049 "Loss of sign when using prepared statements and negative
        time/date values": use the same function as the server to convert
        date/time/datetime values to strings.
      sql-common/my_time.c:
        Implementation of my_{time,datetime,date,TIME}_to_str: it's
        needed by the client library, so it should be shared.
      sql/field.cc:
        Don't create String object if it's not needed.
      sql/item.cc:
        Don't create String object if it's not needed: TIME_to_string was
        moved to my_TIME_to_str, with different arguments.
      sql/item_timefunc.cc:
        Don't create String object if it's not needed.
      sql/mysql_priv.h:
        TIME_to_string and MAX_DATE_REP_LENGTH moved to the client library.
        MAX_DATE_REP_LENGTH was renamed to MAX_DATE_STRING_REP_LENGTH to not 
        conflict with the same name in libmysql.c
      sql/protocol.cc:
        Don't create String object if it's not needed.
      sql/time.cc:
        Implementation of my_{time,date,datetime,TIME}_to_str moved to my_time.c
        shared between the client and the server.
      tests/client_test.c:
        A test case for Bug#6049.
      9aefc403
  22. 13 Oct, 2004 1 commit
    • unknown's avatar
      tests/client_test.c: · ba48e6f9
      unknown authored
        Make checks (asserts) performed in client_test.c work in non-debug
        builds.
      
      
      tests/client_test.c:
        Make checks (asserts) performed in client_test.c work in non-debug
        builds: all asserts/DBUG_ASSERTs replaced with if (!(expr)) abort();
      ba48e6f9
  23. 07 Oct, 2004 1 commit
    • unknown's avatar
      A fix for Bug#5748 "Prepared statement with BETWEEN and bigint values · 8fa6f37a
      unknown authored
      crashes mysqld": implementation for a generic item tree modifications
      registry. Every item tree modification which should be rolled back for
      subsequent execution of a prepared statement or stored procedure should
      be saved in the registry. All such modifications are rolled back at once
      during cleanup stage of PS.
      Actual fix for the bug just adds a call to register modifications to
      convert_constant_item.
      Post review fixes implemented.
      
      
      mysql-test/r/ps.result:
        A fix for bug#5748, test results fixed.
      mysql-test/t/ps.test:
        A test case for Bug#5748 "Prepared statement with BETWEEN and bigint 
        values crashes mysqld"
      sql/item.cc:
        Fix for Bug#5748 "Prepared statement with BETWEEN and bigint values
        crashes mysqld":
        First step in removing up item-specific cleanups: now all such
        tree modifications should be done using the genericm mechanism implemented
        in this changeset.
      sql/item.h:
        Fix for Bug#5748 "Prepared statement with BETWEEN and bigint values
        crashes mysqld": no need for an item-specific change record any more.
      sql/item_cmpfunc.cc:
        A fix for Bug#5748 "Prepared statement with BETWEEN and bigint 
        values crashes mysqld": register item tree transformation performed by
        convert_constant_item.
      sql/sql_class.cc:
        Implementation for item tree transformations registry.
      sql/sql_class.h:
        Declarations, necessary for the tree transformations registry.
      sql/sql_parse.cc:
        Assert that the item tree transformations registry is not used for 
        conventional execution.
      sql/sql_prepare.cc:
        Use of the item tree modifications registry in prepared statements:
        rollback all modifications in the end of statement prepare and execute.
        Also we now always set thd->current_arena to be able to determine that
        this is an execution of prepared statement inside the registry code.
      tests/client_test.c:
        A typo fixed.
      8fa6f37a
  24. 28 Sep, 2004 1 commit
    • unknown's avatar
      client_test.test: · 656bcff6
      unknown authored
        Run client_test as a testcase
        new file
      mysql-test-run.sh:
        More clearly report failure if --force, also exit 1
      client_test.c:
        Use MAXPATHLEN in test_frm_bug()
        Renable test cases disabled for running from mysql-test-run
      mysqltest.c:
        Don't check errno from popen, may not be set
      
      
      client/mysqltest.c:
        Don't check errno from popen, may not be set
      tests/client_test.c:
        Use MAXPATHLEN in test_frm_bug()
        Renable test cases disabled for running from mysql-test-run
      mysql-test/mysql-test-run.sh:
        More clearly report failure if --force, also exit 1
      mysql-test/t/client_test.test:
        Run client_test as a testcase
      656bcff6
  25. 25 Sep, 2004 1 commit
    • unknown's avatar
      client_test.c: · c14ec245
      unknown authored
        Return exit(1) instead of exit(0) on failure.
        Allow longer path names using MAXPATHLEN.
        Added option --testcase that skips some failing tests.
        Replaced 'return' with exit(1) in test_frm_bug().
      mysqltest.c:
        Let --exec fail if command fails
      
      
      client/mysqltest.c:
        Let --exec fail if command fails
      tests/client_test.c:
        Return exit(1) instead of exit(0) on failure.
        Allow longer path names using MAXPATHLEN.
        Added option --testcase that skips some failing tests.
        Replaced 'return' with exit(1) in test_frm_bug().
      c14ec245
  26. 23 Sep, 2004 1 commit
  27. 22 Sep, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#5315 "mysql_change_user() doesn't free · ccf52b4f
      unknown authored
      prepared statements."
      
      
      include/hash.h:
        New declaration for hash_reset() function. The old version was not used.
      libmysql/client_settings.h:
        Declaration for mysql_detach_stmt_list().
      libmysql/libmysql.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        add call to mysql_detach_stmt_list(prepared statements) to
        mysql_change_user(): all statements are freed by server, so client
        counterparts need to be marked as not usable.
      mysys/hash.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of hash_reset(), which frees all hash elements
        and prepares the hash for reuse.
      sql-common/client.c:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of mysql_detach_stmt_list(): zero connection pointer
        in given statement list, thus marking given statements as not usable.
      sql/sql_class.cc:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        reset prepared statements map in THD::change_user().
      sql/sql_class.h:
        Fix for bug#5315 "mysql_change_user() doesn't free prepared statements":
        implementation of Statement_map::reset().
        A little cleanup of ~Statement_map(): first empty names_hash, as st_hash
        has a free function, which will delete statements.
      tests/client_test.c:
        A test case for bug #5315 "mysql_change_user() doesn't free prepared
        statements".
      ccf52b4f
  28. 14 Sep, 2004 2 commits
  29. 09 Sep, 2004 1 commit
    • unknown's avatar
      client_test.c: · 50f9e2f5
      unknown authored
        fix typos noticed while poking around in test program.
      
      
      tests/client_test.c:
        fix typos noticed while poking around in test program.
      50f9e2f5
  30. 08 Sep, 2004 2 commits
    • unknown's avatar
      A fix and test case for Bug#5194 "Bulk Insert Failures with Prepared · d7a23067
      unknown authored
      Statements": 
      - fix a couple of net->buff overruns in libmysql,
      - check in the server that statement parameter count is less than
        65535 (maximum value supported by prepared statements protocol).
       
      
      
      libmysql/libmysql.c:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - clean up my_realloc_str()
        - ensure that net buffer has space when storing null bits and
          parameter typecodes.
      sql/net_serv.cc:
        - set net->last_errno if packet is too big, even on client
          (Why was it ifdefed before?)
      sql/sql_prepare.cc:
        Bug#5194 "Bulk Insert Failures with Prepared Statements":
        - if placeholder count is bigger than 65535, give error.
          We have only 2 bytes reserved for transferring placeholder count
          in 4.1 protocol.
        - can't add a proper error code and message in 4.1 because of
          possible merge difficulties."
      tests/client_test.c:
        A test case for Bug#5194 "Bulk Insert Failures with Prepared 
        Statements".
      d7a23067
    • unknown's avatar
      A fix and test case for bug#5399 "Wrong statement executed by MySQL · e5af92b0
      unknown authored
       server" (use my_charset_bin for stmt id hash).
      
      
      sql/sql_class.cc:
        Fix for bug#5399 "Wrong statement executed by MySQL server": 
        we hash stmt ids bytewise, need to use binary collation for it.
      tests/client_test.c:
        Test case for bug#5399 "Wrong statement executed by MySQL server":
        create number of statements returning different results, execute them
        one by one.
      e5af92b0
  31. 04 Sep, 2004 1 commit
    • unknown's avatar
      Print value of Item_param if it has a value (when debugging) · fa3bfbe4
      unknown authored
      libmysql/libmysql.c:
        More debug
      sql/item.h:
        Print value of param if it has a value (when debugging)
      sql/log.cc:
        Better variable name
      sql/sql_insert.cc:
        Fix bug casused by merge
      sql/sql_parse.cc:
        Added missing command names (caused crash when running with --debug)
      sql/sql_select.cc:
        More debugging
      sql/sql_yacc.yy:
        Fixed typo
      tests/client_test.c:
        More debugging
      fa3bfbe4
  32. 03 Sep, 2004 1 commit
    • unknown's avatar
      Cleanup of new code pushed into 5.0 since last pull · d0211cf5
      unknown authored
      Merged the different find_xxxx_table_in_list functions to one + some inline functions
      
      
      mysql-test/r/view.result:
        Fix result (remove not used view from show tables)
      sql/item_subselect.cc:
        Remove not used functions
      sql/item_subselect.h:
        Remove not used functions
      sql/mysql_priv.h:
        Merged the different find_xxxx_table_in_list functions to one + some inline functions
      sql/sql_acl.cc:
        More debugging + simple cleanups
      sql/sql_base.cc:
        Merged the different find_xxxx_table_in_list functions to one + some inline functions
        Indentation cleanups & more comments
      sql/sql_delete.cc:
        Namechange
      sql/sql_insert.cc:
        Simple optimizations & Style cleanups
        Merged common code (in mysql_prepare_insert_check_table)
      sql/sql_lex.cc:
        function name changes
        More comments
      sql/sql_parse.cc:
        Function name changes
        Made check_one_table_access returning bool
        More debugging in 'check_access'
        Added function 'check_some_access', which is used when creating a view
      sql/sql_prepare.cc:
        Resetting flag directly after test makes code easier to read
      sql/sql_select.cc:
        Code simplifications
      sql/sql_show.cc:
        Indentation cleanups.
        Fixed typo in name
      sql/sql_update.cc:
        Function name change
      sql/sql_view.cc:
        Simple optimizations.
        Style fixes.
        Remove view_field_names[]
        Simplified 'check_key_in_view()'
      sql/table.cc:
        Simplified new code in openfrm()
        variable name change i -> item
        Indentation changes
      sql/table.h:
        Fixed typo in variable name
        Method name change in field iterator: end() -> end_of_fields()
      tests/client_test.c:
        Changed number to macro
      d0211cf5
  33. 02 Sep, 2004 2 commits
    • unknown's avatar
      A fix and test case for Bug#4231 "Wrong result with MYSQL_TIME · 0c58737a
      unknown authored
      parameters": when unpacking binary time recieved from client, handle
      the case when length is 0: it means all MYSQL_TIME members are zero.
      
      
      include/my_time.h:
        Declaration for set_zero_time: a tiny piece of code, which I
        see no reason to not reuse.
      libmysql/libmysql.c:
        set_zero_time implementation is now shared between client and
        server.
      sql-common/my_time.c:
        set_zero_time implementation added.
      sql/sql_prepare.cc:
        A fix for Bug#4231 "Wrong result with MYSQL_TIME parameters": 
        when unpacking binary time recieved from client, handle the
        case when length is 0: it means all MYSQL_TIME members are zero.
      tests/client_test.c:
        Test case for bug#4231 "Wrong result with MYSQL_TIME parameters"
      0c58737a
    • unknown's avatar
      After merge fixes · 762bee96
      unknown authored
      mysql-test/mysql-test-run.sh:
        Export MASTER_MYSOCK (used in some tests)
      mysql-test/t/alter_table.test:
        Use MASTER_MYSOCK instead of master.sock
      762bee96
  34. 01 Sep, 2004 1 commit