1. 06 Oct, 2008 6 commits
    • Chad MILLER's avatar
      Merge fix for join-testcase failure. · 33f69718
      Chad MILLER authored
      33f69718
    • Chad MILLER's avatar
      Merge fix for join-testcase failure. · 79e10003
      Chad MILLER authored
      79e10003
    • Chad MILLER's avatar
    • Alexey Botchkov's avatar
      merging · 72817b14
      Alexey Botchkov authored
      72817b14
    • Mattias Jonsson's avatar
      merge · 7e7e4b8b
      Mattias Jonsson authored
      7e7e4b8b
    • Alexey Botchkov's avatar
      Bug#38083 Error-causing row inserted into partitioned table despite error · a206d672
      Alexey Botchkov authored
            
          problems are located in the sql_partition.cc where functions calculation
          partition_id don't expect error returned from item->val_int().
          Fixed by adding checks to these functions.
          Note  - it tries to fix more problems than just the reported bug.
            
      per-file comments:
      modified:
        mysql-test/r/partition.result
          Bug#38083 Error-causing row inserted into partitioned table despite error
              test result
        mysql-test/t/partition.test
          Bug#38083 Error-causing row inserted into partitioned table despite error
              test case
        sql/opt_range.cc
          Bug#38083 Error-causing row inserted into partitioned table despite error
              get_part_id() call fixed
        sql/partition_info.h
          Bug#38083 Error-causing row inserted into partitioned table despite error
              get_subpart_id_func interface changed. 
        sql/sql_partition.cc
          Bug#38083 Error-causing row inserted into partitioned table despite error
              various functions calculationg partition_id and subpart_id didn't expect
                  an error returned from item->val_int().  Error checks added.
      a206d672
  2. 04 Oct, 2008 2 commits
  3. 03 Oct, 2008 6 commits
  4. 02 Oct, 2008 15 commits
  5. 01 Oct, 2008 11 commits
    • Matthias Leich's avatar
      Fix for Bug#37744 Expected result of "<engine>_storedproc" test · 766803d5
      Matthias Leich authored
                        is inconsistent
      + several improvements
      Details:
      - The subtest with assignment of floating point numbers to
        DECIMAL parameters in functions and procedures checks
        now that the final DECIMAL value is the same as if we assign
        the floating point numbers to columns, user variables etc.
        = The impact of math libs or truncation must be the same.
      - Remove storage engine variants of this test because the
        stored procedure properties tested do not depend on
        the storage engine.
        Use the fastest storage engine (MEMORY) for any tables
        needed.
      - reset global sort_buffer_size to startup value
      - Partially improved formatting.
      766803d5
    • Ingo Struewing's avatar
      merge · 61753a07
      Ingo Struewing authored
      61753a07
    • Georgi Kodinov's avatar
      f80fbfa2
    • Georgi Kodinov's avatar
      Bug#37943: Reproducible mysqld crash/sigsegv in sel_trees_can_be_ored · e59a0361
      Georgi Kodinov authored
                  
      When analyzing the possible index use cases the server was re-using an internal structure.
      This is wrong, as this internal structure gets updated during the analysis.
      Fixed by making a copy of the internal structure for every place it needs to be used.
      Also stopped the generation of empty SEL_TREE structures that unnecessary 
      complicate the analysis.
      e59a0361
    • Ingo Struewing's avatar
      merge · 031a9d26
      Ingo Struewing authored
      031a9d26
    • Sven Sandberg's avatar
      BUG#38269: pushbuild gives valgrind error in ha_statistic_increment for rpl_temporary · 1901da7f
      Sven Sandberg authored
      Re-enabling failing test case because server logs were lost in pushbuild, so we need to run it again.
      1901da7f
    • Georgi Kodinov's avatar
      0005175e
    • Georgi Kodinov's avatar
    • Ingo Struewing's avatar
      merge · 9a65aa38
      Ingo Struewing authored
      9a65aa38
    • Ingo Struewing's avatar
      Bug#37958 - test main.plugin crash on Mac OS X when selecting from EXAMPLE engine. · acaf211d
      Ingo Struewing authored
      This patch contains fixes for two problems:
      
      1. As originally reported, the server crashed on Mac OS X when trying to access
         an EXAMPLE table after the EXAMPLE plugin was installed.
      
         It turned out that the dynamically loaded EXAMPLE plugin called the
         function hash_earch() from a Mac OS X system library, instead of
         hash_earch() from MySQL's mysys library. Makefile.am in storage/example
         does not include libmysys. So the Mac OS X linker arranged the hash_search()
         function to be linked to the system library when the shared object is
         loaded.
      
         One possible solution would be to include libmysys into the linkage of
         dynamic plugins. But then we must have a libmysys.so, which must be
         used by the server too. This could have a minimal performance impact,
         but foremost the change seems to bee too risky at the current state of
         MySQL 5.1.
      
         The selected solution is to rename MySQL's hash_search() to my_hash_search()
         like it has been done before with hash_insert() and hash_reset().
      
         Since this is the third time, we need to rename a hash_*() function,
         I did renamed all hash_*() functions to my_hash_*().
      
         To avoid changing a zillion calls to these functions, and announcing
         this to hundreds of developers, I added defines that map the old names
         to the new names.
      
         This change is in hash.h and hash.c.
      
      2. The other problem was improper implementation of the handlerton-to-plugin
         mapping. We use a fixed-size array to hold a plugin reference for each
         handlerton. On every install of a handler plugin, we allocated a new slot
         of the array. On uninstall we did not free it. After some uninstall/install
         cycles the array overflowed. We did not check for overflow.
      
         One fix is to check for overflow to stop the crashes.
      
         Another fix is to free the array slot at uninstall and search for a free slot
         at plugin install.
      
         This change is in handler.cc.
      acaf211d
    • Georgi Kodinov's avatar
      74a905df