1. 25 Jun, 2003 3 commits
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-4.0 · 349946b3
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.0.674
      
      
      sql/sql_select.cc:
        Auto merged
      349946b3
    • unknown's avatar
      Testcase for #674 added · 8abad215
      unknown authored
      
      mysql-test/r/sel000100.result:
        Result of the testcase added
      mysql-test/t/sel000100.test:
        checking for bug #674 added
      8abad215
    • unknown's avatar
      - reverted change from AC_CONFIG_HEADERS to AM_CONFIG_HEADER in configure.in · 9354da21
      unknown authored
         again - even though the automake docs consider AM_CONFIG_HEADER obsolete, 
         it currently still breaks for too many people to justify this change
         at the moment.
      
      
      configure.in:
         - reverted change from AC_CONFIG_HEADERS to AM_CONFIG_HEADER again - even
           though the automake docs consider AM_CONFIG_HEADER obsolete, it currently
           still breaks for too many people to justify this change at the moment.
      9354da21
  2. 24 Jun, 2003 2 commits
  3. 23 Jun, 2003 9 commits
  4. 22 Jun, 2003 2 commits
    • unknown's avatar
      dict0dict.h, dict0dict.c, ha_innodb.cc: · e0be1a89
      unknown authored
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      
      
      sql/ha_innodb.cc:
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      innobase/dict/dict0dict.c:
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      innobase/include/dict0dict.h:
        In ORDER BY MySQL seems to set the key read flag also in the case where the primary key contains only a prefix of a column - not the whole column; to prevent potential bugs retrieve the whole column if the index contains a prefix of it
      e0be1a89
    • unknown's avatar
      Fixed cleanup_load_tmpdir() which deleted nothing. · f403da4b
      unknown authored
      
      sql/log_event.cc:
        - cleanup_load_tmpdir() did not work at all because it forgot to indicate
        the directory part of the path when calling my_delete().
        - A misplaced R_POS_OFFSET (fortunately this was no bug as this constant is 0).
      sql/sql_repl.cc:
        - fix fake_rotate_event() for pos>4G (correction of a change I pushed yesterday).
      f403da4b
  5. 21 Jun, 2003 2 commits
    • unknown's avatar
      Always send a fake Rotate event (this is roughly 70 bytes) when starting binlog_dump. · 5c9b87ce
      unknown authored
      This way 3.23.58 slaves will always detect a 4.0.14 master (and stop)
      immediately. BUG#198.
      
      
      mysql-test/r/rpl_log.result:
        result update (the relay log now contains a fake Rotate_log_event).
      mysql-test/r/rpl_log_pos.result:
        result update (the relay log now contains a fake Rotate_log_event).
      5c9b87ce
    • unknown's avatar
      Proposed fix for #674 · 1688ada0
      unknown authored
      This crash happens in rather exotic case when we try to run 
      SELECT DISTINCT some_func(SUM(some_field)) GROUP BY another_field;
      on a table with single row.
      Optimizer marks this table as const, sets group=NULL (with remove_const)
      thus, create_tmp_table makes mistake collecting columns for temporary table
      and then crashes because the field_count gets less than hidden_columns_count.
      
      
      sql/sql_select.cc:
        There's several ways to fix this bug.
        This one looks easy and correct to me
      1688ada0
  6. 20 Jun, 2003 6 commits
  7. 19 Jun, 2003 3 commits
    • unknown's avatar
      Fix error msg. Bug #681 · 332334e8
      unknown authored
      
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      332334e8
    • unknown's avatar
      Fix for bug #616 mysqld crash / SSL with SQLyog · 4eef86c6
      unknown authored
      4eef86c6
    • unknown's avatar
      SCRUM · 85d2282e
      unknown authored
      Task ID 894:
      Backport default_week_format variable to 4.0
      
      
      mysql-test/r/func_time.result:
        Backport default_week_format variable to 4.0
      mysql-test/t/func_time.test:
        Backport default_week_format variable to 4.0
      sql/mysqld.cc:
        Backport default_week_format variable to 4.0
      sql/set_var.cc:
        Backport default_week_format variable to 4.0
      sql/sql_class.h:
        Backport default_week_format variable to 4.0
      sql/sql_yacc.yy:
        Backport default_week_format variable to 4.0
      85d2282e
  8. 18 Jun, 2003 6 commits
  9. 17 Jun, 2003 4 commits
    • unknown's avatar
      row0vers.c, row0sel.c, row0ins.c: · 1efc292b
      unknown authored
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      
      
      innobase/row/row0ins.c:
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      innobase/row/row0sel.c:
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      innobase/row/row0vers.c:
        Fix bug: InnoDB could print that it cannot find a clustered index record if an update undo, purge, and a consistent read coincided, in rare cases it might also have returned a wrong row in a query
      1efc292b
    • unknown's avatar
      Changed change_master() to use ER_MASTER_INFO (better display). · b518744d
      unknown authored
      
      mysql-test/r/rpl_rotate_logs.result:
        result update
      mysql-test/t/rpl_rotate_logs.test:
        comments and test update with the error code
      sql/slave.cc:
        A DBUG_PRINT
      sql/sql_repl.cc:
        Use ER_MASTER_INFO instead of custom message and zero error code (which display
        badly).
      b518744d
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.0 · 926d86db
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      926d86db
    • unknown's avatar
      Better error reporting in mysql-test-run (don't hide the important message · 800bbfa0
      unknown authored
      with 'head').
      Test fix (this sync_with_master was nonsense).
      Now all tests pass in 4.0 in autobuild.
      
      
      mysql-test/mysql-test-run.sh:
        Error reporting (how mysql-test-run filters the messages which mysqltest prints
        on stderr) is not reliable. It does a 'head the first line only' which in
        my case caused me to lose some time, because in fact the worrying message was
        on the second line (logically, the one which caused the die() is at the
        end of the $TIMEFILE file, not at the beginning).
        Doing a 'tail' is better but not perfect (depending on the build, one may get
        "Maximum memory usage" as the last line); it's always good to have all messages
        and spot the important one oneself. So we print all $TIMEFILE (that's a few lines
        at most).
      mysql-test/t/rpl_rotate_logs.test:
        Dont sync_with_master as the SQL slave thread may be stopped at this moment;
        just wait_for_slave_to_stop. Doing sync_with_master caused a non-deterministic
        behaviour, because (note that save_master_pos was called to early) sometimes
        MASTER_POS_WAIT() started before the SQL thread died (because of unique
        violation) so returned 0, other times it started after the SQL thread died
        so returned NULL (which is reported by mysqltest as an error, on stderr).
      800bbfa0
  10. 16 Jun, 2003 3 commits