1. 09 Jan, 2009 1 commit
    • Sven Sandberg's avatar
      BUG#37718: rpl.rpl_stm_mystery22 fails sporadically on pushbuild · 3889dffc
      Sven Sandberg authored
      Problem 1: The test waits for an error in the slave sql thread,
      then resolves the error and issues 'start slave'. However, there
      is a gap between when the error is reported and the slave sql
      thread stops. If this gap was long, the slave would still be
      running when 'start slave' happened, so 'start slave' would fail
      and cause a test failure.
      Fix 1: Made wait_for_slave_sql_error wait for the slave to stop
      instead of wait for error in the IO thread. After stopping, the
      error code is verified. If the error code is wrong, debug info
      is printed. To print debug info, the debug printing code in
      wait_for_slave_param.inc was moved out to a new file,
      show_rpl_debug_info.inc.
      Problem 2: rpl_stm_mystery22 is a horrible name, the comments in
      the file didn't explain anything useful, the test was generally
      hard to follow, and the test was essentially duplicated between
      rpl_stm_mystery22 and rpl_row_mystery22.
      Fix 2: The test is about conflicts in the slave SQL thread,
      hence I renamed the tests to rpl_{stm,row}_conflicts. Refactored
      the test so that the work is done in
      extra/rpl_tests/rpl_conflicts.inc, and
      rpl.rpl_{row,stm}_conflicts merely sets some variables and then
      sourced extra/rpl_tests/rpl_conflicts.inc.
      The tests have been rewritten and comments added.
      Problem 3: When calling wait_for_slave_sql_error.inc, you always
      want to verify that the sql thread stops because of the expected
      error and not because of some other error. Currently,
      wait_for_slave_sql_error.inc allows the caller to omit the error
      code, in which case all error codes are accepted.
      Fix 3: Made wait_for_slave_sql_error.inc fail if no error code
      is given. Updated rpl_filter_tables_not_exist accordingly.
      Problem 4: rpl_filter_tables_not_exist had a typo, the dollar
      sign was missing in a 'let' statement.
      Fix 4: Added dollar sign.
      Problem 5: When replicating from other servers than the one named
      'master', the wait_for_slave_* macros were unable to print debug
      info on the master.
      Fix 5: Replace parameter $slave_keep_connection by
      $master_connection.
      3889dffc
  2. 08 Jan, 2009 2 commits
  3. 07 Jan, 2009 1 commit
  4. 28 Dec, 2008 5 commits
  5. 26 Dec, 2008 1 commit
  6. 25 Dec, 2008 1 commit
    • He Zhenxing's avatar
      BUG#40704 main.events_restart fails sporadically in pushbuild: "server has gone away" · e58f77bb
      He Zhenxing authored
      mysqltest command 'shutdown_server' is supposed to shutdown the server
      and wait for it to be gone, and kill it when timeout. But because the
      arguments passed to my_kill were in the wrong order, 'shutdown_server'
      does not wait nor kill the server at all. So after 'shutdown_server',
      the server is still running, and the server may still accepting
      connections.
      e58f77bb
  7. 19 Dec, 2008 8 commits
  8. 18 Dec, 2008 7 commits
  9. 17 Dec, 2008 2 commits
    • Joerg Bruehe's avatar
      Merge the 5.0.74 build into the main tree. · a613f1dc
      Joerg Bruehe authored
      a613f1dc
    • John H. Embretsen's avatar
      Fix (preliminary?) for Bug#41502 - MTR v2 should not load plugins during server bootstrap. · b4781e30
      John H. Embretsen authored
      Adding --loose-skip-falcon option to the mysqld options provided by MTR (v2) during mysqld bootstrap in order to avoid plugin (in this case Falcon) initialization of static variables etc. Options --loose-skip-innodb and --loose-skip-ndbcluster were already included.
      
      This will fix Bug#41014 (falcon_bug_39708 fails in pushbuild in 6.0-rpl: "succeeded - should have failed")
      in the case of MTR v2 (which currently is available in -rpl branches only). 
      MTR v1 (e.g. in main 6.0 branch) does not have this problem.
      
      It would be more ideal to remove the --loose-skip-* options and provide a single option disabling all plugin initialization instead, or have bootstrap do this by default. Server modifications are (most likely) needed to be able to do that.
      b4781e30
  10. 15 Dec, 2008 1 commit
  11. 13 Dec, 2008 2 commits
  12. 12 Dec, 2008 6 commits
    • Andrei Elkin's avatar
      merge 5.1-rpl repository -> 5.1-rpl local · 047eced3
      Andrei Elkin authored
      047eced3
    • Andrei Elkin's avatar
      Bug #40129 no-threads fails on pushbuild in 6.0-rpl, ps_stm_threadpool · cf99c5ba
      Andrei Elkin authored
            
      The test reacted on the way how mtr orders arguments for the server
      that are gathered from different source. It appeared that the opt-file
      options were parsed before those that supplied to mtr via its command
      line. In effect, the opt-file preferences got overriden by the command
      line and some tests, like no-threads, were caught by surprise: a test
      expects an option value that had been "hardcoded" into its opt-file
      but gets another one.
      This server options ordering problem exists on in the new rpl trees
      mtr.  In option of the author of this patch, the opt-file shall be
      considered as having the highest preference weight. The opt-file is
      merely a part of the header of a test, namely a part that can not be
      technically deployed along the test file.
      It's unnatural for the test writer to provide both the opt file value
      and a guard that guarantees the value will be set on in the run time.
      It's logical to provide either one: the option and its value or the
      guard.
      
      Fixed with relocating parse of the opt file to be the last among
      sources of the sever's options.
      
      A side effect: fixing a small problem of resetting the suite options
      at time the opt file starts parsing.
      
      A side effect: main.log_bin_trust_function_creators_func is disabled to
      be re-enabled with the fixes for bug#41003 will be merged from the main trees.
      cf99c5ba
    • Bjorn Munch's avatar
      Bug #31983 Running mysql-test from RPM fails for NDB · ff1161eb
      Bjorn Munch authored
      Added $glob_basedir/sbin to search path for relevant binaries
      ff1161eb
    • Serge Kozlov's avatar
      Bug#41186: Possible reason of bug is waiting any sql error on slave instead · de7be3a4
      Serge Kozlov authored
      exact number of error. The patch does following:
      1) Add new parameter $slave_sql_errno for wait_for_slave_sql_error.inc
      2) Add waiting error 1062 (Duplicate PK) for slave SQL thread in test case.
      de7be3a4
    • Serge Kozlov's avatar
      Bug#41108: It is a testcase timeout bug so the patch fixes test code in places · e67ab663
      Serge Kozlov authored
      where timeout can happen:
      1. Added waiting start/stop slave to make sure that slave works properly.
      2. Added cleanup for slave.
      3. Updated related result files.
      e67ab663
    • Serge Kozlov's avatar
      Bug#40142: possible reason of timeout is stopped slave threads before · e5a14618
      Serge Kozlov authored
      sync_with_master command. The patch add waiting of proper state of slave 
      before sync with master.
      e5a14618
  13. 10 Dec, 2008 2 commits
  14. 08 Dec, 2008 1 commit