1. 17 Mar, 2010 1 commit
    • Mattias Jonsson's avatar
      Bug#50561: ALTER PARTITIONS does not have adequate lock, breaks with · 3b897f2b
      Mattias Jonsson authored
      concurrent I_S query
      
      There were two problem:
      1) MYSQL_LOCK_IGNORE_FLUSH also ignored name locks
      2) there was a race between abort_and_upgrade_locks and
         alter_close_tables
         (i.e. remove_table_from_cache and
          close_data_files_and_morph_locks)
      
      Which allowed the table to be opened with MYSQL_LOCK_IGNORE_FLUSH flag
      resulting in renaming a partition that was already in use,
      which could cause the table to be unusable.
      
      Solution was to not allow IGNORE_FLUSH to skip waiting for
      a named locked table.
      
      And to not release the LOCK_open mutex between the
      calls to remove_table_from_cache and
      close_data_files_and_morph_locks by merging the functions
      abort_and_upgrade_locks and alter_close_tables.
      3b897f2b
  2. 16 Mar, 2010 8 commits
  3. 15 Mar, 2010 1 commit
  4. 14 Mar, 2010 2 commits
    • Staale Smedseng's avatar
      Bug #49829 Many "hides virtual function" warnings with · 3f4d8edb
      Staale Smedseng authored
      SunStudio
            
      SunStudio compilers of late warn about methods that might hide
      methods in base classes due to the use of overloading combined
      with overriding. SunStudio also warns about variables defined
      in local socpe or method arguments that have the same name as
      a member attribute of the class.
            
      This patch renames methods that might hide base class methods,
      to make it easier both for humans and compilers to see what is
      actually called. It also renames variables in local scope.
      3f4d8edb
    • Davi Arnaut's avatar
      0e945118
  5. 13 Mar, 2010 1 commit
  6. 12 Mar, 2010 5 commits
  7. 11 Mar, 2010 5 commits
  8. 10 Mar, 2010 11 commits
  9. 09 Mar, 2010 1 commit
    • Georgi Kodinov's avatar
      Bug #35250: readline check breaks when doing vpath build · a774c83c
      Georgi Kodinov authored
      MySQL uses two source layouts when building : the bzr 
      layout and the source package layout.
      The previous fix for bug 35250 contained 1 change that is
      valid for both modes and a number of changes that are valid
      only for the bzr source layout.
      The important thing was to fix the source package layout.
      And for this the change in configure.in was sufficient.
      It's not trivial (and not requested by this bug) to support 
      VPATH builds from the bzr trees.
      This is why the other changes are reverted and the change to
      fix the VPATH build for source distributions is left intact.
      a774c83c
  10. 10 Mar, 2010 1 commit
  11. 09 Mar, 2010 2 commits
    • Luis Soares's avatar
      Post-push fix for BUG#51251. · 2c23e00a
      Luis Soares authored
      The test case added in previous patch missed a RESET MASTER on
      test start up. Without it, showing binary log contents can
      sometimes show spurious entries from previously executed tests,
      ultimately causing test failure - result mismatch.
      
      The test file was added in:
      revid:luis.soares@sun.com-20100224190153-k0bpdx9abe88uoo2
      
      This patch also moves the test case into binlog_innodb_row.test
      file. This way we avoid having yet another test file,
      binlog_row_innodb_truncate.test, whose only purpose is to host
      one test case. This had been actually suggested during original
      patch review, but somehow the binlog_innodb_row was missed when
      searching for a file to host the test case.
      2c23e00a
    • Davi Arnaut's avatar
      Bug#51770: UNINSTALL PLUGIN requires no privileges · 91223c4d
      Davi Arnaut authored
      The problem was that UNINSTALL PLUGIN wasn't performing privilege
      checks before removing a plugin. Any user (including users without 
      any kind of privileges) could uninstall any plugin.
      
      The solution is to verify if the user has the DELETE privilege for
      the mysql.plugin table before uninstalling a plugin.
      91223c4d
  12. 12 Mar, 2010 1 commit
  13. 09 Mar, 2010 1 commit
    • Georgi Kodinov's avatar
      Bug #41057: mysql_update fails FATAL ERROR: Failed to create temporary file for defaults · 25a271a0
      Georgi Kodinov authored
      mysql_upgrade was passing an non-initialized non-null tmpdir to create_temp_file() if no 
      --tmpdir was specified. This prevents create_temp_file() from taking the system 
      temporary file path and as a result mysql_upgrade was trying to open a file in a 
      directory that it may not have write access to.
      Fixed by making sure mysql_upgrade will pass a zero length temp dir string to 
      create_temp_file() if no --tmpdir is specified.
      25a271a0