1. 25 May, 2006 1 commit
    • evgen@moonbone.local's avatar
      Fixed bug#16716: subselect in concat() may lead to a wrong result. · 40ea3025
      evgen@moonbone.local authored
      The Item_func_concat::val_str() function tries to make as less re-allocations
      as possible. This results in appending strings returned by 2nd and next
      arguments to the string returned by 1st argument if the buffer for the first
      argument has enough free space. A constant subselect is evaluated only once 
      and its result is stored in an Item_cache_str. In the case when the first
      argument of the concat() function is such a subselect Item_cache_str returns
      the stored value and Item_func_concat::val_str() append values of other
      arguments to it. But for the next row the value in the Item_cache_str isn't
      restored because the subselect is a constant one and it isn't evaluated second
      time. This results in appending string values of 2nd and next arguments to the 
      result of the previous Item_func_concat::val_str() call.
      
      The Item_func_concat::val_str() function now checks whether the first argument 
      is a constant one and if so it doesn't append values of 2nd and next arguments
      to the string value returned by it.
      40ea3025
  2. 24 May, 2006 5 commits
  3. 23 May, 2006 3 commits
  4. 22 May, 2006 1 commit
  5. 21 May, 2006 1 commit
  6. 20 May, 2006 2 commits
  7. 19 May, 2006 4 commits
  8. 17 May, 2006 2 commits
  9. 16 May, 2006 9 commits
  10. 15 May, 2006 5 commits
  11. 14 May, 2006 3 commits
  12. 13 May, 2006 1 commit
  13. 12 May, 2006 3 commits