- 09 Aug, 2010 1 commit
-
-
unknown authored
storage/maria/ma_loghandler.c: Fix of soft group commit (assigned LSN instead of file number).
-
- 07 Aug, 2010 3 commits
-
-
Michael Widenius authored
Merge with 5.1 to get bug fix for LP#613408 Memory corruption with (M)aria storage engine and virtual columns Fixed test case to test for virtual columns
-
Michael Widenius authored
This patch fixes LP#613408 Memory corruption with (M)aria storage engine and virtual columns in MariaDB 5.2 Fixed compiler warnings Disabled some tests that doesn't work on windows (uses shell tools or strange characters) client/mysqlshow.c: Fixed compiler warnings client/mysqlslap.c: Fixed compiler warnings mysql-test/mysql-test-run.pl: Use an error file instead of /dev/null (Fixes problem on Windows and the output may be usefull) mysql-test/suite/maria/r/maria.result: Test case for bug LP#613408 (not complete) mysql-test/suite/maria/t/maria.test: Test case for bug LP#613408 (not complete) mysql-test/suite/percona/percona_log_slow_slave_statements-and-use_global_long_query_time.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_log_slow_slave_statements.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-control_global_slow.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-log_slow_filter.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-log_slow_verbosity.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-long_query_time.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-microseconds_in_slow_query_log.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-min_examined_row_limit.test: This test doesn't work one windows (needs shell tools) mysql-test/suite/percona/percona_slow_query_log-use_global_long_query_time.test: This test doesn't work one windows (needs shell tools) mysql-test/t/ctype_filesystem.test: This test doesn't work one windows (problem with character sets) mysql-test/t/events_time_zone.test: Use longer times to get predictable tests mysql-test/t/show_check-master.opt: set long query time to get more predictable tests storage/maria/ma_check.c: Restore info->s->lock_key_trees after repair. Disable logging to temp tables for all repair cases (safety fix) storage/maria/ma_state.c: Ensurethat info->state_start doesn't point to freed memory. (Could happen after running an internal repair to fast create indexes) storage/maria/trnman.c: Added longer comment
-
Michael Widenius authored
Changed to use longlong10_to_str() instead of longlong2str() when base is 10 or -10 as former is much faster than later Changed my_vsnprintf() to use longlong2str instead of int2str() to get rid of warnings and to get support for long pointers even when long is 32 bit. client/mysqltest.cc: longlong2str() -> longlong10_to_str() include/m_string.h: Added extra argument to longlong2str() to make it have same prototype is int2str() mysys/charset.c: Fixed compiler warning mysys/mf_soundex.c: Fixed compiler warning mysys/my_getopt.c: longlong2str() -> longlong10_to_str() sql/create_options.cc: Fixed compiler warning sql/item_strfunc.cc: Added extra argument to longlong2str sql/opt_range.cc: longlong2str() -> longlong10_to_str() sql/partition_info.cc: longlong2str() -> longlong10_to_str() sql/slave.cc: longlong2str() -> longlong10_to_str() sql/sql_bitmap.h: Added extra argument to longlong2str sql/sql_partition.cc: Added extra argument to longlong2str sql/sql_select.cc: longlong2str() -> longlong10_to_str() sql/sql_show.cc: Added extra argument to longlong2str storage/innodb_plugin/handler/ha_innodb.cc: Update to new parameters for longlong2str() storage/maria/ma_dbug.c: longlong2str() -> longlong10_to_str() storage/maria/maria_chk.c: Added extra argument to longlong2str storage/myisam/mi_dbug.c: longlong2str() -> longlong10_to_str() storage/myisam/myisamchk.c: Added extra argument to longlong2str storage/xtradb/handler/ha_innodb.cc: Update to new parameters for longlong2str() strings/longlong2str.c: Added extra argument to longlong2str() to make it have same prototype is int2str() strings/my_vsnprintf.c: Changed my_vsnprintf() to use longlong2str instead of int2str() to get rid of warnings and to get support for long pointers even when long is 32 bit. Added cast to get rid of compiler warnings
-
- 06 Aug, 2010 9 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
Fixed compiler warnings client/mysqlslap.c: Fixed compiler warnings mysql-test/suite/maria/r/maria.result: Test case for LP#614265 mysql-test/suite/maria/t/maria.test: Test case for LP#614265 mysql-test/suite/pbxt/t/skip_name_resolve-master.opt: Ensure that we get restart before test (as test uses show processlist) sql/handler.cc: Added cloned marker if clone was called (for safety checks & debugging) sql/handler.h: Added cloned marker if clone was called (for safety checks & debugging) storage/maria/ha_maria.cc: In clone call, set file->trn if cloned file had this set. This is needed as maria_create_trn_for_mysql() and thus file->trn is never set for cloned table. Ensure that file->trn is properly reset after calls to repair/check/zerofill. Increment locked table count if file->trn is set (as we decrement this in the unlock call) tests/mysql_client_test.c: Fixed compiler warnings
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
-
Michael Widenius authored
mysql-test/suite/innodb_plugin/t/innodb-timeout.test: More time for test case support-files/compiler_warnings.supp: Ignore compiler warning
-
- 05 Aug, 2010 6 commits
-
-
Michael Widenius authored
Removed references to HA_END_SPACE_KEY (which has been 0 for a long time)
-
Michael Widenius authored
-
Michael Widenius authored
Added option: --warning-for-wrong-transaction-id to maria_check mysql-test/r/innodb-use-sys-malloc.result: Remove not used files mysql-test/t/innodb-use-sys-malloc-master.opt: Remove not used files storage/maria/ma_recovery.c: Added support for --lsn-end storage/maria/ma_recovery.h: New prototype storage/maria/ma_write.c: Added logging of KEY_OP_CHECK for all possible keyblock splits. (Helps us find error in log file handling) storage/maria/maria_chk.c: Added option: --warning-for-wrong-transaction-id --update-status now resets open count if check succeds storage/maria/maria_read_log.c: Added option --end-lsn for only appling part of log (good for debugging) Changed options to use '-' instead of '_'
-
Michael Widenius authored
mysql-test/suite/funcs_1/r/is_columns_is.result: Update after change of comment length mysql-test/suite/funcs_1/r/is_engines.result: Update after change of comment length mysql-test/suite/innodb_plugin/t/disabled.def: Disable a test that gives valgrind warnings for xtradb mysql-test/suite/innodb_plugin/t/innodb_bug52745.test: Test requires persian collation
-
Michael Widenius authored
Fixed tests cases.
-
Michael Widenius authored
mysql-test/suite/percona/percona_log_slow_slave_statements.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-control_global_slow.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-control_global_slow.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-log_slow_filter.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-log_slow_filter.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-log_slow_verbosity.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-log_slow_verbosity.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-long_query_time.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-long_query_time.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-microseconds_in_slow_query_log.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-microseconds_in_slow_query_log.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-min_examined_row_limit.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-min_examined_row_limit.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-use_global_long_query_time.result: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/percona/percona_slow_query_log-use_global_long_query_time.test: Replaced 'grep | wc -l' with 'grep -c' as output of wc -l is not portable (for example on Mac) mysql-test/suite/rpl/r/rpl_stm_until.result: Updated results mysql-test/suite/rpl/t/rpl_stm_until.test: Fixed random failure in test suite: master could be reading data from master-bin.00001 at the same time as test suite was changing it.
-
- 04 Aug, 2010 6 commits
-
-
Michael Widenius authored
Fixed some wrong test cases Fixed bug in null handling in XtraDB extra/comp_err.c: Fixed compiler warnings extra/my_print_defaults.c: Fixed compiler warnings mysql-test/suite/binlog/t/binlog_killed.test: Added support for timeouts mysql-test/suite/funcs_1/r/is_columns_is.result: Updated results (INNODB_SYS_TABLES had got new column) scripts/mysql_install_db.sh: Fixed typo sql/mysql_priv.h: Removed not needed argument for compare_record() sql/sql_insert.cc: Removed not needed argument for compare_record() sql/sql_update.cc: Removed not needed argument for compare_record() The argument is not needed becasue we copy the full record[0] to record[1] and the comparison should work even if all columns are not read sql/table.cc: The comparison of rows is independent of HA_PARTIAL_COLUMN_READ storage/maria/maria_chk.c: Fixed compiler warnings storage/maria/maria_read_log.c: Fixed compiler warnings storage/myisam/myisamchk.c: Fixed compiler warnings storage/myisam/myisampack.c: Fixed compiler warnings storage/xtradb/dict/dict0load.c: Fixed compiler warnings storage/xtradb/row/row0sel.c: Fixed null handling in XtraDB. (See comment) storage/xtradb/trx/trx0sys.c: Fixed compiler warnings support-files/compiler_warnings.supp: Fixed compiler warnings
-
Michael Widenius authored
This was triggered by innodb.innodb_multi_update, where we had a static length row without nulls and xtradb didn't fill in the delete-marker byte include/my_bitmap.h: Added prototype for bitmap_union_is_set_all() mysys/my_bitmap.c: Added function to check if union of two bit maps covers all bits. sql/mysql_priv.h: Updated protype for compare_record() sql/sql_insert.cc: Send to compare_record() flag if all fields are used. sql/sql_select.cc: Set share->null_bytes_for_compare. sql/sql_update.cc: In compare_record() don't use the fast cmp_record() (which is basically memcmp) if we don't know that all fields exists. Don't compare the null_bytes if there is no data there. sql/table.cc: Store in share->null_bytes_for_compare the number of bytes that has null or bit fields (but not delete marker) Store in can_cmp_whole_record if we can use memcmp() (assuming all rows are read) to compare rows in compare_record() sql/table.h: Added two elements in table->share to speed up checking how updated rows can be compared.
-
Michael Widenius authored
Added --strace support to mysql-test-run mysql-test/mysql-test-run.pl: Added support for --strace (usefull for example to check how much memory mysqld was using) mysql-test/suite/funcs_1/t/is_engines_innodb.test: Fixed test case to also work with xtradb mysql-test/suite/innodb_plugin/t/innodb.test: Don't run if we don't have the used character sets. mysql-test/suite/innodb_plugin/t/innodb_mysql.test: Don't run if we don't have the used character sets. sql/sql_show.cc: Extended comment to 160 characters to get full comment from xtradb storage/xtradb/handler/ha_innodb.cc: Fixed valgrind warning.
-
unknown authored
-
unknown authored
Comment fixed.
-
unknown authored
-
- 03 Aug, 2010 3 commits
-
-
Michael Widenius authored
If one compiles innodb_plugin, then the tests in suite/innodb_plugin will use the plugin. If not and xtradb is used, the tests will use xtradb. mysql-test/include/have_innodb_plugin.inc: Test both for innodb_plugin and xtradb mysql-test/include/have_real_innodb_plugin.inc: Test if we are using innodb_plugin (but not xtradb) mysql-test/include/have_xtradb.inc: Test if xtradb is used mysql-test/lib/mtr_cases.pm: Enable easy testing of innodb_plugin mysql-test/mysql-test-run.pl: Added supression for difference between xtradb & innodb_plugin mysql-test/suite/innodb_plugin/r/innodb-index-ip.result: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/r/innodb-index-xb.result: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/r/innodb-index.result: Move tests away that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/r/innodb-ip.result: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/r/innodb-xb.result: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/r/innodb.result: Move tests away that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/r/innodb_bug21704-xb.result: Test result differ for xtradb mysql-test/suite/innodb_plugin/r/innodb_bug46000.result: Remove (not needed) error message not given by MariaDB mysql-test/suite/innodb_plugin/r/innodb_bug49164-xb.result: Test result differs for xtradb mysql-test/suite/innodb_plugin/r/innodb_bug49164.result: Update results mysql-test/suite/innodb_plugin/r/innodb_bug53591.result: Remove (not needed) error message not given by MariaDB mysql-test/suite/innodb_plugin/r/innodb_bug54679.result: Updated result file mysql-test/suite/innodb_plugin/r/innodb_mysql.result: Updated result file mysql-test/suite/innodb_plugin/t/disabled.def: Disable some tests that depends on newer version of XtraDB mysql-test/suite/innodb_plugin/t/innodb-index-ip.test: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/t/innodb-index-xb.test: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/t/innodb-index.test: Move tests away that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/t/innodb-ip.test: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/t/innodb-xb.test: Tests from innodb-index that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/t/innodb.test: Move tests away that gave different results for innodb_plugin and xtradb mysql-test/suite/innodb_plugin/t/innodb_bug21704-xb.test: Test result differ for xtradb mysql-test/suite/innodb_plugin/t/innodb_bug21704.test: Test result differ for xtradb mysql-test/suite/innodb_plugin/t/innodb_bug53591.test: Test results only makes sence for innodb_plugin (things works ok for xtradb) sql/sql_table.cc: Don't set HA_CREATE_USED_ROW_FORMAT for create table (only for update_create_info) if ROW_FORMAT is not used. storage/innodb_plugin/handler/ha_innodb.cc: Fixed wrong error message from innodb. This is needed as MariaDB properly handles errors from ha_index_init() storage/xtradb/handler/ha_innodb.cc: Update base information for XtraDB so that one can use informationschema.plugins to check if one is using XtraDB
-
unknown authored
-
unknown authored
Support of virtual columns added to maria engine. mysql-test/suite/vcol/r/vcol_handler_maria.result: Basic tests for virtual column and maria engine. mysql-test/suite/vcol/t/vcol_handler_maria.test: Basic tests for virtual column and maria engine. storage/maria/ha_maria.cc: Support of virtual columns added to maria engine. storage/maria/ha_maria.h: Support of virtual columns added to maria engine.
-
- 02 Aug, 2010 4 commits
-
-
Michael Widenius authored
Speed up some PBXT tests by adding begin...commit around creating of testing tables. include/my_base.h: Fixed wrong constant mysql-test/mysql-test-run.pl: Print MariaDB instead of MySQL mysql-test/r/range.result: Move test that required partitions to parts.optimizer mysql-test/suite/innodb_plugin/t/disabled.def: Disable test that causes valgrind warning about not released memory in xtradb mysql-test/suite/parts/r/optimizer.result: Moved from range.result mysql-test/suite/parts/t/optimizer.test: Moved from range.test mysql-test/suite/pbxt/r/join_nested.result: Updated results after optimizer changes mysql-test/suite/pbxt/r/renamedb.result: Updated test for new error message mysql-test/suite/pbxt/t/check.test: Speed up test mysql-test/suite/pbxt/t/count_distinct2.test: Speed up test mysql-test/suite/pbxt/t/derived.test: Speed up test mysql-test/suite/pbxt/t/renamedb.test: Updated test for new error message mysql-test/suite/rpl/r/rpl_log_pos.result: Updated results mysql-test/suite/rpl/t/rpl_log_pos.test: Update test to read from a position that has 'known wrong' data. The orignal test read a timestamp, so the error message could differ between runs. mysql-test/suite/rpl/t/rpl_temporary_errors.test: Sync to slave to make test predictable mysql-test/t/events_time_zone.test: Extend wait to make test predictable mysql-test/t/range.test: Move test that required partitions to parts.optimizer sql/sql_list.h: Fixed compiler warning sql/sql_load.cc: buffer was not freed in some error conditions tests/mysql_client_test.c: Fixed compiler warning
-
Michael Widenius authored
-
Michael Widenius authored
Added 'Aria' as an alias for the Maria storage engine. Real rename is happening in 5.2 sql/handler.cc: Added 'Aria' as an alias for the Maria storage engine.
-
Michael Widenius authored
Fixed Bug#52005 'JOIN_TAB->dependent' may be incorrectly propageted for multilevel outer joins' in a better way (patch from Sergey Petrunya)
-
- 30 Jul, 2010 1 commit
-
-
Michael Widenius authored
Fix for LP#602604: RQG: ma_blockrec.c:6187: _ma_apply_redo_insert_row_head_or_tail: Assertion `0' failed on Maria engine recovery More DBUG_PRINT (to simplify future debugging) Aria: Added STATE_IN_REPAIR, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally. Aria: Some trivial speedup optimization Aria: Better warning if table was marked crashed by unfinnished repair mysql-test/lib/v1/mysql-test-run.pl: Fix so one can run RQG mysql-test/suite/maria/r/maria-recovery2.result: Update for new error message. mysys/stacktrace.c: Fixed compiler warning storage/maria/ha_maria.cc: More DBUG_PRINT Added STATE_IN_REPAIR flag, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally. Don't log query for dropping temporary table. storage/maria/ha_maria.h: Added prototype for drop_table() storage/maria/ma_blockrec.c: More DBUG_PRINT Make read_long_data() inline for most cases. (Trivial speedup optimization) storage/maria/ma_check.c: Better warning if table was marked crashed by unfinnished repair storage/maria/ma_open.c: More DBUG_PRINT storage/maria/ma_recovery.c: Give warning if found crashed table. Changed warning for tables that can't be opened. storage/maria/ma_recovery_util.c: Write warnings to DBUG file storage/maria/maria_chk.c: Added STATE_IN_REPAIR flag, which is set on start of repair. This allows us to see if 'crashed' flag was set intentionally. storage/maria/maria_def.h: Added maria_mark_in_repair(x) storage/maria/maria_read_log.c: Added option: --character-sets-dir storage/maria/trnman.c: By default set min_read_from to max value. This allows us to remove TRN:s from rows during recovery to get more space. This fixes bug LP#602604: RQG: ma_blockrec.c:6187: _ma_apply_redo_insert_row_head_or_tail: Assertion `0' failed on Maria engine recovery
-
- 28 Jul, 2010 1 commit
-
-
Igor Babaev authored
The CREATE SHOW TABLE command misplaced virtual column specifiers: the AS clause for a virtual column was put before optional character set attributes, not after them as required by the syntax.
-
- 26 Jul, 2010 2 commits
-
-
Igor Babaev authored
-
Igor Babaev authored
-
- 25 Jul, 2010 2 commits
-
-
Sergei Golubchik authored
mysql-test/suite/funcs_1/r/is_columns_is.result: update for monty changes mysql-test/valgrind.supp: more generic suppression for dlerror() internal allocations scripts/make_win_bin_dist: update for hakan changes - we don't generate .map files anymore sql/CMakeLists.txt: innodb_plugin is said to need .map files in sql/
-
Sergei Golubchik authored
-
- 24 Jul, 2010 2 commits
-
-
Sergei Golubchik authored
-
Sergei Golubchik authored
mysys/mf_keycache.c: warning on windows storage/example/ha_example.cc: fighting the warnings don't ifdef too much. a function must return a value! storage/xtradb/Makefile.am: add -lmysqlservices for ha_xtradb.so plugin to load
-