1. 18 Aug, 2004 1 commit
    • unknown's avatar
      BUG# 4466 - Nothing in .err when mysql service ends because of malformed my.ini options · 4736e7d4
      unknown authored
      mysqld.cc:
        Changed option_error_reporter to match new function header that includes LOGLEVEL enum
      mysql_priv.h:
        Removed the MY_ERROR style bitmask.  Changed function headers to use new LOGLEVEL enum
      log.cc:
        Changed print_buffer_to_log to print_buffer_to_file.  Remove the timestamp bool and now all log entries written to stderr are timestamped.  Removed some unused commented code.  changed to use the new LOGLEVEL enum.  
      my_getopt.c:
        Changed functions to use the new LOGLEVEL enum and changed the included error reporter to be default_reporter.  This reporter is used in handle_options if a reporter is not given
      my_getopt.h:
        changed typedefs to use better naming convention.  Moved error bitmask into the LOGLEVEL enum and included it here.
      
      
      include/my_getopt.h:
        changed typedefs to use better naming convention.  Moved error bitmask into the LOGLEVEL enum and included it here.
      mysys/my_getopt.c:
        Changed functions to use the new LOGLEVEL enum and changed the included error reporter to be default_reporter.  This reporter is used in handle_options if a reporter is not given
      sql/log.cc:
        Changed print_buffer_to_log to print_buffer_to_file.  Remove the timestamp bool and now all log entries written to stderr are timestamped.  Removed some unused commented code.  changed to use the new LOGLEVEL enum.
      sql/mysql_priv.h:
        Removed the MY_ERROR style bitmask.  Changed function headers to use new LOGLEVEL enum
      sql/mysqld.cc:
        Changed option_error_reporter to match new function header that includes LOGLEVEL enum
      4736e7d4
  2. 14 Aug, 2004 1 commit
    • unknown's avatar
      mysql_priv.h: · 767d880f
      unknown authored
        Added declarations for print_msg_to_log and vprint_msg_to_log.  sql_print_error are simple functions that wrap calls to print_msg_to_log.  Define the different error types with MY_ERROR_TYPE, MY_WARNING_TYPE, and MY_INFORMATION_TYPE
      gen_lex_hash.cc:
        Added NULL error reporting parameter to handle_options
      log.cc:
        Add print_msg_to_log, print_buffer_to_log, and vprint_msg_to_log.  Print_msg_to_log will write the message to the windows event log if on NT.  We now have error, warning, and information versions of sql_print_xxxx.  T his is a variation of a similar changeset WAX did.
      mysqld.cc:
        Added option_error_reporter callback function and pass that into handle_options
      mysql.cc:
        Added NULL as error reporter arg to the end of handle_options
      Many files:
        Added NULL error reporter parameter as the last paramter to handle_options
      my_getopt.c:
        Added second function pointer to server as an error reporting callback.  Added local function report_option_error that will either write the error to stderr or to the error reporting callback.  changed all calls in handle_options from fprintf(stderr, ... ) to report_option_error
      my_getopt.h:
        Changed declaration of handle_options to use typedefs for the two function pointers.  added second function pointer to server as an error reporting callback
      mysqld.dsp:
        Added custom build step for compiling message file and added message resource file (output of mc)
      
      
      VC++Files/sql/mysqld.dsp:
        Added custom build step for compiling message file and added message resource file (output of mc)
      client/mysqladmin.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqlcheck.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqldump.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqlimport.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqlmanager-pwgen.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqlmanagerc.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqlbinlog.cc:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqlshow.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysqltest.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      extra/my_print_defaults.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      extra/mysql_install.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      extra/mysql_waitpid.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      extra/perror.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      extra/resolve_stack_dump.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      extra/resolveip.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      isam/isamchk.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      isam/pack_isam.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      myisam/mi_test1.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      myisam/myisam_ftdump.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      myisam/myisamchk.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      myisam/myisampack.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      include/my_getopt.h:
        Changed declaration of handle_options to use typedefs for the two function pointers.  added second function pointer to server as an error reporting callback
      mysys/my_getopt.c:
        Added second function pointer to server as an error reporting callback.  Added local function report_option_error that will either write the error to stderr or to the error reporting callback.  changed all calls in handle_options from fprintf(stderr, ... ) to report_option_error
      tools/mysqlmanager.c:
        Added NULL error reporter parameter as the last paramter to handle_options
      client/mysql.cc:
        Added NULL as error reporter arg to the end of handle_options
      sql/mysqld.cc:
        Added option_error_reporter callback function and pass that into handle_options
      sql/log.cc:
        Add print_msg_to_log, print_buffer_to_log, and vprint_msg_to_log.  Print_msg_to_log will write the message to the windows event log if on NT.  We now have error, warning, and information versions of sql_print_xxxx.  T his is a variation of a similar changeset WAX did.
      sql/gen_lex_hash.cc:
        Added NULL error reporting parameter to handle_options
      sql/mysql_priv.h:
        Added declarations for print_msg_to_log and vprint_msg_to_log.  sql_print_error are simple functions that wrap calls to print_msg_to_log.  Define the different error types with MY_ERROR_TYPE, MY_WARNING_TYPE, and MY_INFORMATION_TYPE
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      767d880f
  3. 11 Aug, 2004 2 commits
  4. 10 Aug, 2004 7 commits
  5. 09 Aug, 2004 4 commits
  6. 06 Aug, 2004 2 commits
    • unknown's avatar
      InnoDB: Add option for disabling innodb_status.<pid> files. · fc4364e3
      unknown authored
      InnoDB: Implement tmpfile() differently on Windows (Bug #3998)
      
      
      innobase/dict/dict0dict.c:
        Check the return value of os_file_create_tmpfile(),
        as it can now return NULL
      innobase/include/os0file.h:
        Note that os_file_create_tmpfile() can now return NULL
      innobase/include/srv0srv.h:
        Add a new server flag (srv_innodb_status) to disable
        the creation of innodb_status.<pid> files
      innobase/lock/lock0lock.c:
        Check the return value of os_file_create_tmpfile(),
        as it can now return NULL
      innobase/os/os0file.c:
        os_file_create_tmpfile(): separate implementation for Win32;
        errors will be reported but will not cause assertion failure
      innobase/srv/srv0srv.c:
        Add a new server flag (srv_innodb_status) to disable
        the creation of innodb_status.<pid> files
      innobase/srv/srv0start.c:
        innobase_start_or_create_for_mysql(): create srv_monitor_file
        with tmpfile() or with a visible name "innodb_status.<pid>",
        depending on the setting of the flag srv_innodb_status.
      sql/ha_innodb.cc:
        innobase_init(): initialize srv_innodb_status
        update_table_comment(), get_foreign_key_create_info(): replace
        tmpfile() with os_file_create_tmpfile()
      sql/ha_innodb.h:
        Add new Boolean flag, innobase_create_status_file.
      sql/mysqld.cc:
        Add new Boolean flag, innodb_status_file
      fc4364e3
    • unknown's avatar
      Fix for bug #4491 "timestamp(19) doesn't work". · 3a00469e
      unknown authored
      We should allow 19 as length of newly created TIMESTAMP fields.
      
      
      mysql-test/r/type_timestamp.result:
        Added test of TIMESTAMP(19) support.
      mysql-test/t/type_timestamp.test:
        Added test of TIMESTAMP(19) support.
      sql/sql_parse.cc:
        add_field_to_list(): TIMESTAMP columns should also support 19 as length since it is
        length of 4.1 compatible representation.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      3a00469e
  7. 05 Aug, 2004 4 commits
    • unknown's avatar
      - rename: EXCEPTIONS->EXCEPTIONS-CLIENT · 06cd2efc
      unknown authored
      06cd2efc
    • unknown's avatar
      74e86ee3
    • unknown's avatar
      - Fixed libmysql license texts: added reference to the FLOSS · 7b614774
      unknown authored
         EXCEPTIONS file and amended the GPL text as requested by Zak
      
      
      libmysql/Makefile.am:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/Makefile.shared:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/conf_to_src.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/dll.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/errmsg.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/get_password.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/libmysql.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql/manager.c:
         - Fixed license text, added reference to the EXCEPTIONS file
      libmysql_r/Makefile.am:
         - Fixed license text, added reference to the EXCEPTIONS file
      7b614774
    • unknown's avatar
      - More changes to include the FLOSS License Exception in the · dc82282e
      unknown authored
         various distributions
      
      
      Docs/Makefile.am:
         - Honoured node name change in manual.texi FOSS->FLOSS
      Makefile.am:
         - actually add EXCEPTIONS to the source distribution
      scripts/make_win_src_distribution.sh:
         - add EXCEPTIONS to the Windows source distribution, too
      dc82282e
  8. 04 Aug, 2004 4 commits
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.0 · d3095410
      unknown authored
      into mysql.com:/space/my/mysql-4.0
      
      
      d3095410
    • unknown's avatar
      - applied the required changes to create the FOSS License exception · d62dff22
      unknown authored
         file "EXCEPTIONS" and include it in the source and binary 
         distributions
      
      
      Build-tools/mysql-copyright:
         - remove COPYING and EXCEPTIONS from the commercial packages
      Docs/Makefile.am:
         - create the EXCEPTIONS file that includes the FOSS License exception
      scripts/make_binary_distribution.sh:
         - include EXCEPTIONS in the binary distribution, too.
      support-files/mysql.spec.sh:
         - add EXCEPTIONS to the server RPM
      d62dff22
    • unknown's avatar
    • unknown's avatar
      Print MYSQL_COMPILATION_COMMENT after ER_READY on server startup · 03daa16a
      unknown authored
      
      sql/share/czech/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/danish/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/dutch/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/english/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/estonian/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/french/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/german/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/greek/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/hungarian/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/japanese/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/korean/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/norwegian-ny/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/norwegian/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/polish/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/portuguese/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/romanian/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/russian/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/slovak/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/spanish/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/swedish/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      sql/share/ukrainian/errmsg.txt:
        Remove trailing \n from ER_READY (it is now printed in mysqld.cc)
      03daa16a
  9. 03 Aug, 2004 1 commit
  10. 02 Aug, 2004 1 commit
    • unknown's avatar
      dyn0dyn.h: · b525356a
      unknown authored
        dyn_array_open(): mention the size limit
      mtr0log.ic, mtr0log.h:
        mlog_open(): mention the size limit
      
      
      innobase/include/mtr0log.h:
        mlog_open(): mention the size limit
      innobase/include/mtr0log.ic:
        mlog_open(): mention the size limit
      innobase/include/dyn0dyn.h:
        dyn_array_open(): mention the size limit
      b525356a
  11. 01 Aug, 2004 2 commits
  12. 31 Jul, 2004 5 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 69789688
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      69789688
    • unknown's avatar
      BUG#4393, BUG#4356 - incorrect decimals in fix_length_and_dec() in some functions · 9ca47d04
      unknown authored
      
      mysql-test/mysql-test-run.sh:
        report failed test name
      mysql-test/r/func_math.result:
        test results fixed
      9ca47d04
    • unknown's avatar
      Fix for: · 00e7ec42
      unknown authored
      Bug #4810 "deadlock with KILL when the victim was in a wait state"
      (I included mutex unlock into exit_cond() for future safety)
      and BUG#4827 "KILL while START SLAVE may lead to replication slave crash"
      
      
      sql/lock.cc:
        we did exit_cond() before unlock(LOCK_open), which led to deadlocks with THD::awake(). Fixing this.
      sql/log.cc:
        mutex unlock is now included in exit_cond()
      sql/repl_failsafe.cc:
        we did exit_cond() before unlock(LOCK_rpl_status), which led to deadlocks with THD::awake(). Fixing this.
      sql/slave.cc:
        we did exit_cond() before unlock(cond_lock), which led to deadlocks with THD::awake(). Fixing this.
        Fixing also that if killed while waiting for slave thread to start, we don't release the mutex
        (that caused a double release of the mutex => crash).
      sql/sql_class.h:
        comments about exit_cond()/enter_cond().
        Mutex unlock is now included in exit_cond() so that it's always done in the good order.
      sql/sql_table.cc:
        unlock is now included in exit_cond().
      00e7ec42
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 42ed0103
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      42ed0103
    • unknown's avatar
      removing assertion (will be moved to 4.1) for non-debug to compile · 6ce5da27
      unknown authored
      
      sql/sql_class.h:
        removing the assertion as I don't want to include assert.h (inclusion of assert.h has already been
        reworked in 4.1, so I'll move the assertion to 4.1). Assertion makes compilation fail if non-debug.
      6ce5da27
  13. 30 Jul, 2004 6 commits