1. 06 Jun, 2006 1 commit
    • unknown's avatar
      Fixed some problems for Windows build · b03ba905
      unknown authored
      VC++Files/client/mysql.dsp:
        Fixed omission of mysys\my_conio.c.
      VC++Files/client/mysql_ia64.dsp:
        Fixed omission of mysys\my_conio.c.
      client/mysqldump.c:
        VS compiler does not accept variable declarations within blocks.
        Such a behaviour complies with the Standard C.
      b03ba905
  2. 30 May, 2006 1 commit
    • unknown's avatar
      Bug#17371: Unable to dump a schema with invalid views · ab95de5d
      unknown authored
      'show create' works even on views that are short of a base-table (this
      throw a warning though, like you would expect). Unfortunately, this is
      not what mysqldump uses; it creates stand-in tables and hence requests
      'show fields' on the view which fails with missing base-tables.  The
      --force option prevents the dump from stopping at this point; furthermore
      this patch dumps a comment showing create for the offending view for
      better diagnostics. This solution was confirmed by submitter as solving
      their/clients' problem. Problem might become non-issue once mysqldump no
      longer creates stand-in tables.
      
      
      client/mysqldump.c:
        Dump a comment showing create for a view if we can't show fields for it for
        better diagnostics.
      mysql-test/r/mysqldump.result:
        add test for #17371 - be defensive. if we can't do a full dump on a view
        (incl. 'show fields' for a stand-in table), at least create a comment with
        the 'show create' info when --force is given.
      mysql-test/t/mysqldump.test:
        add test for #17371 - be defensive. if we can't do a full dump on a view
        (incl. 'show fields' for a stand-in table), at least create a comment with
        the 'show create' info when --force is given.
      ab95de5d
  3. 29 May, 2006 2 commits
    • unknown's avatar
      after merge fix. · a9eae996
      unknown authored
      
      client/mysqldump.c:
        after merge fix.
          - 'lengths' declaration moved to the beginning of the block.
      a9eae996
    • unknown's avatar
      manual merge · 8c083f0a
      unknown authored
      8c083f0a
  4. 25 May, 2006 1 commit
    • unknown's avatar
      BUG#17201: Improve handling of views. · 02dcdb33
      unknown authored
      client/mysqldump.c:
         Better view handling:
        
          Distinguish better between tables and views in the output.
          
          Add many comments about the distinctions between tables and views, and
          the tradeoffs that we make, notably that, since we don't maintain
          dependencies.
          
          get_table_structure: Clarify in the output that a view is first
          		       created as a workaround for the lack of
          		       dependencies.
          
          dump_table:  Return if we're trying to dump a view.
          
          dump_all_views_in_db: Don't call init_dumping.  It's already been done
                                in dump_all_tables_in_db.  This is the problem
                                reported in BUG#17201.
          
          Change the variable was_views to seen_views, and clarify the comment.
          The previous name was not overly "intuitive".
      mysql-test/r/mysqldump.result:
        We no longer have spurious text in the results.
        Add results for the final test (BUG#17201)
      mysql-test/t/mysqldump.test:
        Add a new test (BUG#17201)
      02dcdb33
  5. 19 May, 2006 1 commit
    • unknown's avatar
      Fix for bug #18536: mysqldump does not maintain table orders as per --tables option · 985f4684
      unknown authored
      client/mysqldump.c:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - use list to store table names instead of hash.
      mysql-test/r/mysqldump.result:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - test result.
      mysql-test/t/mysqldump.test:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - test case.
      985f4684
  6. 18 Apr, 2006 1 commit
    • unknown's avatar
      Bug#17208 SSL: client does not verify server certificate · edfc0149
      unknown authored
       - Add new function 'ssl_verify_server_cert' which is used if we are 
         connecting to the server with SSL. It will compare the hostname in 
         the server's cert against the hostname that we used when connecting 
         to the server. Will reject the connection if hostname does not match.
       - Add new option "OPT_SSL_VERIFY_SERVER_CERT" to be passed to mysql_options
         which will turn on checking of servers cert.
       - Add new argument "ssl-verify-server-cert" to all mysql* clients which 
         will activate the above option.
       - Generate a new server cert with 1024 bits that has "localhost" as the server name.
      
      
      SSL/server-cert.pem:
        Generate a new server cert that has "localhost" as CN, so that we can test to verify the hostname we connected against with the hostname in the cert
      client/client_priv.h:
        Add OPT_SSL_VERIFY_CERT
      client/mysql.cc:
        Pass the variable "opt_ssl_verify_server_cert" to the mysql_options function. It's processed/included by include/sslopt*.h files
      client/mysqladmin.cc:
        Pass the variable "opt_ssl_verify_server_cert" to the mysql_options function. It's processed/included by include/sslopt*.h files
      client/mysqldump.c:
        Pass the variable "opt_ssl_verify_server_cert" to the mysql_options function. It's processed/included by include/sslopt*.h files
      client/mysqlimport.c:
        Pass the variable "opt_ssl_verify_server_cert" to the mysql_options function. It's processed/included by include/sslopt*.h files
      client/mysqlshow.c:
        Pass the variable "opt_ssl_verify_server_cert" to the mysql_options function. It's processed/included by include/sslopt*.h files
      client/mysqltest.c:
        Always set opt_ssl_verify_server_cert on in mysqltest if we are using SSL
      include/mysql.h:
        Add variable ssl_verify_cerver_cert
      include/sslopt-longopts.h:
        Add ssl-verify-server-cert options to all clients.
      include/sslopt-vars.h:
        Add opt_ssl_varify_server_cert to all clients.
      sql-common/client.c:
        Add ssl_vertify_server_cert function which is executed if user has set the option ssl_verify_cerver_cert
      vio/viosslfactories.c:
        Ask the SSL library to verify servers cert by setting the SSL_VERIFY_PEER flag
      edfc0149
  7. 10 Mar, 2006 1 commit
    • unknown's avatar
      Fix version of DEFINER-clause in mysqldump. · 4f83f961
      unknown authored
      Now DEFINER-clause in stored routines is expected to appear
      in 5.0.20 release, not in 5.0.19. as it was supposed before.
      
      
      client/mysqldump.c:
        Fixing version.
      mysql-test/r/mysqldump.result:
        Updated the result file.
      4f83f961
  8. 02 Mar, 2006 1 commit
    • unknown's avatar
      Implementation of WL#2897: Complete definer support in the stored routines. · e159ce93
      unknown authored
      The idea is to add DEFINER-clause in CREATE PROCEDURE and CREATE FUNCTION
      statements. Almost all support of definer in stored routines had been already
      done before this patch.
      
      NOTE: this patch changes behaviour of dumping stored routines in mysqldump.
      Before this patch, mysqldump did not dump DEFINER-clause for stored routines
      and this was documented behaviour. In order to get full information about stored
      routines, one should have dumped mysql.proc table. This patch changes this
      behaviour, so that DEFINER-clause is dumped.
      
      Since DEFINER-clause is not supported in CREATE PROCEDURE | FUNCTION statements
      before this patch, the clause is covered by additional version-specific comments.
      
      
      client/mysqldump.c:
        Updated the code for dumping stored routines: cover DEFINER-clause
        into version-specific comment.
      mysql-test/r/gis.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/information_schema.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/mysqldump.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/rpl_ddl.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/rpl_sp.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/rpl_trigger.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/sp-security.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/sp.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/r/sql_mode.result:
        Updated result file after adding DEFINER-clause.
      mysql-test/t/sp-security.test:
        Updated result file after adding DEFINER-clause.
      sql/sp.cc:
        Added DEFINER-clause.
      sql/sp_head.cc:
        Added a new convenient variant of set_definer() operation.
      sql/sp_head.h:
        Updated result file after adding DEFINER-clause.
      sql/sql_lex.h:
        Renamed trigger_definition_begin into stmt_definition_begin to be used for
        triggers and stored routines.
      sql/sql_parse.cc:
        Check DEFINER-clause.
      sql/sql_trigger.cc:
        Renamed trigger_definition_begin into stmt_definition_begin to be used for
        triggers and stored routines.
      sql/sql_yacc.yy:
        Added DEFINER-clause.
      e159ce93
  9. 23 Feb, 2006 2 commits
  10. 21 Feb, 2006 1 commit
    • unknown's avatar
      Bug#14871 mysqldump: invalid view dump output · 98d16294
      unknown authored
       - Add comments with embeded veriosn info around the parts of the view syntax that are only supported by a certain version of MySQL Server
      
      
      client/mysqldump.c:
        Use information_schema.views to gather information about the view, then replace some parts of the output from "SHOW CREATE VIEW" with comment markers with version, to make thos parts of the view syntax become parsed only of MySQL servers that supports it.
        Create common function "open_sql_file_for_table" to open the individual .sql file where to dump the table or view.
      mysql-test/r/mysqldump.result:
        Update results
      mysql-test/t/mysqldump.test:
        Add test to see that views can be deumped and reloaded alos when they contain "SECURITY TYPE", "CHECK OPTION" and "DEFINER"
      98d16294
  11. 01 Feb, 2006 1 commit
  12. 10 Jan, 2006 1 commit
    • unknown's avatar
      Fix for BUG#15110: mysqldump --triggers: does not include DEFINER clause · fffe9d4f
      unknown authored
      There are two main idea of this fix:
        - introduce a common function for server and client to split user value
          (<user name>@<host name>) into user name and host name parts;
        - dump DEFINER clause in correct format in mysqldump.
      
      
      BitKeeper/etc/ignore:
        added client/my_user.c libmysqld/my_user.c sql/my_user.c
      client/Makefile.am:
        Use my_user.c in linking of mysqldump executable.
      client/mysqldump.c:
        Fix for BUG#15110(mysqldump --triggers: does not include DEFINER clause)
      include/Makefile.am:
        Add my_user.c
      include/mysql_com.h:
        Introduce a constant for max user length.
      libmysqld/Makefile.am:
        Add my_user.c
      mysql-test/r/mysqldump.result:
        Update result file.
      sql-common/Makefile.am:
        Add my_user.c
      sql/Makefile.am:
        Add my_user.c
      sql/sp.cc:
        Use constant for max user length.
      sql/sp_head.cc:
        Use common function to parse user value.
      sql/sql_acl.cc:
        Use constant for max user length.
      sql/sql_parse.cc:
        Use constant for max user length.
      sql/sql_show.cc:
        Use constant for max user length.
      sql/sql_trigger.cc:
        Use constant for max user length.
      include/my_user.h:
        A header file for parse_user().
      sql-common/my_user.c:
        A new file for parse_user() implementation.
      fffe9d4f
  13. 03 Jan, 2006 1 commit
    • unknown's avatar
      many warnings (practically safe but annoying) corrected · 12e22065
      unknown authored
      client/mysqladmin.cc:
        don't use the handler after it's closed
      client/mysqlbinlog.cc:
        memory leak
      client/mysqldump.c:
        many "ignore return value" warnings, one "NULL dereference"
      cmd-line-utils/libedit/history.c:
        memory leak
      include/my_base.h:
        cleanup
      libmysql/libmysql.c:
        "return value ignored" warning
      myisam/mi_delete.c:
        "return value ignored" warning
      myisam/myisampack.c:
        "out-of-bound access" warning
      myisam/sort.c:
        "double free" warning
      mysys/default_modify.c:
        "double free" warning
      mysys/mf_iocache2.c:
        "return value ignored" warnings
      mysys/my_bitmap.c:
        s/return/DBUG_RETURN/
      mysys/my_error.c:
        memory leak
      server-tools/instance-manager/parse.cc:
        "NULL dereference" warning
      sql-common/client.c:
        "NULL dereference" warning
      sql/field.cc:
        deadcode, "NULL dereference", "uninitialized" warnings
      sql/field.h:
        unused parameters removed from constructor
      sql/ha_myisam.cc:
        "return value ignored" warnings
      sql/item.cc:
        "return value ignored" warnings
        changed constructor
      sql/item_func.cc:
        "return value ignored" warnings
      sql/log_event.cc:
        uninitialized warning
      sql/opt_range.cc:
        "double free" and uninitialized warnings
      sql/opt_range.h:
        "return value ignored" warning
      sql/repl_failsafe.cc:
        "return value ignored" warning
      sql/set_var.cc:
        "return value ignored" warning
      sql/slave.cc:
        "return value ignored" warnings
      sql/slave.h:
        new prototype
      sql/sql_acl.cc:
        deadcode and "NULL dereference" warnings
      sql/sql_db.cc:
        "return value ignored" warning
      sql/sql_handler.cc:
        "NULL dereference" warning
      sql/sql_help.cc:
        "NULL dereference" warning
      sql/sql_insert.cc:
        "return value ignored" warning
      sql/sql_parse.cc:
        "return value ignored" warning
        one more DBUG_ASSERT
      sql/sql_repl.cc:
        "return value ignored" and memory leak warnings
      sql/sql_show.cc:
        "return value ignored" and "NULL dereference"  warnings
      sql/sql_test.cc:
        "return value ignored" warning
      sql/table.cc:
        memory leak
      sql/uniques.cc:
        "return value ignored" warning
        endspaces deleted
      12e22065
  14. 04 Dec, 2005 1 commit
    • unknown's avatar
      A set of Netware related patches. · 1d5fc2ff
      unknown authored
      client/mysql.cc:
        Fixed option name.
      client/mysqladmin.c:
        Fixed option name.
      client/mysqlbinlog.cc:
        Fixed option name.
      client/mysqlcheck.c:
        Fixed option name.
      client/mysqldump.c:
        Fixed option name.
      client/mysqlimport.c:
        Fixed option name.
      client/mysqlshow.c:
        Fixed option name.
      isam/isamchk.c:
        Fixed option name.
      myisam/myisamchk.c:
        Fixed option name.
      myisam/myisampack.c:
        Fixed option name.
      sql/sql_parse.cc:
        Fix problem with kill connection on NetWare.
      1d5fc2ff
  15. 24 Nov, 2005 1 commit
  16. 21 Nov, 2005 1 commit
    • unknown's avatar
      Fixed BUG #14554: mysqldump does not separate "ROW" and trigger · 360a088c
      unknown authored
       statement for tables created in the IGNORE_SPACE sql mode.
      
      
      client/mysqldump.c:
        Modified dump_triggers_for_table(): if trigger statement returned
         by SHOW TRIGGERS query does not contain a leading white space,
         additional space is inserted between "ROW" and the statement.
         The leading white spaces are removed by yylex() in the
         IGNORE_SPACE sql mode.
      mysql-test/r/mysqldump.result:
        Fixed test case result for bug 14554.
      mysql-test/t/mysqldump.test:
        Added test case for bug 14554.
      360a088c
  17. 18 Nov, 2005 1 commit
    • unknown's avatar
      Netware specific changes for 5.0.16a · 2f840aa9
      unknown authored
      client/mysql.cc:
        Fixed option.
      client/mysqladmin.cc:
        Fixed option.
      client/mysqlbinlog.cc:
        Fixed option.
      client/mysqlcheck.c:
        Fixed option.
      client/mysqldump.c:
        Fixed option.
      client/mysqlimport.c:
        Fixed option.
      client/mysqlshow.c:
        Fixed option.
      configure.in:
        Changed version for Netware.
      myisam/myisamchk.c:
        Fixed option.
      myisam/myisampack.c:
        Fixed option.
      netware/mysql_test_run.c:
        NetWare specific changes:
        Define MYSQL_CHECK environment variable to make mysqlcheck test case pass
      2f840aa9
  18. 27 Oct, 2005 1 commit
    • unknown's avatar
      Add DROP TABLE before trying to create view (in mysqldump) · 22501603
      unknown authored
      Cleaned up xxxx_gis.test's and made gis_generic.inc independent of ndb
      (Note that archive_gis.test fails, but this is independent of this patch)
      
      
      client/mysqldump.c:
        Add DROP TABLE to be able to re-run mysqldump if it fails after 'table-named-as-view' is created
      mysql-test/include/gis_generic.inc:
        Remove dependency of ndb
      mysql-test/include/have_archive.inc:
        Fix syntax
      mysql-test/include/have_geometry.inc:
        Fix syntax
      mysql-test/r/mysqldump.result:
        New test results after adding 'drop table'
      mysql-test/t/archive_gis.test:
        gis_generic tests for have_geometry.inc
      mysql-test/t/bdb_gis.test:
        gis_generic tests for have_geometry.inc
      mysql-test/t/innodb_gis.test:
        gis_generic tests for have_geometry.inc
      mysql-test/t/ndb_gis.test:
        gis_generic tests for have_geometry.inc
      sql/item_func.cc:
        Simplify code (as signal_divide_by_null sets 'null_value')
      22501603
  19. 25 Oct, 2005 1 commit
    • unknown's avatar
      This cset fixes BUG# 12838, 14061, 12129 · 94562078
      unknown authored
      mysqldump.result:
        BUG# 12838
            New test results for mysqldump -x on a DB with views
      mysqldump.test:
        sqldump.test:
            BUG# 12838
            New test to run mysqldump -x on a DB with views
      mysqldump.c:
        BUG# 12838
            Removed/Changed code which created tables to be put into the dump
            (For loading views of views) by creating temp tables and then using
            the CREATE TABLE information in those temp tables. The problem with this
            is that when mysqldump -x is called, it locks all tables, so the
            temp tables could not be created, causing the mysqldump to exit with
            failure. The code was changed to use SHOW FIELDS to get the column
            names and type to build CREATE TABLE text used to create these tables
            that views need in the dump.
      
      
      client/mysqldump.c:
        BUG# 12838
            Removed/Changed code which created tables to be put into the dump
            (For loading views of views) by creating temp tables and then using
            the CREATE TABLE information in those temp tables. The problem with this
            is that when mysqldump -x is called, it locks all tables, so the
            temp tables could not be created, causing the mysqldump to exit with
            failure. The code was changed to use SHOW FIELDS to get the column
            names and type to build CREATE TABLE text used to create these tables
            that views need in the dump.
      mysql-test/t/mysqldump.test:
        sqldump.test:
            BUG# 12838
            New test to run mysqldump -x on a DB with views
      mysql-test/r/mysqldump.result:
        BUG# 12838
            New test results for mysqldump -x on a DB with views
      94562078
  20. 19 Oct, 2005 2 commits
    • unknown's avatar
      mysqldump.c: · 258d1811
      unknown authored
        Slight change to help message.
      
      
      client/mysqldump.c:
        Slight change to help message.
      258d1811
    • unknown's avatar
      Changeset: · f415d919
      unknown authored
        Changed option text in mysqldump.c
      mysqldump.c:
        Changed text to read "+00:00" as opposed to "UTC" (per what the code does)
      
      
      client/mysqldump.c:
        Changed text to read "+00:00" as opposed to "UTC" (per what the code does)
      f415d919
  21. 17 Oct, 2005 1 commit
  22. 13 Oct, 2005 3 commits
    • unknown's avatar
      BUG# 13146 · 6d233f2a
      unknown authored
      Re-application of patch to clean 5.0 tree. Fixed issue with ANSI quotes 
      when dumping triggers
      
      
      client/mysqldump.c:
        BUG# 13146
        
        Re-application of fix to clean 5.0 tree. 
        
        Added comments for quote_name, moved declarations into proper order, 
        unset MASK_ANSI_QUOTES flag in opt_compatible_mode global when dumping
        triggers
      mysql-test/r/mysqldump.result:
        BUG# 13146
        
        New test results
      mysql-test/t/mysqldump.test:
        BUG# 13146
        
        New test
      6d233f2a
    • unknown's avatar
      Fix being able to set default TCP port for command-line utilities · 0812e569
      unknown authored
      by using MYSQL_TCP_PORT variable. (Bug #5792)
      
      
      client/mysql.cc:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqladmin.cc:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqlbinlog.cc:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqlcheck.c:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqldump.c:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqlimport.c:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqlshow.c:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      client/mysqltest.c:
        Set default port to 0 so MYSQL_TCP_PORT is handled by mysql_server_init().
      0812e569
    • unknown's avatar
      BUG# 13052 · 6c23c383
      unknown authored
      Clean application of patch - 
      - Added --tz-utc to fix issue of dumping timestamp values between 
      servers with different global time zone settings, particularly 
      with regard to the day of DST changeover, which without this fix,
       would dump duplicate timestamp values.
      
      
      client/client_priv.h:
        BUG# 13052 - clean application of http://lists.mysql.com/internals/30993
      client/mysqldump.c:
        BUG# 13052
        
        Clean application of patch http://lists.mysql.com/internals/30993
        
        - added new --tz-utc option
        - added saving of TIME_ZONE in dump file
        - set TIME_ZONE to "+00:00" in dump
      mysql-test/r/mysqldump.result:
        BUG# 13052 New results
      mysql-test/t/mysqldump.test:
        BUG# 13052
        
        Added new test to test if the new option --tz-utc places 
        'SET TIME_ZONE="+00:00" at the top of the file and that this fixes 
        the problem of ending up with duplicate timestamp values that should
         be unique on eve of DST
      6c23c383
  23. 11 Oct, 2005 1 commit
    • unknown's avatar
      Reviewing new pushed code · d6ccd7c7
      unknown authored
      - CHAR() now returns binary string as default
      - CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
      - Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        (Some old systems returns ETIME and it's safer to test for both values
         than to try to write a wrapper for each old system)
      - Fixed new introduced bug in NOT BETWEEN X and X
      - Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      - Use octet2hex() for all conversion of string to hex
      - Simplify and optimize code
      
      
      client/mysqldump.c:
        Simple optimizations of new code
        Indentation fixes
      client/mysqltest.c:
        Removed not needed variable
      include/mysql_com.h:
        Made octec2hex() more usable
      mysql-test/r/ctype_utf8.result:
        CHAR() now returns binary string as default
      mysql-test/r/func_str.result:
        CHAR() now returns binary string as default
      mysql-test/r/range.result:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/r/user_var-binlog.result:
        CHAR() now returns binary string as default
      mysql-test/r/view.result:
        More tests of view rename
      mysql-test/t/ctype_utf8.test:
        CHAR() now returns binary string as default
      mysql-test/t/func_str.test:
        CHAR() now returns binary string as default
      mysql-test/t/range.test:
        Added test to verify new introduced bug in NOT BETWEEN X and X
      mysql-test/t/view.test:
        More tests of view rename
      mysys/mf_keycache.c:
        Indentation changes
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/my_os2cond.c:
        Fix to MySQL coding style
        Optimized functions
      mysys/thr_lock.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      mysys/thr_mutex.c:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/instance.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      server-tools/instance-manager/thread_registry.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/ha_federated.cc:
        Use octet2hex()
      sql/ha_ndbcluster.cc:
        Removed not used variable
      sql/handler.cc:
        Simplify code
        Use *NONE* instead of 'none' for not existing storage engine
        Ensure we call commit_by_xid or rollback_by_xid for all engines, even if one engine has failed
      sql/item.h:
        Remove not needed test for *ref.  (If ref is set, it should never point at 0)
      sql/item_func.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
        Simplify code
        More comments
        Require that last argument to find_and_check_access() is given
        (Made code shorter and faster)
      sql/item_strfunc.cc:
        Changed CHAR() to return result in binary collation
        CHAR(X*65536+Y*256+Z) is now equal to CHAR(X,Y,Z) independent of the character set for CHAR()
        
        Bar will shortly add the following syntax:
        CHAR(.... USING character_set)
        and ensure that
        CONVERT(CHAR(....) USING utf8) cuts not legal utf8 strings
        Use ocet2hex()
      sql/item_strfunc.h:
        CHAR() now returns a binary string
      sql/log_event.cc:
        Use octet2hex()
        Simplify code
      sql/parse_file.cc:
        Indentation fixes
        Use for() instead of while()
      sql/password.c:
        Make octet2hex() more generally usable by returning pointer to end 0
      sql/slave.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_base.cc:
        Indentation fixes
      sql/sql_insert.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_manager.cc:
        Test for both ETIMEDOUT and ETIME from pthread_cond_timedwait()
      sql/sql_parse.cc:
        Don't check thd->db when checking for function privileges
      sql/sql_prepare.cc:
        Fixed wrong merge
      sql/sql_select.cc:
        Fixed new bug for NOT BETWEEN X and X
      sql/sql_show.cc:
        Removed not used variable
      sql/sql_table.cc:
        Indentation fixed
        Removed DBUG_PRINT that is obvious from context
      sql/sql_view.cc:
        Simplify code
      sql/unireg.cc:
        Use octet2hex()
      d6ccd7c7
  24. 06 Oct, 2005 1 commit
    • unknown's avatar
      Review of code pushed since last 5.0 pull: · 872a537c
      unknown authored
      Ensure that ccache is also used for C programs
      mysql: Ensure that 'delimiter' works the same way in batch mode as in normal mode
      mysqldump: Change to use ;; (instead of //) as a stored procedure/trigger delimiter
      Fixed test cases by adding missing DROP's and rename views to be of type 'v#'
      Removed MY_UNIX_PATH from fn_format()
      Removed current_db_used from TABLE_LIST
      Removed usage of 'current_thd' in Item_splocal
      Removed some compiler warnings
      A bit faster longlong2str code
      
      
      
      BUILD/FINISH.sh:
        Ensure that ccache is also used for C programs
      BUILD/SETUP.sh:
        Ensure that ccache is also used for C programs
      client/mysql.cc:
        More debugging
        Ensure that 'delimiter' works the same way in batch mode as in normal mode.
        Compare 'delimiter' command case-insensitive.
        The above fixes the delimiter bugs so that we can now use ;; as a trigger/SP function delimiter in mysqldump.
      client/mysqldump.c:
        Indentation fixes
        Use ;; as a delmimiter for stored procedures and triggers instead of //
      client/mysqltest.c:
        Indentation fixes
      include/my_sys.h:
        Remove not needed MY_UNIX_PATH parameter
      mysql-test/r/alter_table.result:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/r/func_str.result:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/r/information_schema.result:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/r/information_schema_inno.result:
        Drop all used tables
      mysql-test/r/multi_statement.result:
        Drop used tables
      mysql-test/r/mysql.result:
        Add error messages to result
      mysql-test/r/mysqldump.result:
        ;; is now used as SP/trigger delimiter
      mysql-test/r/mysqlshow.result:
        Drop used tables
      mysql-test/r/temp_table.result:
        Drop used views
        Rename views to v#
      mysql-test/t/alter_table.test:
        Better to reuse mysqltest database (test didn't properly delete mysqltest1 at start)
      mysql-test/t/func_str.test:
        More testing of CONV() (to ensure that longlong2str() works correctly)
      mysql-test/t/information_schema.test:
        Drop all used tables and views
        Rename view tables to 'v#' to ensure that if this test fails, not a lot of other test fails
      mysql-test/t/information_schema_inno.test:
        Drop all used tables
      mysql-test/t/multi_statement.test:
        Drop used tables
      mysql-test/t/mysql.test:
        Add error messages to result
      mysql-test/t/mysqlshow.test:
        Drop used tables
      mysql-test/t/temp_table.test:
        Drop used views
        Rename views to v#
      mysys/mf_format.c:
        Remove not needed MY_UNIX_PATH parameter
        (This goes against how fn_format() is supposed to work and also conflicts with other options like MY_RETURN_REAL_PATH)
      sql/ha_federated.cc:
        Removed extra empty line
      sql/item.cc:
        Use 'str_value' instead of 'str_value_ptr' to hold result for Item_splocal
        Remove some calls to 'thd' in Item_splocal by making 'thd' a class variable
        One doesn't have to set 'null_value' when calling 'is_null()'
      sql/item.h:
        Add THD as a class variable to Item_splocal
        Use 'str_value' instead of 'str_value_ptr' to hold temp result
        Fixed bug in Item_hex when used in CAST()
      sql/item_func.cc:
        Optimize new code
      sql/log_event.cc:
        Move 'to_unix_path()' out of fn_format()
      sql/opt_range.cc:
        Simplify code
      sql/sp_head.cc:
        Ensure that Item_splocal has thd set before we call '->this_item()'
      sql/sql_class.cc:
        Return error if Statement::insert() fails in either hash_insert()
      sql/sql_parse.cc:
        Remove 'current_db_used' as we can trivially check if db table qualifier was used without this.
        Simplify code
      sql/sql_prepare.cc:
        Use enum instead of const int, to avoid ugly code for VC++
      sql/structs.h:
        Remove compiler warnings when using STRING_WITH_LEN() with constant strings.
      sql/table.cc:
        Fixed indentation
      sql/table.h:
        Remove not needed current_db_used
      strings/decimal.c:
        Simplify code
      strings/longlong2str-x86.s:
        A bit faster longlong2str.
        (Took some ideas from Peter Gulutzan's code)
      strings/my_strtoll10.c:
        Simplify code for MetroWerks compiler
      872a537c
  25. 27 Sep, 2005 2 commits
    • unknown's avatar
      BUG #7815 - Post-review fixes required for push. · d3a2e432
      unknown authored
      client/mysqldump.c:
        BUG #7815
        
        Pre-push fixes requested per Sergei's review.
      d3a2e432
    • unknown's avatar
      BUG #7815 · 96c43505
      unknown authored
      Changes per serg to http://lists.mysql.com/internals/30281
      
      Re-enabled --delayed-insert
      
      
      client/mysqldump.c:
        BUG #7815 
        
        Changes per serg on patch: http://lists.mysql.com/internals/30281
        
        1. Re-enabled --delayed-insert
             - modified options, removed code that was in place until bug was 
               fixed    
        2. Moved the call to get_table_structure to dump_table 
          - Use added 'ignore_flag' variable to determine what exactly is
            being ignored - whole table or just delayed insert ability
        3. Changed return type of ignore_table to char with byte value that
           determines what exactly is being ignored - the whole table, or
           delayed inserts
        4. Added ignore_table flags IGNORE_DATA and IGNORE_INSERT_DELAYED
        5. Added logic in get_table_structure to not append INSERT data text
           if the table's data isn't going to be dumped because the return
           value from ignore_table is IGNORE_DATA
        6. Changed the name of numFields to numfields. Studly caps aren't
           consistent with the rest of the code!
        7. Added inclusive list to check_if_ignore_table to set the flag to
           IGNORE_INSERT_DELAYED if the table type doesn't support delayed
           inserts.
        8. More documentation
      mysql-test/r/mysqldump.result:
        BUG #7815 new results
      mysql-test/r/mysqldump-max.result:
        BUG #7815
        
        New test results
      mysql-test/t/mysqldump-max.test:
        BUG #7815
        New test for testing if insert delayed is applied to tables that support
        it in mysqldump, but only if all storage engines in test have been compiled
        in
      96c43505
  26. 14 Sep, 2005 2 commits
  27. 13 Sep, 2005 1 commit
  28. 08 Sep, 2005 2 commits
    • unknown's avatar
      BUG #12597 This is a complete patch (2nd) containing fixes per Serg's review · 4e8d6424
      unknown authored
      client/mysqldump.c:
        BUG #12597
        - Dump triggers after data dump of each table
        - created dump_triggers_for_table function
        - added space between "MODE" and "*/"
      mysql-test/r/mysqldump.result:
        Tests to test BUG #12597
      mysql-test/t/mysqldump.test:
        BUG #12597
        - New tests to test bug #12597
      4e8d6424
    • unknown's avatar
      BUG #9056 Changes to patch #2 per Serg's review · 21c1d0c9
      unknown authored
      client/mysqldump.c:
        BUG #9056 Fixes per serg
        * if opt_lock for locking mysql.proc
        * calling mysql_query_with_error_report where needed
        * print functions same way as procs, file bug about commented functions
      mysql-test/r/mysqldump.result:
        BUG #9056 New results
      mysql-test/t/mysqldump.test:
        BUG #9056 Removed redirect, simplified, dump in results, per Serg
      21c1d0c9
  29. 03 Sep, 2005 1 commit
    • unknown's avatar
      BUG #9056 Added --routines flag to mysqldump to enable mysqldump to be able · d09054d1
      unknown authored
      to dump PROCEDURES and FUNCTIONS.
      
      
      client/mysqldump.c:
        BUG #9056, added dumping of functions/procs to mysqldump
        - added opt_routines (--routines/-R)
        - added dump_routines_for_db, function that dumps proc and funcs
        - added calling of dump_routines to dump_all_tables_in_db and dump_selected_tables
      mysql-test/r/mysqldump.result:
        BUG #9056 new test results for mysqldump --routines
      mysql-test/t/mysqldump.test:
        BUG #9056 New tests for mysqldump --routines
      d09054d1
  30. 24 Aug, 2005 1 commit
    • unknown's avatar
      Several fixes for Netware. · 2451d94f
      unknown authored
      client/client_priv.h:
        Added option auto close for Netware.
      client/mysql.cc:
        Added option auto close for Netware.
      client/mysqladmin.c:
        Added option auto close for Netware.
      client/mysqlbinlog.cc:
        Added option auto close for Netware.
      client/mysqlcheck.c:
        Added option auto close for Netware.
      client/mysqldump.c:
        Added option auto close for Netware.
      client/mysqlimport.c:
        Added option auto close for Netware.
      client/mysqlshow.c:
        Added option auto close for Netware.
      client/mysqltest.c:
        Fixed help messages for Netware.
      extra/my_print_defaults.c:
        Fixed help messages for Netware.
      extra/perror.c:
        Fixed help messages for Netware.
      extra/resolve_stack_dump.c:
        Fixed help messages for Netware.
      include/help_end.h:
        Fixed help messages for Netware.
      include/help_start.h:
        Fixed help messages for Netware.
      isam/isamchk.c:
        Added auto close of window for Netware
      isam/pack_isam.c:
        Added auto close of window for Netware
      myisam/myisamchk.c:
        Added auto close of window for Ne...
      2451d94f
  31. 31 Jul, 2005 1 commit
    • unknown's avatar
      Fixes during review of new pushed code · f5589f21
      unknown authored
      Change bool in C code to my_bool
      Added to mysqltest --enable_parsning and --disable_parsing to avoid to have to comment parts of tests
      Added comparison of LEX_STRING's and use this to compare file types for view and trigger files.
      
      
      client/client_priv.h:
        Added OPT_TRIGGERS (to get rid of compiler warning)
      client/mysql.cc:
        Added cast to get rid of compiler warning
      client/mysqldump.c:
        Added OPT_TRIGGERS (to get rid of compiler warning)
        Abort if we can't write to outfile (even if --ignore-errors is given)
      client/mysqltest.c:
        Added --enable_parsning and --disable_parsing to avoid to have to comment parts of tests
      include/my_sys.h:
        Make my_progname const
      include/my_time.h:
        Avoid using 'bool' in C programs
      mysql-test/lib/init_db.sql:
        Align with mysql_create_system_tables
        (Ideally this file should be auto-generated from the above script)
      mysql-test/r/mysqltest.result:
        Test for --enable_parsing
      mysql-test/r/variables.result:
        Update results after fix for ...
      f5589f21
  32. 29 Jul, 2005 1 commit
    • unknown's avatar
      Added sql_mode saving to mysql_dump (BUG#5891, part 2) · 3c8f29cd
      unknown authored
      client/client_priv.h:
        add OPT_ for --trigger parameter
      client/mysqldump.c:
        fixed short simbol for trigger
        fixed lines break for more compiler compatibility
        added sql_mode output
        added comments
        made protection of trigger and view restoring commands from execution by old versions of mysql
      mysql-test/r/mysqldump.result:
        changed test, to test sql_mode
      mysql-test/r/sp.result:
        now sql_mode preserved in SP
      mysql-test/t/mysqldump.test:
        changed test, to test sql_mode
      mysql-test/t/sp.test:
        now sql_mode preserved in SP
      sql/set_var.cc:
        fixed comment
      3c8f29cd