An error occurred fetching the project authors.
  1. 12 Oct, 2005 1 commit
    • unknown's avatar
      sql_yacc.yy: · be559ad6
      unknown authored
        Bug #10308: Parse 'purge master logs' with subselect correctly.
      subselect.test:
        Bug #10308: Test for 'purge master logs' with subselect.
      subselect.result:
        Bug #10308: Test result for 'purge master logs' with subselect.
      
      
      mysql-test/r/subselect.result:
        Bug #10308: Test result for 'purge master logs' with subselect.
      mysql-test/t/subselect.test:
        Bug #10308: Test for 'purge master logs' with subselect.
      sql/sql_yacc.yy:
        Bug #10308: Parse 'purge master logs' with subselect correctly.
      be559ad6
  2. 16 Aug, 2005 2 commits
    • unknown's avatar
      subselect.result: · 4161d7cb
      unknown authored
        Added missing drop statement
      subselect.test:
        Added missing drop statement.
      
      
      mysql-test/t/subselect.test:
        Added missing dro statement.
      mysql-test/r/subselect.result:
        Added missing drop statement
      4161d7cb
    • unknown's avatar
      sql_select.cc: · 4b49cbfb
      unknown authored
        Fixed bug #11479.
        The JOIN::reinit method cannot call setup_tables
        after the optimization phase since this function
        removes some optimization settings for joined
        tables. E.g. it resets values of the null_row flag to 0.
      subselect.result, subselect.test:
        Added a test case for bug #11479.
      
      
      mysql-test/t/subselect.test:
        Added a test case for bug #11479.
      mysql-test/r/subselect.result:
        Added a test case for bug #11479.
      sql/sql_select.cc:
        Fixed bug #11479.
        The JOIN::reinit method cannot call setup_tables
        after the optimization phase since this function
        removes some optimization settings for joined
        tables. E.g. it resets values of the null_row flag to 0.
      4b49cbfb
  3. 13 Aug, 2005 1 commit
    • unknown's avatar
      fixed convertion and handling IN subqueries with rows (BUG#11867) · 19b4760f
      unknown authored
      mysql-test/r/subselect.result:
        testst of IN subqueries with row
      mysql-test/t/subselect.test:
        tests of ion subqueries with row
      sql/item.h:
        add method to prevent of removing Item_ref_null_helper from HAVING
      sql/item_cmpfunc.h:
        Prevented removing of Item_test_isnotnull from HAVING
      sql/item_subselect.cc:
        fixed converting row IN subqueries
      sql/sql_select.cc:
        fixed debug print
      19b4760f
  4. 08 Aug, 2005 2 commits
    • unknown's avatar
      subselect.test, subselect.result: · 6f0a6260
      unknown authored
        Added a test case for bug #12392.
      item_cmpfunc.cc:
        Fixed bug #12392.
        Missing handling of rows containing NULL components
        when evaluating IN predicates caused a crash.
      
      
      sql/item_cmpfunc.cc:
        Fixed bug #12392.
        Missing handling of rows containing NULL components
        when evaluating IN predicates caused a crash.
      mysql-test/r/subselect.result:
        Added a test case for bug #12392.
      mysql-test/t/subselect.test:
        Added a test case for bug #12392.
      6f0a6260
    • unknown's avatar
      Review of new pushed code · 97988099
      unknown authored
      - Fixed some error condtion when handling dates with 'T'
      - Added extra test for bug #11867 (Wrong result with "... WHERE ROW( a, b ) IN ( SELECT DISTINCT a, b WHERE ...)" to show it's not yet fixed
      - Safety fixes and cleanups
      
      
      mysql-test/r/subselect.result:
        Added extra test case to test case for bug #11867
        (Result shows that current code is not yet right and needs to be fixed)
      mysql-test/r/type_datetime.result:
        More tests for dates of type CCYYMMDDTHHMMSS
      mysql-test/t/subselect.test:
        Added extra test case to test case for bug #11867
      mysql-test/t/type_datetime.test:
        More tests for dates of type CCYYMMDDTHHMMSS
      sql-common/my_time.c:
        Fixed handling of dates of type CCYYMMDDTHHMMSS
        (Old code couldn't handle 2003-0304 or 2003-0003-02)
      sql/slave.cc:
        Indentation cleanup
      sql/sql_parse.cc:
        Added test of return value of get_system_var()
      sql/sql_select.cc:
        Removed unnecessary call to field->table->maybe_null
      sql/sql_union.cc:
        Indentation fixes
      97988099
  5. 07 Aug, 2005 1 commit
    • unknown's avatar
      subselect.result: · 84d34d9d
      unknown authored
        Added test case for bug #11867.
        Fixed results for two existing test cases.
      subselect.test:
        Added test case for bug #11867.
      item_subselect.cc:
        Fixed bug #11867.
        Added missing code in Item_in_subselect::row_value_transformer
        that caused problems for queries with
        ROW(elems) IN (SELECT DISTINCT cols FROM ...).
      
      
      sql/item_subselect.cc:
        Fixed bug #11867.
        Added missing code in Item_in_subselect::row_value_transformer
        that caused problems for queries with
        ROW(elems) IN (SELECT DISTINCT cols FROM ...).
      mysql-test/t/subselect.test:
        Added test case for bug #11867.
      mysql-test/r/subselect.result:
        Added test case for bug #11867.
        Fixed results for two existing test cases.
      84d34d9d
  6. 12 Jul, 2005 1 commit
  7. 16 May, 2005 1 commit
  8. 30 Mar, 2005 1 commit
    • unknown's avatar
      postreview changes · dda97623
      unknown authored
      fixed bug in IN/ALL/ANY subqeries with HAVING clause (BUG#9350)
      
      
      mysql-test/r/subselect.result:
        added new subquery tests to make code covarage better
      mysql-test/t/subselect.test:
        added new subquery tests to make code covarage better
      sql/item_subselect.cc:
        fixed typo in comment
        removed unused code
        fixed bug with HAVING clause detectiuon (BUG#9350)
        postreview changes
      dda97623
  9. 10 Mar, 2005 1 commit
    • unknown's avatar
      fixed left expression of IN/ALL/ANY subquery transformation support (BUG#8888) · 070fe467
      unknown authored
      mysql-test/r/subselect.result:
        result changing
        fixed last test
        test of transformation of left expression of subquery
      mysql-test/t/subselect.test:
        fixed last test
        test of transformation of left expression of subquery
      sql/item_subselect.cc:
        fixfields made for left part of IN/ALL/ANY subquery before calling cols() to detect type of transformation (scalar or row)
        similar action of both transformation moved to separate function
      sql/item_subselect.h:
        optimised field initialization and new method
      070fe467
  10. 14 Feb, 2005 1 commit
  11. 12 Feb, 2005 1 commit
    • unknown's avatar
      Fix for BUG#8218: · 84d11996
      unknown authored
      Remove TMP_TABLE_PARAM::copy_funcs_it. TMP_TABLE_PARAM is a member of JOIN which is 
      copied via memcpy, and List_iterator_fast TMP_TABLE_PARAM::copy_funcs_it ends up 
      pointing to the wrong List.
      
      
      mysql-test/r/subselect.result:
        Testcase for BUG#8218
      mysql-test/t/subselect.test:
        Testcase for BUG#8218
      sql/sql_select.cc:
        Fix for BUG#8218: Create/use own iterator since TMP_TABLE_PARAM::copy_funcs_it is removed.
      84d11996
  12. 09 Feb, 2005 1 commit
  13. 06 Feb, 2005 1 commit
    • unknown's avatar
      fixed test 'subselect' in case when innodb is not compiled in (thanks HF who niticed it) · 3455bc53
      unknown authored
      mysql-test/r/subselect.result:
        test depends on innodb moved from 'subselect' to 'subselect_innodb'
      mysql-test/r/subselect_innodb.result:
        test depends on innodb moved from 'subselect' to 'subselect_innodb'
      mysql-test/t/subselect.test:
        test depends on innodb moved from 'subselect' to 'subselect_innodb'
      mysql-test/t/subselect_innodb.test:
        test depends on innodb moved from 'subselect' to 'subselect_innodb'
      3455bc53
  14. 26 Jan, 2005 1 commit
    • unknown's avatar
      fixed cleanup of result object of subqueries. (BUG#8125) · 755c9aab
      unknown authored
      mysql-test/r/subselect.result:
        cleaning up of results of subselects test
      mysql-test/t/subselect.test:
        cleaning up of results of subselects test
      sql/item_subselect.cc:
        call result object cleupup on engine cleunup
      sql/sql_class.cc:
        added cleanup of select_max_min_finder_subselect
      sql/sql_class.h:
        added cleanup of select_max_min_finder_subselect
      755c9aab
  15. 24 Jan, 2005 3 commits
    • unknown's avatar
      fixed way of forward reference detection to support literal constant (BUG#8025) · 38e664cf
      unknown authored
      mysql-test/r/subselect.result:
        Forward reference detection
      mysql-test/t/subselect.test:
        Forward reference detection
      sql/item.cc:
        now forward reference is detected via ref_pointer_array, because some literal constants are 'fixed' just after creation
      sql/sql_base.cc:
        fill ref_pointer_array with zerows for forward reference detection.
      38e664cf
    • unknown's avatar
      check that row elements have the same dimention that SELECT list elements in... · 91827869
      unknown authored
      check that row elements have the same dimention that SELECT list elements in comporison between rows and subqueries added (BUG#8022)
      
      
      mysql-test/r/subselect.result:
        Comparison subquery and row with nested rows
      mysql-test/t/subselect.test:
        Comparison subquery and row with nested rows
      sql/item_subselect.cc:
        check that row elements have the same dimention that SELECT list elements
      91827869
    • unknown's avatar
      fixed column number fetchinmg for subqueries. (BUG#8020) · d514a06a
      unknown authored
      fixed cols() method call (it have to be called only after fix_fields())
      
      
      mysql-test/r/subselect.result:
        Comparison subquery with * and row
      mysql-test/t/subselect.test:
        Comparison subquery with * and row
      sql/item_cmpfunc.h:
        initialization allowed_arg_cols for autodetection
      sql/item_func.cc:
        support of allowed_arg_cols autodetection by first argument
      sql/item_func.h:
        commant
      sql/item_subselect.cc:
        correct column number fetching for subqueries
      sql/sql_lex.h:
        method to check that UNION is prepared
      d514a06a
  16. 18 Jan, 2005 1 commit
    • unknown's avatar
      Fix for BUG#7885 · 2e50981a
      unknown authored
      mysql-test/r/subselect.result:
        Testcase for BUG#7885
      mysql-test/t/subselect.test:
        Testcase for BUG#7885
      sql/item_subselect.cc:
        Fix for BUG#7885: In Item_subselect::fix_fields, return error if engine->prepare fails.
        Also removed redundant code line.
      2e50981a
  17. 26 Dec, 2004 2 commits
    • unknown's avatar
      subselect.result, subselect.test: · a9eef185
      unknown authored
        Added a couple of new test cases for bug #7351.
      
      
      mysql-test/t/subselect.test:
        Added a couple of new test cases for bug #7351.
      mysql-test/r/subselect.result:
        Added a couple of new test cases for bug #7351.
      a9eef185
    • unknown's avatar
      subselect.result, subselect.test: · a4d840a0
      unknown authored
        Added test cases for bug #7351.
      item_cmpfunc.cc:
        Fixed bug #7351: incorrect result for a query with a
        subquery returning empty set.
        If in the predicate v IN (SELECT a FROM t WHERE cond)
        v is null, then the result of the predicate is either
        INKNOWN or FALSE. It is FALSE if the subquery returns
        an empty set.
      item_subselect.cc:
        Fixed bug #7351: incorrect result for a query with a
        subquery returning empty set.
        The problem was due to not a quite legal transformation
        for 'IN' subqueries. A subquery containing a predicate
        of the form
        v IN (SELECT a FROM t WHERE cond)
        was transformed into
        EXISTS(SELECT a FROM t WHERE cond AND (a=v OR a IS NULL)).
        Yet, this transformation is valid only if v is not null.
        If v is null, then, in the case when
        (SELECT a FROM t WHERE cond) returns an empty set the value
        of the predicate is FALSE, otherwise the result of the
        predicate is INKNOWN.
        The fix resolves this problem by changing the result
        of the transformation to
        EXISTS(SELECT a FROM t WHERE cond AND (v IS NULL OR (a=v OR a IS NULL)))
        in the case when v is nullable.
        The new transformation prevents applying the lookup
        optimization for IN subqueries. To make it still
        applicable we have to introduce guarded access methods.
      
      
      sql/item_subselect.cc:
        Fixed bug #7351: incorrect result for a query with a
        subquery returning empty set.
        The problem was due to not a quite legal transformation
        for 'IN' subqueries. A subquery containing a predicate
        of the form
        v IN (SELECT a FROM t WHERE cond)
        was transformed into
        EXISTS(SELECT a FROM t WHERE cond AND (a=v OR a IS NULL)).
        Yet, this transformation is valid only if v is not null.
        If v is null, then, in the case when
        (SELECT a FROM t WHERE cond) returns an empty set the value
        of the predicate is FALSE, otherwise the result of the
        predicate is INKNOWN.
        The fix resolves this problem by changing the result
        of the transformation to
        EXISTS(SELECT a FROM t WHERE cond AND (v IS NULL OR (a=v OR a IS NULL)))
        in the case when v is nullable.
        The new transformation prevents applying the lookup
        optimization for IN subqueries. To make it still
        applicable we have to introduce guarded access methods.
      sql/item_cmpfunc.cc:
        Fixed bug #7351: incorrect result for a query with a
        subquery returning empty set.
        If in the predicate v IN (SELECT a FROM t WHERE cond)
        v is null, then the result of the predicate is either
        INKNOWN or FALSE. It is FALSE if the subquery returns
        an empty set.
      mysql-test/t/subselect.test:
        Added test cases for bug #7351.
      mysql-test/r/subselect.result:
        Added test cases for bug #7351.
      a4d840a0
  18. 14 Dec, 2004 1 commit
    • unknown's avatar
      Clean-up. · e938cfce
      unknown authored
      TYPE=MyISAM replaced with ENGINE=MyISAM.
      
      
      e938cfce
  19. 12 Dec, 2004 1 commit
    • unknown's avatar
      fixed optimized SOME subquery · a9457c57
      unknown authored
      mysql-test/r/subselect.result:
        correct results of SOME subquery
      sql/item_cmpfunc.cc:
        some comments added
        fixed optimized SOME subquery
      a9457c57
  20. 11 Dec, 2004 1 commit
    • unknown's avatar
      new reference which refer to current value not to result used for resolving outer · 3ce0df59
      unknown authored
      refernces if subqueri is not in HAVING clause (BUG#7079)
        and the same used for subquery transformetion
      
      
      mysql-test/r/subselect.result:
        reference on changable fields from subquery
      mysql-test/t/subselect.test:
        reference on changable fields from subquery
      sql/item.cc:
        new reference which refer to current value not to result used
      sql/item.h:
        new reference which refer to current value not to result used
      sql/item_subselect.cc:
        new reference which refer to current value not to result used
      3ce0df59
  21. 25 Nov, 2004 1 commit
  22. 22 Nov, 2004 1 commit
    • unknown's avatar
      Fix for bug #6462 "Same request on same data returns different · 4389be75
      unknown authored
      results." a.k.a. "Proper cleanup of subqueries is missing for SET and DO
      statements". (Version #2 with after-review fixes).
      
      To perform proper cleanup for statements that can contain subqueries 
      but don't have main select we must call free_undelaid_joins().
      
      
      mysql-test/r/subselect.result:
        Added test for bug #6462 "Same request on same data returns different
        results." a.k.a. "Proper cleanup of subqueries is missing for SET and DO
        statements".
      mysql-test/t/subselect.test:
        Added test for bug #6462 "Same request on same data returns different
        results." a.k.a. "Proper cleanup of subqueries is missing for SET and DO
        statements".
      sql/set_var.cc:
        Added missing cleanup of joins used in subqueries to SET statement.
      sql/sql_do.cc:
        Added missing cleanup of joins used in subqueries to DO statement.
      4389be75
  23. 18 Nov, 2004 1 commit
    • unknown's avatar
      reporting empty result added in case of max/min optimisation of ALL/ANY/SOME subqueries · 9438c2ca
      unknown authored
      fixed null processing in NOT operation used in ALL subquery (Bug #6247)
      
      
      mysql-test/r/subselect.result:
        new tests of ALL/ANY wiews
      mysql-test/t/subselect.test:
        new tests of ALL/ANY wiews
      sql/item_cmpfunc.cc:
        fixed special NOT ALL processing
        fixed processing max/min optimized subqueries with empty results (added methods to detect empty results) and special NOP operation to process them for SOME/ANY sobqueries
      sql/item_cmpfunc.h:
        fixed processing max/min optimized subqueries with empty results (added methods to detect empty results) and special NOP operation to process them for SOME/ANY sobqueries
      sql/item_subselect.cc:
        reporting empty result added for max/min subqueries
      sql/item_subselect.h:
        reporting empty result added for max/min subqueries
      sql/item_sum.cc:
        reporting empty result added fox max/min aggregate functions
      sql/item_sum.h:
        reporting empty result added fox max/min aggregate functions
      sql/sql_class.cc:
        reporting empty result added for max/min subqueries
      sql/sql_parse.cc:
        reporting empty result added for max/min subqueries
      sql/sql_union.cc:
        reporting empty result added for max/min subqueries
      9438c2ca
  24. 16 Nov, 2004 1 commit
    • unknown's avatar
      backport Serg's fix of FT interface (BUG#6523) · 70ed3160
      unknown authored
      mysql-test/r/subselect.result:
        subqueries with full text search
      mysql-test/t/subselect.test:
        subqueries with full text search
      sql/ha_myisam.h:
        backport Serg's fix of FT interface
      sql/handler.h:
        backport Serg's fix of FT interface
      sql/opt_range.h:
        backport Serg's fix of FT interface
      sql/sql_select.cc:
        comment for previous patch
      70ed3160
  25. 15 Nov, 2004 2 commits
    • unknown's avatar
      fixed joincleunup to avoid double deletin tables, and too earlyfull cleanup in case of EXPLAIN · dd93baa0
      unknown authored
      fixed cleunup of TMP_TABLE_PARAM
      (BUG#6406)
      
      
      mysql-test/r/subselect.result:
        primary query with temporary table and subquery with groupping
      mysql-test/t/subselect.test:
        primary query with temporary table and subquery with groupping
      sql/sql_class.h:
        fixed cleunup of TMP_TABLE_PARAM
      sql/sql_select.cc:
        uncacheable test made simplier
        fixed joincleunup to avoid double deletin tables, and too earlyfull cleanup in case of EXPLAIN
      dd93baa0
    • unknown's avatar
      moved procedure list initialization (BUG#6517) · b685909d
      unknown authored
      mysql-test/r/subselect.result:
        Subselect in non-select command just after connection
      mysql-test/t/subselect.test:
        Subselect in non-select command just after connection
      sql/sql_lex.cc:
        moved procedure initialization
      sql/sql_parse.cc:
        moved procedure initialization
      b685909d
  26. 27 Oct, 2004 1 commit
    • unknown's avatar
      removed incorrect error message about aggregate functions · 464da8f1
      unknown authored
      improved mechanisn of detection posibility to be NULL for single row queries
      switched off substitution optimisation for single row subqueries in PS due to problem in resolving substituted expressions
      (changes to make subselects test working with PS protocol)
      
      
      mysql-test/r/subselect.result:
        removed incorrect error message about aggregate functions
        improved mechanisn of detection posibility to be NULL for single row queries
      mysql-test/t/subselect.test:
        removed incorrect error message about aggregate functions
      sql/item_subselect.cc:
        removed incorrect error message about aggregate functions
        switched off substitution optimisation for single row subqueries in PS due to problem in resolving substituted expressions
        improved mechanisn of detection posibility to be NULL for single row queries
      sql/item_subselect.h:
        new method to help in NULL ability detection
      464da8f1
  27. 22 Oct, 2004 1 commit
    • unknown's avatar
      A fix and test case for Bug#6088 "FOUND_ROWS returns wrong values for · 9b5cf946
      unknown authored
      prepared statements when LIMIT is used" and post-review comments.
      The fix changes the approach we calculate the need for ORDER BY 
      in UNION: the previous was not PS friendly, as it damaged SELECT_LEX 
      options in case of single select.
      
      
      mysql-test/r/ps.result:
        Test results fixed: the test case for Bug#6088
      mysql-test/r/subselect.result:
        Test results fixed: now we don't perform ORDER BY for parts of UNION
        if there is no LIMIT clause.
      mysql-test/t/ps.test:
        A test case for Bug#6088 "FOUND_ROWS returns wrong values for
         prepared statements when LIMIT is used".
      sql/sql_union.cc:
        The actual fix for Bug#6088:
        - don't modify SELECT_LEX'es
        - use boolean variable can_skip_order_by to check if we can skip
          ORDER BY in UNION
      9b5cf946
  28. 17 Sep, 2004 1 commit
    • unknown's avatar
      fixed error handling if creating derived table failed · 580f12cc
      unknown authored
      single row subquery always can return NULL (no rows found) (BUG#5590)
      
      
      mysql-test/r/subselect.result:
        maybe_null flag returning by subquwery for temporary table creation
      mysql-test/t/subselect.test:
        maybe_null flag returning by subquwery for temporary table creation
      sql/item.cc:
        storing maybe_null in type holder
      sql/item_subselect.cc:
        single row subquery always can return NULL (no rows found)
      sql/sql_derived.cc:
        fixed error handling if creating derived table failed
      580f12cc
  29. 06 Sep, 2004 1 commit
    • unknown's avatar
      fixed temporary table processing expresions of subqueries and removed wrong... · 77ee831d
      unknown authored
      fixed temporary table processing expresions of subqueries and removed wrong restrictions of field resolving (BUG#5326)
      
      
      mysql-test/r/subselect.result:
        tests of fields resolving
      mysql-test/t/subselect.test:
        tests of fields resolving
      sql/item.cc:
        fixed fild resolving
      sql/item_subselect.cc:
        removed aneed call
      sql/sql_base.cc:
        fixed case whan we scan un-fixfielded fields
      sql/sql_select.cc:
        fixed temporary table processing expresions of subqueries
      77ee831d
  30. 24 Aug, 2004 2 commits
  31. 23 Aug, 2004 1 commit
    • unknown's avatar
      after review fixes: · 13f7338a
      unknown authored
       allowed parsing of table fields inside aggregate functions
       added new tests of fields resolving in grouping
      
      
      mysql-test/r/func_gconcat.result:
        allowed parsing of table fields inside aggregate functions
      mysql-test/r/subselect.result:
        added new tests of fields resolving in grouping
      mysql-test/t/func_gconcat.test:
        allowed parsing of table fields inside aggregate functions
      mysql-test/t/subselect.test:
        added new tests of fields resolving in grouping
      sql/item_subselect.cc:
        allowed parsing of table fields inside aggregate functions
      13f7338a
  32. 21 Aug, 2004 1 commit
    • unknown's avatar
      Proposed fix for bug #5003 (subselect with MIN() and LIKE crashes server) · ac4c0538
      unknown authored
      We have next problem here:
      active_index is wrong in the subselect's handler on the second val_int() call.
      Optimizer sees that we can use index-read for that kind of condition,
      and matching_cond() (sql/opt_sum.cc) doesn't. I suspect, proper solution is
      to add appropriate code to the matching_cond() but now just added
      missed initialization.
      
      
      mysql-test/r/subselect.result:
        Appropriate test result
      mysql-test/t/subselect.test:
        Test case added
      sql/records.cc:
        index's initialization added
      ac4c0538
  33. 19 Aug, 2004 1 commit