1. 19 Nov, 2007 2 commits
  2. 10 Nov, 2007 1 commit
  3. 09 Nov, 2007 1 commit
    • kaa@polly.(none)'s avatar
      Fix for bug #32202: ORDER BY not working with GROUP BY · 8c193678
      kaa@polly.(none) authored
      The bug is a regression introduced by the fix for bug30596. The problem
      was that in cases when groups in GROUP BY correspond to only one row,
      and there is ORDER BY, the GROUP BY was removed and the ORDER BY
      rewritten to ORDER BY <group_by_columns> without checking if the
      columns in GROUP BY and ORDER BY are compatible. This led to
      incorrect ordering of the result set as it was sorted using the
      GROUP BY columns. Additionaly, the code discarded ASC/DESC modifiers
      from ORDER BY even if its columns were compatible with the GROUP BY
      ones.
      
      This patch fixes the regression by checking if ORDER BY columns form a
      prefix of the GROUP BY ones, and rewriting ORDER BY only in that case,
      preserving the ASC/DESC modifiers. That check is sufficient, since the
      GROUP BY columns contain a unique index.
      8c193678
  4. 08 Nov, 2007 2 commits
  5. 07 Nov, 2007 1 commit
    • kaa@polly.(none)'s avatar
      Fix for bug #32103: optimizer crash when join on int and mediumint with · f1a3c364
      kaa@polly.(none) authored
      variable in where clause.
      
      Problem: the new_item() method of Item_uint used an incorrect
      constructor. "new Item_uint(name, max_length)" calls
      Item_uint::Item_uint(const char *str_arg, uint length) which assumes the
      first argument to be the string representation of the value, not the
      item's name. This could result in either a server crash or incorrect
      results depending on usage scenarios.
      
      Fixed by using the correct constructor in new_item():
      Item_uint::Item_uint(const char *str_arg, longlong i, uint length).
      f1a3c364
  6. 05 Nov, 2007 2 commits
  7. 02 Nov, 2007 3 commits
    • kaa@polly.(none)'s avatar
      5.1-specific changes for bug #26215 after merging the patch from 5.0: · 794274ab
      kaa@polly.(none) authored
      - Added trigger tests back.
      - Fixed test cases to match the extended output format of SHOW CREATE ...
      - Replaced 'gptr' with 'uchar *'.
      794274ab
    • kaa@polly.(none)'s avatar
      Merge polly.(none):/home/kaa/src/opt/bug26215/my50-bug26215 · 4b12f943
      kaa@polly.(none) authored
      into  polly.(none):/home/kaa/src/opt/bug26215/my51-bug26215
      4b12f943
    • kaa@polly.(none)'s avatar
      Fix for: · 9cd5f49c
      kaa@polly.(none) authored
        bug #26215: mysql command line client should not strip comments
                    from SQL statements
      and
        bug #11230: Keeping comments when storing stored procedures
      
      With the introduction of multiline comments support in the command line
      client (mysql) in MySQL 4.1, it became impossible to preserve
      client-side comments within single SQL statements or stored routines.
      This feature was useful for monitoring tools and maintenance.
      
      The patch adds a new option to the command line client
      ('--enable-comments', '-c') which allows to preserve SQL comments and
      send them to the server for single SQL statements, and to keep comments
      in the code for stored procedures / functions / triggers.
      
      The patch is a modification of the contributed patch from bug #11230
      with the following changes:
      - code style changes to conform to the coding guidelines
      - changed is_prefix() to my_strnncoll() to detect the DELIMITER
      command, since the first one is case-sensitive and not charset-aware
      - renamed t/comments-51.* to t/mysql_comments.*
      - removed tests for comments in triggers since 5.0 does not have SHOW
      CREATE TRIGGER (those tests will be added back in 5.1).
      
      The test cases are only for bug #11230. No automated test case for bug
      #26215 is possible due to the test suite deficiencies (though the cases
      from the bug report were tested manually).
      9cd5f49c
  8. 21 Oct, 2007 2 commits
    • kaa@polly.(none)'s avatar
      Merge polly.(none):/home/kaa/src/opt/bug28550/my50-bug28550 · d55d3093
      kaa@polly.(none) authored
      into  polly.(none):/home/kaa/src/opt/bug28550/my51-bug28550
      d55d3093
    • kaa@polly.(none)'s avatar
      Bug #28550 "Potential bugs related to the return type of the CHAR function". · 34984111
      kaa@polly.(none) authored
        
      Since, as of MySQL 5.0.15, CHAR() arguments larger than 255 are converted into multiple result bytes, a single CHAR() argument can now take up to 4 bytes. This patch fixes Item_func_char::fix_length_and_dec() to take this into account.
        
      This patch also fixes a regression introduced by the patch for bug21513. As now we do not always have the 'name' member of Item set for Item_hex_string and Item_bin_string, an own print() method has been added to Item_hex_string so that it could correctly be printed by Item_func::print_args().
      34984111
  9. 17 Oct, 2007 3 commits
  10. 16 Oct, 2007 2 commits
  11. 15 Oct, 2007 3 commits
  12. 14 Oct, 2007 2 commits
  13. 13 Oct, 2007 4 commits
  14. 12 Oct, 2007 8 commits
  15. 11 Oct, 2007 4 commits