1. 25 Oct, 2006 1 commit
    • istruewing@chilla.local's avatar
      Bug#22119 - Changing MI_KEY_BLOCK_LENGTH makes a wrong myisamchk · 7dc7af51
      istruewing@chilla.local authored
      When compiling with a default key block size greater than the
      smallest key block size used in a table, checking that table
      failed with bogus errors. The table was marked corrupt. This
      affected myisamchk and the server.
      
      The problem was that the default key block size was used at
      some places where sizes less or equal to the block size of the
      index in check was required.
      
      We do now use the key block size of the particular index
      when checking.
      
      A test case is available for later versions only.
      7dc7af51
  2. 19 Oct, 2006 3 commits
  3. 18 Oct, 2006 1 commit
    • svoj@mysql.com/april.(none)'s avatar
      BUG#23175 - MYISAM crash/repair failed during repair · a2e0059f
      svoj@mysql.com/april.(none) authored
      Repair table could crash a server if there is not sufficient
      memory (myisam_sort_buffer_size) to operate. Affects not only
      repair, but also all statements that use create index by sort:
      repair by sort, parallel repair, bulk insert.
      
      Return an error if there is not sufficient memory to store at
      least one key per BUFFPEK.
      
      Also fixed memory leak if thr_find_all_keys returns an error.
      a2e0059f
  4. 17 Oct, 2006 1 commit
  5. 16 Oct, 2006 1 commit
  6. 13 Oct, 2006 2 commits
  7. 11 Oct, 2006 4 commits
  8. 10 Oct, 2006 1 commit
  9. 09 Oct, 2006 2 commits
    • istruewing@chilla.local's avatar
      Merge chilla.local:/home/mydev/mysql-4.1-bug8283 · 1daa6a71
      istruewing@chilla.local authored
      into  chilla.local:/home/mydev/mysql-4.1-bug8283-one
      1daa6a71
    • istruewing@chilla.local's avatar
      Bug#8283 - OPTIMIZE TABLE causes data loss · 5f08a831
      istruewing@chilla.local authored
      OPTIMIZE TABLE with myisam_repair_threads > 1 performs a non-quick 
      parallel repair. This means that it does not only rebuild all 
      indexes, but also the data file.
      
      Non-quick parallel repair works so that there is one thread per 
      index. The first of the threads rebuilds also the new data file.
      
      The problem was that all threads shared the read io cache on the
      old data file. If there were holes (deleted records) in the table,
      the first thread skipped them, writing only contiguous, non-deleted
      records to the new data file. Then it built the new index so that
      its entries pointed to the correct record positions. But the other
      threads didn't know the new record positions, but put the positions
      from the old data file into the index.
      
      The new design is so that there is a shared io cache which is filled
      by the first thread (the data file writer) with the new contiguous
      records and read by the other threads. Now they know the new record
      positions.
      
      Another problem was that for the parallel repair of compressed
      tables a common bit_buff and rec_buff was used. I changed it so
      that thread specific buffers are used for parallel repair.
      
      A similar problem existed for checksum calculation. I made this
      multi-thread safe too.
      5f08a831
  10. 08 Oct, 2006 1 commit
  11. 06 Oct, 2006 4 commits
  12. 05 Oct, 2006 3 commits
  13. 03 Oct, 2006 7 commits
  14. 02 Oct, 2006 9 commits