- 21 Aug, 2012 2 commits
-
-
unknown authored
The fix backports from MWL#182: Explain running statements the logic that saves the original JOIN_TAB array of a query plan after optimization. This array is later used during EXPLAIN to iterate over the original JOIN plan nodes in the cases when this plan could be changed by early subquery execution during the optimization phase of the outer query.
-
Michael Widenius authored
The crash happend when combining query cache, prepared statements and using a read only cursor. sql/sql_cache.cc: Fixed unlikely error when one adjust query cache size in middle of operation sql/sql_cursor.cc: Disable query cache when using cursors. This fixed lp:1039277 tests/mysql_client_test.c: Test case for lp:1039277
-
- 20 Aug, 2012 1 commit
-
-
Michael Widenius authored
sql/handler.cc: SHOW INNODB STATUS sometimes returns 0 even if it has generated an error. This code is here to catch it until InnoDB some day is fixed. storage/innobase/handler/ha_innodb.cc: Catch at least one of the possible errors from SHOW INNODB STATUS to provide a correct return code. storage/xtradb/handler/ha_innodb.cc: Catch at least one of the possible errors from SHOW INNODB STATUS to provide a correct return code. support-files/my-huge.cnf.sh: Fixed typo
-
- 17 Aug, 2012 2 commits
-
-
unknown authored
-
Michael Widenius authored
Fixed error in test that caused following tests to fail extra/yassl/taocrypt/src/dsa.cpp: Fixed compiler warning by adding cast mysql-test/suite/rpl/t/rpl_start_slave_deadlock_sys_vars.test: We have to first test for have_debug_sync to not start master wrongly plugin/auth_pam/auth_pam.c: Fixed compiler warning sql/sys_vars.h: Fixed compiler warning (Sys_var_max_user_conn is now signed) support-files/compiler_warnings.supp: Don't give warnings for auth_pam.c (Tried to fix it by changing the code, but could not find an easy way to do that on solaris)
-
- 15 Aug, 2012 4 commits
-
-
Michael Widenius authored
Fixed MDEV-366: Assertion `share->reopen == 1' failed in maria_extra on DROP TABLE which is locked twice mysql-test/suite/maria/lock.result: Added test case mysql-test/suite/maria/lock.test: Added test case sql/sql_table.cc: One can't call HA_EXTRA_FORCE_REOPEN on something that may be opened twice. It's safe to remove the call in this case as we will call HA_EXTRA_PREPARE_FOR_DROP for the table anyway. (One nice side effect is that drop is a bit faster as we are not flushing the cache to disk before the drop anymore)
-
Michael Widenius authored
mysql-test/r/partition.result: Added test case mysql-test/t/partition.test: Added test case sql/sql_partition.cc: Do mysql_trans_prepare_alter_copy_data() after all original tables are locked. (We don't want to disable transactions for the original tables, that still may be in the cache) sql/sql_table.cc: Fixed two wrong DBUG_ENTER
-
Michael Widenius authored
-
Michael Widenius authored
sql/item_subselect.cc: Added purecov info sql/sql_select.cc: Added cast storage/innobase/handler/ha_innodb.cc: Added cast storage/xtradb/btr/btr0btr.c: Added buf_block_get_frame_fast() to avoid compiler warning storage/xtradb/handler/ha_innodb.cc: Added cast storage/xtradb/include/buf0buf.h: Innodb has buf_block_get_frame(block) defined as (block)->frame. Didn't want to do a big change to break xtradb as it may use block_get_frame() differently, so I mad this quick hack to patch one compiler warning.
-
- 14 Aug, 2012 2 commits
-
-
Michael Widenius authored
Updated test to also work on 32 bit mysql-test/suite/heap/heap.test: Updated test to also work on 32 bit
-
unknown authored
Starting the SQL thread might deadlock with reading the values of the replication filtering options. The deadlock is due to a lock order violation when the variables are read or set. For example, reading replicate_ignore_table first acquires LOCK_global_system_variables in sys_var::value_ptr and later acquires LOCK_active_mi in Sys_var_rpl_filter::global_value_ptr. This violates the order established when starting a SQL thread, where LOCK_active_mi is acquired before start_slave, and ends up creating a thread (handle_slave_sql) that allocates a THD handle whose constructor acquires LOCK_global_system_variables in THD::init. The solution is to unlock LOCK_global_system_variables before the replication filtering options are set or read. This way the lock order is preserved and the data being read/set is still protected given that it acquires LOCK_active_mi.
-
- 13 Aug, 2012 4 commits
-
-
Michael Widenius authored
-
Michael Widenius authored
client/mysqldump.c: Slave needs to be initialized with 0 dbug/dbug.c: Removed not existing function plugin/semisync/semisync_master.cc: Fixed compiler warning sql/opt_range.cc: thd needs to be set early as it's used in some error conditions. sql/sql_table.cc: Changed to use uchar* to make array indexing portable storage/innobase/handler/ha_innodb.cc: Removed not used variable storage/maria/ma_delete.c: Fixed compiler warning storage/maria/ma_write.c: Fixed compiler warning
-
Sergei Golubchik authored
fix add_identifier() to distinguish between temporary tables (#sql- prefix) and temporary partitions (#TMP# suffix). change add_identifier() to use the same name variant constants as sql_partition.cc does.
-
Sergei Golubchik authored
include mytop in bintars, rpms, and debs. install mysqlbug.1 too.
-
- 11 Aug, 2012 1 commit
-
-
Sergei Golubchik authored
compile oqgraph with -fno-strict-aliasing
-
- 10 Aug, 2012 1 commit
-
-
Sergei Golubchik authored
-
- 09 Aug, 2012 2 commits
-
-
Sergei Golubchik authored
two items didn't do that properly, one was exploitable, the other was not, but fixed anyway.
-
Sergei Golubchik authored
manually checked every change, reverted incorrect or stupid changes.
-
- 08 Aug, 2012 3 commits
-
-
Michael Widenius authored
-
Sergei Golubchik authored
-
Sergei Golubchik authored
remove unused mtr option
-
- 06 Aug, 2012 2 commits
-
-
Michael Widenius authored
mysql-test/suite/heap/heap.result: Added test case for MDEV-436 mysql-test/suite/heap/heap.test: Added test case for MDEV-436 storage/heap/hp_block.c: Don't allocate a set of HP_PTRS when not needed. This saves us about 1024 bytes for most allocations. storage/heap/hp_create.c: Made the initial allocation of block sizes depending on min_records and max_records.
-
Michael Widenius authored
sql/log.h: Fixed compiler warnings reported for gcc 2.7.1 storage/xtradb/handler/ha_innodb.cc: Remove not used variables
-
- 01 Aug, 2012 1 commit
-
-
Sergei Golubchik authored
When appliying parent combinations to the overlay, filter them through the %skip_combinations using the overlayed filename
-
- 02 Aug, 2012 3 commits
-
-
Vladislav Vaintroub authored
-
Elena Stepanova authored
Post-merge fixes for mismatches that only affect 5.5 (but not 5.3)
-
Elena Stepanova authored
-
- 01 Aug, 2012 1 commit
-
-
Elena Stepanova authored
Following reasons caused mismatches: - different handling of invalid values; - different CAST results with fractional seconds; - microseconds support in MariaDB; - different algorithm of comparing temporal values; - differences in error and warning texts and codes; - different approach to truncating datetime values to time; - additional collations; - different record order for queries without ORDER BY; - MySQL bug#66034. More details in MDEV-369 comments.
-
- 31 Jul, 2012 5 commits
-
-
Sergei Golubchik authored
make CMakeLists.txt to detect if the installed boost can be compiled with the installed compile and specified set of compiler options. Background: even sufficiently new Boost cannot be compiled with the sufficiently old gcc in the presence of -fno-rtti
-
Sergei Golubchik authored
add missing checks to configure.cmake remove dead code and unused HAVE_xxx constants from the sources
-
Sergei Golubchik authored
Don't use ER(xxx) in THD::close_connection(), when current_thd is already reset to NULL. Prefer ER_THD() or ER_DEFAULT() instead.
-
Alexey Botchkov authored
mysql_rm_table_no_locks() function was modified. When we construct log record for the DROP TABLE, now we look if there's a comment before the first table name and add it to the record if so. per-file comments: sql/sql_table.cc MDEV-340 Save replication comments for DROP TABLE. comment_length() function implemented to find comments in the query, call it in mysql_rm_table_no_locks() and use the result to form log record. mysql-test/suite/binlog/r/binlog_drop_if_exists.result MDEV-340 Save replication comments for DROP TABLE. test result updated. mysql-test/suite/binlog/t/binlog_drop_if_exists.test MDEV-340 Save replication comments for DROP TABLE. test case added.
-
Sergei Golubchik authored
Add the check for sys/utsname.h to configure.cmake
-
- 30 Jul, 2012 2 commits
-
-
Vladislav Vaintroub authored
use correct macro for Microsoft compiler. It is _MSC_VER , not _MSV_VER
-
Elena Stepanova authored
Following reasons caused mismatches: - different handling of invalid values; - different CAST results with fractional seconds; - microseconds support in MariaDB; - different algorithm of comparing temporal values; - differences in error and warning texts and codes; - different approach to truncating datetime values to time; - additional collations; - different record order for queries without ORDER BY; - MySQL bug#66034. More details in MDEV-369 comments.
-
- 26 Jul, 2012 1 commit
-
-
Elena Stepanova authored
-
- 25 Jul, 2012 1 commit
-
-
Sergey Petrunya authored
- Make Item_subselect::fix_fields() ignore UNCACHEABLE_EXPLAIN flag when deciding whether the subquery item should be marked as constant.
-
- 24 Jul, 2012 1 commit
-
-
unknown authored
-
- 23 Jul, 2012 1 commit
-
-
Vladislav Vaintroub authored
Fix : use attribute %config(noreplace) for /etc/my.cnf , instead of (automatically generated) %config
-