1. 03 Mar, 2007 1 commit
  2. 02 Mar, 2007 1 commit
    • unknown's avatar
      Bug #21103: DATE column not compared as DATE · fed9bb98
      unknown authored
      If we compare two items A and B, with B being (a constant) of a
      larger type, then A gets promoted to B's type for comparison if
      it's a constant, function, or CAST() column, but B gets demoted
      to A's type if A is a (not explicitly CAST()) column. This is
      counter-intuitive and not mandated by the standard.
       
      Disabling optimisation where it would be lossy so field value
      will properly get promoted and compared as binary string (rather
      than as integers).
      
      
      mysql-test/include/ps_conv.inc:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Fix certain queries to still work.
      mysql-test/r/func_time.result:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Show that everything works as expected.
      mysql-test/r/ps_2myisam.result:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Fix certain queries to still work.
      mysql-test/r/ps_3innodb.result:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Fix certain queries to still work.
      mysql-test/r/ps_4heap.result:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Fix certain queries to still work.
      mysql-test/r/ps_5merge.result:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Fix certain queries to still work.
      mysql-test/r/ps_7ndb.result:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Fix certain queries to still work.
      mysql-test/t/func_time.test:
        Bug #21103: DATE column not compared as DATE
        
        When comparing a DATE field with a DATETIME constant, we now compare
        as DATETIMEs, not as DATEs.  Show that everything works as expected.
      sql/field.cc:
        Bug #21103: DATE column not compared as DATE
        
        #0 stores the date only as a 3-byte integer; save_in_field() in
        #1 saves 'this' in field's format (DATE), #2 "converts a constant
        item to an int and replaces the original item" -- consequently,
        this replaces the Item_string "2006-11-06 04:08:36.0" with the
        Item_int_with_ref 20061106.
        
        #0  Field_newdate::store (this=0x8d26880, from=0x8d5e658 "2006-11-06
        04:08:36.0", len=21, cs=0x88022c0) at field.cc:5344
        #1  0x0817e3b0 in Item_string::save_in_field (this=0x8d5e670, field=0x8d26880, no_conversions=true) at item.cc:4340
        #2  0x081b22ae in convert_constant_item (thd=0x8d25240, field=0x8d26880, item=0x8d5e74c) at item_cmpfunc.cc:245
        #3  0x081b8a36 in Item_bool_func2::fix_length_and_dec (this=0x8d5e6f8) at item_cmpfunc.cc:309
        #4  0x081a3427 in Item_func::fix_fields (this=0x8d5e6f8, thd=0x8d25240, ref=0x8d5f5fc) at item_func.cc:190
        #5  0x0825bc2d in setup_conds (thd=0x8d25240, tables=0x8d5e410, leaves=0x8d5e410, conds=0x8d5f5fc) at sql_base.cc:4941
        ...
        
        Disabling optimisation where it would be lossy so field value will
        properly get promoted and compared as binary string (rather than as
        integers).
      fed9bb98
  3. 01 Mar, 2007 22 commits
  4. 28 Feb, 2007 16 commits
    • unknown's avatar
      Merge mysql.com:/nfsdisk1/lars/bkroot/mysql-5.0-rpl · d5e983aa
      unknown authored
      into  mysql.com:/nfsdisk1/lars/MERGE/mysql-5.0-merge
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      d5e983aa
    • unknown's avatar
      Fixed compiler warnings. · def9c0b2
      unknown authored
      
      client/mysql_upgrade.c:
        Fixed problem with mysql_upgrade being dependent
        on local my.cnf files and problem with memory not being freed.
      client/mysqltest.c:
        Changed type to avoid warning.
      cmd-line-utils/readline/xmalloc.c:
        Fix to avoid warning.
      include/my_dbug.h:
        To disable parts from code in non-debug more.
      sql/field.cc:
        Fixed warning.
      sql/ha_archive.cc:
        Fixed warning.
      sql/ha_berkeley.cc:
        Added casts to avoid warnings.
      sql/ha_ndbcluster.cc:
        Fixed warnings.
      sql/log.cc:
        Added casts to avoid warnings.
      sql/slave.cc:
        Avoid warning.
      sql/sql_repl.cc:
        Avoid warning.
      support-files/compiler_warnings.supp:
        Added disabled warnings to compiler_warnings.supp file.
        These are backported mainly from 5.1 suppress file, but there
        are some additional new ones.
      def9c0b2
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/bug25074/my50-bug25074 · b9c36948
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      b9c36948
    • unknown's avatar
      Bug #25074 mysql_upgrade test can't give consistent results · 57af6dc4
      unknown authored
       - Tell the programs executed by mysql_upgrade to only read
        from the defaults file generated by msyql_upgrade
       - Fix memory leaks
      
      
      client/mysql_upgrade.c:
        - Always generate defaults file used for the programs executed
          by mysql_upgrade.
        - Set the executed programs to read options _only_ from the
          generated defaults file 
        - Add DBUG printouts
        - Add comments
        - Fix memory leaks
        - Change one 'my_delete'(delete a file) to 'my_free'(free memory)
        - Free memory allocated by 'load_default'
      57af6dc4
    • unknown's avatar
      Bug #20166 mysql-test-run.pl does not test system privilege tables creation · 890332a4
      unknown authored
       - No .sql files in mysql-test/lib/ anymore, don't copy them
      
      
      scripts/make_binary_distribution.sh:
        No need to copy mysql-test/lib/*.sql there are no sql files there anymore
      scripts/make_win_bin_dist:
        No need to copy mysql-test/lib/*.sql there are no sql files there anymore
      890332a4
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0-maint · 6ffe8c8a
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      6ffe8c8a
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint-bug20166 · 2a02f9c9
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/deleted/.del-init_db.sql:
        Auto merged
      BitKeeper/deleted/.del-init_db.sql~a77d572c39d5a1f8:
        Auto merged
      client/mysqltest.c:
        Auto merged
      mysql-test/Makefile.am:
        Auto merged
      mysql-test/lib/mtr_process.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      2a02f9c9
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/mysql-4.1-maint · 47a824ae
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint
      
      
      BitKeeper/etc/ignore:
        auto-union
      mysql-test/Makefile.am:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      BitKeeper/deleted/.del-init_db.sql:
        Auto merged
      BitKeeper/deleted/.del-init_db.sql~a77d572c39d5a1f8:
        Auto merged
      47a824ae
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/bug24878/my41-bug24878 · acdfc1e9
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-4.1-maint
      
      
      acdfc1e9
    • unknown's avatar
      Bug#24878 mysql server doesn't log incident time in "mysqld got signal 11" error messages · 87eee8fc
      unknown authored
       - Add printout of current time when mysqld is killed by an
         unhandled signal
      
      
      sql/mysqld.cc:
        Add printout of current time before the "mysqld got signal %d" message
        Hopefully we don't crash in the calls to 'time' or 'localtime_r'
        but if that should start to happen we can move the printout of
        time further down. At least it's now below the check for segfault
        inside of segfault handler.
      87eee8fc
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-5.0-rpl · a2b4f529
      unknown authored
      into  mysql.com:/home/bar/mysql-5.0.b24478
      
      
      a2b4f529
    • unknown's avatar
      Bug#20166 mysql-test-run.pl does not test system privilege tables creation · b1988b0d
      unknown authored
       - Null merge 4.1 patch
      
      
      mysql-test/Makefile.am:
        Null merge to 4.1 patch
      scripts/Makefile.am:
        No need to clean mysql_create_system_tablesa anyomre
      b1988b0d
    • unknown's avatar
      Additional test changes for · 4a83cd38
      unknown authored
      Bug N 15126 character_set_database is not replicated (LOAD DATA INFILE need it)
      Positions of some binlog events were changed because of
      additional logging of @@collation_database.
      
      
      4a83cd38
    • unknown's avatar
      Merge pilot.blaudden:/home/msvensson/mysql/mysql-4.1-maint · d8fb19e1
      unknown authored
      into  pilot.blaudden:/home/msvensson/mysql/mysql-5.0-maint-bug20166
      
      
      BitKeeper/etc/ignore:
        auto-union
      BitKeeper/deleted/.del-init_db.sql:
        Auto merged
      BitKeeper/deleted/.del-init_db.sql~a77d572c39d5a1f8:
        Auto merged
      client/mysqltest.c:
        Auto merged
      mysql-test/Makefile.am:
        Auto merged
      mysql-test/lib/mtr_process.pl:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      d8fb19e1
    • unknown's avatar
      Bug#20166 mysql-test-run.pl does not test system privilege tables creation · 22cac737
      unknown authored
       - Build lib/init-db.sql from the output of mysql_create_system_tables
       - Remove mysql-test/init_db.sql and mysql-test/lib/init_db.sql
       - Leave netware/init_db.sql until 5.0 where we should soon have possibility
         to test with mysql-test-run.pl
      
      
      BitKeeper/deleted/.del-init_db.sql:
        Delete: mysql-test/init_db.sql
      BitKeeper/deleted/.del-init_db.sql~a77d572c39d5a1f8:
        Delete: mysql-test/lib/init_db.sql
      BitKeeper/etc/ignore:
        Added mysql-test/lib/init_db.sql to the ignore list
      mysql-test/Makefile.am:
        Build lib/init_db.sql from the output of mysql_create_system_tables
      22cac737
    • unknown's avatar
      After merge fix · 18f1d1a2
      unknown authored
      18f1d1a2