An error occurred fetching the project authors.
  1. 02 Aug, 2006 1 commit
    • unknown's avatar
      BUG#13926: --order-by-primary fails if PKEY contains quote character. · 7fd78b84
      unknown authored
      Quote PKEY.
      
      
      mysql-test/t/mysqldump.test:
        Test for BUG#13926: --order-by-primary fails if PKEY contains quote character
      mysql-test/r/mysqldump.result:
        Test results for BUG#13926: --order-by-primary fails if PKEY contains quote character
      client/mysqldump.c:
        Fix for BUG#13926: --order-by-primary fails if PKEY contains quote character.
        Quote PKEY.
      7fd78b84
  2. 17 Jul, 2006 1 commit
    • unknown's avatar
      Bug# 20221- Dumping of multiple databases containing view(s) yields maleformed dumps. · 674636e7
      unknown authored
      client/mysqldump.c:
        When dumping more than one database, make sure that the proper database is selected before restoring that database's views.
        Replaced hard-coded database name length with appropiate token.
      mysql-test/r/mysqldump.result:
        Added new result and corrected results for existing test cases.
      mysql-test/t/mysqldump.test:
        Added new case for dumping and restoring multiple databases each containing a view.
      674636e7
  3. 14 Jul, 2006 1 commit
    • unknown's avatar
      Bug#21014: Segmentation fault of mysqldump on view · 3d35522f
      unknown authored
      mysqldump did not select the correct database before trying to dump
      views from it. this resulted in an empty result set, which in turn
      startled mysql-dump into a core-dump.  this only happened for views,
      not for tables, and was only visible with multiple databases that
      weren't by sheer luck in the order mysqldump required, anyway. this
      fixes by selecting the correct database before dumping views; it also
      catches the empty set-condition if it should occur for other reasons.
      
      
      client/mysqldump.c:
        Bug#21014: Segmentation fault of mysqldump on view
        
        failsafe: if "select ... from information_schema.views" returns an
        empty set, don't deref NULL; throw an error instead.
        
        fix: select the correct database not only before dumping tables, but
        before dumping views, as well.
      mysql-test/r/mysqldump.result:
        Bug#21014: Segmentation fault of mysqldump on view
        
        show that mysqldump selects the correct database before trying to dump
        views from it.
      mysql-test/t/mysqldump.test:
        Bug#21014: Segmentation fault of mysqldump on view
        
        show that mysqldump selects the correct database before trying to dump
        views from it.
      3d35522f
  4. 13 Jul, 2006 1 commit
    • unknown's avatar
      Bug#21014: Segmentation fault of mysqldump on view · f27e9254
      unknown authored
      mysqldump did not select the correct database before trying to dump
      views from it. this resulted in an empty result set, which in turn
      startled mysql-dump into a core-dump.  this only happened for views,
      not for tables, and was only visible with multiple databases that
      weren't by sheer luck in the order mysqldump required, anyway. this
      fixes by selecting the correct database before dumping views; it also
      catches the empty set-condition if it should occur for other reasons.
      
      
      client/mysqldump.c:
        Bug#21014: Segmentation fault of mysqldump on view
        
        failsafe: if "select ... from information_schema.views" returns an
        empty set, don't deref NULL; throw an error instead.
        
        fix: select the correct database not only before dumping tables, but
        before dumping views, as well.
      mysql-test/r/mysqldump.result:
        Bug#21014: Segmentation fault of mysqldump on view
        
        show that mysqldump selects the correct database before trying to dump
        views from it.
      mysql-test/t/mysqldump.test:
        Bug#21014: Segmentation fault of mysqldump on view
        
        show that mysqldump selects the correct database before trying to dump
        views from it.
      f27e9254
  5. 07 Jul, 2006 1 commit
    • unknown's avatar
      Cleanups: ignore more files. · e9775dd8
      unknown authored
      BitKeeper/etc/ignore:
        Modify ignore list to work with BitKeeper 4
      mysql-test/t/mysqldump.test:
        Fix the test for Bug#18462 to use MYSQLTEST_VARDIR instead of mysql-test/
        directory for temporary files.
      e9775dd8
  6. 30 Jun, 2006 1 commit
    • unknown's avatar
      Don't read ~/.my.cnf in mysqldump.test · c5ed64a4
      unknown authored
      heap/hp_test1.c:
        Changed type from last commit
      mysql-test/mysql-test-run.sh:
        Fixed problem with running with --gdb and two masters
        Don't disable ndb becasue we run gdb
      mysql-test/t/mysqldump.test:
        Don't read ~/.my.cnf
      sql/ha_ndbcluster.cc:
        Portability fix
      c5ed64a4
  7. 22 Jun, 2006 1 commit
    • unknown's avatar
      Bug#20588: mysqldump.test may fail, depending on system-wide configuration · df4ba783
      unknown authored
      mysqldump.test calls my_print_defaults in a way that includes the systemwide
      my.cnf, so the results will be beyond our control and depend on whatever the
      user has in their my.cnf, namely the [mysqldump] section.
      
      call my_print_defaults with --config-file rather than --defaults-extra-file
      to prevent inclusion of system-wide defaults and use our config-file only.
      
      
      mysql-test/t/mysqldump.test:
        call my_print_defaults with our setup only, do not include the systemwide
        my.cnf as that would make the results unpredictable.
      df4ba783
  8. 19 Jun, 2006 1 commit
  9. 15 Jun, 2006 1 commit
  10. 31 May, 2006 1 commit
    • unknown's avatar
      Bug#18462: mysqldump does not dump view structures correctly · c69ba255
      unknown authored
      (The above problem only occurs with -T -- create a separate file for
      each table / view.) This ChangeSet results in correct output of view-
      information while omitting the information for the view's stand-in
      table. The rationale is that with -T, the user is likely interested
      in transferring part of a database, not the db in its entirety (that
      would be difficult as replay order is obscure, the files being named
      for the table/view they contain rather than getting a sequence number).
      
      
      client/mysqldump.c:
        Added missing fclose(). Before, a view's stand-in table would get
        dumped in get_table_structure(), and the file would remain open.
        get_view_structure() would re-open the same file and write to it,
        resulting in garbage.  The way we handle it now, the table-struct
        gets closed, then the opening of the view-struct (same name)
        overwrites it. (The SQL for the view drop-if-exists the table,
        anyway.) If this were not desired and we wanted SQL for the views
        that contains the create for the stand-in table, we'd hand a mode
        to open_sql_file_for_table(), which would feature O_APPEND in
        get_view_structure(), but not in get_table_structure().
      mysql-test/r/mysqldump.result:
        prove mysqldump -T (each item gets its own file) dumps views correctly
      mysql-test/t/mysqldump.test:
        prove mysqldump -T (each item gets its own file) dumps views correctly
      c69ba255
  11. 30 May, 2006 1 commit
    • unknown's avatar
      Bug#17371: Unable to dump a schema with invalid views · 443de045
      unknown authored
      'show create' works even on views that are short of a base-table (this
      throw a warning though, like you would expect). Unfortunately, this is
      not what mysqldump uses; it creates stand-in tables and hence requests
      'show fields' on the view which fails with missing base-tables.  The
      --force option prevents the dump from stopping at this point; furthermore
      this patch dumps a comment showing create for the offending view for
      better diagnostics. This solution was confirmed by submitter as solving
      their/clients' problem. Problem might become non-issue once mysqldump no
      longer creates stand-in tables.
      
      
      client/mysqldump.c:
        Dump a comment showing create for a view if we can't show fields for it for
        better diagnostics.
      mysql-test/r/mysqldump.result:
        add test for #17371 - be defensive. if we can't do a full dump on a view
        (incl. 'show fields' for a stand-in table), at least create a comment with
        the 'show create' info when --force is given.
      mysql-test/t/mysqldump.test:
        add test for #17371 - be defensive. if we can't do a full dump on a view
        (incl. 'show fields' for a stand-in table), at least create a comment with
        the 'show create' info when --force is given.
      443de045
  12. 29 May, 2006 1 commit
  13. 26 May, 2006 1 commit
    • unknown's avatar
      mysqldump.result: · 45972e0e
      unknown authored
        Get output from modified test (dropping t1).
      mysqldump.test:
        Drop t1 at end so that the next test doesn't trip over it.
      
      
      mysql-test/t/mysqldump.test:
        Drop t1 at end so that the next test doesn't trip over it.
      mysql-test/r/mysqldump.result:
        Get output from modified test (dropping t1).
      45972e0e
  14. 25 May, 2006 1 commit
    • unknown's avatar
      BUG#17201: Improve handling of views. · 45710b7f
      unknown authored
      client/mysqldump.c:
         Better view handling:
        
          Distinguish better between tables and views in the output.
          
          Add many comments about the distinctions between tables and views, and
          the tradeoffs that we make, notably that, since we don't maintain
          dependencies.
          
          get_table_structure: Clarify in the output that a view is first
          		       created as a workaround for the lack of
          		       dependencies.
          
          dump_table:  Return if we're trying to dump a view.
          
          dump_all_views_in_db: Don't call init_dumping.  It's already been done
                                in dump_all_tables_in_db.  This is the problem
                                reported in BUG#17201.
          
          Change the variable was_views to seen_views, and clarify the comment.
          The previous name was not overly "intuitive".
      mysql-test/r/mysqldump.result:
        We no longer have spurious text in the results.
        Add results for the final test (BUG#17201)
      mysql-test/t/mysqldump.test:
        Add a new test (BUG#17201)
      45710b7f
  15. 19 May, 2006 1 commit
    • unknown's avatar
      Fix for bug #18536: mysqldump does not maintain table orders as per --tables option · c41b767a
      unknown authored
      client/mysqldump.c:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - use list to store table names instead of hash.
      mysql-test/r/mysqldump.result:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - test result.
      mysql-test/t/mysqldump.test:
        Fix for bug #18536: mysqldump does not maintain table orders as per --tables option
          - test case.
      c41b767a
  16. 11 May, 2006 1 commit
    • unknown's avatar
      Bug#15328 Segmentation fault occured if my.cnf is invalid for escape sequence · a9e0d277
      unknown authored
       - Check that length of value is longer than 1 before decrementing length by 2.
       - Backport from 5.0, make it possible to use my_print_defaults in tests
      
      
      mysql-test/mysql-test-run.pl:
        Backport from 5.0, make it possible to use my_print_defaults from tests
      mysql-test/mysql-test-run.sh:
        Backport from 5.0, make it possible to use my_print_defaults from tests
      mysql-test/r/mysqldump.result:
        Update result
      mysql-test/t/mysqldump.test:
        Test that my_print default don't segfault when encountering an option without closing "
      mysys/default.c:
        Check that length of value is longer than 1 before deciding to decrement its length by 2.
      mysql-test/std_data/bug15328.cnf:
        New BitKeeper file ``mysql-test/std_data/bug15328.cnf''
      a9e0d277
  17. 04 May, 2006 1 commit
    • unknown's avatar
      Bug#19025 4.1 mysqldump doesn't correctly dump "auto_increment = [int]" · d300ceea
      unknown authored
      mysqldump / SHOW CREATE TABLE will show the NEXT available value for
      the PK, rather than the *first* one that was available (that named in
      the original CREATE TABLE ... AUTO_INCREMENT = ... statement).
      
      This should produce correct and robust behaviour for the obvious use
      cases -- when no data were inserted, then we'll produce a statement
      featuring the same value the original CREATE TABLE had; if we dump
      with values, INSERTing the values on the target machine should set the
      correct next_ID anyway (and if not, we'll still have our AUTO_INCREMENT =
      ... to do that). Lastly, just the CREATE statement (with no data) for
      a table that saw inserts would still result in a table that new values
      could safely be inserted to).
      
      There seems to be no robust way however to see whether the next_ID
      field is > 1 because it was set to something else with CREATE TABLE
      ... AUTO_INCREMENT = ..., or because there is an AUTO_INCREMENT column
      in  the table (but no initial value was set with AUTO_INCREMENT = ...)
      and then one or more rows were INSERTed, counting up next_ID. This
      means that in both cases, we'll generate an AUTO_INCREMENT =
      ... clause in SHOW CREATE TABLE / mysqldump.  As we also show info on,
      say, charsets even if the user did not explicitly give that info in
      their own CREATE TABLE, this shouldn't be an issue.
      
      As per above, the next_ID will be affected by any INSERTs that have
      taken place, though.  This /should/ result in correct and robust
      behaviour, but it may look non-intuitive to some users if they CREATE
      TABLE ... AUTO_INCREMENT = 1000 and later (after some INSERTs) have
      SHOW CREATE TABLE give them a different value (say, CREATE TABLE
      ... AUTO_INCREMENT = 1006), so the docs should possibly feature a
      caveat to that effect.
      
      It's not very intuitive the way it works now (with the fix), but it's
      *correct*.  We're not storing the original value anyway, if we wanted
      that, we'd have to change on-disk representation?
      
      If we do dump/load cycles with empty DBs, nothing will change.  This
      changeset includes an additional test case that proves that tables
      with rows will create the same next_ID for AUTO_INCREMENT = ... across
      dump/restore cycles.
      
      Confirmed by support as likely solution for client's problem.
      
      
      mysql-test/r/auto_increment.result:
        test for creation of AUTO_INCREMENT=... clause
      mysql-test/r/gis-rtree.result:
        Add AUTO_INCREMENT=... clauses where appropriate
      mysql-test/r/mysqldump.result:
        show that AUTO_INCREMENT=... will survive dump/restore cycles
      mysql-test/r/symlink.result:
        Add AUTO_INCREMENT=... clauses where appropriate
      mysql-test/t/auto_increment.test:
        test for creation of AUTO_INCREMENT=... clause
      mysql-test/t/mysqldump.test:
        show that AUTO_INCREMENT=... will survive dump/restore cycles
      sql/sql_show.cc:
        Add AUTO_INCREMENT=... to output of SHOW CREATE TABLE if there is an
        AUTO_INCREMENT column, and NEXT_ID > 1 (the default).  We must not print
        the clause for engines that do not support this as it would break the
        import of dumps, but as of this writing, the test for whether
        AUTO_INCREMENT columns are allowed and wether AUTO_INCREMENT=...
        is supported is identical, !(file->table_flags() & HA_NO_AUTO_INCREMENT))
        Because of that, we do not explicitly test for the feature,
        but may extrapolate its existence from that of an AUTO_INCREMENT column.
      d300ceea
  18. 02 Mar, 2006 1 commit
    • unknown's avatar
      Make the "system" command become executed in a bash shell in cygwin. · 326acd57
      unknown authored
      client/mysqltest.c:
        Prepend the command to execute by system with "sh" to make it executed by cygwin's bash
      mysql-test/t/mysqldump.test:
        Change from " to ' to avoid bash's filename expanding. I.e to avoid that "[mysqltest1]" will be llok for any dirs in mysql-test/* that are named m, y, s, q etc. And ther is actually one dir called t, so we will get a match and thus echo "t" to the file.
      326acd57
  19. 24 Feb, 2006 1 commit
  20. 23 Feb, 2006 1 commit
    • unknown's avatar
      Add new parameter to do_eval so that only unescaped variables in input string... · 44e286d2
      unknown authored
      Add new parameter to do_eval so that only unescaped variables in input string is expanded and rest of string is left untouched.
      
      
      client/mysqltest.c:
        Add new parameter to 'do_eval' that will add any escape chars found in the input string to the output string. 
        This is used in 'do_system' and in 'do_exec' where only unescaped variables
        will be expanded, rest of the string will be left untouched.
      mysql-test/r/mysqltest.result:
        Update test result
      mysql-test/t/mysqldump.test:
        Revert previous patch that added extra \\ in "exec" command
      mysql-test/t/mysqltest.test:
        Revert previous patch that added extra \\ in exec command
      44e286d2
  21. 21 Feb, 2006 2 commits
    • unknown's avatar
      Bug#14857 Reading dump files with single statement stored routines fails.Bug... · 1f12107f
      unknown authored
      Bug#14857 Reading dump files with single statement stored routines fails.Bug #14857  	Reading dump files with single statement stored routines fails.
       - Add tests, fixed by patch for 16878
      
      
      mysql-test/r/mysqldump.result:
        Update test results
      mysql-test/t/mysqldump.test:
        Add tests for bug 14857
      1f12107f
    • unknown's avatar
      Bug#14871 mysqldump: invalid view dump output · 15c37025
      unknown authored
       - Add comments with embeded veriosn info around the parts of the view syntax that are only supported by a certain version of MySQL Server
      
      
      client/mysqldump.c:
        Use information_schema.views to gather information about the view, then replace some parts of the output from "SHOW CREATE VIEW" with comment markers with version, to make thos parts of the view syntax become parsed only of MySQL servers that supports it.
        Create common function "open_sql_file_for_table" to open the individual .sql file where to dump the table or view.
      mysql-test/r/mysqldump.result:
        Update results
      mysql-test/t/mysqldump.test:
        Add test to see that views can be deumped and reloaded alos when they contain "SECURITY TYPE", "CHECK OPTION" and "DEFINER"
      15c37025
  22. 16 Feb, 2006 2 commits
  23. 09 Feb, 2006 1 commit
    • unknown's avatar
      Bug#16878 dump of trigger · 2caa5608
      unknown authored
       - Pass "in_comment" variable on to new lex in sp_head::reset_lex
       - Add testcases for dumping and reloading trigger without BEGIN/END
      
      
      mysql-test/r/mysqldump.result:
        Update test result
      mysql-test/t/mysqldump.test:
        Add test for dumping trigger without begin/end, and test that the output from mysqldump can be reloaded.
      sql/sp_head.cc:
        If already in a comment before parsing a substatement, set in_comment in the new lex as well.
        This will handle cases where the comment starts before the substatement, which is common in 
        output from mysqldump to mask away syntax not supported by earlier versions of MySQL.
        Ex:
        /*!50003 CREATE TRIGGER `tr1` BEFORE INSERT ON `t1` FOR EACH ROW
        set new.created=now() */;
        ^=== sp_head::reset_lex is called when already in comment
      2caa5608
  24. 24 Jan, 2006 1 commit
    • unknown's avatar
      Make it possible to run mysql-test-run.pl with default test suite in different vardir. · d40f7056
      unknown authored
      mysql-test/include/have_outfile.inc:
        Use MYSQLTEST_VARDIR
      mysql-test/include/test_outfile.inc:
        Use MYSQLTEST_VARDIR
      mysql-test/mysql-test-run.pl:
        Create variable $MYSQLTEST_VARDIR that points to  the vardir
        Don't create a symlink from var/ to the physical vardir if it's somewhere else
        Setup a symlink(or copy dir on windows) for std_data so it is available in the physical vardir
        Use "../tmp" as slave-load-tmpdir, since the server is started in var/master-data and slave in var/slave-data they will both find the dumps in "../tmp"
      mysql-test/mysql-test-run.sh:
        Export MYSQLTEST_VARDIR, always pointing at mysql-test/var
      mysql-test/r/backup.result:
        Use MYSQLTEST_VARDIR
      mysql-test/r/blackhole.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/loaddata.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/mysqlbinlog.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/mysqltest.result:
        Use MYSQLTEST_VARDIR
      mysql-test/r/outfile.result:
        Use MYSQLTEST_VARDIR
      mysql-test/r/query_cache.result:
        Add missing drop function
      mysql-test/r/rpl000001.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl000004.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_innodb.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_loaddata.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_loaddata_rule_m.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_loaddata_rule_s.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_loaddatalocal.result:
        Use MYSQLTEST_VARDIR
      mysql-test/r/rpl_log.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_misc_functions.result:
        Use MYSQLTEST_VARDIR
      mysql-test/r/rpl_replicate_do.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_rewrite_db.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/rpl_timezone.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/symlink.result:
        Use MYSQLTEST_VARDIR
      mysql-test/r/trigger.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/view.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/r/warnings.result:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/backup-master.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/backup.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/blackhole.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/ctype_ucs_binlog.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/im_daemon_life_cycle-im.opt:
        Use MYSQLTEST_VARDIR
      mysql-test/t/im_options_set.imtest:
        Use MYSQLTEST_VARDIR
      mysql-test/t/im_options_unset.imtest:
        Use MYSQLTEST_VARDIR
      mysql-test/t/loaddata.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/myisam.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/mysqlbinlog.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/mysqlbinlog2.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/mysqldump.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/mysqltest.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/ndb_autodiscover.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/outfile.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/query_cache.test:
        Add missing drop function
      mysql-test/t/repair.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl000001.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl000004.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl000009.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl000015-slave.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl000017-slave.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_EE_error.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_charset.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_drop_db.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_flush_log_loop-master.opt:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_flush_log_loop-master.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_flush_log_loop-slave.opt:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_flush_log_loop-slave.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_innodb.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_loaddata.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_loaddata_rule_m.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_loaddata_rule_s.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_loaddatalocal.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_log.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_misc_functions-slave.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_misc_functions.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_replicate_do.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_rewrite_db.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/rpl_rotate_logs-slave.sh:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_rotate_logs.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/rpl_timezone.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/show_check.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/sp-destruct.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/symlink.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/temp_table-master.opt:
        Use MYSQLTEST_VARDIR
      mysql-test/t/trigger-compat.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/trigger-grant.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/trigger.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/type_varchar.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/user_var-binlog.test:
        Use MYSQLTEST_VARDIR
      mysql-test/t/view.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/t/warnings.test:
        Use "../std_data_ln" to find std_data files
      mysql-test/include/sourced.inc:
        New BitKeeper file ``mysql-test/include/sourced.inc''
      mysql-test/include/sourced1.inc:
        New BitKeeper file ``mysql-test/include/sourced1.inc''
      d40f7056
  25. 24 Nov, 2005 1 commit
  26. 21 Nov, 2005 1 commit
    • unknown's avatar
      Fixed BUG #14554: mysqldump does not separate "ROW" and trigger · 3ecbc8e6
      unknown authored
       statement for tables created in the IGNORE_SPACE sql mode.
      
      
      client/mysqldump.c:
        Modified dump_triggers_for_table(): if trigger statement returned
         by SHOW TRIGGERS query does not contain a leading white space,
         additional space is inserted between "ROW" and the statement.
         The leading white spaces are removed by yylex() in the
         IGNORE_SPACE sql mode.
      mysql-test/r/mysqldump.result:
        Fixed test case result for bug 14554.
      mysql-test/t/mysqldump.test:
        Added test case for bug 14554.
      3ecbc8e6
  27. 10 Nov, 2005 2 commits
    • unknown's avatar
      WL#2818 (Add creator to the trigger definition for privilege · 7dbea7df
      unknown authored
      checks on trigger activation)
      
      
      mysql-test/r/information_schema.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/mysqldump.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_ddl.result:
        Update result file: a new column DEFINER has been added to
        INFORMATION_SCHEMA.TRIGGERS.
      mysql-test/r/rpl_sp.result:
        Update result file: a new clause DEFINER has been added to
        CREATE TRIGGER statement.
      mysql-test/r/rpl_trigger.result:
        Results for new test cases were added.
      mysql-test/r/skip_grants.result:
        Error message has been changed.
      mysql-test/r/trigger.result:
        Added DEFINER column.
      mysql-test/r/view.result:
        Error messages have been changed.
      mysql-test/r/view_grant.result:
        Error messages have been changed.
      mysql-test/t/mysqldump.test:
        Drop created procedure to not affect further tests.
      mysql-test/t/rpl_trigger.test:
        Add tests for new column in information schema.
      mysql-test/t/skip_grants.test:
        Error tag has been renamed.
      mysql-test/t/view.test:
        Error tag has been renamed.
      mysql-test/t/view_grant.test:
        Error tag has been changed.
      sql/item_func.cc:
        Fix typo in comments.
      sql/mysql_priv.h:
        A try to minimize copy&paste:
          - introduce operations to be used from sql_yacc.yy;
          - introduce an operation to be used from trigger and
            view processing code.
      sql/share/errmsg.txt:
        - Rename ER_NO_VIEW_USER to ER_MALFORMED_DEFINER in order to
          be shared for view and trigger implementations;
        - Fix a typo;
        - Add a new error code for trigger warning.
      sql/sp.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.cc:
        set_info() was split into set_info() and set_definer().
      sql/sp_head.h:
        set_info() was split into set_info() and set_definer().
      sql/sql_acl.cc:
        Add a new check: exit from the cycle if the table is NULL.
      sql/sql_lex.h:
        - Rename create_view_definer to definer, since it is used for views
          and triggers;
        - Change st_lex_user to LEX_USER, since st_lex_user is a structure.
          So, formally, it should be "struct st_lex_user", which is longer
          than just LEX_USER;
        - Add trigger_definition_begin.
      sql/sql_parse.cc:
        - Add a new check: exit from the cycle if the table is NULL;
        - Implement definer-related functions.
      sql/sql_show.cc:
        Add DEFINER column.
      sql/sql_trigger.cc:
        Add DEFINER support for triggers.
      sql/sql_trigger.h:
        Add DEFINER support for triggers.
      sql/sql_view.cc:
        Rename create_view_definer to definer.
      sql/sql_yacc.yy:
        Add support for DEFINER-clause in CREATE TRIGGER statement.
        
        Since CREATE TRIGGER and CREATE VIEW can be similar at the start,
        yacc is unable to distinguish between them. So, had to modify both
        statements in order to make it parsable by yacc.
      mysql-test/r/trigger-compat.result:
        Result file for triggers backward compatibility test.
      mysql-test/r/trigger-grant.result:
        Result file of the test for WL#2818.
      mysql-test/t/trigger-compat.test:
        Triggers backward compatibility test: check that the server
        still can load triggers w/o definer attribute and modify
        tables with such triggers (add a new trigger, etc).
      mysql-test/t/trigger-grant.test:
        Test for WL#2818 -- check that DEFINER support in triggers
        works properly
      7dbea7df
    • unknown's avatar
      Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong. · 0c97fbef
      unknown authored
      mysql-test/t/mysqldump.test:
        Fix for bug #14822: Test "mysqldump" fails, "result" protocol seems wrong.
        2>&1 added to be able to see error messages.
      0c97fbef
  28. 04 Nov, 2005 1 commit
  29. 25 Oct, 2005 2 commits
    • unknown's avatar
      BUG# 12123 · cf59103d
      unknown authored
      Made change to mysqlimport to set character_set_database to binary to 
      make importing various charsets/columns work correctly.
      
      
      client/mysqlimport.c:
        BUG# 12123
        
        Added 'set @@character_set_database=binary' to make loading of tables with
        mixed charset types and non-latin characters load.
      mysql-test/mysql-test-run.pl:
        BUG #12123
        
        Added $MYSQL_IMPORT in order to test mysqlimport bug.
      mysql-test/mysql-test-run.sh:
        BUG #12123
        
        Added $MYSQL_IMPORT in order to test mysqlimport bug.
      mysql-test/r/mysqldump.result:
        BUG #12123
        
        Added dumping and reloading (using mysql, mysqldump, and mysqlimport) to
        show that this fix handles dumping and reloading of non-latin1 charsets
        in table with different charset columns (mixing of charsets, also can be a
        UTF table with latin1 tables). Note the select before and after dump and 
        restore - should be exact.
      mysql-test/t/mysqldump.test:
        BUG #12123
        
        Added dumping and reloading (using mysql, mysqldump, and mysqlimport) to
        show that this fix handles dumping and reloading of non-latin1 charsets
        in table with different charset columns (mixing of charsets, also can be a
        UTF table with latin1 tables). Note the select before and after dump and 
        restore - should be exact. (results of this)
      cf59103d
    • unknown's avatar
      This cset fixes BUG# 12838, 14061, 12129 · cecdc15a
      unknown authored
      mysqldump.result:
        BUG# 12838
            New test results for mysqldump -x on a DB with views
      mysqldump.test:
        sqldump.test:
            BUG# 12838
            New test to run mysqldump -x on a DB with views
      mysqldump.c:
        BUG# 12838
            Removed/Changed code which created tables to be put into the dump
            (For loading views of views) by creating temp tables and then using
            the CREATE TABLE information in those temp tables. The problem with this
            is that when mysqldump -x is called, it locks all tables, so the
            temp tables could not be created, causing the mysqldump to exit with
            failure. The code was changed to use SHOW FIELDS to get the column
            names and type to build CREATE TABLE text used to create these tables
            that views need in the dump.
      
      
      client/mysqldump.c:
        BUG# 12838
            Removed/Changed code which created tables to be put into the dump
            (For loading views of views) by creating temp tables and then using
            the CREATE TABLE information in those temp tables. The problem with this
            is that when mysqldump -x is called, it locks all tables, so the
            temp tables could not be created, causing the mysqldump to exit with
            failure. The code was changed to use SHOW FIELDS to get the column
            names and type to build CREATE TABLE text used to create these tables
            that views need in the dump.
      mysql-test/t/mysqldump.test:
        sqldump.test:
            BUG# 12838
            New test to run mysqldump -x on a DB with views
      mysql-test/r/mysqldump.result:
        BUG# 12838
            New test results for mysqldump -x on a DB with views
      cecdc15a
  30. 13 Oct, 2005 2 commits
    • unknown's avatar
      BUG# 13146 · b52b67eb
      unknown authored
      Re-application of patch to clean 5.0 tree. Fixed issue with ANSI quotes 
      when dumping triggers
      
      
      client/mysqldump.c:
        BUG# 13146
        
        Re-application of fix to clean 5.0 tree. 
        
        Added comments for quote_name, moved declarations into proper order, 
        unset MASK_ANSI_QUOTES flag in opt_compatible_mode global when dumping
        triggers
      mysql-test/r/mysqldump.result:
        BUG# 13146
        
        New test results
      mysql-test/t/mysqldump.test:
        BUG# 13146
        
        New test
      b52b67eb
    • unknown's avatar
      BUG# 13052 · a2ceebf2
      unknown authored
      Clean application of patch - 
      - Added --tz-utc to fix issue of dumping timestamp values between 
      servers with different global time zone settings, particularly 
      with regard to the day of DST changeover, which without this fix,
       would dump duplicate timestamp values.
      
      
      client/client_priv.h:
        BUG# 13052 - clean application of http://lists.mysql.com/internals/30993
      client/mysqldump.c:
        BUG# 13052
        
        Clean application of patch http://lists.mysql.com/internals/30993
        
        - added new --tz-utc option
        - added saving of TIME_ZONE in dump file
        - set TIME_ZONE to "+00:00" in dump
      mysql-test/r/mysqldump.result:
        BUG# 13052 New results
      mysql-test/t/mysqldump.test:
        BUG# 13052
        
        Added new test to test if the new option --tz-utc places 
        'SET TIME_ZONE="+00:00" at the top of the file and that this fixes 
        the problem of ending up with duplicate timestamp values that should
         be unique on eve of DST
      a2ceebf2
  31. 29 Sep, 2005 2 commits
    • unknown's avatar
      mtr_report.pl: · 3dd066e8
      unknown authored
        Text formatting, adjust table header
      mysql-test-run.pl:
        Remove requirement for source tree to run embedded server test
      mysqldump.test:
        Removed ending ';' from --exec line
      
      
      mysql-test/t/mysqldump.test:
        Removed ending ';' from --exec line
      mysql-test/mysql-test-run.pl:
        Remove requirement for source tree to run embedded server test
      mysql-test/lib/mtr_report.pl:
        Text formatting, adjust table header
      3dd066e8
    • unknown's avatar
      f4ec1ed5
  32. 14 Sep, 2005 1 commit
  33. 13 Sep, 2005 2 commits
    • unknown's avatar
      Added option --valgrind-mysqltest to mysql-test-run · f8f1c016
      unknown authored
      Added flag to Field::store(longlong) to specify if value is unsigned.
      This fixes bug #12750: Incorrect storage of 9999999999999999999 in DECIMAL(19, 0)
      Fixed warning from valgrind in CREATE ... SELECT
      Fixed double free of mysql.options if reconnect failed
      
      
      mysql-test/mysql-test-run.sh:
        Added option --valgrind-mysqltest to allow one to run mysqltest with valgrind
      mysql-test/r/bigint.result:
        Update results after fix for Field::store(longlong)
      mysql-test/r/range.result:
        Update results after fix for Field::store(longlong)
      mysql-test/r/strict.result:
        Update results after fix for Field::store(longlong)
        (This fixes some wrong results when storing things into bigint columns)
      mysql-test/r/type_ranges.result:
        Update results after fix for Field::store(longlong)
      mysql-test/t/bigint.test:
        Added testing for #12750: Incorrect storage of 9999999999999999999 in DECIMAL(19, 0)
      mysql-test/t/innodb.test:
        Removed comments affected by this bug fix
      mysql-test/t/mysqldump.test:
        Fixed result to not depend on existing config files
      mysql-test/t/range.test:
        0xff numbers are now unsigned
      mysql-test/t/strict.test:
        Added errors for things that previously (wrongly) succeeded
      sql-common/client.c:
        Fixed double free of mysql.options if reconnect failed
      sql/field.cc:
        Added flag to Field::store(longlong) to specify if value is unsigned
      sql/field.h:
        Added flag to Field::store(longlong) to specify if value is unsigned
      sql/field_conv.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/ha_ndbcluster.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/handler.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/item.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/item_sum.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/sp.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/sql_acl.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/sql_help.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/sql_show.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/sql_table.cc:
        Fixed varning from valgrind
      sql/sql_udf.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/tztime.cc:
        Fixed calls to Field::store(longlong,flag)
      sql/unireg.cc:
        Fixed calls to Field::store(longlong,flag)
      f8f1c016
    • unknown's avatar
      after pull review - many bugs in mysqldump --routines · 21f4f6cf
      unknown authored
      mysql-test/r/mysqldump.result:
        updated
      mysql-test/t/mysqldump.test:
        cleanup, new test
      21f4f6cf