1. 30 Apr, 2010 3 commits
    • Sergei Golubchik's avatar
      create table options bug: · 8792d8a3
      Sergei Golubchik authored
      parse_engine_table_options() was only called when there was at least option with a
      non-default value. otherwise it was not called and option structure was not
      allocated at all. NULL pointer dereference in ::open().
      8792d8a3
    • Sergei Golubchik's avatar
      create table options bug: · 2b8de050
      Sergei Golubchik authored
      alter table does not reset HA_OPTION_TEXT_CREATE_OPTIONS when the last option value is removed
      2b8de050
    • Sergei Golubchik's avatar
      small changes to WL#43: · b58cb7c4
      Sergei Golubchik authored
        consistency: don't use "index" and "key" interchangeably
        => rename "key" to "index"
        consistency: all option types are logical, besides ULL
        => rename ULL to NUMBER
        don't accept floats where integers are expected
        accept hexadecimal where integers are expected
      b58cb7c4
  2. 06 May, 2010 1 commit
  3. 05 May, 2010 2 commits
  4. 29 Apr, 2010 1 commit
  5. 28 Apr, 2010 1 commit
    • Kristian Nielsen's avatar
      Fix buffer overflow in COM_FIELD_LIST. · 1f683a72
      Kristian Nielsen authored
      sql/sql_base.cc:
        Replace strmov() with strnmov() to remove the possibility for buffer overflow.
      sql/sql_parse.cc:
        Reject COM_FIELD_LIST with too-big table or wildcard argument.
        (libmysqlclient doesn't allow sending too long arguments anyway, but we
        need this to protect against buffer overflow exploits).
      1f683a72
  6. 21 Apr, 2010 1 commit
  7. 14 Apr, 2010 1 commit
  8. 12 Apr, 2010 1 commit
  9. 09 Apr, 2010 4 commits
  10. 08 Apr, 2010 12 commits
    • Sergei Golubchik's avatar
      merged · c49726b9
      Sergei Golubchik authored
      c49726b9
    • Igor Babaev's avatar
      5b8c42d9
    • Sergei Golubchik's avatar
      fixes for buildbot: · cda2c0ce
      Sergei Golubchik authored
      update test results
      fix compilation failure on windows
      fix for ps-protocol
      
      mysql-test/r/plugin.result:
        make sure the PS handle is closed
      mysql-test/t/plugin.test:
        make sure the PS handle is closed
      sql/mysqld.cc:
        compilation failure: lable without a statement.
      sql/sql_plugin.cc:
        make plugin lock and plugin unlock use the same format of the dbug info string.
        print the ref_count *after* the lock and *after* the unlock.
      cda2c0ce
    • Sergei Golubchik's avatar
      fix dialog plugin to work again · c277c43a
      Sergei Golubchik authored
      (fgets, unlike gets, does not strip \n)
      c277c43a
    • Michael Widenius's avatar
      Merge with local tree · 6e294768
      Michael Widenius authored
      6e294768
    • Michael Widenius's avatar
      Merge with 5.1 · 664709e7
      Michael Widenius authored
      664709e7
    • Michael Widenius's avatar
      Fixed compiler warnings · 8ee9c636
      Michael Widenius authored
      Changed version string to beta
      
      client/mysql.cc:
        Fixed compiler warning
      configure.in:
        Changed version string to beta
      plugin/auth/dialog.c:
        Fixed compiler warning (gets() is a not recommended function)
      8ee9c636
    • Sergei Golubchik's avatar
      MWL#43 CREATE TABLE options (by Sanja) · e24e1668
      Sergei Golubchik authored
      Docs/sp-imp-spec.txt:
        New sql_mode added.
      include/my_base.h:
        Flag in frm of create options.
      libmysqld/CMakeLists.txt:
        New files added.
      libmysqld/Makefile.am:
        New files added.
      mysql-test/r/events_bugs.result:
        New sql_mode added.
      mysql-test/r/information_schema.result:
        New sql_mode added.
      mysql-test/r/sp.result:
        New sql_mode added.
      mysql-test/r/system_mysql_db.result:
        New sql_mode added.
      mysql-test/suite/funcs_1/r/is_columns_mysql.result:
        New sql_mode added.
      mysql-test/suite/funcs_1/r/is_columns_mysql_embedded.result:
        New sql_mode added.
      mysql-test/t/events_bugs.test:
        New sql_mode added.
      mysql-test/t/sp.test:
        New sql_mode added.
      scripts/mysql_system_tables.sql:
        New sql_mode added.
      scripts/mysql_system_tables_fix.sql:
        New sql_mode added.
      sql/CMakeLists.txt:
        New files added.
      sql/Makefile.am:
        New files added.
      sql/event_db_repository.cc:
        New sql_mode added.
      sql/field.cc:
        Create options support added.
      sql/field.h:
        Create options support added.
      sql/ha_partition.cc:
        Create options support added.
      sql/handler.cc:
        Create options support added.
      sql/handler.h:
        Create options support added.
      sql/log_event.h:
        New sql_mode added.
      sql/mysql_priv.h:
        New sql_mode added.
      sql/mysqld.cc:
        New sql_mode added.
      sql/share/errmsg.txt:
        New error messages added.
      sql/sp.cc:
        New sql_mode added.
      sql/sp_head.cc:
        Create options support added.
      sql/sql_class.cc:
        Create options support added.
        Debug added.
      sql/sql_class.h:
        Create options support added.
      sql/sql_insert.cc:
        my_safe_a* moved to mysqld_priv.h
      sql/sql_lex.h:
        Create options support added.
      sql/sql_parse.cc:
        Create options support added.
      sql/sql_show.cc:
        Create options support added.
      sql/sql_table.cc:
        Create options support added.
      sql/sql_view.cc:
        New sql_mode added.
      sql/sql_yacc.yy:
        Create options support added.
      sql/structs.h:
        Create options support added.
      sql/table.cc:
        Create options support added.
      sql/table.h:
        Create options support added.
      sql/unireg.cc:
        Create options support added.
      storage/example/ha_example.cc:
        Create options example.
      storage/example/ha_example.h:
        Create options example.
      storage/pbxt/src/discover_xt.cc:
        Create options support added.
      e24e1668
    • Michael Widenius's avatar
      Fixed race condition in safe_process.cc which may have caused some mysqltests... · 4a462710
      Michael Widenius authored
      Fixed race condition in safe_process.cc which may have caused some mysqltests to be reported as failed even if they succeded.
      
      mysql-test/lib/My/SafeProcess/safe_process.cc:
        Fixed race condition when getting a signal while calling waitpid()
        Don't send kill on killed processes
        Return different exit codes depending on how we die.
      4a462710
    • Michael Widenius's avatar
      Merge with 5.1 · db1d83a5
      Michael Widenius authored
      db1d83a5
    • Michael Widenius's avatar
      Fixed compiler warning · a91e89de
      Michael Widenius authored
      a91e89de
    • Michael Widenius's avatar
      Fixed syntax error and some timeing issues in test suite · 04ff96f7
      Michael Widenius authored
      mysql-test/r/func_time.result:
        Updated result
      mysql-test/t/func_time.test:
        sysdate() could be same even with one sleep(1) in between.
      storage/maria/ma_loghandler.c:
        Fixed syntax error
      04ff96f7
  11. 07 Apr, 2010 2 commits
    • Michael Widenius's avatar
      Fixed suppression of compiler/test warnings · b3426226
      Michael Widenius authored
      Fixed some timing issues in test suite
      
      
      
      mysql-test/mysql-test-run.pl:
        Added suppression of errors that comes when master is killed before slave has connect (like with rpl_udf.test)
      mysql-test/suite/funcs_1/datadict/processlist_priv.inc:
        Wait for check thread to end
      mysql-test/suite/pbxt/t/status.test:
        Added longer sleep to avoid timing issue
      support-files/compiler_warnings.supp:
        Fixed wrong suppression
      b3426226
    • Sergei Golubchik's avatar
      test fix for sol-sparc-32 · 8e122db9
      Sergei Golubchik authored
      8e122db9
  12. 06 Apr, 2010 7 commits
    • Michael Widenius's avatar
      Removed compiler warnings · 1bee5903
      Michael Widenius authored
      Removed random failures from test suite
      
      mysql-test/extra/rpl_tests/rpl_insert_id_pk.test:
        Make test predicatable.
      mysql-test/include/maria_empty_logs.inc:
        We can't use 'Threads_connected' for syncronization, as the 'check_warnings' thread that just quit may still be counted in 'Threads_connected'
        Now we just wait until MySQLD answers again, which should be good enough for our purposes
      mysql-test/suite/binlog/r/binlog_index.result:
        Updated results file
      mysql-test/suite/binlog/t/binlog_index-master.opt:
        Added option file to not get stack traces in .err file.
      mysql-test/suite/binlog/t/binlog_index.test:
        Added 'flush tables' to remove warning about crashed suppression file from logs
      mysql-test/suite/pbxt/r/multi_statement.result:
        Updated results
      mysql-test/suite/pbxt/t/multi_statement-master.opt:
        Added options so that slow query testing makes sense
      sql/events.cc:
        Don't write Event Scheduler startup message if warnings are turned off.
      sql/handler.cc:
        Removed compiler warning
      sql/log.cc:
        Removed compiler warning
      sql/mysqld.cc:
        Added option 'test-expect-abort'; If this is set, we don't write message to log in case of 'DBUG_ABORT'.
        (Gives us smaller, easier to read log files)
      sql/set_var.cc:
        Removed compiler warning
      sql/slave.cc:
        Removed compiler warning
      sql/sql_plugin.cc:
        Don't write warnings about disabled plugin if using --log_warnings=0
      storage/xtradb/include/ut0lst.h:
        Removed compiler warning
      support-files/compiler_warnings.supp:
        Supress warning from xtradb
      1bee5903
    • Sergei Golubchik's avatar
      more fixes for buildbot failures · 076a1378
      Sergei Golubchik authored
      sql/log_event.cc:
        revert a wrong attempt to get rid of a warning.
        it broke tests on x86
      sql/sql_show.cc:
        more fixes for old gcc
      076a1378
    • Sergei Golubchik's avatar
      fixes for builbot failures · 0b23966f
      Sergei Golubchik authored
      mysql-test/t/connect.test:
        replace the port correctly
      sql/set_var.cc:
        opensolaris gcc (or just an old gcc ?) does not like offsetof() as a case label.
      0b23966f
    • Sergei Golubchik's avatar
      keep acl_user->auth_string and acl_user->salt always in sync · fd3e6e37
      Sergei Golubchik authored
      print authenticated via in show grants
      fd3e6e37
    • Sergei Golubchik's avatar
      fix a warning · d04d8aa6
      Sergei Golubchik authored
      d04d8aa6
    • Igor Babaev's avatar
    • Igor Babaev's avatar
      Post review fixes. · a37899a8
      Igor Babaev authored
      a37899a8
  13. 05 Apr, 2010 2 commits
  14. 03 Apr, 2010 1 commit
  15. 02 Apr, 2010 1 commit