An error occurred fetching the project authors.
  1. 21 Dec, 2006 1 commit
  2. 19 Dec, 2006 1 commit
    • unknown's avatar
      Added innodb_rollback_on_timeout option to restore the 4.1 · 47b0a0b0
      unknown authored
      InnoDB timeout behavior (Bug #24200)
      
      
      mysql-test/t/innodb_mysql-master.opt:
        Set --innodb-lock-wait-timeout=2, since test for bug #24200 times out.
        
        This *could* cause random test failures if some long-running transaction concurrency is being tested.  However, such a test really should go in innodb-big or some other test file.
      47b0a0b0
  3. 05 Dec, 2006 1 commit
  4. 02 Dec, 2006 1 commit
    • unknown's avatar
      WL# 3031 · 4e72191c
      unknown authored
      Backport of functionality in private 5.2 tree. 
      
      Added new language to parser, new mysql.servers table and associated code
      to be used by the federated storage engine to allow central connection information
      per WL entry.
      
      
      libmysqld/Makefile.am:
        WL# 3031
        
        Added sql_servers.cc to libmysqld Makefile.am
      mysql-test/lib/init_db.sql:
        WL# 3031
        
        Added mysql.servers creation to init_db.sql, which is in turn called by mysql-test-run.pl
      scripts/mysql_create_system_tables.sh:
        WL# 3031
        
        Added mysql.servers table creation to script called by non-perl mysql-test-run
      sql/Makefile.am:
        WL# 3031
        
        Added sql_servers source and headers to Makefile.am to be built
      sql/lex.h:
        WL# 3031
        
        Added tokens needed for SERVERS scheme
      sql/mysql_priv.h:
        WL #3031
        
        Added sql_servers.h to mysql_priv.h so mysqld.cc and other code can link with sql_servers code
      sql/mysqld.cc:
        WL# 3031
        
        Added servers_free and servers_init to mysqld
      sql/sql_lex.cc:
        WL# 3031
        
        Added lex->server_options parameter initialisation
      sql/sql_lex.h:
        WL #3031
        
        Added SQLCOM commands needed for sql_server actions
      sql/sql_parse.cc:
        WL# 3031
        
        Added switch actions for new SQLCOM sql_server actions
      sql/sql_yacc.yy:
        WL #3031
        
        Added tokens needed for sql_servers, CREATE/DROP/ALTER server functionality
      sql/share/errmsg.txt:
        WL# 3031
        
        Added two new errors to errormsg.sys
      storage/federated/ha_federated.cc:
        WL #3031
        
        Modified federated storage engine to use new connection scheme (servers 
        table) if connection string only specifies connection name vs. complete
        URL
      storage/federated/ha_federated.h:
        WL# 3031
        
        Added new share members needed for connection scheme
      sql/sql_servers.cc:
        WL #3031
        
        sql_servers.cc - all methods required for manipulating mysql.servers table
        to work with federated new connection scheme (CREATE/ALTER/DROP SERVER ...)
      sql/sql_servers.h:
        WL #3031
        
        New header file for sql_servers functionality
      mysql-test/r/federated_server.result:
        WL #3031
        
        New test results for testing new connection scheme
      sql/sql_yacc.yy.bak:
        WL #3031
        
        Added tokens and definitions required for new CREATE/ALTER/DROP SERVER
        for sql_servers functionality. See WL for details.
      mysql-test/t/federated_server.test:
        WL #3031
        
        New test for testing CREATE/ALTER/DROP SERVER, as well as testing that
        federated works with both tradition connection scheme as well as new
        connection scheme.
      4e72191c
  5. 30 Nov, 2006 1 commit
    • unknown's avatar
      Fixed compiler warnings · 25226de9
      unknown authored
      Don't assert if my_thread_end() is called twice (common case)
      
      
      client/mysql.cc:
        Removed not used variables
      client/mysqldump.c:
        Fixed compiler warnings
      client/mysqltest.c:
        Fixed compiler warnings
      cmd-line-utils/readline/bind.c:
        Fixed compiler warnings
      cmd-line-utils/readline/histfile.c:
        Fixed compiler warnings
      extra/replace.c:
        Fixed compiler warning on windows
      extra/yassl/taocrypt/include/algebra.hpp:
        Fixed compiler warnings
      heap/hp_write.c:
        Fixed compiler warnings
      innobase/os/os0file.c:
        Fixed compiler warnings
      libmysql/libmysql.c:
        Call my_end()/my_thread_end last.
        my_end() calls free_charsets(), which allowed me to move the call
      myisam/myisampack.c:
        Fixed compiler warnings
      myisammrg/myrg_rkey.c:
        Fixed compiler warnings
      mysys/my_thr_init.c:
        More comments
        Don't assert if my_thread_end() is called twice (common case)
      ndb/src/mgmapi/mgmapi.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/Ndb.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/NdbScanOperation.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/NdbTransaction.cpp:
        Fixed compiler warnings
      ndb/src/ndbapi/Ndblist.cpp:
        Fixed compiler warnings
      server-tools/instance-manager/guardian.cc:
        Removed not used variable
      server-tools/instance-manager/portability.h:
        Removed duplicated symbol
      sql/gen_lex_hash.cc:
        Fixed compiler warning
      sql/ha_archive.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/mysqld.cc:
        Fixed compiler warnings
      sql/sql_cache.cc:
        Fixed compiler warnings
        Fixed DBUG_PRINT strings to be consistent with 5.1
      sql/tztime.cc:
        Fixed compiler warnings
      sql/uniques.cc:
        Fixed compiler warnings
      25226de9
  6. 29 Nov, 2006 1 commit
    • unknown's avatar
      Added back sql-bench directory, so that one can more easily run benchmarks on... · ee1c5226
      unknown authored
      Added back sql-bench directory, so that one can more easily run benchmarks on a server and add new benchmarks for new optimizations
      Fixed memory leak in _db_set() (Bug#24497 Valgrind warning: get_one_option)
      Don't call net_clear() on COM_QUIT. This avoids a warning from net_clear() after shutdown: "skipped ## bytes from file"
      BUG#21428: skipped 9 bytes from file: socket (3)" on "mysqladmin shutdown"
      
      
      sql-bench/test-wisconsin.sh:
        Rename: BitKeeper/deleted/.del-test-wisconsin.sh~c0b86821b5f95f26 -> sql-bench/test-wisconsin.sh
      sql-bench/test-transactions.sh:
        Rename: BitKeeper/deleted/.del-test-transactions.sh~c1c892f10c40caf -> sql-bench/test-transactions.sh
      sql-bench/test-insert.sh:
        Rename: BitKeeper/deleted/.del-test-insert.sh~893bfac9dedb79a7 -> sql-bench/test-insert.sh
      sql-bench/test-select.sh:
        Rename: BitKeeper/deleted/.del-test-select.sh~6d5cc770acf11be6 -> sql-bench/test-select.sh
      sql-bench/test-create.sh:
        Rename: BitKeeper/deleted/.del-test-create.sh~f9a1ea38c191b17a -> sql-bench/test-create.sh
      sql-bench/test-big-tables.sh:
        Rename: BitKeeper/deleted/.del-test-big-tables.sh~5b1b0c5fb623565a -> sql-bench/test-big-tables.sh
      sql-bench/test-connect.sh:
        Rename: BitKeeper/deleted/.del-test-connect.sh~382a728c949ee075 -> sql-bench/test-connect.sh
      sql-bench/test-ATIS.sh:
        Rename: BitKeeper/deleted/.del-test-ATIS.sh~e8ebff7086c95773 -> sql-bench/test-ATIS.sh
      sql-bench/test-alter-table.sh:
        Rename: BitKeeper/deleted/.del-test-alter-table.sh~eba6cfa9972fcced -> sql-bench/test-alter-table.sh
      sql-bench/innotest2b.sh:
        Rename: BitKeeper/deleted/.del-innotest2b.sh~7b99ece835e8dff3 -> sql-bench/innotest2b.sh
      sql-bench/run-all-tests.sh:
        Rename: BitKeeper/deleted/.del-run-all-tests.sh~41d6da1cf211ee95 -> sql-bench/run-all-tests.sh
      sql-bench/innotest2.sh:
        Rename: BitKeeper/deleted/.del-innotest2.sh~9c14df528285603 -> sql-bench/innotest2.sh
      sql-bench/innotest2a.sh:
        Rename: BitKeeper/deleted/.del-innotest2a.sh~e01d016a7cafdc0b -> sql-bench/innotest2a.sh
      sql-bench/innotest1a.sh:
        Rename: BitKeeper/deleted/.del-innotest1a.sh~c64f4610ae1e26fe -> sql-bench/innotest1a.sh
      sql-bench/innotest1b.sh:
        Rename: BitKeeper/deleted/.del-innotest1b.sh~aafd0819ae84da7b -> sql-bench/innotest1b.sh
      sql-bench/innotest1.sh:
        Rename: BitKeeper/deleted/.del-innotest1.sh~aa36bce09ca783c7 -> sql-bench/innotest1.sh
      sql-bench/crash-me.sh:
        Rename: BitKeeper/deleted/.del-crash-me.sh~2fa881d0b40339c8 -> sql-bench/crash-me.sh
      sql-bench/graph-compare-results.sh:
        Rename: BitKeeper/deleted/.del-graph-compare-results.sh~7e4e28b3591b4542 -> sql-bench/graph-compare-results.sh
      sql-bench/copy-db.sh:
        Rename: BitKeeper/deleted/.del-copy-db.sh~e8116afb93144ccd -> sql-bench/copy-db.sh
      sql-bench/compare-results.sh:
        Rename: BitKeeper/deleted/.del-compare-results.sh~a9e26e2644c694b3 -> sql-bench/compare-results.sh
      sql-bench/bench-count-distinct.sh:
        Rename: BitKeeper/deleted/.del-bench-count-distinct.sh~a92f174271a831d7 -> sql-bench/bench-count-distinct.sh
      sql-bench/as3ap.sh:
        Rename: BitKeeper/deleted/.del-as3ap.sh~f54eebbd8d34c9b6 -> sql-bench/as3ap.sh
      sql-bench/Comments/Informix.crash-me:
        Rename: BitKeeper/deleted/.del-Informix.crash-me~51ab5b717cefe74 -> sql-bench/Comments/Informix.crash-me
      sql-bench/Comments/postgres.crash-me:
        Rename: BitKeeper/deleted/.del-postgres.crash-me~eacac145c3e30f17 -> sql-bench/Comments/postgres.crash-me
      sql-bench/Comments/Empress.crash-me:
        Rename: BitKeeper/deleted/.del-Empress.crash-me~bdaff0c68ce10f02 -> sql-bench/Comments/Empress.crash-me
      sql-bench/Comments/Adabas.crash-me:
        Rename: BitKeeper/deleted/.del-Adabas.crash-me~ce88ba1a540971ac -> sql-bench/Comments/Adabas.crash-me
      sql-bench/Comments/Access.crash-me:
        Rename: BitKeeper/deleted/.del-Access.crash-me~bb457ec282d939b6 -> sql-bench/Comments/Access.crash-me
      sql-bench/Comments/postgres.benchmark:
        Rename: BitKeeper/deleted/.del-postgres.benchmark~4d30890732b784a -> sql-bench/Comments/postgres.benchmark
      sql-bench/Comments/mysql.benchmark:
        Rename: BitKeeper/deleted/.del-mysql.benchmark~4d8729c0937456fc -> sql-bench/Comments/mysql.benchmark
      sql-bench/Comments/FrontBase.benchmark:
        Rename: BitKeeper/deleted/.del-FrontBase.benchmark~217041ef18274c2e -> sql-bench/Comments/FrontBase.benchmark
      sql-bench/Comments/interbase:
        Rename: BitKeeper/deleted/.del-interbase~cdad59622b4d6f3 -> sql-bench/Comments/interbase
      sql-bench/uname.bat:
        Rename: BitKeeper/deleted/.del-uname.bat~a6d933d2ee9314c -> sql-bench/uname.bat
      sql-bench/pwd.bat:
        Rename: BitKeeper/deleted/.del-pwd.bat~9b64050849abf51 -> sql-bench/pwd.bat
      sql-bench/example.bat:
        Rename: BitKeeper/deleted/.del-example.bat~22d0170bccf0f030 -> sql-bench/example.bat
      sql-bench/Makefile.am:
        Rename: BitKeeper/deleted/.del-Makefile.am~7b07da85b2e9375 -> sql-bench/Makefile.am
      sql-bench/Data/ATIS/transport.txt:
        Rename: BitKeeper/deleted/.del-transport.txt~fa4ca40735f8354c -> sql-bench/Data/ATIS/transport.txt
      sql-bench/Data/ATIS/time_zone.txt:
        Rename: BitKeeper/deleted/.del-time_zone.txt~4171f9ca732f65c0 -> sql-bench/Data/ATIS/time_zone.txt
      sql-bench/Data/Wisconsin/tenk.data:
        Rename: BitKeeper/deleted/.del-tenk.data~6aeaebdd534e458e -> sql-bench/Data/Wisconsin/tenk.data
      sql-bench/Data/Wisconsin/onek.data:
        Rename: BitKeeper/deleted/.del-onek.data~6cd1edaf596a7f7 -> sql-bench/Data/Wisconsin/onek.data
      sql-bench/Data/ATIS/stop1.txt:
        Rename: BitKeeper/deleted/.del-stop1.txt~f09ba164ad44a288 -> sql-bench/Data/ATIS/stop1.txt
      sql-bench/Data/ATIS/time_interval.txt:
        Rename: BitKeeper/deleted/.del-time_interval.txt~a1def62e267a59b2 -> sql-bench/Data/ATIS/time_interval.txt
      sql-bench/Data/ATIS/stop.txt:
        Rename: BitKeeper/deleted/.del-stop.txt~31fb564e1f415e34 -> sql-bench/Data/ATIS/stop.txt
      sql-bench/Data/ATIS/restriction.txt:
        Rename: BitKeeper/deleted/.del-restriction.txt~6ae208924617784a -> sql-bench/Data/ATIS/restriction.txt
      sql-bench/Data/ATIS/state.txt:
        Rename: BitKeeper/deleted/.del-state.txt~9dd470ce14075b90 -> sql-bench/Data/ATIS/state.txt
      sql-bench/Data/ATIS/restrict_class.txt:
        Rename: BitKeeper/deleted/.del-restrict_class.txt~2f741bf0ea498f84 -> sql-bench/Data/ATIS/restrict_class.txt
      sql-bench/Data/ATIS/month_name.txt:
        Rename: BitKeeper/deleted/.del-month_name.txt~4c44f7a323d57d92 -> sql-bench/Data/ATIS/month_name.txt
      sql-bench/Data/ATIS/restrict_carrier.txt:
        Rename: BitKeeper/deleted/.del-restrict_carrier.txt~925b5492f3f9cba3 -> sql-bench/Data/ATIS/restrict_carrier.txt
      sql-bench/Data/ATIS/ground_service.txt:
        Rename: BitKeeper/deleted/.del-ground_service.txt~1087e477e86e84c -> sql-bench/Data/ATIS/ground_service.txt
      sql-bench/Data/ATIS/food_service.txt:
        Rename: BitKeeper/deleted/.del-food_service.txt~66d95a150c28458 -> sql-bench/Data/ATIS/food_service.txt
      sql-bench/Data/ATIS/flight_day.txt:
        Rename: BitKeeper/deleted/.del-flight_day.txt~76868d6d265d441e -> sql-bench/Data/ATIS/flight_day.txt
      sql-bench/Data/ATIS/flight_fare.txt:
        Rename: BitKeeper/deleted/.del-flight_fare.txt~d7322593c8530487 -> sql-bench/Data/ATIS/flight_fare.txt
      sql-bench/Data/ATIS/flight_class.txt:
        Rename: BitKeeper/deleted/.del-flight_class.txt~1801101474c29098 -> sql-bench/Data/ATIS/flight_class.txt
      sql-bench/Data/ATIS/fconnection.txt:
        Rename: BitKeeper/deleted/.del-fconnection.txt~e0ef6a8b5560a713 -> sql-bench/Data/ATIS/fconnection.txt
      sql-bench/Data/ATIS/flight.txt:
        Rename: BitKeeper/deleted/.del-flight.txt~e5065423760e99eb -> sql-bench/Data/ATIS/flight.txt
      sql-bench/Data/ATIS/fare.txt:
        Rename: BitKeeper/deleted/.del-fare.txt~ea0652f490bc24a6 -> sql-bench/Data/ATIS/fare.txt
      sql-bench/Data/ATIS/day_name.txt:
        Rename: BitKeeper/deleted/.del-day_name.txt~f813b215955d894c -> sql-bench/Data/ATIS/day_name.txt
      sql-bench/Data/ATIS/dual_carrier.txt:
        Rename: BitKeeper/deleted/.del-dual_carrier.txt~a7dd776224fbd92b -> sql-bench/Data/ATIS/dual_carrier.txt
      sql-bench/Data/ATIS/date_day.txt:
        Rename: BitKeeper/deleted/.del-date_day.txt~4e9a282fcf54cfd8 -> sql-bench/Data/ATIS/date_day.txt
      sql-bench/Data/ATIS/compound_class.txt:
        Rename: BitKeeper/deleted/.del-compound_class.txt~d4a2f1b7f96340b9 -> sql-bench/Data/ATIS/compound_class.txt
      sql-bench/Data/ATIS/connect_leg.txt:
        Rename: BitKeeper/deleted/.del-connect_leg.txt~f97b6e94e108bb36 -> sql-bench/Data/ATIS/connect_leg.txt
      sql-bench/Data/ATIS/code_description.txt:
        Rename: BitKeeper/deleted/.del-code_description.txt~f9117373e438b0e2 -> sql-bench/Data/ATIS/code_description.txt
      sql-bench/Data/ATIS/city.txt:
        Rename: BitKeeper/deleted/.del-city.txt~d96dd6d073344d2e -> sql-bench/Data/ATIS/city.txt
      sql-bench/Data/ATIS/class_of_service.txt:
        Rename: BitKeeper/deleted/.del-class_of_service.txt~21f6b9848b8c76d -> sql-bench/Data/ATIS/class_of_service.txt
      sql-bench/Data/ATIS/airport_service.txt:
        Rename: BitKeeper/deleted/.del-airport_service.txt~6ee6d5b852b3e38 -> sql-bench/Data/ATIS/airport_service.txt
      sql-bench/Data/ATIS/airline.txt:
        Rename: BitKeeper/deleted/.del-airline.txt~a79f8eadf853f2c8 -> sql-bench/Data/ATIS/airline.txt
      sql-bench/Data/ATIS/airport.txt:
        Rename: BitKeeper/deleted/.del-airport.txt~59c78514130e1f45 -> sql-bench/Data/ATIS/airport.txt
      sql-bench/Data/ATIS/aircraft.txt:
        Rename: BitKeeper/deleted/.del-aircraft.txt~15e4de7ab37c92d3 -> sql-bench/Data/ATIS/aircraft.txt
      sql-bench/TODO:
        Rename: BitKeeper/deleted/.del-TODO~cac6d7a63c426ae5 -> sql-bench/TODO
      sql-bench/limits/sybase.cfg:
        Rename: BitKeeper/deleted/.del-sybase.cfg~c4636b12767b3f14 -> sql-bench/limits/sybase.cfg
      sql-bench/limits/solid-nt4.cfg:
        Rename: BitKeeper/deleted/.del-solid-nt4.cfg~cca779f0c9e29d31 -> sql-bench/limits/solid-nt4.cfg
      sql-bench/limits/solid.cfg:
        Rename: BitKeeper/deleted/.del-solid.cfg~5ae0e4342eadb0fb -> sql-bench/limits/solid.cfg
      sql-bench/limits/pg.cfg:
        Rename: BitKeeper/deleted/.del-pg.cfg~db59cf39a5d417be -> sql-bench/limits/pg.cfg
      sql-bench/limits/mysql.cfg:
        Rename: BitKeeper/deleted/.del-mysql.cfg~9cab20a8771b93cf -> sql-bench/limits/mysql.cfg
      sql-bench/limits/oracle.cfg:
        Rename: BitKeeper/deleted/.del-oracle.cfg~affab21af8f438fd -> sql-bench/limits/oracle.cfg
      sql-bench/limits/mysql-4.1.cfg:
        Rename: BitKeeper/deleted/.del-mysql-4.1.cfg~b6c5e74aefc99e3c -> sql-bench/limits/mysql-4.1.cfg
      sql-bench/limits/mysql-3.23.cfg:
        Rename: BitKeeper/deleted/.del-mysql-3.23.cfg~3cf9d6be54b77a3c -> sql-bench/limits/mysql-3.23.cfg
      sql-bench/limits/mysql-4.0.cfg:
        Rename: BitKeeper/deleted/.del-mysql-4.0.cfg~6c9d63c85b5ef574 -> sql-bench/limits/mysql-4.0.cfg
      sql-bench/limits/mysql-3.22.cfg:
        Rename: BitKeeper/deleted/.del-mysql-3.22.cfg~e706f26a161175cd -> sql-bench/limits/mysql-3.22.cfg
      sql-bench/limits/msql.cfg:
        Rename: BitKeeper/deleted/.del-msql.cfg~52710b12932cceb9 -> sql-bench/limits/msql.cfg
      sql-bench/limits/ms-sql65.cfg:
        Rename: BitKeeper/deleted/.del-ms-sql65.cfg~6b9bc3c460dbee05 -> sql-bench/limits/ms-sql65.cfg
      sql-bench/limits/mimer.cfg:
        Rename: BitKeeper/deleted/.del-mimer.cfg~234e6c1c3c47b612 -> sql-bench/limits/mimer.cfg
      sql-bench/limits/ms-sql.cfg:
        Rename: BitKeeper/deleted/.del-ms-sql.cfg~1907964264d2786a -> sql-bench/limits/ms-sql.cfg
      sql-bench/limits/interbase.cfg:
        Rename: BitKeeper/deleted/.del-interbase.cfg~c6951a0376cc6ff3 -> sql-bench/limits/interbase.cfg
      sql-bench/limits/interbase-dialect3.cfg:
        Rename: BitKeeper/deleted/.del-interbase-dialect3.cfg~46277bdfc74c667a -> sql-bench/limits/interbase-dialect3.cfg
      sql-bench/limits/interbase-superserver.cfg:
        Rename: BitKeeper/deleted/.del-interbase-superserver.cfg~22501198689243b0 -> sql-bench/limits/interbase-superserver.cfg
      sql-bench/limits/interbase-dialect1.cfg:
        Rename: BitKeeper/deleted/.del-interbase-dialect1.cfg~659206b5b9a11036 -> sql-bench/limits/interbase-dialect1.cfg
      sql-bench/limits/empress.cfg:
        Rename: BitKeeper/deleted/.del-empress.cfg~1f97f34d6560a499 -> sql-bench/limits/empress.cfg
      sql-bench/limits/frontbase.cfg:
        Rename: BitKeeper/deleted/.del-frontbase.cfg~71369e9c002696e -> sql-bench/limits/frontbase.cfg
      sql-bench/limits/db2.cfg:
        Rename: BitKeeper/deleted/.del-db2.cfg~711099b4d7906959 -> sql-bench/limits/db2.cfg
      sql-bench/limits/access.cfg:
        Rename: BitKeeper/deleted/.del-access.cfg~5239ea3655b7bba0 -> sql-bench/limits/access.cfg
      sql-bench/limits/access_odbc.cfg:
        Rename: BitKeeper/deleted/.del-access_odbc.cfg~34b4cf0eda56c4b1 -> sql-bench/limits/access_odbc.cfg
      sql-bench/limits/Informix.cfg:
        Rename: BitKeeper/deleted/.del-Informix.cfg~b94188e1ececb51b -> sql-bench/limits/Informix.cfg
      sql-bench/limits/Adabas.cfg:
        Rename: BitKeeper/deleted/.del-Adabas.cfg~343ed4e7f8b02111 -> sql-bench/limits/Adabas.cfg
      sql-bench/README:
        Rename: BitKeeper/deleted/.del-README~b1aa0c1bf9f5eb5e -> sql-bench/README
      BitKeeper/deleted/.del-create-pg_fast-Linux_2.2.14_my_SMP_i686-crashed:
        Delete: sql-bench/Results/create-pg_fast-Linux_2.2.14_my_SMP_i686-crashed
      Makefile.am:
        Added back sql-bench
      configure.in:
        Added back sql-bench
      dbug/dbug.c:
        Fixed memory leak in _db_set()
        This is not a complete fix as we can still get memory leaks if we do any of the following:
        mysqld --debug --debug
        CAll DBUG_SET or DBUG_SET_INITIAL more than once in a program
        Use SET @@global.debug=xxxx
        
        At some point we should fix the above, but this is not critical for normal operation (only for debugging)
        
        Bug #24497 Valgrind warning: get_one_option
        
        Note that all changes to _db_set_ is only a variable access change, and can be ignored while reviewing the bug fix.
      mysql-test/t/flush_read_lock_kill-master.opt:
        Added '+' to option, to be able to use this together with --debug
      mysql-test/valgrind.supp:
        Removed warning that is now fixed
      mysys/ptr_cmp.c:
        Fixed wrong pointer read (probably never used)
      scripts/make_binary_distribution.sh:
        Added back sql_bench
      sql/field.h:
        Removed class function that was identical in parent class
      sql/mysqld.cc:
        Removed some calls to my_thread_init() / my_thread_end() that was not needed.
        Only call DBUG_SET_INITAL, not DBUG_SET
        (Fixes memory leak in dbug)
        Mark some code as deadcode
      sql/net_serv.cc:
        Add information about from where error comes
      sql-bench/bench-init.pl.sh:
        Cleaned up help text
      sql-bench/server-cfg.sh:
        Don't write '/' after server name of no ssl version
      sql-common/client.c:
        Don't call net_clear() on COM_QUIT. This avoids a warning from net_clear() after shutdown: "skipped ## bytes from file"
        BUG#21428: skipped 9 bytes from file: socket (3)" on "mysqladmin shutdown"
      sql/sql_parse.cc:
        Added comment
      sql/table.h:
        Removed compiler warning
      ee1c5226
  7. 28 Nov, 2006 1 commit
  8. 27 Nov, 2006 3 commits
    • unknown's avatar
      Increased heap max length to > 4G for 64 bit machines · 129a48b0
      unknown authored
      Initialize key_part->type on open. This caused key_copy() to fail for bit_fields. (key_copy is used in HANDLER and opt_range)
      
      
      include/heap.h:
        Increased heap max length to > 4G for 64 bit machines
      mysql-test/r/show_check.result:
        Updated results after heap size change
      mysql-test/r/type_bit.result:
        Added test for bug in bit field handling (in handler and opt_range.cc)
      mysql-test/t/type_bit.test:
        Added test for bug in bit field handling (in handler and opt_range.cc)
      sql/ha_heap.cc:
        Increased heap max length to > 4G for 64 bit machines
      sql/item_sum.cc:
        Increased heap max length to > 4G for 64 bit machines
      sql/mysqld.cc:
        Increased heap max length to > 4G for 64 bit machines
      sql/set_var.cc:
        Increased heap max length to > 4G for 64 bit machines
      sql/sql_class.h:
        Increased heap max length to > 4G for 64 bit machines
      sql/sql_select.cc:
        Increased heap max length to > 4G for 64 bit machines
      sql/table.cc:
        Initialize key_part->type ; This was used for bit fields but only set in temporary tables
      sql/uniques.cc:
        Increased heap max length to > 4G for 64 bit machines
      129a48b0
    • unknown's avatar
    • unknown's avatar
      Removed compiler warnings · c1477a3f
      unknown authored
      Ensure that my_size_t is always unsigned (to get predictiable results from system to system)
      Removed some %lld, as these are not portable
      
      
      BUILD/FINISH.sh:
        Remove configure files from storage engines (as some of them may be old versions and may cause conflicts)
      client/mysqldump.c:
        Removed compiler warning
      client/mysqlslap.c:
        Removed compiler warning
      client/mysqltest.c:
        Removed compiler warning
      cmd-line-utils/readline/bind.c:
        Removed compiler warning
      cmd-line-utils/readline/histfile.c:
        Removed compiler warning
      include/my_global.h:
        Ensure that my_size_t is always unsigned (to get predictiable results from system to system)
        Moved my_offset_t here from parse_file.h
      sql/event_data_objects.cc:
        Removed compiler warning
      sql/event_scheduler.cc:
        Removed compiler warning
      sql/field.h:
        Removed compiler warning
      sql/ha_ndbcluster_binlog.cc:
        Removed compiler warning
      sql/ha_partition.cc:
        Removed compiler warning
      sql/item_strfunc.cc:
        Removed compiler warning
      sql/log_event.cc:
        Removed compiler warning
      sql/mysqld.cc:
        Removed compiler warning
      sql/parse_file.h:
        Moved my_offset_t to my_global.h
      sql/rpl_utility.cc:
        Removed compiler warning
      sql/sql_binlog.cc:
        Removed compiler warning
      sql/sql_cache.cc:
        Removed compiler warning
      sql/tztime.cc:
        Removed compiler warning
      storage/archive/ha_archive.cc:
        Removed compiler warning
        Removed %lld as it's not portable
      storage/heap/hp_write.c:
        Removed compiler warning
      storage/innobase/os/os0file.c:
        Removed compiler warning
      storage/myisam/myisampack.c:
        Removed compiler warning
      storage/myisammrg/myrg_rkey.c:
        Removed compiler warning
      storage/ndb/include/kernel/signaldata/DictTabInfo.hpp:
        Use my_offsetof instead of offsetof to get rid of compiler warnings
      storage/ndb/src/kernel/blocks/dbdict/printSchemaFile.cpp:
        Removed compiler warning
      storage/ndb/src/kernel/blocks/dbtup/DbtupRoutines.cpp:
        Removed compiler warning
        Note: Someone from NDB team should check this fix!
      storage/ndb/src/kernel/vm/Rope.cpp:
        Removed compiler warning
      storage/ndb/src/mgmapi/mgmapi.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/Ndb.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/NdbTransaction.cpp:
        Removed compiler warning
      storage/ndb/src/ndbapi/Ndblist.cpp:
        Removed compiler warning
      c1477a3f
  9. 26 Nov, 2006 1 commit
    • unknown's avatar
      Fixed a LOT of compiler warnings · 788ad30f
      unknown authored
      Added missing DBUG_RETURN statements (in mysqldump.c)
      Added missing enums
      Fixed a lot of wrong DBUG_PRINT() statements, some of which could cause crashes
      Removed usage of %lld and %p in printf strings as these are not portable or produces different results on different systems.
      
      
      client/mysqldump.c:
        Fixed some compiler warnings
        Added some missing DBUG_RETURN
        Remove copying of 'cluster' database
      client/mysqlslap.c:
        Fixed compiler warnings
      client/mysqltest.c:
        After merge fix
      extra/yassl/taocrypt/include/algebra.hpp:
        Removed compiler warning
      mysql-test/include/im_check_env.inc:
        Fixed race condition (mysqld1 could report 'starting' or 'online'
      mysql-test/mysql-test-run.pl:
        After merge fixes
        Added missing directory to LD_LIBRARY_PATH
      mysql-test/r/ctype_cp1250_ch.result:
        After merge fix
      mysql-test/r/im_cmd_line.result:
        Fixed race condition
      mysql-test/r/im_daemon_life_cycle.result:
        Fixed race condition
      mysql-test/r/im_instance_conf.result:
        Fixed race condition
      mysql-test/r/im_life_cycle.result:
        Fixed race condition
      mysql-test/r/im_utils.result:
        Fixed race condition
      mysql-test/r/log_tables.result:
        Fixed wrong result
      mysql-test/t/disabled.def:
        Disabled ndb_restore_partion, as ndb_restore_compate caused it to fail, becasue of table 'cluster/def/schema' which is stored in ndb_backup50
      mysys/my_compress.c:
        Removed compiler warnings
      mysys/my_getopt.c:
        Ensure we always have at least one space between option name and value
      plugin/fulltext/plugin_example.c:
        Removed compiler warnings
      server-tools/instance-manager/mysql_connection.cc:
        After merge fix
      sql/event_data_objects.cc:
        Fixed compiler warnings
        Fixed platform compatibility issues (%lld is not portable)
      sql/event_data_objects.h:
        Fixed compiler warnings
      sql/event_db_repository.cc:
        Fixed compiler warnings
      sql/event_queue.cc:
        Fixed compiler warnings
      sql/event_scheduler.cc:
        Fixed compiler warnings
      sql/events.cc:
        Fixed compiler warnings
      sql/field.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster.cc:
        Fixed compiler warnings
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warnings
      sql/ha_partition.cc:
        Fixed compiler warnings
      sql/handler.cc:
        Fixed compiler warnings
      sql/item_cmpfunc.cc:
        Fixed DBUG_PRINT style
      sql/item_func.cc:
        Fixed compiler warnings
      sql/log.cc:
        Fixed compiler warnings
      sql/log_event.cc:
        Fixed compiler warnings
      sql/mysqld.cc:
        Fixed compiler warnings
      sql/opt_range.cc:
        Fixed compiler warnings
      sql/repl_failsafe.cc:
        Indentation fixes
      sql/rpl_rli.cc:
        Fixed compiler warnings
      sql/rpl_tblmap.cc:
        Fixed compiler warnings
      sql/set_var.cc:
        Fixed compiler warnings
      sql/slave.cc:
        Fixed compiler warnings
      sql/sp_head.cc:
        Fixed compiler warnings
      sql/sql_base.cc:
        Fixed compiler warnings
        Fixed indentation
      sql/sql_binlog.cc:
        Fixed compiler warnings
      sql/sql_cache.cc:
        Fixed compiler warnings
      sql/sql_class.cc:
        Fixed compiler warnings
      sql/sql_handler.cc:
        Fixed compiler warnings
      sql/sql_lex.cc:
        Fixed compiler warnings
      sql/sql_parse.cc:
        Fixed compiler warnings
      sql/sql_partition.cc:
        Fixed compiler warnings
      sql/sql_prepare.cc:
        Fixed compiler warnings
      sql/sql_table.cc:
        Fixed compiler warnings
      sql/sql_test.cc:
        Fixed DBUG_PRINT style
      sql/sql_trigger.cc:
        Fixed DBUG_PRINT style
      sql/table.cc:
        Fixed compiler warnings
      storage/federated/ha_federated.cc:
        Fixed compiler warnings
      storage/myisam/mi_rsamepos.c:
        Fixed compiler warnings
      storage/ndb/include/ndb_global.h.in:
        After merge fix
      storage/ndb/include/util/NdbOut.hpp:
        Inform gcc that ndbout_c takes a printf() string as argument
      storage/ndb/include/util/SimpleProperties.hpp:
        After merge fixes
      storage/ndb/src/kernel/blocks/backup/Backup.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbacc/DbaccMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbdih/DbdihMain.cpp:
        Fixed compiler warnings
        Fixed usage of uninitialized value (Got help from Jonas with patch)
      storage/ndb/src/kernel/blocks/dblqh/DblqhMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/lgman.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/pgman.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/restore.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtc/DbtcMain.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupCommit.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupDiskAlloc.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupExecQuery.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/dbtup/DbtupFixAlloc.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/ndbfs/Ndbfs.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/blocks/suma/Suma.cpp:
        Fixed compiler warnings
        Added missing enum's to switch
      storage/ndb/src/kernel/vm/Configuration.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/DLHashTable.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/RWPool.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/SimulatedBlock.cpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/WOPool.hpp:
        Fixed compiler warnings
      storage/ndb/src/kernel/vm/ndbd_malloc_impl.cpp:
        Fixed compiler warnings
      storage/ndb/src/mgmclient/CommandInterpreter.cpp:
        Fixed compiler warnings
      storage/ndb/src/mgmsrv/MgmtSrvr.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/DictCache.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbDictionaryImpl.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbEventOperationImpl.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbIndexOperation.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbIndexStat.cpp:
        Initialize possible uninitialized variable
      storage/ndb/src/ndbapi/NdbOperationInt.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/NdbRecAttr.cpp:
        Added missing enum's (To avoid compiler warnings)
      storage/ndb/src/ndbapi/NdbScanOperation.cpp:
        Fixed compiler warnings
      storage/ndb/src/ndbapi/ObjectMap.hpp:
        Fixed compiler warnings
      storage/ndb/tools/desc.cpp:
        Fixed compiler warnings
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warnings
      storage/ndb/tools/restore/consumer_restore.cpp:
        Fixed compiler warnings
      unittest/mytap/t/basic-t.c:
        Fixed compiler warnings
      unittest/mytap/tap.c:
        Fixed compiler warnings
      788ad30f
  10. 21 Nov, 2006 3 commits
    • unknown's avatar
      Added --debug-info to most clients to detect memory leaks in mysql-test-run · 85a590a2
      unknown authored
      Moved .progress files into the log directory
      Moved 'cluster' database tables into the MySQL database, to not have 'cluster' beeing a reserved database name
      Fixed bug where mysqld got a core dump when trying to use a table created by MySQL 3.23
      Fixed some compiler warnings
      Fixed small memory leak in libmysql
      Note that this doesn't changeset doesn't include the new mysqldump.c code required to run some tests. This will be added when I merge 5.0 to 5.1
      
      
      client/client_priv.h:
        Added OPT_DEBUG_INFO and OPT_COLUMN_TYPES
      client/mysql.cc:
        Split --debug-info into --debug-info and --column-type-info
      client/mysql_upgrade.c:
        Give only error info at end if using --debug-info
      client/mysqladmin.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlbinlog.cc:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlcheck.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlimport.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqlshow.c:
        Added --debug-info to detect memory leaks in mysqltest
      client/mysqltest.c:
        Added --debug-info to detect memory leaks in mysqltest
        Added option --logdir to force .progress files in a specific directory
      libmysql/libmysql.c:
        Fixed memory leak
      mysql-test/include/ndb_setup_slave.inc:
        Moved cluster tables under 'mysql'
      mysql-test/include/query_cache.inc:
        Added more tests for query cache
      mysql-test/lib/init_db.sql:
        Move cluster.binlog_index -> mysql.binlog_index
      mysql-test/lib/mtr_report.pl:
        Find memory leaks
      mysql-test/mysql-test-run-shell.sh:
        Added --debug-info to programs to detect memory leaks
      mysql-test/mysql-test-run.pl:
        Added --debug-info to programs to detect memory leaks
        Force log files to var/log
        cluster tables moved under 'mysql'
      mysql-test/r/cache_innodb.result:
        New query cache test with innodb
      mysql-test/r/connect.result:
        binlog_index is now in mysql
      mysql-test/r/drop.result:
        Removed 'cluster' database
      mysql-test/r/information_schema.result:
        Removed 'cluster' database
      mysql-test/r/mysqlcheck.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_basic.result:
        cluster.binlog_index -> mysql.binlog_index
      mysql-test/r/ndb_binlog_ddl_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_discover.result:
        cluster -> mysql
      mysql-test/r/ndb_binlog_multi.result:
        cluster -> mysql
      mysql-test/r/ndb_restore_compat.result:
        cluster -> mysql
      mysql-test/r/ps_1general.result:
        Removed cluster database
      mysql-test/r/rpl_create_database.result:
        Removed cluster database
      mysql-test/r/rpl_load_from_master.result:
        Removed cluster database
      mysql-test/r/rpl_loaddata_m.result:
        Removed cluster database
      mysql-test/r/rpl_ndb_bank.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_advance.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_dd_basic.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_idempotent.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_log.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_multi.result:
        cluster -> mysql
      mysql-test/r/rpl_ndb_sync.result:
        cluster -> mysql
      mysql-test/r/rpl_row_basic_11bugs.result:
        Removed cluster database
      mysql-test/r/rpl_truncate_7ndb.result:
        Position have changed
      mysql-test/r/rpl_truncate_7ndb_2.result:
        cluster -> mysql
      mysql-test/r/schema.result:
        Removed cluster database
      mysql-test/r/show_check.result:
        Removed cluster database
      mysql-test/r/system_mysql_db.result:
        binlog_index moved under mysql
      mysql-test/r/upgrade.result:
        More tests
      mysql-test/t/information_schema.test:
        cluster -> mysql
      mysql-test/t/mysqldump.test:
        More test to detect memory leaks
      mysql-test/t/ndb_binlog_basic.test:
        cluster -> mysql
      mysql-test/t/ndb_binlog_multi.test:
        cluster -> mysql
      mysql-test/t/ndb_restore_compat.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_bank.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_dd_advance.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_idempotent.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_multi.test:
        cluster -> mysql
      mysql-test/t/rpl_ndb_sync.test:
        cluster -> mysql
      mysql-test/t/system_mysql_db_fix.test:
        Drop also binlog_index
      mysql-test/t/upgrade.test:
        Check that tables created with 3.23 works
      mysys/my_error.c:
        Remove all registered errors (to avoid memory leaks)
      mysys/my_init.c:
        call my_error_unregister_all() to avoid some possible memory leaks
      mysys/mysys_priv.h:
        Added prototype
      scripts/mysql_create_system_tables.sh:
        cluster -> mysql
      scripts/mysql_fix_privilege_tables.sql:
        Changed -- to #
        Create binlog_index table if it dosesn't exist
      sql/field.cc:
        Made offset() inline
      sql/field.h:
        Changed prototype of offset() to not make it depending on TABLE structure
      sql/field_conv.cc:
        Removed some usage of current_thd
      sql/ha_ndbcluster_tables.h:
        cluster -> mysql
      sql/item_sum.cc:
        Usage of new 'offset' parameters
      sql/key.cc:
        Changed 'find_ref_key' to not be dependent on field->table
        (This fixed a crash when using a table created in MySQL 3.23)
      sql/mysql_priv.h:
        Changed find_ref_key() to not use field->table
      sql/mysqld.cc:
        Fix that plugin_init() works properly on bootstrap
        (Previously we got warnings from plugin_init)
      sql/sql_class.cc:
        new 'field->offset()'
      sql/sql_select.cc:
        New field->offset()
      sql/table.cc:
        We don't need field->table to be set in find_ref_key() or find_field() anymore.
      storage/archive/ha_archive.cc:
        New field->offset()
      storage/federated/ha_federated.cc:
        New field->offset()
      storage/innobase/handler/ha_innodb.cc:
        Fixed compiler warnings
      storage/myisam/ha_myisam.cc:
        Fixed compiler warnings (Wrong paramter to sprintf())
        New field->offset()
      storage/myisam/ha_myisam.h:
        Fixed wrong type of table_flags
      storage/ndb/tools/restore/Restore.cpp:
        Fixed compiler warning
      mysql-test/r/1st.result:
        New BitKeeper file ``mysql-test/r/1st.result''
      mysql-test/std_data/old_table-323.frm:
        New BitKeeper file ``mysql-test/std_data/old_table-323.frm''
      mysql-test/t/1st.test:
        New BitKeeper file ``mysql-test/t/1st.test''
      85a590a2
    • unknown's avatar
      Update after merge. · 5e1c2e36
      unknown authored
      Use mutex when reading prepared_stmt_count global status variable.
      
      Update test case for bug 16365 and bug 23159: add test for
      prepared_stmt_count being decreased when some connection that had
      prepared statements is closed.
      
      
      mysql-test/r/ps.result:
        Update result for bug#16365 and bug#23159.
      mysql-test/t/ps.test:
        Update test case for bug#16365 and bug#23159: add test for
        prepared_stmt_count being decreased when some connection that had
        prepared statements is closed.
      sql/mysqld.cc:
        Use mutex when reading prepared_stmt_count global status variable.
      5e1c2e36
    • unknown's avatar
      BUG#23159: prepared_stmt_count should be status variable · 7a45fb54
      unknown authored
      Make Prepared_stmt_count a global status variable, accessible via
      SHOW STATUS LIKE 'Prepared_stmt_count';.  Documentation should be
      updated.
      
      
      mysql-test/r/ps.result:
        Update result for bug#16365: Prepared Statements: DoS with too many
        open statements, according to bug#23159: prepared_stmt_count should be
        status variable.
      mysql-test/t/ps.test:
        Update test case for bug#16365: Prepared Statements: DoS with too many
        open statements, according to bug#23159: prepared_stmt_count should be
        status variable.
      sql/mysqld.cc:
        Add Prepared_stmt_count as global status variable.
      sql/set_var.cc:
        Remove prepared_stmt_count as system variable.
      7a45fb54
  11. 20 Nov, 2006 2 commits
    • unknown's avatar
      This straightens up usage of have_ variables, and removes dead -skip-isam option. · b894f480
      unknown authored
      mysql-test/r/warnings.result:
        Modified skip to use NDB.
      mysql-test/t/warnings-master.opt:
        Removed dead options
      mysql-test/t/warnings.test:
        Updated test to use NDB
      sql/mysql_priv.h:
        Removed dead have_ variables
      sql/mysqld.cc:
        Removed dead options (one which was never documenteD).
      sql/set_var.cc:
        Removed have_ variables for prefered usage of show engines
      storage/federated/ha_federated.cc:
        Removed head variable
      storage/myisammrg/ha_myisammrg.cc:
        Updated to use correct state
      b894f480
    • unknown's avatar
      Remove compiler warnings · 14decc4f
      unknown authored
      (Mostly in DBUG_PRINT() and unused arguments)
      Fixed bug in query cache when used with traceing (--with-debug)
      Fixed memory leak in mysqldump
      Removed warnings from mysqltest scripts (replaced -- with #)
      
      
      BitKeeper/etc/ignore:
        added mysql-test/r/*.warnings
      BUILD/SETUP.sh:
        Don't build with BDB as default
      client/client_priv.h:
        Added OPT_DEBUG_INFO
      client/mysqlbinlog.cc:
        Fixed compiler warning
      client/mysqldump.c:
        Removed compiler warnings
        Added option --debug-info to detect memory leaks
        Fixed memory leak
        Don't backup cluster replication tables (if used with 5.1)
      cmd-line-utils/readline/bind.c:
        Fixed compiler warning
      cmd-line-utils/readline/chardefs.h:
        Fixed compiler warning
      cmd-line-utils/readline/complete.c:
        Fixed compiler warning
      cmd-line-utils/readline/display.c:
        Fixed compiler warning
      cmd-line-utils/readline/histexpand.c:
        Fixed compiler warning
      cmd-line-utils/readline/input.c:
        Fixed compiler warning
      cmd-line-utils/readline/isearch.c:
        Fixed compiler warning
      cmd-line-utils/readline/kill.c:
        Fixed compiler warning
      cmd-line-utils/readline/macro.c:
        Fixed compiler warning
      cmd-line-utils/readline/misc.c:
        Fixed compiler warning
      cmd-line-utils/readline/nls.c:
        Fixed compiler warning
      cmd-line-utils/readline/readline.c:
        Fixed compiler warning
      cmd-line-utils/readline/rltty.c:
        Fixed compiler warning
      cmd-line-utils/readline/search.c:
        Fixed compiler warning
      cmd-line-utils/readline/terminal.c:
        Fixed compiler warning
      cmd-line-utils/readline/text.c:
        Fixed compiler warning
      cmd-line-utils/readline/tilde.c:
        Fixed compiler warning
      cmd-line-utils/readline/undo.c:
        Fixed compiler warning
      cmd-line-utils/readline/util.c:
        Fixed compiler warning
      cmd-line-utils/readline/vi_mode.c:
        Fixed compiler warning
      dbug/dbug_analyze.c:
        Fixed compiler warning
      extra/yassl/src/ssl.cpp:
        Fixed compiler warning
      extra/yassl/testsuite/testsuite.cpp:
        Fixed compiler warning
      heap/_check.c:
        Fixed compiler warning
      heap/hp_delete.c:
        Fixed compiler warning
      heap/hp_hash.c:
        Fixed compiler warning
      heap/hp_open.c:
        Fixed compiler warning
      heap/hp_rkey.c:
        Fixed compiler warning
      heap/hp_rrnd.c:
        Fixed compiler warning
      heap/hp_write.c:
        Fixed compiler warning
      libmysql/libmysql.c:
        Fixed compiler warning
      libmysqld/libmysqld.c:
        Fixed compiler warning
      myisam/mi_close.c:
        Fixed compiler warning
      myisam/mi_delete.c:
        Fixed compiler warning
      myisam/mi_dynrec.c:
        Fixed compiler warning
      myisam/mi_keycache.c:
        Fixed compiler warning
      myisam/mi_page.c:
        Fixed compiler warning
      myisam/mi_statrec.c:
        Fixed compiler warning
      myisam/mi_test2.c:
        Fixed compiler warning
      myisam/mi_write.c:
        Fixed compiler warning
      myisam/myisampack.c:
        Fixed compiler warning
      myisammrg/myrg_extra.c:
        Fixed compiler warning
      mysql-test/mysql-test-run.pl:
        Remove .reject, .progress, .log and .warnings flag at start
        cluster -> mysql database (for 5.1)
      mysql-test/include/federated.inc:
        Remove mysqltest warnings
      mysql-test/include/sp-vars.inc:
        Remove mysqltest warnings
      mysql-test/mysql-test-run.sh:
        Fix so that 'make test' works again
        Remove .reject, .progress .log and .warnings files at startup
      mysql-test/r/ctype_cp1250_ch.result:
        Drop used tables at startup
      mysql-test/t/create.test:
        Remove mysqltest warnings
      mysql-test/t/csv.test:
        Remove mysqltest warnings
      mysql-test/t/ctype_collate.test:
        Remove mysqltest warnings
      mysql-test/t/ctype_cp1250_ch.test:
        Drop used tables at startup
      mysql-test/t/ctype_ucs.test:
        Remove mysqltest warnings
      mysql-test/t/func_sapdb.test:
        Remove mysqltest warnings
      mysql-test/t/func_str.test:
        Remove mysqltest warnings
      mysql-test/t/grant.test:
        Remove mysqltest warnings
      mysql-test/t/greedy_optimizer.test:
        Remove mysqltest warnings
      mysql-test/t/group_min_max.test:
        Remove mysqltest warnings
      mysql-test/t/innodb.test:
        Remove mysqltest warnings
      mysql-test/t/join.test:
        Remove mysqltest warnings
      mysql-test/t/limit.test:
        Remove mysqltest warnings
      mysql-test/t/null.test:
        Remove mysqltest warnings
      mysql-test/t/select.test:
        Remove mysqltest warnings
      mysql-test/t/sp-prelocking.test:
        Remove mysqltest warnings
      mysql-test/t/strict.test:
        Remove mysqltest warnings
      mysql-test/t/subselect.test:
        Remove mysqltest warnings
      mysql-test/t/type_newdecimal.test:
        Remove mysqltest warnings
      mysql-test/t/view_grant.test:
        Remove mysqltest warnings
      mysys/default.c:
        Fixed compiler warning
      mysys/hash.c:
        Fixed compiler warning
      mysys/list.c:
        Fixed compiler warning
      mysys/mf_iocache.c:
        Fixed compiler warning
      mysys/mf_keycache.c:
        Fixed compiler warning
      mysys/mf_keycaches.c:
        Fixed compiler warning
      mysys/my_alloc.c:
        Fixed compiler warning
      mysys/my_dup.c:
        Fixed compiler warning
      mysys/my_fopen.c:
        Fixed compiler warning
      mysys/my_fstream.c:
        Fixed compiler warning
      mysys/my_getwd.c:
        Fixed compiler warning
      mysys/my_handler.c:
        Fixed compiler warning
        Added missing enums in switch
      mysys/my_lib.c:
        Fixed compiler warning
      mysys/my_lread.c:
        Fixed compiler warning
      mysys/my_lwrite.c:
        Fixed compiler warning
      mysys/my_malloc.c:
        Fixed compiler warning
      mysys/my_pread.c:
        Fixed compiler warning
      mysys/my_read.c:
        Fixed compiler warning
      mysys/my_realloc.c:
        Fixed compiler warning
      mysys/my_seek.c:
        Fixed compiler warning
      mysys/my_write.c:
        Fixed compiler warning
      mysys/safemalloc.c:
        Fixed compiler warning
      mysys/thr_lock.c:
        Fixed compiler warning
      mysys/tree.c:
        Fixed compiler warning
      mysys/typelib.c:
        Fixed compiler warning
      ndb/include/logger/LogHandler.hpp:
        Changed SetErrorStr() to take const char* to remove compiler warnings (as many arguments to this are const strings)
      ndb/include/ndb_global.h.in:
        Added LINT_SET_PTR macro to be able to remove some compiler warnings
      ndb/include/util/InputStream.hpp:
        Fixed compiler warning
      ndb/include/util/OutputStream.hpp:
        Fixed compiler warning
      ndb/include/util/SimpleProperties.hpp:
        Fixed compiler warning
      ndb/src/common/debugger/EventLogger.cpp:
        remove if on 'signal' as this is a function pointer and is always true
      ndb/src/common/debugger/signaldata/BackupSignalData.cpp:
        Add missing enums
      ndb/src/common/logger/LogHandler.cpp:
        Changed SetErrorStr() to take const char* to remove compiler warnings (as many arguments to this are const strings)
      ndb/src/common/portlib/NdbMutex.c:
        Fixed compiler warning
      ndb/src/common/portlib/NdbThread.c:
        Fixed compiler warning
      ndb/src/common/transporter/Transporter.cpp:
        Swapped arguments to remove compiler warnings
      ndb/src/cw/cpcd/CPCD.hpp:
        Fixed compiler warning
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Fixed compiler warning
      ndb/src/kernel/blocks/cmvmi/Cmvmi.cpp:
        Fixed compiler warning
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Fixed compiler warning
      ndb/src/kernel/blocks/dbtux/DbtuxSearch.cpp:
        Fixed compiler warning
      ndb/src/kernel/blocks/ndbcntr/NdbcntrMain.cpp:
        Added missing enums
      ndb/src/kernel/blocks/qmgr/QmgrMain.cpp:
        Fixed compiler warning
      ndb/src/kernel/error/ErrorReporter.cpp:
        Fixed compiler warning
      ndb/src/kernel/error/ErrorReporter.hpp:
        Fixed compiler warning
      ndb/src/kernel/error/ndbd_exit_codes.c:
        Fixed compiler warning
      ndb/src/kernel/vm/TransporterCallback.cpp:
        Fixed compiler warning
      ndb/src/mgmapi/mgmapi.cpp:
        Fixed compiler warning
      ndb/src/mgmclient/CommandInterpreter.cpp:
        Fixed compiler warning
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Fixed compiler warning
      ndb/src/mgmsrv/Services.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/ClusterMgr.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/DictCache.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/Ndb.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/NdbOperationDefine.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/NdbOperationExec.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/NdbOperationInt.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/NdbOperationSearch.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/NdbTransaction.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/Ndbif.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/Ndbinit.cpp:
        Fixed compiler warning
      ndb/src/ndbapi/ndb_cluster_connection.cpp:
        Fixed compiler warning
      ndb/tools/drop_index.cpp:
        Fixed compiler warning
      ndb/tools/drop_tab.cpp:
        Fixed compiler warning
      ndb/tools/ndb_config.cpp:
        Fixed compiler warning
      regex/regexec.c:
        Fixed compiler warning
      server-tools/instance-manager/mysql_connection.cc:
        Fixed compiler warning
      sql/Makefile.am:
        Fix for bison 1.875, which adds an attribute statement that gcc 4.1.0 can't parse
      sql/filesort.cc:
        Fixed compiler warning
      sql/ha_archive.cc:
        Fixed compiler warning
      sql/ha_federated.cc:
        Fixed compiler warning
      sql/ha_federated.h:
        Fixed compiler warning
      sql/ha_innodb.cc:
        Fixed compiler warning
      sql/ha_myisam.cc:
        Fixed compiler warning
      sql/ha_myisammrg.cc:
        Fixed compiler warning
      sql/ha_ndbcluster.cc:
        Fixed compiler warning
      sql/handler.cc:
        Fixed compiler warning
      sql/item_cmpfunc.cc:
        Fixed compiler warning
      sql/item_subselect.cc:
        Fixed compiler warning
      sql/item_timefunc.cc:
        Fixed compiler warning
      sql/log_event.cc:
        Fixed compiler warning
      sql/mysqld.cc:
        Fixed compiler warning
      sql/net_serv.cc:
        Fixed compiler warning
      sql/opt_range.cc:
        Fixed compiler warning
        Formated DBUG statements to be as rest of code
      sql/slave.cc:
        Fixed compiler warning
      sql/sql_acl.cc:
        Fixed compiler warning
      sql/sql_cache.cc:
        Fixed compiler warning
        Fixed bug in query cache when used with DBUG traceing
      sql/sql_class.cc:
        Fixed compiler warning
      sql/sql_class.h:
        Fixed compiler warning
      sql/sql_delete.cc:
        Fixed compiler warning
      sql/sql_parse.cc:
        Fixed compiler warning
        Hack to fix my_sprintf() strings with %b
      sql/sql_prepare.cc:
        Fixed compiler warning
        Hack to fix my_sprintf() strings with %b
      sql/sql_repl.cc:
        Fixed compiler warning
      sql/sql_select.cc:
        Fixed compiler warning
      sql/sql_update.cc:
        Fixed compiler warning
      sql/sql_view.cc:
        Fixed compiler warning
      sql/strfunc.cc:
        Fixed compiler warning
      sql-common/client.c:
        Fixed compiler warning
      sql-common/my_time.c:
        Fixed compiler warning
      sql/table.cc:
        Fixed compiler warning
      sql/tztime.cc:
        Fixed compiler warning
      sql/unireg.cc:
        Fixed compiler warning
      strings/decimal.c:
        Fixed compiler warning
      tests/mysql_client_test.c:
        Fixed compiler warning
      vio/viosocket.c:
        Fixed compiler warning
      vio/viossl.c:
        Fixed compiler warning
      vio/viosslfactories.c:
        Fixed compiler warning
      14decc4f
  12. 13 Nov, 2006 1 commit
    • unknown's avatar
      WL#3368 mixed binlog_format default · 421f4c09
      unknown authored
        
        An amendment for parsing argument in case NDB is compiled and active.
        NDB switches from mixed to row-based and back per each query. The previous patch
        was not aware of such behaviour and made exceptional assingment to row-based when
        no command line arg --binlog-format provided.
        
        Removing #if HAVE_NDB_BINLOG block alltogether: ndb supports mixed and if server 
        was build without NDB using binlog nothing to care.
        Test for this piece of code is rather specific. While there is active bug23110
        ndb_alter_table and some other should fail if no explict --binlog-format is given:
        mysql-test-run ndb_alter_table
      
      
      sql/mysqld.cc:
        ndb accepts mixed binlog_format switching to row internally via calling
        thd->set_binlog_format_row_if_mixed at the beginning and careful
        the->reset_current_stmt_binlog_row_based(). There is 
        bug#23110 to implement it all carefully for DDL.
      421f4c09
  13. 11 Nov, 2006 1 commit
    • unknown's avatar
      This patch fixes the example engine, the example parser, and the example... · 81d3eb54
      unknown authored
      This patch fixes the example engine, the example parser, and the example daemon to compile. AKA You can now test that the interface is actually working :)
      
      
      configure.in:
        Removed unneeded call to old plugin syntax.
      include/mysql/plugin.h:
        Updates for daemon type (and fixed warning on declare end).
      plugin/fulltext/Makefile.am:
        Updated names so that we can install and test it.
      plugin/fulltext/plugin_example.c:
        Fixed wrong call.
      sql/mysqld.cc:
        Removed old have_example (we don't need it any longer).
      sql/set_var.cc:
        Removed old have_example
      sql/sql_plugin.cc:
        Added support for DAEMON type (just an internal raw plugin)
      storage/example/plug.in:
        Removed example static build so that we can test dynamic engines
      plugin/daemon_example/AUTHORS:
        New BitKeeper file ``plugin/daemon_example/AUTHORS''
      plugin/daemon_example/ChangeLog:
        New BitKeeper file ``plugin/daemon_example/ChangeLog''
      plugin/daemon_example/Makefile.am:
        New BitKeeper file ``plugin/daemon_example/Makefile.am''
      plugin/daemon_example/NEWS:
        New BitKeeper file ``plugin/daemon_example/NEWS''
      plugin/daemon_example/README:
        New BitKeeper file ``plugin/daemon_example/README''
      plugin/daemon_example/configure.in:
        New BitKeeper file ``plugin/daemon_example/configure.in''
      plugin/daemon_example/daemon_example.c:
        New BitKeeper file ``plugin/daemon_example/daemon_example.c''
      plugin/daemon_example/plug.in:
        New BitKeeper file ``plugin/daemon_example/plug.in''
      plugin/fulltext/plug.in:
        Added plug.in file so that we compile fulltext example!
      81d3eb54
  14. 10 Nov, 2006 1 commit
    • unknown's avatar
      Bug #22860: Option --memlock should be revisited · 93e1030d
      unknown authored
      Support says that memlock doesn't work on OSes other than Solaris.  
      Add a warning about --memlock to the crash monologue.
      
      
      sql/mysqld.cc:
        On a crash when --memlock was active, emit advice about the insta-
        bility of that parameter.
      93e1030d
  15. 05 Nov, 2006 1 commit
  16. 02 Nov, 2006 1 commit
    • unknown's avatar
      Bug#21114 (Foreign key creation fails to table with name format) · 384407aa
      unknown authored
      Due to the complexity of this change, everything is documented in WL#3565
      
      This patch is the third iteration, it takes into account the comments
      received to date.
      
      
      mysql-test/r/func_math.result:
        Improved test coverage
      mysql-test/r/view.result:
        Name collision, x() is a geometry native in function
      mysql-test/t/func_math.test:
        Improved test coverage
      mysql-test/t/view.test:
        Name collision, x() is a geometry native in function
      sql/item_create.cc:
        Revised the create_func implementation
      sql/item_create.h:
        Revised the create_func implementation
      sql/item_geofunc.h:
        Explicit Item allocation in the thread memory pool.
      sql/lex.h:
        Removed function parsing from the lexical parser
      sql/lex_symbol.h:
        Removed function parsing from the lexical parser
      sql/mysql_priv.h:
        Server initialization and shutdown
      sql/mysqld.cc:
        Server initialization and shutdown
      sql/share/errmsg.txt:
        New error messages
      sql/sql_yacc.yy:
        Removed function parsing from the lexical parser
      tests/mysql_client_test.c:
        Spaces are no longer significant for function calls
      mysql-test/include/parser_bug21114.inc:
        New tests
      mysql-test/r/parser.result:
        New tests
      mysql-test/r/parser_bug21114_innodb.result:
        New tests
      mysql-test/t/parser.test:
        New tests
      mysql-test/t/parser_bug21114_innodb.test:
        New tests
      384407aa
  17. 01 Nov, 2006 2 commits
    • unknown's avatar
      Fixed a lot of compiler warnings (Mainly in mysqld and instance manager) · 07d8be45
      unknown authored
      Fixed some possible fatal wrong arguments to printf() style functions
      Initialized some not initialized variables
      Fixed bug in stored procedure and continue handlers
      (Fixes Bug#22150)
      
      
      include/mysql/plugin.h:
        Remove compiler warning
      mysql-test/mysql-test-run.pl:
        Ensure that --extern works on a clean tree (when 'var' directory doesn't exists)
      server-tools/instance-manager/commands.cc:
        Fixed possible use of unitialized variable
      server-tools/instance-manager/guardian.cc:
        Fixed wrong arguments to log_info() that could cause crashes
      server-tools/instance-manager/instance.cc:
        Fixed wrong arguments to log_info() and log_error() that could cause crashes
      server-tools/instance-manager/instance_options.cc:
        Fixed wrong arguments to log_error() that could cause crashes
      server-tools/instance-manager/mysql_connection.cc:
        Fixed wrong arguments to log_info()
      server-tools/instance-manager/parse.cc:
        Fixed possible use of unitialized variable
      server-tools/instance-manager/user_map.cc:
        Fixed wrong arguments to log_error() that could cause crashes
      sql/Makefile.am:
        Fix for bison 1.875
        (It write an __attribute__() tag that was causing compiler failures)
      sql/ha_ndbcluster.cc:
        Fixed wrong snprintf() arguments
        Remoed not used variables
      sql/ha_ndbcluster_binlog.cc:
        Fixed compiler warning (unsigned/signed comparision)
      sql/handler.cc:
        Fixed wrong parameter to hton->binlog_func()
      sql/item_cmpfunc.cc:
        Removed compiler warnings
      sql/item_timefunc.cc:
        Removed compiler warnings
      sql/log.cc:
        fixed wrong argument to snprintf()
      sql/mysqld.cc:
        Removed compiler warnings
        Fixed wrong arguments to printf()
      sql/partition_info.cc:
        Removed compiler warnings
      sql/protocol.cc:
        reset is_fatal_error for stored procedures
        (Fix for Bug#22150)
      sql/sp_head.cc:
        More DBUG information
        Reset is_fatal_error in case of continue handler.
        (Fix for Bug#22150)
      sql/sql_base.cc:
        Removed compiler warnings
      sql/sql_class.h:
        More DBUG information
      sql/sql_insert.cc:
        Removed compiler warnings
        Initialize not initialized variable (fatal bug)
      sql/sql_parse.cc:
        Added DBUG_ASSERT to detect if stored procedure code returns with a wrong state
        Removed compiler warning
      sql/sql_plugin.cc:
        Fied wrong aruguments to printf() (Fatal bug)
      sql/sql_select.cc:
        Initailize not initialized variable.
        Remove compiler warnings
        Fixed wrong argument to printf() (Possible fatal error)
      sql/sql_view.cc:
        Removed compiler warnings
      sql/table.cc:
        Fixed wrong argument to printf() (Possible fatal)
      07d8be45
    • unknown's avatar
      Adding in an ha_end() call. This is the first part of the patch I and Monty... · b014bd22
      unknown authored
      Adding in an ha_end() call. This is the first part of the patch I and Monty have agreed on. In the future engines will have the option of shutting down more quickly via the panic call, or just shutting down during the unloading of a plugin. 
      
      
      sql/handler.cc:
        Adding ha_end
      sql/handler.h:
        Function declaration for ha_end()
      sql/mysqld.cc:
        Adding ha_end call.
      b014bd22
  18. 30 Oct, 2006 3 commits
    • unknown's avatar
      Bug#22958 Com_create_user missing within 5.0 · a6097b05
      unknown authored
       - Add Com_create_user to SHOW STATUS command
      
      
      sql/mysqld.cc:
        Add Com_create_user to the status variables list, it's already counted
        with the default mechanism
      a6097b05
    • unknown's avatar
      BUG#21915: Changing limits of table_cache when setting max_connections · 885dc1cb
      unknown authored
      If the user has specified --max-connections=N or --table-open-cache=M
      options to the server, a warning could be given that some values were
      recalculated, and table-open-cache could be assigned greater value.
      
      Note that both warning and increase of table-open-cache were totally
      harmless.
      
      This patch fixes recalculation code to ensure that table-open-cache will
      be never increased automatically and that a warning will be given only if
      some values had to be decreased due to operating system limits.
      
      No test case is provided because we neither can't predict nor control
      operating system limits for maximal number of open files.
      
      
      sql/mysql_priv.h:
        Add constants for table_cache minimum and default values.
      sql/mysqld.cc:
        Fix max_connections and table_cache_size re-computation.
      885dc1cb
    • unknown's avatar
      Improve comments around FLUSH STATUS · e948c64f
      unknown authored
      It's not possible to flush the global status variables in 5.0
      Update test case so it works by recording the value of handle_rollback
      before and compare it to the value after
      
      
      mysql-test/r/innodb_mysql.result:
        Update result file
      mysql-test/t/innodb_mysql.test:
        It's not possible to reset the global status variables in 5.0 so intead its value
        is recorded and compared to the after value.
        It should not have changed.
      sql/mysqld.cc:
        Improve comments
      sql/set_var.cc:
        Improve comments
      sql/sql_class.cc:
        Improve comments
      sql/sql_class.h:
        Improve comments
      e948c64f
  19. 16 Oct, 2006 1 commit
    • unknown's avatar
      Changed several char* to LEX_STRING*. · e94087c5
      unknown authored
      BUILD/SETUP.sh:
        Added check for CCACHE_DISABLE. If set, do not
        use ccache at all.
      BUILD/compile-pentium-gcov:
        Moved CCACHE_DISABLE up before going into SETUP.sh.
        
        Added debug_extra_flags to extra_flags.
      mysql-test/r/create.result:
        Added tests for incorrect database names.
      mysql-test/r/ctype_create.result:
        Added tests for incorrect alter database names.
      mysql-test/r/events.result:
        Added tests for incorrect database names.
      mysql-test/r/grant.result:
        Output changed to capital letters.
      mysql-test/t/alter_table.test:
        Removed extra empty line
      mysql-test/t/create.test:
        Added tests for incorrect database names.
      mysql-test/t/ctype_create.test:
        Added tests for incorrect name handling
      mysql-test/t/events.test:
        Added tests for incorrect database names.
      sql/item_timefunc.cc:
        Added dummy case to avoid compiler warning.
      sql/mysql_priv.h:
        Changed argument from char pointer to LEX_STRING pointer.
      sql/mysqld.cc:
        Added a missing component from struct.
      sql/sql_class.h:
        Added function LEX_STRING_make that sets the string and length.
      sql/sql_db.cc:
        Changed several char pointers to lex_strings.
      sql/sql_lex.cc:
        name is now LEX_STRING
      sql/sql_lex.h:
        Changed name to LEX_STRING.
      sql/sql_parse.cc:
        Changed several char pointers to lex_strings.
        
        db_length needed a trick, because in old client protocol there
        was an extra char zero added to the string.
        
        check_db_name() now takes LEX_STRING pointer as an argument.
        
        Changed remove_escape() to take LEX_STRING pointer as an argument.
        
        Removed COM_CREATE_DB and COM_DROP_DB. These are obsolete.
      sql/sql_table.cc:
        char* -> LEX_STRING*
      sql/sql_yacc.yy:
        Changed char* -> LEX_STRING*
      sql/table.cc:
        check_db_name() now takes LEX_STRING* as argument instead of char*.
        
        Optimized code a bit.
      tests/mysql_client_test.c:
        Added test for (short) status.
        
        After defining out (ifdef) COM_DROP_DB and COM_CREATE_DB
        in mysqld.cc mysql_client_test needed to be informed that
        failing in recognizing these commands is not fatal error
        anymore.
      e94087c5
  20. 12 Oct, 2006 1 commit
    • unknown's avatar
      Panic was being called twice! · deb36ce1
      unknown authored
      Both on its own and in the plugin shutdown.... not so good. The code is a bit simpler, and we could now technically remove the panic all entirely if we wanted to. 
      
      
      sql/handler.cc:
        Handler was returning from a panic failure. Bad idea! This means that the rest of the shutdown is not carried outin the engine.
        Removed panic specific calls. 
        
        Panic should also be called regardless of "startup".
      sql/mysqld.cc:
        Removed ha_panic call (since its called in plugin shutdown)
      deb36ce1
  21. 01 Oct, 2006 1 commit
    • unknown's avatar
      This patch updates to remove most global hton needs. Cleans up wrong message in partition. · 40bf7b0a
      unknown authored
      mysql-test/r/partition.result:
        Updated results
      sql/ha_ndbcluster.cc:
        Updated hton
      sql/ha_partition.cc:
        Removed need for global internal hton.
      sql/handler.cc:
        Removed need for global mrg
      sql/mysql_priv.h:
        Updated needs for global variables.
      sql/mysqld.cc:
        Removed needs around hton
      sql/partition_info.cc:
        Removed bug.... aka what happens if tables are neither?
      sql/share/errmsg.txt:
        Made error message more generic.
      sql/sql_cache.cc:
        Removed specific hton reference
      40bf7b0a
  22. 30 Sep, 2006 1 commit
    • unknown's avatar
      This patch adds handlerton passing to functions. NDB and Innodb still require... · 76b83865
      unknown authored
      This patch adds handlerton passing to functions. NDB and Innodb still require a global hanlderton in the main code due to the nature of the sql_cache call back function (should be solveable... another patch).
      Partitioning now has a flag to allow disabling of engines from being compatible with partitioning. Cleaned up heap naming convention on panic call. 
      
      
      include/heap.h:
        Added new function
      sql/ha_ndbcluster.cc:
        Updated hanlderton functions
      sql/ha_ndbcluster_binlog.cc:
        Updated handlerton functions.
      sql/handler.cc:
        Updated handlerton functions.
      sql/handler.h:
        Updated hanlderton functions
      sql/log.cc:
        Updated handlerton functions
      sql/mysql_priv.h:
        Updated handlerton functions
      sql/mysqld.cc:
        Added Legacy handlerton functions
      sql/partition_info.cc:
        Added flag support for marking engines not compatible with partitioning
      sql/sql_cursor.cc:
        Updated hanlderton functions
      sql/sql_show.cc:
        Updated hanlderton functions
      sql/sql_tablespace.cc:
        Update for handlerton functions
      storage/archive/ha_archive.cc:
        Update for hanlderton functions
      storage/archive/ha_archive.h:
        Update for handlerton functions
      storage/blackhole/ha_blackhole.cc:
        Update for handlerton functions
      storage/csv/ha_tina.cc:
        Update for handlerton functions
      storage/csv/ha_tina.h:
        Update for handlerton functions
      storage/federated/ha_federated.cc:
        Updated for handlerton functions
      storage/federated/ha_federated.h:
        Updated for handlerton functions
      storage/heap/ha_heap.cc:
        Update for handlerton functions
      storage/heap/hp_panic.c:
        Update of function name
      storage/heap/hp_test1.c:
        Update of function name
      storage/heap/hp_test2.c:
        Update of function name.
      storage/innobase/handler/ha_innodb.cc:
        Update of function name
      storage/innobase/handler/ha_innodb.h:
        Update of function name
      storage/myisam/ha_myisam.cc:
        Update of function name.
      storage/myisammrg/ha_myisammrg.cc:
        Update of function name
      76b83865
  23. 15 Sep, 2006 2 commits
    • unknown's avatar
      This changes the order of the universe, black is now the new white. · d79485a9
      unknown authored
      In practice this means that handlerton is now created by the server and is passed to the engine. Plugin startups can now also control how plugins are inited (and can optionally pass values). Bit more flexibility to those who want to write plugin interfaces to the database. 
      
      
      include/mysql/plugin.h:
        Optional to pass parameter now to init and deinit functions
      sql/ha_ndbcluster.cc:
        Cleanup, handlerton is now a pointer.
      sql/ha_ndbcluster_binlog.cc:
        Cleanup (handlerton is now a pointer)
      sql/ha_ndbcluster_binlog.h:
        Cleanup (handlerton is now a pointer)
      sql/ha_partition.cc:
        Cleaned up handlerton change
      sql/handler.cc:
        Cheanup of handlerton change
      sql/item_sum.cc:
        Cleanedup of handlerton change
      sql/log.cc:
        Cleanup of handlerton change
      sql/mysql_priv.h:
        Reverted patch for variables (what would have happen previously if a have_ would have been called that was dynamically loaded? boom!)
      sql/mysqld.cc:
        Cleanup of handlerton changes and reverted have variable patch
      sql/partition_info.cc:
        Cleanup of handlerton (we need to clean this up a bit more).
      sql/set_var.cc:
        Cleanup related to handlerton changes
      sql/sql_cache.cc:
        Handlerton changes cleanup
      sql/sql_insert.cc:
        Handlerton changes cleanup.
      sql/sql_partition.cc:
        Handlerton cleanup changes
      sql/sql_plugin.cc:
        Handlerton changes.
        
        init() can now be controlled by a plugin specific startup. 
        
        There was also an issue with how we deinited the status variables. It should have been occuring before we shut down the engines.
      sql/sql_select.cc:
        Handlerton cleanup changes
      sql/sql_show.cc:
        Handlerton cleanup changes
      sql/sql_table.cc:
        Handlerton cleanup changes
      sql/table.cc:
        Cleanup
      storage/archive/ha_archive.cc:
        Cleanup
      storage/archive/ha_archive.h:
        Cleanup
      storage/blackhole/ha_blackhole.cc:
        Cleanup
      storage/csv/ha_tina.cc:
        Cleanup
      storage/example/ha_example.cc:
        Cleanup
      storage/federated/ha_federated.cc:
        Cleanup
      storage/heap/ha_heap.cc:
        Cleanup
      storage/innobase/handler/ha_innodb.cc:
        Cleanup
      storage/myisam/ha_myisam.cc:
        Cleanup
      storage/myisammrg/ha_myisammrg.cc:
        Cleanup
      d79485a9
    • unknown's avatar
  24. 13 Sep, 2006 2 commits
  25. 07 Sep, 2006 1 commit
  26. 06 Sep, 2006 1 commit
  27. 05 Sep, 2006 1 commit
    • unknown's avatar
      Fix bad manual merge. · 1ad1ee30
      unknown authored
      sql/mysqld.cc:
        Fixes bad merge.
      mysql-test/r/grant.result:
        Fix bad merge.
      1ad1ee30
  28. 01 Sep, 2006 1 commit
    • unknown's avatar
      WL#3337 (Event scheduler new architecture) · da4734c3
      unknown authored
      This is a post-review patch.
      
      Fixes the typelib implementation, available only in 5.1.11.
      
      --event-scheduler cmdline : DISABLED | ON | OFF | 0 | 1
      DISABLED - makes the scheduler unavailable during the server run
      (ON|1)-  When the server is started the scheduler will be started. It can
               be stopped and restarted by setting appropriate values to
               GLOBAL event_scheduler
      (OFF|0)- When the server is started, the scheduler won't be started. It
               can be started and again stopped by setting appropriate values to
               GLOBAL event_scheduler. _DEFAULT_ value
      
      The GLOBAL variable event_scheduler can have the following values:
      OFF | ON | 0 | 1
      DISABLED is not possible and every attempt will end with an error that
      it's not a valid value for the variable.
      OFF | 0 - This is the pre-5.1.11 behavior - The scheduler stops, if not
                already stopped, and can be started again  by setting
                the value of the variable to ON|1.
      ON | 1  - This is the pre-5.1.11 behavior - The scheduler starts, if not
                already started, and can be stopped again by setting the value
                of the variable to OFF|0.
      
      
      mysql-test/r/events.result:
        update result
      mysql-test/r/events_bugs.result:
        update result
      mysql-test/r/events_logs_tests.result:
        update result
      mysql-test/r/events_restart_phase1.result:
        update result
      mysql-test/r/events_restart_phase3.result:
        update result
      mysql-test/r/events_scheduling.result:
        update result
      mysql-test/r/events_stress.result:
        update result
      mysql-test/t/events.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_bugs.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_logs_tests.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_restart_phase1.test:
        update test:
        2 -> off
        1 -> on
      mysql-test/t/events_restart_phase2-master.opt:
        update master file : 1 => on
      mysql-test/t/events_scheduling.test:
        update test:
        2 -> off
        1 -> on
        
        add tests for event_scheduler global variable representation from
        SHOW VARIABLES.
      mysql-test/t/events_stress.test:
        update test:
        2 -> off
        1 -> on
      sql/events.cc:
        Implement two different TYPELIBs for --event-scheduler cmd line
        option and for GLOBAL variable event_scheduler
        
        --event-scheduler cmdline : DISABLED | ON | OFF | 0 | 1
        DISABLED - makes the scheduler unavailable during the server run
        (ON|1)-  When the server is started the scheduler will be started. It can
                 be stopped and restarted by setting appropriate values to
                 GLOBAL event_scheduler
        (OFF|0)- When the server is started, the scheduler won't be started. It
                 can be started and again stopped by setting appropriate values to
                 GLOBAL event_scheduler. _DEFAULT_ value
        
        The GLOBAL variable event_scheduler can have the following values:
        OFF | ON | 0 | 1
        DISABLED is not possible and every attempt will end with an error that
        it's not a valid value for the variable.
        OFF | 0 - This is the pre-5.1.11 behavior - The scheduler stops, if not
                  already stopped, and can be started again  by setting
                  the value of the variable to ON|1.
        ON | 1  - This is the pre-5.1.11 behavior - The scheduler starts, if not
                  already started, and can be stopped again by setting the value
                  of the variable to OFF|0.
      sql/events.h:
        additional TYPELIB for GLOBAL event_scheduler
      sql/mysqld.cc:
        --event-scheduler should be checked against a TYPELIB and
        therefore should be GET_STR, as well as we make the parameter optional.
        When not provided OFF|0 is used.
      sql/set_var.cc:
        Implement typelib for event_scheduler variable.
        If allows both INT_RESULT -> 0 | 1 
        and STRING_RESULT -> OFF | ON
        The variable is shown as DISABLED | ON | OFF
      sql/set_var.h:
        Implement typelib, which expects both STRING and INT,
        for event_scheduler.
      da4734c3
  29. 30 Aug, 2006 1 commit
    • unknown's avatar
      Changes made according to HLD/LLD. · 930e542f
      unknown authored
         The following is an excerption from the WL.
            
         1. Change so that MIXED is default format
            1.1 to change the default for command line --binlog-format
            1.2 to alter global_system_variables.binlog_format calculation
                basing on command line --binlog-format parameter and 
                its default.
         2. Change test suite so that more testing is done by MIXED format.
            2.1 to check if there are test cases requiring --binlog-foramt=statement via
                `source include/have_binlog_format_statement.inc' and affected by 
                altering the latter to be "mixed".
            2.2 to check the content of such vulnerable cases to find if
                extending to the mixed does not modify results. In that case simply
                substitute source arguments as explained.
            2.3 if a test in mixed mode deals with features triggering
                row-binlogging then if necessary we can switch explicitly
                to statement mode or create another test to run with 
                non-recommended STATEMENT mode
         
                Particullarily, extracting INSERT DELAYED 
                binlogging subtest for statement mode is performed, and 
                the snippet is moved into a separate test file.
                Note that since now all three modes verify this use case
                through 3 different tests.
         
         No changes in item 3 of HLD appeared to be needed.
      
      
      mysql-test/extra/binlog_tests/binlog.test:
        Moving INSERT DELAYED verification section into separate file. The latter is sourced
        from two different files: the current one and a newly created for STATEMENT
        mode check.
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        require mixed_or_statement
      mysql-test/extra/rpl_tests/rpl_stm_000001.test:
        require mixed_or_statement
      mysql-test/extra/rpl_tests/rpl_stm_charset.test:
        require mixed_or_statement
      mysql-test/r/binlog_stm_binlog.result:
        new result to correspond to MIXED mode.
      mysql-test/r/rpl_rbr_to_sbr.result:
        result changed
      mysql-test/t/archive.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_binlog.test:
        require exclusive mixed format because of INSERT DELAYED.
      mysql-test/t/binlog_stm_blackhole.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_ctype_cp932.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_ctype_ucs.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_drop_tmp_tbl.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_innodb_stat.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_insert_select.test:
        require mixed_or_statement
      mysql-test/t/binlog_stm_mix_innodb_myisam.test:
        require mixed_or_statement
      mysql-test/t/create_select_tmp.test:
        require mixed_or_statement
      mysql-test/t/ctype_cp932_binlog_stm.test:
        require mixed_or_statement
      mysql-test/t/date_formats.test:
        MIXED case appended to the replace instruction
      mysql-test/t/mysqlbinlog.test:
        require mixed_or_statement
      mysql-test/t/mysqlbinlog2.test:
        require mixed_or_statement
      mysql-test/t/ndb_multi.test:
        require mixed_or_statement
      mysql-test/t/rpl000013.test:
        require mixed_or_statement
      mysql-test/t/rpl_heap.test:
        require mixed_or_statement
      mysql-test/t/rpl_loaddata_s.test:
        require mixed_or_statement
      mysql-test/t/rpl_mixed_ddl_dml.test:
        require mixed_or_statement
      mysql-test/t/rpl_rbr_to_sbr.test:
        Rather meaningless line is discarded.
        The test does not loose anything without it and without considering the WL.
      mysql-test/t/rpl_rewrt_db.test:
        require mixed_or_statement
      mysql-test/t/rpl_rotate_logs.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_EE_err2.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_flsh_tbls.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_log.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_max_relay_size.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_multi_query.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_mystery22.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_no_op.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_reset_slave.test:
        require mixed_or_statement
      mysql-test/t/rpl_stm_until.test:
        require mixed_or_statement
      mysql-test/t/rpl_temp_table.test:
        require mixed_or_statement
      mysql-test/t/rpl_trigger.test:
        require mixed_or_statement
      mysql-test/t/rpl_trunc_temp.test:
        require mixed_or_statement
      mysql-test/t/user_var-binlog.test:
        require mixed_or_statement
      sql/mysqld.cc:
        Implementation of making BINLOG_FORMAT_MIXED to be the default of
        global_system_variables.binlog_format. Not in the case of embedded.
      mysql-test/extra/binlog_tests/binlog_insert_delayed.test:
        Snippend sourced from two tests to verify INSERT DELAYED in all three binlog formats.
      mysql-test/include/have_binlog_format_mixed.inc:
        Part of exclusive MIXED format requirement
      mysql-test/include/have_binlog_format_mixed_or_statement.inc:
        requirement to have mixed or statement. Most of the tests with STATEMENT format indeed
        are tolerant to MIXED format to yield the same result files. There are few exception
        because of features triggering RBR events when MIXED format.
      mysql-test/r/binlog_statement_insert_delayed.result:
        BitKeeper file /home/elkin/MySQL/TEAM/FIXES/5.1/wl3368_mixed_default/mysql-test/r/binlog_statement_insert_delayed.result
      mysql-test/r/have_binlog_format_mixed.require:
        Exclusive MIXED format
      mysql-test/t/binlog_statement_insert_delayed.test:
        BitKeeper file /home/elkin/MySQL/TEAM/FIXES/5.1/wl3368_mixed_default/mysql-test/t/binlog_statement_insert_delayed.test
      930e542f
  30. 29 Aug, 2006 1 commit
    • unknown's avatar
      Re'ordering of startup. Fixed Execution path issues. Added function for... · 2f8849e2
      unknown authored
      Re'ordering of startup. Fixed Execution path issues. Added function for de'initing everything. This includes Antony's suggestions (bk collapse uber alles!)
      
      
      sql/handler.cc:
        Removed temp work needed for making status variables work with plugins.
      sql/mysqld.cc:
        Removed call to plugin_load()  (not needed any longer).
      sql/sql_plugin.cc:
        Status vars are now located in only one location (while this fixed execution path problems, we will need to now fix "the name" issues). Monty and I have a solution to this :)
        Added function for deiniting engines (before the logic was scattered about).
        Added step by step processing for startup of plugins. MyISAM is now loaded first (we will address this long term in a different manner).
      sql/sql_plugin.h:
        Removed calls that did not need to be extern.
      2f8849e2