1. 12 Mar, 2013 3 commits
    • Venkatesh Duggirala's avatar
      BUG#14593883-REPLICATION BREAKS WHEN SET DATA TYPE · 8a49d7a8
      Venkatesh Duggirala authored
      COLUMNS ARE USED INSIDE A STORED PROCEDURE                                      
                                                                                      
      Problem: The operator '=' overload method inside
      'String' class is not coping str_charset member from
      R.H.S object to L.H.S object. Hence charset is wrongly
      set while using string assignments
      
      Analaysis: The above mentioned problem is
      identified while doing the analaysis of bug#14593883.
      Though the test scenario mentioned in the bug page
      is not  an issue in mysql-5.1 code, the actual root cause
      ie., "str_charset member is not copied" exists in the 
      mysql-5.1 code base. 
      
      Fix: Handle coping str_charset member in operator '=' overload                  
      method.
      
      sql/sql_string.h:
        Handled coping str_charset member in operator '=' overload                  
        method.
      8a49d7a8
    • Marko Mäkelä's avatar
      Bug#16463505 PESSIMISTIC PAGE_ZIP_AVAILABLE() MAY CAUSE INFINITE PAGE SPLIT · daa28126
      Marko Mäkelä authored
      For a fresh insert, page_zip_available() was counting some fields twice.
      In the worst case, the compressed page size grows by PAGE_ZIP_DIR_SLOT_SIZE
      plus the size of the record that is being inserted. The size of the record
      already includes the fields that will be stored in the uncompressed portion
      of the compressed page.
      
      page_zip_get_trailer_len(): Remove the output parameter entry_size,
      because no caller is interested in it.
      
      page_zip_max_ins_size(), page_zip_available(): Assume that the page grows
      by PAGE_ZIP_DIR_SLOT_SIZE and the record size (which includes the fields
      that would be stored in the uncompressed portion of the page).
      
      rb#2169 approved by Sunny Bains
      daa28126
    • unknown's avatar
      No commit message · 893a97e4
      unknown authored
      No commit message
      893a97e4
  2. 05 Mar, 2013 1 commit
  3. 28 Feb, 2013 1 commit
  4. 27 Feb, 2013 2 commits
    • Gleb Shchepa's avatar
      Bug #16311231: MISSING DATA ON SUBQUERY WITH WHERE + XOR · f8cd565d
      Gleb Shchepa authored
      IN IN-CLAUSE USING MYISAM OR MEMORY ENGINE
      
      Backport from 5.6. Original message:
      
      The coincidences caused a data loss:
      * The query has IN subqueries nested twice,
      * the WHERE clause of the inner subquery refers to the
        outer field, and the whole WHERE clause returns FALSE,
      * the inner subquery has a LEFT JOIN that joins a single
        row with a row of NULLs; one of that NULL columns
        represents the select list of the subquery.
      
      Normally, that inner subquery should return empty record set.
      However, in our case:
      * the Item_is_not_null_test item goes constant, since
        its underlying field is NULL (because of LEFT JOIN ... ON 
        FALSE of const table row with a row of nulls);
      * we evaluate Item_is_not_null_test::val_int() as a part
        of fake HAVING expression of the transformed subquery;
      * as far as the underlying field is NULL, we optimize
        out the whole fake HAVING expression as FALSE as well
        as a whole subquery with a zero result:
        Impossible HAVING noticed after reading const tables";
      * thus, the optimizer ignores the presence of the WHERE
        clause (the WHERE expression is FALSE in our case, so
        the subquery should return empty set);
      * however, during the evaluation of the 
        Item_is_not_null_test::val_int() in the optimizer,
        it marked its "owner" with the "was_null" flag -- that
        forced the subquery to return UNKNOWN instead of empty
        set.
      That caused a wrong result.
      
      
      The problem is a regression of the small cleanup in
      the fix for the bug11827369 (the Item_is_not_null_test part)
      that conflicts with optimizations in the fix for the bug11752543.
      Before that regression the Item_is_not_null_test items
      never were constants.
      
      The fix is the rollback of Item_is_not_null_test parts
      of the bug11827369 fix.
      f8cd565d
    • Marko Mäkelä's avatar
      Bug#16400920 INNODB TRIES TO PASS EMPTY BUFFER TO ZLIB, GETS Z_BUF_ERROR · d065d727
      Marko Mäkelä authored
      page_zip_compress_node_ptrs(): Do not attempt to invoke deflate() with
      c_stream->avail_in, because it will result in Z_BUF_ERROR (and
      page_zip_compress() failure and unnecessary further splits of the node
      pointer page). A node pointer record can have empty payload, provided
      that all key fields are empty.
      
      Approved by Jimmy Yang
      d065d727
  5. 26 Feb, 2013 1 commit
    • Harin Vadodaria's avatar
      Bug#16372927: STACK OVERFLOW WITH LONG DATABASE NAME IN · fd4ea8b0
      Harin Vadodaria authored
                    GRANT STATEMENT
      
      Description: A missing length check causes problem while
                   copying source to destination when
                   lower_case_table_names is set to a value
                   other than 0. This patch fixes the issue
                   by ensuring that requried bound check is
                   performed.
      fd4ea8b0
  6. 25 Feb, 2013 1 commit
  7. 23 Feb, 2013 1 commit
  8. 22 Feb, 2013 1 commit
    • Annamalai Gurusami's avatar
      Bug #14211565 CRASH WHEN ATTEMPTING TO SET SYSTEM VARIABLE TO RESULT OF VALUES() · dc696973
      Annamalai Gurusami authored
      Problem:
      
      When the VALUES() function is inappropriately used in the SET stmt the server
      exits.  
      
      set port = values(v);
      
      This happens because the values(v) will be parsed as an Item_insert_value by
      the parser.  Both Item_field and Item_insert_value return the type as
      FIELD_ITEM.  But for Item_insert_value the field_name member is NULL.  In
      set_var constructor, when the type of the item is FIELD_ITEM we try to access
      the non-existent field_name. 
      
      The class hierarchy is as follows:
      Item -> Item_ident -> Item_field -> Item_insert_value
      
      The Item_ident::field_name is NULL for Item_insert_value.  
      
      Solution:
      
      In the parsing stage, in the set_var constructor if the item type is
      FIELD_ITEM and if the field_name is non-existent, then it is probably
      the Item_insert_value.  So leave it as it is for later evaluation.
      
      rb://2004 approved by Roy and Norvald.
      
      dc696973
  9. 19 Feb, 2013 3 commits
    • Sujatha Sivakumar's avatar
      Bug#11746817:MYSQL_INSTALL_DB CREATES WILDCARD GRANTS WHEN · 4d494b17
      Sujatha Sivakumar authored
      HOST HAS '_' IN THE HOSTNAME
      
      Problem:
      =======
      '_' and '%' are treated as a wildcards by the ACL code and
      this is documented in the manual. The problem with
      mysql_install_db is that it does not take this into account
      when creating the initial GRANT tables:
      
      --- cut ---
      REPLACE INTO tmp_user SELECT @current_hostname,'root','','Y',
      'Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y',
      'Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','Y','','','','',
      0,0,0,0 FROM dual WHERE LOWER( @current_hostname) != 'localhost';
      --- cut ---
      
      If @current_hostname contains any wildcard characters, then 
      a wildcard entry will be defined for the 'root' user, 
      which is a flaw.
      
      Analysis:
      ========
      As per the bug description when we have a hostname with a
      wildcard character in it, it allows clients from several other
      hosts with similar name pattern to connect to the server as root.
      For example, if the hostname is like 'host_.com' then the same
      name is logged in mysql.user table. This allows 'root' users
      from other hosts like 'host1.com', 'host2.com' ... to connect
      to the server as root user.
      
      While creating the intial GRANT tables we do not have a check
      for wildcard characters in hostname.
      
      Fix:
      ===
      As part of fix escape character "\" is added before wildcard
      character to make it a plain character, so that the one and
      only host with the exact name will be able to connect to the
      server.
      
      scripts/mysql_system_tables_data.sql:
        while creating default users get the hostname and
        replace the wildcard characters within the hostname after
        escaping them.
      4d494b17
    • Harin Vadodaria's avatar
      Bug#16235681: TURN OFF DEFAULT COMPRESSION WHILE USING · c4013654
      Harin Vadodaria authored
                    OPENSSL
      
      Description: Specify preference to disable compression
                   while using OpenSSL library. OpenSSL uses
                   zlib compression by default which may
                   lead to some problems.
      c4013654
    • unknown's avatar
      No commit message · 8ea6ed92
      unknown authored
      No commit message
      8ea6ed92
  10. 18 Feb, 2013 1 commit
  11. 16 Feb, 2013 1 commit
    • Shivji Kumar Jha's avatar
      BUG#15965353- RPL.RPL_ROW_UNTIL FAILS ON PB2, · 5fcf40a2
      Shivji Kumar Jha authored
                    PLATFORM= MACOSX10.6 X86_64 MAX
      
      Problem: The test was failing on pb2's mac machine because
               it was not cleaned up properly. The test checks if
               the command 'start slave until' throws a proper
               error when issued with a wrong number/type of
               parameters. After this,the replication stream was
               stopped using the include file 'rpl_end.inc'.
               The errors thrown earlier left the slave in an
               inconsistent state to be closed by the include
               file which was caught by the mac machine.
      
      Fix: Started slave by invoking start_slave.inc to have a
           working slave before calling rpl_reset.inc
      
      Problem: The test file was not in a good shape. It tested
               start slave until relay log file/pos combination 
               wrongly. A couple of commands were executed at 
               master and replicated at slave. Next, the 
               coordinates in terms of relay log file and pos 
               were noted down followed by reset slave and start
               slave until saved relay log file/pos. Reset slave
               deletes  all relay log files and makes the slave 
               forget its replication position. So, using the 
               saved coordiantes after reset slave is wrong.
      
      Fix: Split the test in two parts:
           a) Test for start slave until master log file/pos and
              checking for correct errors in the failure 
              scenarios.
           b) Test for start slave until relay log file/pos.
      
      Problem: The variables auto_increment_increment and 
               auto_increment_offset were set in the the include
               file rpl_init.inc. This was only configured for 
               some connections that are rarely used by test 
               cases, so likely that it will cause confusion. 
               If replication tests want to setup these variables
               they should do so explicitly.
      
      Fix:
           a) Removed code to set the variables
              auto_increment_increment and auto_increment_offset
              in the include file.
           b) Updated tests files using the same.
      5fcf40a2
  12. 15 Feb, 2013 2 commits
    • Pedro Gomes 's avatar
      BUG#13545447: RPL_ROTATE_LOGS FAILS DUE TO CONCURRENCY ISSUES IN REP. CODE · 7e8c8877
      Pedro Gomes authored
      In method mysql_binlog_send, right after detecting a EOF in the
      read event loop, and before deciding if we should change to a new
      binlog file there is a execution window where new events can be
      written to the binlog and a rotation can happen. When reaching
      the test, the function will then change to a new binlog file
      ignoring all the events written in this window. This will result
      in events not being replicated.
      
      Only when the binlog is detected as deactivated in the event loop
      of the dump thread, can we really know that no more events
      remain. For this reason, this test is now made under the log lock
      in the beginning of the event loop when reading the events.
      7e8c8877
    • Harin Vadodaria's avatar
      Bug#16218104: MYSQL YASSL - LUCKY THIRTEEN: BREAKING THE · 795b8acc
      Harin Vadodaria authored
                    TLS AND DTLS RECORD PROTOCOLS
      
      Description: In yassl, decryption phase in TLS protocol
                   depends on type of padding. This patch
                   removes this dependancy and makes error
                   generation/decryption process independent
                   of padding type.
      795b8acc
  13. 14 Feb, 2013 2 commits
  14. 12 Feb, 2013 1 commit
    • Annamalai Gurusami's avatar
      Bug #11753153 INNODB GENERATES SYMBOLS THAT ARE TOO LONG, INVALID DDL · 8aecb30c
      Annamalai Gurusami authored
      FROM SHOW CREATE
      
      Problem: The length of the internally generated foreign key name 
      is not checked. 
      
      Solution: The length of the internally generated foreign key name is
      checked.  If it is greater than the allowed limit, an error message
      is reported. Also, the constraint name is printed in the same manner
      as the table name, using the system charset information.
      
      rb://1969 approved by Marko.
      
      8aecb30c
  15. 08 Feb, 2013 4 commits
  16. 07 Feb, 2013 3 commits
  17. 06 Feb, 2013 1 commit
  18. 05 Feb, 2013 2 commits
  19. 04 Feb, 2013 1 commit
  20. 31 Jan, 2013 3 commits
    • Gleb Shchepa's avatar
      Bug #11827369: ASSERTION FAILED: !THD->LEX->CONTEXT_ANALYSIS_ONLY · 7ebfe30b
      Gleb Shchepa authored
      Some queries with the "SELECT ... FROM DUAL" nested subqueries
      failed with an assertion on debug builds.
      Non-debug builds were not affected.
      
      There were a few different issues with similar assertion
      failures on different queries:
      
      1. The first problem was related to the incomplete propagation
      of the "non-constant" item status from underlying subquery
      items to the outer item tree: in some cases non-constants were
      interpreted as constants and evaluated at the preparation stage
      (val_int() calls withing fix_fields() etc).
      
      Thus, the default implementation of Item_ref::const_item() from
      the Item parent class didn't take into account the "const_item"
      status of the referenced item tree -- it used the insufficient
      "used_tables() == 0" check instead. This worked in most cases
      since our "non-constant" functions like RAND() and SLEEP() set
      the RAND_TABLE_BIT in the used table map, so they aren't
      non-constant from Item_ref's "point of view". However, the
      "SELECT ... FROM DUAL" subquery may have an empty map of used
      tables, but at the same time subqueries are never "constant" at
      the context analysis stage (preparation, view creation etc).
      So, the non-contantness of such subqueries was missed.
      
      Fix: the Item_ref::const_item() function has been overloaded to
      take into account both (*ref)->const_item() status and tricky
      Item_ref::used_tables() return values, since the only
      (*ref)->const_item() call is not enough there.
      
      2. In some cases instead of the const_item() call we check a
      value of the Item::with_subselect field to recognize items
      with nested subqueries. However, the Item_ref class didn't
      propagate this value from the referenced item tree.
      
      Fix: Item::has_subquery() and Item_ref::has_subquery()
      functions have been backported from 5.6. All direct
      references to the with_subselect fields of nested items have
      been replaced with the has_subquery() function call.
      
      3. The Item_func_regex class didn't propagate with_subselect
      as well, since it overloads the Item_func::fix_fields()
      function with insufficient fix_fields() implementation.
      
      Fix: the Item_func_regex::fix_fields() function has been
      modified to gather "constant" statuses from inner items.
      
      4. The Item_func_isnull::update_used_tables() function has
      a special branch for the underlying item where the maybe_null
      value is false: in this case it marks the Item_func_isnull
      as a "const_item" and sets the cached_value to false.
      However, the Item_func_isnull::val_int() was not in sync with
      update_used_tables(): it didn't take into account neither
      const_item_cache nor cached_value for the case of
      "args[0]->maybe_null == false optimization".
      As far as such an Item_func_isnull has "const_item() == true",
      it's ok to call Item_func_isnull::val_int() etc from outer
      items on preparation stage. In this case the server tried to
      call Item_func_isnull::args[0]->isnull(), and if the args[0]
      item contained a nested not-nullable subquery, it failed
      with an assertion.
      
      Fix: take the value of Item_func_isnull::const_item_cache into
      account in the val_int() function.
      
      5. The auxiliary Item_is_not_null_test class has a similar
      optimization in the update_used_tables() function as the
      Item_func_isnull class has, and the same issue in the val_int()
      function.
      In addition to that the Item_is_not_null_test::update_used_tables()
      doesn't update the const_item_cache value, so the "maybe_null"
      optimization is useless there. Thus, we missed some optimizations
      of cases like these (before and after the fix):
        <  <is_not_null_test>(a),
        ---
        >  <cache>(<is_not_null_test>(a)),
      or
        < having (<is_not_null_test>(a) and <is_not_null_test>(a))
        ---
        > having 1
      etc.
      
      Fix: update Item_is_not_null_test::const_item_cache in
      update_used_tables() and take in into account in val_int().
      7ebfe30b
    • Yasufumi Kinoshita's avatar
      Bug #16220051 : INNODB_BUG12400341 FAILS ON VALGRIND WITH TOO MANY ACTIVE CONCURRENT TRANSACTION · c3d2803c
      Yasufumi Kinoshita authored
      innodb_bug12400341.test is disabled for valgrind daily test.
      It might be affected by the previous test's undo slots existing,
      because of slower execution.
      c3d2803c
    • Chaithra Gopalareddy's avatar
      Bug#14096619: UNABLE TO RESTORE DATABASE DUMP · e1ee9581
      Chaithra Gopalareddy authored
      Backport of Bug#13581962
      
      mysql-test/r/cast.result:
        Added test result for Bug#13581962,Bug#14096619
      mysql-test/t/cast.test:
        Added test case for Bug#13581962,Bug#14096619
      sql/item_func.h:
        limit max length by MY_INT64_NUM_DECIMAL_DIGITS
      e1ee9581
  21. 30 Jan, 2013 2 commits
    • unknown's avatar
      No commit message · 7aa707f2
      unknown authored
      No commit message
      7aa707f2
    • Krunal Bauskar krunal.bauskar@oracle.com's avatar
      - BUG#1608883: KILLING A QUERY INSIDE INNODB CAUSES IT TO EVENTUALLY CRASH · ed15e9c2
        WITH AN ASSERTION
      
        Correcting the build failure that was caused because of changes 
        checked-in to below mentioned revision.
        (Changes: DEBUG_SYNC_C should be disabled for innodb_plugin under
         Windows enviornment. Note: only for innodb_plugin.)
      
        revno: 3915
        revision-id: krunal.bauskar@oracle.com-20130114051951-ang92lkirop37431
        parent: nisha.gopalakrishnan@oracle.com-20130112054337-gk5pmzf30d2imuw7
        committer: Krunal Bauskar krunal.bauskar@oracle.com
        branch nick: mysql-5.1
        timestamp: Mon 2013-01-14 10:49:51 +0530
      
      
      ed15e9c2
  22. 29 Jan, 2013 1 commit
  23. 28 Jan, 2013 2 commits
    • Nuno Carvalho's avatar
      BUG#16200555: EMPTY NAME FOR USER VARIABLE IS ALLOWED AND BREAKS STATEMENT BINARY LOGGING · d1378565
      Nuno Carvalho authored
      On a previous fix, user variables with zero length name were incorrectly
      considered as event corruption, despite that them are allowed by server.
      
      Fix this wrong assumption by allowing again user variables with zero
      length on binary log.
      d1378565
    • Venkatesh Duggirala's avatar
      Bug#16084594 USER_VAR ITEM IN 'LOAD FILE QUERY' WAS NOT · 7e0901b9
      Venkatesh Duggirala authored
      PROPERLY QUOTED IN BINLOG FILE
      Problem: In load data file query, User variables are allowed
      inside "Into_list" and "Set_list". These user variables used
      inside these two lists are not properly guarded with backticks
      while server is writting into binlog. Hence user variable names
      like a` cannot be used in this context.
      
      Fix: Properly quote these variables while
      writting into binlog
      
      mysql-test/r/func_compress.result:
        changing result file
      mysql-test/r/variables.result:
        changing result file
      mysql-test/suite/binlog/r/binlog_stm_mix_innodb_myisam.result:
        changing result file
      sql/item_func.cc:
        Quote the user variable items
      7e0901b9