1. 08 May, 2007 1 commit
    • unknown's avatar
      Bug#26518 XPath and variables problem · 8ce067ca
      unknown authored
      Problem: XPath variables didn't work.
      Fix: adding variables support,
      both user-defined and sp local variables are now supported by XPath.
      
      
      mysql-test/r/xml.result:
        Adding test case
      mysql-test/t/xml.test:
        Adding test case
      sql/item_xmlfunc.cc:
        Adding variables support:
        - SP variables with standard XPath syntax:  $i
        - User variables with non-standard syntax:  $@i
      8ce067ca
  2. 22 Mar, 2007 8 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-5.1-rpl · 11aa04c9
      unknown authored
      into  gbichot3.local:/home/mysql_src/mysql-5.1-rpl-26194
      
      
      sql/log_event.cc:
        Auto merged
      sql/log_event.h:
        Auto merged
      11aa04c9
    • unknown's avatar
      Fix for BUG#26194 "mysqlbinlog --base64-output produces invalid SQL"; · 8ceea7c4
      unknown authored
      when it was printing a Query event, it produced invalid SQL (missing
      the BINLOG keyword, so the SQL started with the base64 string, which
      is incorrect).
      Note: no testcase; I have a .test which shows that the bugfix works,
      but it triggers BUG#26361 and so gives Valgrind warnings. I'm sending
      this test to the fixer of BUG#26361 for her/him to push when she/he
      fixes BUG#26361.
      
      
      client/mysqlbinlog.cc:
        writing the header (a line started with "#", i.e. a comment) and the
        body (the real operation) of an event to the same IO_CACHE
        (result_cache) confused the logic of Log_event::print_base64()
        (which is that if the cache is not empty then the BINLOG keyword
        should not be printed); it caused the BINLOG keyword to miss hence
        a syntactically wrong output of "mysqlbinlog --base64-output"
        for Query events.
        So we just use the two IO_CACHE already available in "print_event_info".
      sql/log_event.cc:
        using the new small inline function.
        Note that the replication code should one day be fixed to trap all
        errors (like disk write errors).
      sql/log_event.h:
        small inline function to group two operations: copying an IO_CACHE
        to a FILE, and reinitializing this IO_CACHE for being filled again.
      sql/records.cc:
        fix after merge
      8ceea7c4
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · 09f3dda7
      unknown authored
      into  romeo.(none):/home/bk/b23171-mysql-5.1-new-rpl
      
      
      09f3dda7
    • unknown's avatar
      BUG#23171: Illegal group log position · 05861963
      unknown authored
      Post-merge fixes.
      
      
      mysql-test/r/rpl_ndb_basic.result:
        Result change.
      sql/log_event.cc:
        Adding const-cast.
      05861963
    • unknown's avatar
      Merge gbichot3.local:/home/mysql_src/mysql-5.0-rpl · c4e4bc32
      unknown authored
      into  gbichot3.local:/home/mysql_src/mysql-5.1-rpl-26194
      will fix by hand
      
      
      mysql-test/t/rpl_misc_functions.test:
        Auto merged
      sql/lock.cc:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_derived.cc:
        Auto merged
      sql/sql_select.cc:
        will fix by hand
      sql/table.h:
        merge from 5.0
      c4e4bc32
    • unknown's avatar
      - renaming TMP_TABLE to NON_TRANSACTIONAL_TMP_TABLE because this is · 685d21b7
      unknown authored
      what it actually means (Monty approved the renaming)
      - correcting description of transaction_alloc command-line options
      (our manual is correct)
      - fix for a failure of rpl_trigger.
      
      
      mysql-test/t/rpl_misc_functions.test:
        test was cleaning up only on slave, but it's also needed on master,
        otherwise it influences rpl_trigger.test
      sql/lock.cc:
        clearer name
      sql/mysqld.cc:
        I checked the code that those two variables are not about binlogging
        but about the size of the transaction's memroot which is used
        to create savepoint structures and to store list of tables to be invalidated
        (for NDB). The manual has a correct description, no need to fix it.
      sql/sql_base.cc:
        clearer name
      sql/sql_derived.cc:
        clearer name
      sql/sql_select.cc:
        clearer name
      sql/table.h:
        clearer name: TMP_TABLE is used for non-transactional tables.
      685d21b7
    • unknown's avatar
      Merge romeo.(none):/home/bkroot/mysql-5.1-new-rpl · 833ea3fd
      unknown authored
      into  romeo.(none):/home/bk/b23171-mysql-5.1-new-rpl
      
      
      mysql-test/r/rpl_row_tabledefs_2myisam.result:
        Auto merged
      mysql-test/r/rpl_row_tabledefs_3innodb.result:
        Auto merged
      sql/rpl_rli.cc:
        Auto merged
      sql/rpl_rli.h:
        Auto merged
      sql/rpl_utility.cc:
        Auto merged
      sql/rpl_utility.h:
        Auto merged
      sql/slave.h:
        Auto merged
      sql/log.cc:
        Manual merge
      sql/log_event.cc:
        Manual merge
      sql/log_event.h:
        Manual merge
      sql/slave.cc:
        Manual merge
      sql/sql_binlog.cc:
        Manual merge
      833ea3fd
    • unknown's avatar
      BUG#23171: Illegal group log position · 8666675f
      unknown authored
      Tail fixes after re-applying patches to older version of clone.
      
      
      sql/log_event.cc:
        Name change of shall_skip() -> do_shall_skip()
        Introducing public shall_skip().
        Name change of skip reason enumeration constants.
        Removing extreneous argument to slave_print_msg() causing compiler warning.
      sql/log_event.h:
        Adding enumeration for skip reason.
        Factoring out exec_event() into exec_relay_log_event().
        Making public interface to event execution primitives.
        Adding documentation.
        Making some (internal) functions const-correct.
      sql/rpl_rli.cc:
        replicate_same_server_id is now a member variable of RLI.
      sql/rpl_rli.h:
        replicate_same_server_id is now a member variable of RLI.
      sql/slave.cc:
        Using RLI-specific member variable replicate_same_server_id instead of
        global instance.
        Moving comments about skipping logic to exec_relay_log_event().
        Moving event execution logic to exec_relay_log_event().
      sql/sql_binlog.cc:
        Using apply_event() directly and adding comment with explenation.
      8666675f
  3. 21 Mar, 2007 1 commit
    • unknown's avatar
      Merge mysql_cab_desk.:C:/source/c++/mysql-5.0_BUG_25543 · 89bfca83
      unknown authored
      into  mysql_cab_desk.:C:/source/c++/mysql-5.1_BUG_25543
      
      
      mysql-test/r/rpl_misc_functions.result:
        Auto merged
      mysql-test/t/rpl_misc_functions.test:
        Auto merged
      sql/sql_class.cc:
        Manual merge of conflicts during push of BUG#25543.
      89bfca83
  4. 19 Mar, 2007 1 commit
  5. 10 Mar, 2007 5 commits
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 8a140cb7
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/bk-trees/mysql-5.1-opt
      
      
      mysql-test/r/explain.result:
        Auto merged
      mysql-test/r/func_default.result:
        Auto merged
      mysql-test/r/func_regexp.result:
        Auto merged
      mysql-test/r/func_test.result:
        Auto merged
      mysql-test/r/having.result:
        Auto merged
      mysql-test/r/olap.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      mysql-test/r/varbinary.result:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      sql/item_strfunc.cc:
        Auto merged
      sql/opt_range.cc:
        Auto merged
      sql/sql_union.cc:
        Auto merged
      mysql-test/r/func_str.result:
        Manually merged
      mysql-test/t/func_str.test:
        Manually merged
      8a140cb7
    • unknown's avatar
      Merge moonbone.local:/mnt/gentoo64/work/15757-bug-5.0-opt-mysql · 2f774b47
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/25373-bug-5.0-opt-mysql
      
      
      sql/item_strfunc.cc:
        Auto merged
      mysql-test/r/func_str.result:
        SCCS merged
      mysql-test/t/func_str.test:
        SCCS merged
      2f774b47
    • unknown's avatar
      Bug#15757: Wrong SUBSTRING() result when a tmp table was employed. · 816ea8a3
      unknown authored
      When the SUBSTRING() function was used over a LONGTEXT field the max_length of
      the SUBSTRING() result was wrongly calculated and set to 0. As the max_length
      parameter is used while tmp field creation it limits the length of the result
      field and leads to printing an empty string instead of the correct result.
      
      Now the Item_func_substr::fix_length_and_dec() function correctly calculates
      the max_length parameter.
      
      
      mysql-test/t/func_str.test:
        Added a test case for the bug#15757: Wrong SUBSTRING() result when a tmp table was employed.
      mysql-test/r/func_str.result:
        Added a test case for the bug#15757: Wrong SUBSTRING() result when a tmp table was employed.
      sql/item_strfunc.cc:
        Bug#15757: Wrong SUBSTRING() result when a tmp table was employed.
        Now the Item_func_substr::fix_length_and_dec() function correctly calculates
        the max_length parameter.
      816ea8a3
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c0a05435
      unknown authored
      into  moonbone.local:/mnt/gentoo64/work/25373-bug-5.0-opt-mysql
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/r/union.result:
        Auto merged
      sql/item.cc:
        Auto merged
      c0a05435
    • unknown's avatar
      Fixed bug #26830: a crash for the query with a subselect containing ROLLUP. · 4d6ad7ac
      unknown authored
      Crash happened because the function get_best_group_min_max detected
      joins with ROLLUP incorrectly.
      
      
      mysql-test/r/olap.result:
        Added a test case for bug #26830.
      mysql-test/t/olap.test:
        Added a test case for bug #26830.
      4d6ad7ac
  6. 09 Mar, 2007 17 commits
    • unknown's avatar
      Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized · 944030ae
      unknown authored
      away.
      
      Additional fix for bug#22331. Now Item_field prints its value in the case of
      the const field.
      
      
      mysql-test/r/varbinary.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/union.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/subselect.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_test.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/having.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_regexp.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_str.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/func_default.result:
        Corrected test case after fix for bug#22331.
      mysql-test/r/explain.result:
        Corrected test case after fix for bug#22331.
      sql/sql_union.cc:
        Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized
        away.
        Cleanup of the SELECT_LEX::order_list list.
      sql/item.h:
        Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized
        away.
        Added the print() member function to the Item_field class.
      sql/item.cc:
        Bug#22331: Wrong WHERE in EXPLAIN EXTENDED when all expressions were optimized
        away.
        Added the print() member function to the Item_field class.
      944030ae
    • unknown's avatar
      Bug #25543 Replication of wrong values if using rand() in stored procedure · bcba75df
      unknown authored
      When rand() is called multiple times inside a stored procedure, the server does 
      not binlog the correct random seed values.
      
      This patch corrects the problem by resetting rand_used= 0 in 
      THD::cleanup_after_query() allowing the system to save the random seeds if needed
      for each command in a stored procedure body.
      
      However, rand_used is not reset if executing in a stored function or trigger 
      because these operations are binlogged by call and thus only the calling statement
      need detect the call to rand() made by its substatements. These substatements must 
      not set rand_used to 0 because it would remove the detection of rand() by the 
      calling statement.
      
      
      mysql-test/r/rpl_misc_functions.result:
        Bug #25543 Replication of wrong values if using rand() in stored procedure
        
        The result file was modified to include the correct processing of the new
        additions to the test. The results from execution are written to files on 
        both the master and the slave. The files are compared to ensure the values 
        from rand() generated on the master are correctly generated on the slave.
      mysql-test/t/rpl_misc_functions.test:
        Bug #25543 Replication of wrong values if using rand() in stored procedure
        
        The test was modified to include a test of a stored procedure that calls
        the rand() function multiple times. 
        
        The results from execution are written to files on both the master and the
        slave. The files are compared to ensure the values from rand() generated
        on the master are correctly generated on the slave.
      sql/sql_class.cc:
        Bug #25543 Replication of wrong values if using rand() in stored procedure
        
        The code was modified to reset rand_used so that detection of calls to rand() 
        will save random seeds if needed by the slave.
      bcba75df
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 209802eb
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/union.result:
        Auto merged
      mysql-test/t/union.test:
        Auto merged
      sql/item.cc:
        Auto merged
      209802eb
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 52fb60da
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26281-5.0-opt
      
      
      52fb60da
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1 · d5f3bc14
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      d5f3bc14
    • unknown's avatar
      Merge gkodinov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · c7de22a1
      unknown authored
      into  magare.gmz:/home/kgeorge/mysql/autopush/B26281-5.0-opt
      
      
      sql/item_strfunc.cc:
        Auto merged
      mysql-test/r/func_str.result:
        resolved test merge conflicts
      mysql-test/t/func_str.test:
        resolved test merge conflicts
      c7de22a1
    • unknown's avatar
      Bug #26281: · 29b6d554
      unknown authored
       Fixed boundry checks in the INSERT() function:
       were one off.
      
      
      mysql-test/r/func_str.result:
        Bug #26281: test case
      mysql-test/t/func_str.test:
        Bug #26281: test case
      sql/item_strfunc.cc:
        Bug #26281: fixed boundry checks
      29b6d554
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · e68df7a1
      unknown authored
      into  olga.mysql.com:/home/igor/mysql-5.0-opt
      
      
      sql/item.cc:
        Auto merged
      e68df7a1
    • unknown's avatar
      Merge olga.mysql.com:/home/igor/mysql-5.0-opt · 413604f9
      unknown authored
      into  olga.mysql.com:/home/igor/dev-opt/mysql-5.0-opt-bug26661
      
      
      413604f9
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 84ceb01e
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      sql/sql_select.cc:
        Auto merged
      84ceb01e
    • unknown's avatar
      Fixed bug #26661: crash when order by clause in a union · 729bcaf4
      unknown authored
      construct references invalid name.
      Derived tables currently cannot use outer references.
      Thus there is no outer context for them.
      The 4.1 code takes this fact into account while the 
      Item_field::fix_outer_field code of 5.0 lost the check that blocks
      any attempts to resolve names in outer context for derived tables.
      
      
      mysql-test/r/union.result:
        Added a test case for bug #26661.
      mysql-test/t/union.test:
        Added a test case for bug #26661.
      sql/item.cc:
        Fixed bug #26661.
        Derived tables currently cannot use outer references.
        Thus there is no outer context for them.
        The 4.1 code takes this fact into account while the 
        Item_field::fix_outer_field code of 5.0 lost the check that blocks
        any attempts to resolve names in outer context for derived tables.
      729bcaf4
    • unknown's avatar
      Merge abotchkov@bk-internal.mysql.com:/home/bk/mysql-5.0-opt · 76542acd
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      sql/sql_select.cc:
        Auto merged
      76542acd
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-5.0-opt · 0b85b793
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/func_str.result:
        Auto merged
      mysql-test/r/order_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/order_by.test:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/sp.result:
        merging
      mysql-test/r/view.result:
        merging
      mysql-test/t/func_str.test:
        merging
      mysql-test/t/view.test:
        merging
      0b85b793
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mrg/mysql-4.1-opt · 3cd8b881
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      3cd8b881
    • unknown's avatar
      aftermerge fix · 32ed7ddc
      unknown authored
      
      mysql-test/r/sp.result:
        merging
      mysql-test/r/view.result:
        merging
      32ed7ddc
    • unknown's avatar
      aftermerge fix · 5c1e48c5
      unknown authored
      
      mysql-test/r/view.result:
        merging
      5c1e48c5
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-5.1 · e51213dd
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      e51213dd
  7. 08 Mar, 2007 7 commits
    • unknown's avatar
      rpl_ssl.result, rpl_ssl.test: · d4ede3f5
      unknown authored
        Mask out *_Master_Log_Pos in rpl_ssl test; it varies depending on binlog format
      
      
      mysql-test/t/rpl_ssl.test:
        Mask out *_Master_Log_Pos in rpl_ssl test; it varies depending on binlog format
      mysql-test/r/rpl_ssl.result:
        Mask out *_Master_Log_Pos in rpl_ssl test; it varies depending on binlog format
      d4ede3f5
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.1 · 3d52be15
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.1-opt
      
      
      mysql-test/r/order_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/order_by.test:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/func_str.result:
        merging
      mysql-test/r/sp.result:
        merging
      mysql-test/r/view.result:
        merging
      mysql-test/t/func_str.test:
        merging
      mysql-test/t/view.test:
        merging
      3d52be15
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 12af6585
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-5.0-opt
      
      
      mysql-test/r/order_by.result:
        Auto merged
      mysql-test/r/subselect.result:
        Auto merged
      mysql-test/t/order_by.test:
        Auto merged
      mysql-test/t/sp.test:
        Auto merged
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      sql/item_cmpfunc.h:
        Auto merged
      sql/item_func.cc:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      sql/sql_lex.cc:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_load.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_update.cc:
        Auto merged
      mysql-test/r/func_str.result:
        merging
      mysql-test/r/sp.result:
        merging
      mysql-test/r/view.result:
        merging
      mysql-test/t/func_str.test:
        merging
      mysql-test/t/view.test:
        merging
      12af6585
    • unknown's avatar
      The most recent push into mysql-5.1 from mysql-5.2 was a mistake. · f68891f8
      unknown authored
      This just reverses those changes.  I'm really sorry about that.
      
      configure.in, version.c:
        Reverse last push (from mysql-5.2 into mysql-5.1)
      
      
      configure.in:
        Reverse last push (from mysql-5.2 into mysql-5.1)
      storage/ndb/src/common/util/version.c:
        Reverse last push (from mysql-5.2 into mysql-5.1)
      f68891f8
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-4.1 · 0fcd9c2b
      unknown authored
      into  mysql.com:/home/hf/work/mrg/mysql-4.1-opt
      
      
      0fcd9c2b
    • unknown's avatar
      merging · 012ae635
      unknown authored
      012ae635
    • unknown's avatar
      Merge bk-internal.mysql.com:/data0/bk/mysql-5.1 · ceefecb2
      unknown authored
      into  bk-internal.mysql.com:/data0/bk/tsmith-tmp/mysql-5.2
      
      
      configure.in:
        Auto merged
      ceefecb2