1. 29 Aug, 2005 11 commits
    • unknown's avatar
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.0 · e7816165
      unknown authored
      into lmy004.:/work/mysql-5.0-clean
      
      
      e7816165
    • unknown's avatar
      Remove a no longer used header. · a5403486
      unknown authored
      a5403486
    • unknown's avatar
      Cleanup the instance manager code. · 26b6b1b2
      unknown authored
      
      BitKeeper/deleted/.del-factory.h~c1679505d3a6dd53:
        Delete: server-tools/instance-manager/factory.h
      BitKeeper/deleted/.del-factory.cc~6836cccd4cd35b4d:
        Delete: server-tools/instance-manager/factory.cc
      server-tools/instance-manager/Makefile.am:
        - remove Commands_factory: it'll be needed when we add support
        for NNTP/HTTP connections, currently it only adds unnecessary
        complexity.
      server-tools/instance-manager/commands.cc:
        - fix coding style: no else after return; fix comments, make
        one place a bit faster.
      server-tools/instance-manager/guardian.cc:
        - fix coding style and comments.
        - we must register the current thread in the thread registry
          before entering pthread_cond_timedwait, because at shutdown
          the thread registry will try to kick out of wait all blocked 
          threads. Unregistered threads are not awakened by the registry. 
          This fixes the failinig assert in Thread_registry::~Thread_registry
          at shutdown, when shutdown is requested and there is an
          instance monitored by Guardian.
      server-tools/instance-manager/guardian.h:
        - fix coding style: enums must start with enum_
      server-tools/instance-manager/instance.h:
        - move comment to the variable it comments
      server-tools/instance-manager/instance_map.cc:
        - cleanup
      server-tools/instance-manager/instance_options.cc:
        - cleanup; no else after return (fix coding style).
      server-tools/instance-manager/manager.cc:
        - fix alignment; make some code easier to read.
      server-tools/instance-manager/mysql_connection.cc:
        - remove Commands_factory
      server-tools/instance-manager/options.cc:
        - fix a possible crash when the instance manager is started with
        --no-defaults --defaults-file=~/.my.cnf: if we return
        without cloning saved_argv by calling load_defaults, Options::cleanup
        will crash on attempt to free_defaults(saved_argv);
      server-tools/instance-manager/parse.cc:
        - get rid of Commands_factory
      server-tools/instance-manager/parse.h:
        - get rid of Commands_factory
      server-tools/instance-manager/parse_output.cc:
        - in parse_output_and_get_value return error also if the specified
          pattern was not found, or the command failed to execute.
      server-tools/instance-manager/portability.h:
        - fix coding style (// comments are allowed only at ends of lines)
      server-tools/instance-manager/thread_registry.cc:
        - implement Thread_registry::cond_timedwait
      server-tools/instance-manager/thread_registry.h:
        - implement Thread_registry::cond_timedwait; remove
          unused out parameter from Thread_registry::cond_wait.
      server-tools/instance-manager/user_map.cc:
        - safety: newline can take 2 bytes.
      26b6b1b2
    • unknown's avatar
      fix for bug 12207 (alter table discard tablespace on MyISAM table · 04af59a3
      unknown authored
      causes ERROR 2013).
      (all-in-one approved patch)
      
      
      mysql-test/r/alter_table.result:
        result for test for bug #12207
        (alter table discard database works on mysiam and causes error 2013)
      mysql-test/t/alter_table.test:
        test for bug #12207 (alter table discard tablescpae on MyISAM table
        causes ERROR 2013)
      sql/sql_table.cc:
        send all error message to table->file->print_error() thus not missing
        handing of some (like engine not supported).
        
        fix for bug #12207 (alter table discard tablespace on MyISAM table
        causes ERROR 2013)
      04af59a3
    • unknown's avatar
      Merge mysql.com:/usr/home/bar/mysql-4.1 · 7efa8d9b
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-5.0
      
      
      sql/item.h:
        don't merge bug#12371 fix into 5.0.
        It's correct only for 4.1.
      7efa8d9b
    • unknown's avatar
      fix for bug #12841 · c38e297b
      unknown authored
      (Server crash on DO IFNULL(NULL,NULL)
      (fixes also "SELECT CAST(IFNULL(NULL,NULL) as DECIMAL)" unreported
       crash)
      (new revampled fix with suggestions from Igor)
      
      
      mysql-test/r/select.result:
        result of test for bug 12841
      mysql-test/t/select.test:
        test for bug #12841
        (Server crash on DO IFNULL(NULL,NULL)
      sql/item_func.cc:
        don't use the return value of ::str_op() without checking it
        whether checking it for NULL. (fixes bug #12841 as well as
        another not reported bug, but existing one - test case added).
        All other places where ::str_op() is used are safe.
      c38e297b
    • unknown's avatar
      ctype_utf8.result, ctype_utf8.test, item.cc: · 593f03d9
      unknown authored
        Bug#12371 executing prepared statement fails (illegal mix of collations)
        After review fixes.
      
      
      sql/item.cc:
        Bug#12371 executing prepared statement fails (illegal mix of collations)
        After review fixes.
      mysql-test/t/ctype_utf8.test:
        Bug#12371 executing prepared statement fails (illegal mix of collations)
        After review fixes.
      mysql-test/r/ctype_utf8.result:
        Bug#12371 executing prepared statement fails (illegal mix of collations)
        After review fixes.
      593f03d9
    • unknown's avatar
      Merge abarkov@bk-internal.mysql.com:/home/bk/mysql-4.1 · 527a9cad
      unknown authored
      into  mysql.com:/usr/home/bar/mysql-4.1.b12371
      
      
      sql/item.cc:
        Auto merged
      sql/item.h:
        Auto merged
      527a9cad
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 901075ac
      unknown authored
      into lmy004.:/work/mysql-5.0-ready4
      
      
      sql/sql_yacc.yy:
        Auto merged
      901075ac
    • unknown's avatar
      fix for bug #12490 (all-in-one patch) · afe5507c
      unknown authored
      (Packets out of order if calling HELP CONTENTS from Stored Procedure)
      
      
      mysql-test/r/sp-error.result:
        results of test of bug 12490
      mysql-test/t/sp-error.test:
        test for bug 12490
        (Packets out of order if calling HELP CONTENTS from Stored Procedure)
      sql/sql_yacc.yy:
        disable HELP in SP
        (fixes bug 12490)
      afe5507c
  2. 28 Aug, 2005 6 commits
  3. 27 Aug, 2005 13 commits
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 9f5ef4a1
      unknown authored
      into rurik.mysql.com:/home/igor/dev/mysql-5.0-0
      
      
      9f5ef4a1
    • unknown's avatar
      gis.test corrected with Pem's wishes · 3a65c1b1
      unknown authored
      
      mysql-test/r/gis.result:
        result fixed
      mysql-test/t/gis.test:
        test corrected
      3a65c1b1
    • unknown's avatar
      Merge deer.(none):/home/hf/work/mysql-5.0.11207 · 8ac7225d
      unknown authored
      into deer.(none):/home/hf/work/mysql-5.0.clean
      
      
      sql/sql_yacc.yy:
        Auto merged
      8ac7225d
    • unknown's avatar
      Addition to the fix for #11207 (SET GLOBAL TRANSACTION ISOLATION LEVEL) · f2539a49
      unknown authored
      
      sql/sql_yacc.yy:
        exact types specified for opt_var_type and similar
      f2539a49
    • unknown's avatar
      Merge deer.(none):/home/hf/work/mysql-5.0.10499 · 8f3daaf1
      unknown authored
      into deer.(none):/home/hf/work/mysql-5.0.clean
      
      
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      8f3daaf1
    • unknown's avatar
      Merge deer.(none):/home/hf/work/mysql-4.1.clean · c11cb6a3
      unknown authored
      into deer.(none):/home/hf/work/mysql-5.0.clean
      
      
      myisam/mi_check.c:
        Auto merged
      mysql-test/r/gis-rtree.result:
        Auto merged
      mysql-test/t/gis-rtree.test:
        Auto merged
      c11cb6a3
    • unknown's avatar
      Merge deer.(none):/home/hf/work/mysql-4.1.9645 · 56b8fc52
      unknown authored
      into deer.(none):/home/hf/work/mysql-4.1.clean
      
      
      56b8fc52
    • unknown's avatar
      retest the fix for bug #10362 (SHOW PROCEDURE always qualifies name with database) · d5be483c
      unknown authored
      (already approved)
      
      
      mysql-test/r/information_schema.result:
        update test results
      mysql-test/r/sp.result:
        update test results
      mysql-test/r/sql_mode.result:
        update test results
      sql/sp.cc:
        don qualify the name
      d5be483c
    • unknown's avatar
      Merge ahristov@bk-internal.mysql.com:/home/bk/mysql-5.0 · 5e938cfd
      unknown authored
      into lmy004.:/work/mysql-5.0-bug11904
      
      
      sql/sql_select.cc:
        Auto merged
      tests/mysql_client_test.c:
        Auto merged
      5e938cfd
    • unknown's avatar
      Merge acurtis@bk-internal.mysql.com:/home/bk/mysql-5.0 · ef055c33
      unknown authored
      into  xiphis.org:/usr/home/antony/work2/p3-bug9048.2
      
      
      ef055c33
    • unknown's avatar
      Bug#9048 · bddf61cf
      unknown authored
        "Creating a function with char binary IN parameter fails"
        Parse BINARY as part of type declaration, not as 
        a column attribute.
      
      
      mysql-test/r/sp.result:
        test for bug 9048
      mysql-test/t/sp.test:
        test for bug 9048
      sql/sql_yacc.yy:
        fix bug 9048
        parse BINARY as part of type declaration and not as column modifier.
      bddf61cf
    • unknown's avatar
      func_str.result, null.result: · 28920f59
      unknown authored
        Corrected results after the fix for bug #12791.
      func_test.result, func_test.test:
        Added test cases for bug #12791.
      item_func.h, item_func.cc:
        Fixed bug #12791.
        Made LEAST/GREATES fully Oracle compliant.
        LEAST/GREATEST did not return NULL if only some
        arguments were NULLs. This did not comply with Oracle.
      
      
      sql/item_func.cc:
        Fixed bug #12791.
        Made LEAST/GREATES fully Oracle compliant.
        LEAST/GREATEST did not return NULL if only some
        arguments were NULLs. This did not comply with Oracle.
      sql/item_func.h:
        Fixed bug #12791.
        Made LEAST/GREATES fully Oracle compliant.
        LEAST/GREATEST did not return NULL if only some
        arguments were NULLs. This did not comply with Oracle.
      mysql-test/t/func_test.test:
        Added test cases for bug #12791.
      mysql-test/r/func_test.result:
        Added test cases for bug #12791.
      mysql-test/r/null.result:
        Corrected results after the fix for bug #12791.
      mysql-test/r/func_str.result:
        Corrected results after the fix for bug #12791.
      28920f59
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-5.0-release · f0aeadcd
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0
      
      
      f0aeadcd
  4. 26 Aug, 2005 10 commits
    • unknown's avatar
      unireg.h: · c7e56146
      unknown authored
        Max index key length increased from 1024 to 3072
        for 64 bit builds.
      
      
      sql/unireg.h:
        Max index key length increased from 1024 to 3072
        for 64 bit builds.
      c7e56146
    • unknown's avatar
      No commit message · 7662fc2a
      unknown authored
      No commit message
      7662fc2a
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0 · 73feede9
      unknown authored
      into mysql.com:/home/psergey/mysql-5.0-rpl-bug
      
      
      73feede9
    • unknown's avatar
      mtr_timer.pl: · 857258f1
      unknown authored
        Simplified and corrected mtr_timer_stop_all()
      
      
      mysql-test/lib/mtr_timer.pl:
        Simplified and corrected mtr_timer_stop_all()
      857258f1
    • unknown's avatar
      Merge spetrunia@bk-internal.mysql.com:/home/bk/mysql-5.0 · 16238242
      unknown authored
      into mysql.com:/home/psergey/mysql-5.0-rpl-bug
      
      
      sql/sp_head.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      16238242
    • unknown's avatar
      Slightly amended Monty's SP replication code cleanup patch · 9bc3976c
      unknown authored
      
      sql/item.cc:
        Code cleanup
      sql/item.h:
        Code cleanup
      sql/log.cc:
        Added comments
      sql/sp_head.cc:
        Code cleanup patch from Monty: 
        in subst_spvars()
        - Move local variables first in block
        - Use res|= instead of res |=
        - Use strmake() instead of alloc + memcpy
        Added:
        - Fail the query if we don't have enough memory to produce a binlog-suitable query string: 
          if we're so low on memory we're likely to fail the query anyway, and failing now removes
          the need for hack with THD::query_str_binlog_suitable.
      sql/sql_class.cc:
        Remove THD::query_str_binlog_unsuitable
      sql/sql_class.h:
        Remove THD::query_str_binlog_unsuitable
      sql/sql_delete.cc:
        Remove THD::query_str_binlog_unsuitable
      sql/sql_insert.cc:
        Remove THD::query_str_binlog_unsuitable
      sql/sql_parse.cc:
        Code cleanup
      sql/sql_update.cc:
        Remove THD::query_str_binlog_unsuitable
      9bc3976c
    • unknown's avatar
      Merge radha.local:/Users/patg/mysql-build/mysql-4.1 · 4428baaf
      unknown authored
      into  radha.local:/Users/patg/mysql-build/mysql-5.0.clean
      
      
      sql/ha_blackhole.cc:
        Resolve of fixed typo application to both 4.1 and 5.0
      4428baaf
    • unknown's avatar
      typo to DBUG_RETURN fixed · 809ea163
      unknown authored
      
      sql/ha_blackhole.cc:
        Typo to DBUG_RETURN fixed
      809ea163
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 9b01c006
      unknown authored
      into sergbook.mysql.com:/usr/home/serg/Abk/mysql-5.0
      
      
      9b01c006
    • unknown's avatar
      bad blind change fixed · 661f20cb
      unknown authored
      661f20cb