1. 27 Apr, 2013 1 commit
    • Bill Qu's avatar
      Bug #13004581 BLACKHOLE BINARY LOG WITH ROW IGNORES UPDATE AND DELETE STATEMENTS · 975968e2
      Bill Qu authored
        
      When logging to the binary log in row, updates and deletes to a BLACKHOLE
      engine table are skipped.
        
      It is impossible to log binary log in row format for updates and deletes to
      a BLACKHOLE engine table, as no row events can be generated in these cases.
      After fix, generate a warning for UPDATE/DELETE statements that modify a
      BLACKHOLE table, as row events are not logged in row format.
      975968e2
  2. 25 Apr, 2013 1 commit
    • Venkatesh Duggirala's avatar
      BUG#16698172-CANNOT DO POINT-IN-TIME RECOVERY FOR · 2557f2c4
      Venkatesh Duggirala authored
      SINGLE DATABASE; MYSQLBINLOG
            
      Problem: If last subevent inside a RBR event
      is skipped while replaying a binary log
      using mysqlbinlog with --database=... option,
      generated output is missing end marker('/*!*/;)
      for that RBR event. Thence causing syntax error
      while replaying the generated output.
            
      Fix: Append end marker ('/*!*/;) if the last 
      subevent is getting skipped.
      Append end marker if the last 
      subevent is getting skipped.
      
      client/mysqlbinlog.cc:
        Append end marker if the last 
        subevent is getting skipped.
      2557f2c4
  3. 24 Apr, 2013 6 commits
  4. 22 Apr, 2013 2 commits
  5. 20 Apr, 2013 2 commits
    • Neeraj Bisht's avatar
      Bug#16073689 : CRASH IN ITEM_FUNC_MATCH::INIT_SEARCH · d5cb6649
      Neeraj Bisht authored
      Problem:
      In query like
      select 1 from .. order by match .. against ...;
      causes a debug assert failue.
      
      Analysis:
      In union type query like
      
      (select * from order by a) order by b;
      or
      (select * from order by a) union (select * from order by b);
      
      We skip resolving of order by a for 1st query and order by of a and b in 
      2nd query.
      
      
      This means that, in case when our order by have Item_func_match class, 
      we skip resolving it.
      But we maintain a ft_func_list and at the time of optimization, when we 
      Perform FULLTEXT search before all regular searches on the bases of the 
      list we call Item_func_match::init_search() which will cause debug assert 
      as the item is not resolved.
      
      
      Solution:
      We will skip execution if the item is not fixed and we will not 
      fix index(Item_func_match::fix_index()) for which 
      Item_func_match::fix_field() is not called so that on later changes 
      we can check the dependency on fix field.
      bz
      
      sql/item_func.cc:
        skiping execution, if item is not resolved.
      d5cb6649
    • Neeraj Bisht's avatar
      Bug#16073689 : CRASH IN ITEM_FUNC_MATCH::INIT_SEARCH · 89b1b508
      Neeraj Bisht authored
      Problem:
      In query like
      select 1 from .. order by match .. against ...;
      causes a debug assert failue.
      
      Analysis:
      In union type query like
      
      (select * from order by a) order by b;
      or
      (select * from order by a) union (select * from order by b);
      
      We skip resolving of order by a for 1st query and order by of a and b in 
      2nd query.
      
      
      This means that, in case when our order by have Item_func_match class, 
      we skip resolving it.
      But we maintain a ft_func_list and at the time of optimization, when we 
      Perform FULLTEXT search before all regular searches on the bases of the 
      list we call Item_func_match::init_search() which will cause debug assert 
      as the item is not resolved.
      
      
      Solution:
      We will skip execution if the item is not fixed and we will not 
      fix index(Item_func_match::fix_index()) for which 
      Item_func_match::fix_field() is not called so that on later changes 
      we can check the dependency on fix field.
      
      
      sql/item_func.cc:
        skiping execution, if item is not resolved.
      89b1b508
  6. 18 Apr, 2013 1 commit
  7. 17 Apr, 2013 1 commit
  8. 16 Apr, 2013 3 commits
  9. 14 Apr, 2013 2 commits
    • Chaithra Gopalareddy's avatar
      Merge from 5.1 to 5.5 · 51555d2a
      Chaithra Gopalareddy authored
      sql/sql_class.h:
        Parsing for group_concat's order by  is made independent.
        As a result, add_order_to_list cannot be used anymore.
      51555d2a
    • Chaithra Gopalareddy's avatar
      Bug#16347426:ASSERTION FAILED: (SELECT_INSERT && · 2d836633
      Chaithra Gopalareddy authored
                   !TABLES->NEXT_NAME_RESOLUTION_TABLE) || !TAB
            
      Problem:
      The context info of select query gets corrupted when a query
      with group_concat having order by is present in an order by
      clause of the select query. As a result, server crashes with
      an assert.
            
      Analysis:
      While parsing order by for group_concat, it is presumed that
      it is always present before the actual order by for the
      select query.
      As a result, parser uses select->order_list to populate the
      order by items of group_concat and creates a select->gorder_list
      to which select->order_list is copied onto. Once this is done,
      it empties the select->order_list.
      In the case presented in the bugpage, as order by is already
      parsed when group_concat's order by is encountered, parser
      presumes that it is the second order by in the select query
      and creates fake_lex_unit which results in the change of
      context info.
            
      Solution:
      Make group_concat's order by parsing independent of the select
      
      
      sql/item_sum.cc:
        Change the argument as, select->gorder_list is not pointer anymore
      sql/item_sum.h:
        Change the argument as, select->gorder_list is not pointer anymore
      sql/mysql_priv.h:
        Parsing for group_concat's order by is made independent.
        As a result, add_order_to_list cannot be used anymore.
      sql/sql_lex.cc:
        Parsing for group_concat's order by is made independent.
        As a result, add_order_to_list cannot be used anymore.
      sql/sql_lex.h:
        Parsing for group_concat's order by is made independent.
        As a result, add_order_to_list cannot be used anymore.
      sql/sql_yacc.yy:
         Make group_concat's order by parsing independent of the select
        queries order by.
      2d836633
  10. 12 Apr, 2013 3 commits
    • Balasubramanian Kandasamy's avatar
      e5055e22
    • Venkatesh Duggirala's avatar
      BUG#16615117 MYSQLDUMP PRODUCES A CHANGE MASTER STATEMENT · 0fe3128c
      Venkatesh Duggirala authored
      WITH A PORT NUMBER ENCLOSED IN QUOTES
      
      Problem: mysqldump --dump-slave --include-master-host-port
      prints the CHANGE MASTER command in the generated logical
      backup. The PORT number that is generated with this command
      is a string and should be an integer.
      
      Fix: Remove the Enclosed quotes for port number.
      0fe3128c
    • Jorgen Loland's avatar
      Bug#16540042: WRONG QUERY RESULT WHEN USING RANGE OVER · 2c780b46
      Jorgen Loland authored
                    PARTIAL INDEX
      
      Consider the following table definition:
      
      CREATE TABLE t (
        my_col CHAR(10),
        ...
        INDEX my_idx (my_col(1))
      )
      
      The my_idx index is not able to distinguish between rows with
      equal first-character my_col-values (e.g. "f", "foo", "fee").
      
      Prior to this CS, the range optimizer would translate
      
      "WHERE my_col NOT IN ('f', 'h')" into (optimizer trace syntax)
      
      "ranges": [
        "NULL < my_col < f",
        "f < my_col"
      ]
      
      But this was not correct because the rows with values "foo" 
      and "fee" would not belong to any of those ranges. However, the
      predicate "my_col != 'f' AND my_col != 'h'" would translate
      to 
      
      "ranges": [
        "NULL < my_col"
      ]
      
      because get_mm_leaf() changes from "<" to "<=" for partial
      keyparts. This CS changes the range optimizer implementation 
      for NOT IN to behave like a conjunction of NOT EQUAL: it 
      replaces "<" with "<=" for all but the first range when the
      keypart is partial.
      2c780b46
  11. 11 Apr, 2013 1 commit
  12. 10 Apr, 2013 2 commits
    • Tor Didriksen's avatar
      Bug#16395606 SCRIPTS MISSING EXECUTE BIT · 6b9233fb
      Tor Didriksen authored
      Add execute bit for scripts:
       - in build directory
       - in install directory
      6b9233fb
    • Thayumanavar's avatar
      BUG#16402143 - STACK CORRUPTION IN DBUG_EXPLAIN · 348d14c7
      Thayumanavar authored
      DESCRIPTION AND FIX:
      DBUG_EXPLAIN result in buffer overflow when the
      DEBUG variable values length exceed 255.
      In _db_explain_ function which call macro str_to_buf
      incorrectly passes the length of buf avaliable to
      strnmov as len+1. The fix calculates the avaliable
      space in buf and passes it to strnxmov.
      348d14c7
  13. 09 Apr, 2013 2 commits
  14. 08 Apr, 2013 5 commits
    • Gopal Shankar's avatar
      null merge · 90738111
      Gopal Shankar authored
      90738111
    • unknown's avatar
      No commit message · 6777c3fa
      unknown authored
      No commit message
      6777c3fa
    • unknown's avatar
      No commit message · 944ea996
      unknown authored
      No commit message
      944ea996
    • unknown's avatar
      No commit message · dc7af6e6
      unknown authored
      No commit message
      dc7af6e6
    • Raghav Kapoor's avatar
      BUG#15978766 - TEST VALGRIND_REPORT FAILS INNODB TESTS · 0d67ea37
      Raghav Kapoor authored
      BACKGROUND:
      The testcase i_innodb.innodb_bug14036214 when run under valgrind
      leaks memory.
      
      ANALYSIS:
      In the code path of mysql_update, a temporary file is opened
      using open_cached_file().
      When an error has occured in that code path, this temporary
      file was not closed since call to close_cached_file() was 
      missing.
      This problem exists in 5.5 but it does not exists in 5.6 and 
      trunk. 
      This is because in 5.6 and trunk, when we issue the update
      statement in the test case, it does not take the same code path
      as in 5.5. The code path is different because a different plan 
      is chosen by optimizer. 
      See Bug#14036214 for details.
      However, the problem can still be examined in 5.6 and trunk
      by code inspection.
      
      FIX:
      The file opened by open_cached_file() has been closed by calling
      close_cached_file() when an error occurs so that it does not 
      results in a memory leak.
      0d67ea37
  15. 04 Apr, 2013 1 commit
  16. 03 Apr, 2013 1 commit
  17. 02 Apr, 2013 5 commits
  18. 01 Apr, 2013 1 commit