1. 21 Jul, 2004 1 commit
  2. 20 Jul, 2004 9 commits
    • unknown's avatar
      Merge gbichot@213.136.52.20:/home/bk/mysql-4.1 · bf95f919
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.1-874
      
      
      bf95f919
    • unknown's avatar
      Sanja will probably rework this tomorrow; we need to unify the normal · 5a37da8e
      unknown authored
      client code and replication slave code, as far as LOAD DATA INFILE and
      other queries' execution is concerned. Duplication of code leads to
      replication bugs, because the replication duplicate lags much behind.
      Fix for 2 Valgrind errors on slave replicating LOAD DATA INFILE
        - one serious (causing a random test failure in rpl_loaddata in 5.0)
        - one not serious (theoretically a bug but not dangerous): uninited thd->row_count
      
      
      sql/log_event.cc:
        Fix for 2 Valgrind errors:
        - one serious (causing a random test failure in rpl_loaddata in 5.0): uninited lex in replic of LOAD DATA INFILE on slave
        - one not serious (theoretically a bug but not dangerous): uninited thd->row_count in replication of LOAD DATA INFILE on slave.
        Sanja is likely to rework the fix to the 1st problem tomorrow.
      5a37da8e
    • unknown's avatar
      Updates for archive storage engine. · 325de4eb
      unknown authored
      
      sql/examples/ha_archive.cc:
        Corrections from Bar's comments. Mainly small code changes/style changes.
      325de4eb
    • unknown's avatar
      Merge tsmith@build.mysql.com:/home/bk/mysql-4.1 · 3750abaa
      unknown authored
      into sand.box:/home/tim/m/41/bk
      
      
      mysql-test/r/ps_1general.result:
        Auto merged
      3750abaa
    • unknown's avatar
      Get ps_1general test to pass (replace .result with .reject - some text · f32eb834
      unknown authored
      was changed in the SHOW STORAGE ENGINES results)
      
      
      mysql-test/r/ps_1general.result:
        SHOW STORAGE ENGINES now has different text ("type" -> "engine", etc.)
      f32eb834
    • unknown's avatar
      Added innodb_locks_unsafe_for_binlog option. This option turns off Innodb · 238b226f
      unknown authored
        next-key locking. Using this option the locks InnoDB sets on index 
        records do not affect the ``gap'' before that index record. Thus, this option
        allows phantom problem.
      
      
      innobase/include/srv0srv.h:
        Added srv_locks_unsafe_for_binlog for innodb_locks_unsafe_for_binlog option.
      innobase/row/row0sel.c:
        If innodb_locks_unsafe_for_binlog option is used, we lock only the record, i.e. 
        next-key locking is not used. Therefore, setting lock to the index record
        do not affect the ``gap'' before that index record. Thus, this option
        allows phantom problem, because concurrent insert operations are allowed inside 
        the select range.
      innobase/srv/srv0srv.c:
        Added srv_locks_unsafe_for_binlog for innodb_locks_unsafe_for_binlog option.
      sql/ha_innodb.cc:
        Added innobase_locks_unsafe_for_binlog and srv_locks_unsafe_for_binlog for 
        innodb_locks_unsafe_for_binlog option.
      sql/ha_innodb.h:
        Added innobase_locks_unsafe_for_binlog for innodb_locks_unsafe_for_binlog option.
      sql/mysqld.cc:
        Added OPT_INNODB_LOCKS_UNSAFE_FOR_BINLOG, innobase_locks_unsafe_for_binlog for
        innodb_locks_unsafe_for_binlog option.
      sql/set_var.cc:
        Added innodb_locks_unsafe_for_binlog and innobase_locks_unsafe_for_binlog for
        innodb_locks_unsafe_for_binlog option.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      238b226f
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1/ · 26821ee3
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-4.1
      
      
      26821ee3
    • unknown's avatar
      oops, forgot to checkin... · 4b3ee02e
      unknown authored
      4b3ee02e
    • unknown's avatar
      results fixed after merge · 8818cd9b
      unknown authored
      
      mysql-test/t/create_select_tmp.test:
        --disable_warnings
      mysql-test/t/rpl_drop.test:
        --disable_warnings
      8818cd9b
  3. 19 Jul, 2004 6 commits
    • unknown's avatar
      manual merged (blame me!) · eee5f15b
      unknown authored
      
      Build-tools/Do-compile:
        Auto merged
      Docs/Makefile.am:
        Auto merged
      innobase/btr/btr0cur.c:
        Auto merged
      innobase/include/lock0lock.h:
        Auto merged
      innobase/include/row0mysql.h:
        Auto merged
      innobase/include/srv0srv.h:
        Auto merged
      innobase/include/sync0arr.h:
        Auto merged
      innobase/include/trx0trx.h:
        Auto merged
      innobase/lock/lock0lock.c:
        Auto merged
      innobase/srv/srv0srv.c:
        Auto merged
      innobase/srv/srv0start.c:
        Auto merged
      innobase/sync/sync0arr.c:
        Auto merged
      innobase/trx/trx0trx.c:
        Auto merged
      sql/ha_innodb.cc:
        Auto merged
      sql/sql_insert.cc:
        Auto merged
      mysql-test/r/innodb.result:
        to be fixed after the merge
      eee5f15b
    • unknown's avatar
      Compilation failure on Windows fixed. · 784191d9
      unknown authored
      784191d9
    • unknown's avatar
      merged with 'ul' · b940ae10
      unknown authored
      b940ae10
    • unknown's avatar
      handler.cc: · d57d78ac
      unknown authored
        Revise output of SHOW ENGINES.
      
      
      sql/handler.cc:
        Revise output of SHOW ENGINES.
      d57d78ac
    • unknown's avatar
      make acl_init() more robust - · 6592c1af
      unknown authored
        don't be confused if  new privilege - ENUM ('N','Y') - columns are added (mostly because of downgrade)
        don't expect NOT NULL fields to never contain a NULL :) - somebody may've changed table definition, or we may be reading the wrong column
      
      
      6592c1af
    • unknown's avatar
      - only include the GPL license in the LICENSE text, not the FOSS · d0934eca
      unknown authored
         exception (it only applies to 4.0 and above)
      
      
      d0934eca
  4. 18 Jul, 2004 1 commit
    • unknown's avatar
      Fix for BUG#4551 "Temporary InnoDB tables not replicated properly with CREATE TABLE .. SELECT" · 382ff793
      unknown authored
      The problem was that (for any storage engine), the created temporary table was not removed if CREATE SELECT failed (because
      of a constraint violation for example). This was not consistent with the manual and with CREATE SELECT (no TEMPORARY).
      
      
      sql/sql_insert.cc:
        Fix for BUG#4551 "Temporary InnoDB tables not replicated properly with CREATE TABLE .. SELECT"
        The problem was that (for any storage engine), the created temporary table was not removed if CREATE SELECT failed (because
        of a constraint violation for example). This was not consistent with the manual and with CREATE SELECT (no TEMPORARY).
        And it led to the above bug, because the binlogging of CREATE SELECT is done by select_insert::send_eof() (same function
        as INSERT SELECT) and so, if the table is transactional and there is a failure, the statement is considered as rolled
        back and so nothing is written in the binlog. So temp table MUST be deleted.
      382ff793
  5. 17 Jul, 2004 2 commits
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 474c2578
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      474c2578
    • unknown's avatar
      Fixes for · cf8dbcc6
      unknown authored
      BUG#4506 "mysqlbinlog --position --read-from-remote-server has wrong "# at" lines",
      BUG#4553 "Multi-table DROP TABLE replicates improperly for nonexistent table" with a test file.
      It was not possible to add a test for BUG#4506 as in the test suite we must use --short-form
      which does not display the "# at" lines.
      
      
      client/mysqlbinlog.cc:
        Fix for BUG#4506 "mysqlbinlog --position --read-from-remote-server has wrong "# at" lines"
        when reading a remote binlog, the start position is not always BIN_LOG_HEADER_SIZE (4).
      sql/sql_table.cc:
        Fix for BUG#4553 "Multi-table DROP TABLE replicates improperly for nonexistent table"
        we must my_error() _before_ we write to the binlog, so that a meaningful error code is available
        in thd->net.last_errno for storage of the DROP TABLE statement into the binlog.
      cf8dbcc6
  6. 16 Jul, 2004 8 commits
  7. 15 Jul, 2004 6 commits
    • unknown's avatar
      Merge lgrimmer@build.mysql.com:/home/bk/mysql-4.1 · 6a7ecbb7
      unknown authored
      into mysql.com:/space/my/mysql-4.1
      
      
      6a7ecbb7
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.1 · 8871b054
      unknown authored
      into mysql.com:/space/my/mysql-4.1-build
      
      
      8871b054
    • unknown's avatar
      - Avoid the error message "Can't read index header from..." · c2753d95
      unknown authored
         when copying a small index file because the value returned
         for $length is < 1024. This can happen if the filehandle
         was open()ed as an UTF-8 encoded file with Unicode characters
         (In this case read() returns characters not bytes)
         (Thanks to Mike Bethune) for this hint)
      
      
      c2753d95
    • unknown's avatar
      InnoDB: limit the recursion depth for ON (UPDATE|DELETE) CASCADE · 13985521
      unknown authored
      (Bug #4446)
      
      
      innobase/row/row0ins.c:
        row_ins_foreign_check_on_constraint(): limit recursion for UPDATE too
      mysql-test/r/innodb.result:
        Add test for recursion depth limit
      mysql-test/t/innodb.test:
        Add test for recursion depth limit
      13985521
    • unknown's avatar
      check that all system tables deleted added · 3d8c7c3d
      unknown authored
      3d8c7c3d
    • unknown's avatar
      btr0cur.c: · 9e6f6198
      unknown authored
        Do not add + 1 to the InnoDB index cardinality estimate if the B-tree just contains one page; the fix made in March 2004 caused InnoDB systematically to overestimate the cardinality of empty or small tables by 1
      
      
      innobase/btr/btr0cur.c:
        Do not add + 1 to the InnoDB index cardinality estimate if the B-tree just contains one page; the fix made in March 2004 caused InnoDB systematically to overestimate the cardinality of empty or small tables by 1
      9e6f6198
  8. 14 Jul, 2004 3 commits
  9. 13 Jul, 2004 4 commits