1. 26 Jul, 2007 2 commits
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25679.3 · 99dc9bdb
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25679.3.merge-5.1
      
      
      storage/federated/ha_federated.cc:
        Auto merged
      99dc9bdb
    • unknown's avatar
      fix pushbuild failures · 85af6ba9
      unknown authored
      
      sql/ha_federated.cc:
        remote_error_number is set to -1 when an error was already reported
        with my_error(). ER(-1) will also cause a crash on 64bit arch and only
        worked on 32bit arch by luck
      85af6ba9
  2. 25 Jul, 2007 4 commits
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25679.3 · c6a0b224
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25679.3.merge-5.1
      
      
      mysql-test/r/federated.result:
        Auto merged
      mysql-test/t/federated.test:
        Auto merged
      storage/federated/ha_federated.h:
        Auto merged
      storage/federated/ha_federated.cc:
        manual merge 5.0 to 5.1
      c6a0b224
    • unknown's avatar
      Bug#25679 · b42247bc
      unknown authored
        "Federated Denial of Service"
        Federated storage engine used to attempt to open connections within
        the ::create() and ::open() methods which are invoked while LOCK_open
        mutex is being held by mysqld. As a result, no other client sessions
        can open tables while Federated is attempting to open a connection.
        Long DNS lookup times would stall mysqld's operation and a rogue
        connection string which connects to a remote server which simply
        stalls during handshake can stall mysqld for a much longer period of
        time.
        This patch moves the opening of the connection much later, when the
        federated actually issues queries, by which time the LOCK_open mutex is
        no longer being held.
      
      
      mysql-test/r/federated.result:
        change of test/results due to patch for bug25679
      mysql-test/t/federated.test:
        change of test/results due to patch for bug25679
      sql/ha_federated.cc:
        bug25679
          remove function check_foreign_fata_source()
          ha_federated::open() no longer opens the federated connection.
          ha_federated::create() no longer opens and tests connection.
          ha_federated::real_connect() opens connection and tests presence of table.
          ha_federated::real_query() sends query, calling real_connect() if neccessary.
      sql/ha_federated.h:
        bug25679
          new methods real_query() and real_connect()
      b42247bc
    • unknown's avatar
      Merge mysql.com:/home/svoj/devel/bk/mysql-5.1-engines · 34864af8
      unknown authored
      into  mysql.com:/home/svoj/devel/mysql/BUG29806/mysql-5.1-engines
      
      
      sql/ha_ndbcluster.cc:
        Auto merged
      sql/lock.cc:
        Auto merged
      34864af8
    • unknown's avatar
      BUG#29806 - binlog_innodb.test creates a server log · 4537a0c9
      unknown authored
      Stopping mysql server could result in an entry in mysql error
      file: "InnoDB: Error: MySQL is freeing a thd".
      
      This happened because InnoDB assumes that the server will never
      call external_lock(F_UNLCK) in case external_lock(READ/WRITE)
      failed.
      
      Prior to this patch we haven't had strict definition whether
      external_lock(F_UNLCK) must be called in case external_lock(READ/WRITE)
      fails.
      
      This patch states that we never call external_lock(F_UNLCK) in case
      external_lock(READ/WRITE) fails.
      
      
      mysql-test/suite/binlog/t/disabled.def:
        Re-enabled binlog_innodb and binlog_killed tests.
      sql/ha_ndbcluster.cc:
        Restore handler state in case external_lock() failed.
      sql/ha_partition.cc:
        Do not call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed.
      sql/lock.cc:
        Do not call external_lock(F_UNLCK) in case external_lock(READ/WRITE) failed.
      storage/myisammrg/myrg_locking.c:
        Restore handler state in case external_lock() failed.
      4537a0c9
  3. 24 Jul, 2007 10 commits
    • unknown's avatar
      Merge... · 8a159e38
      unknown authored
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
      
      
      
      8a159e38
    • unknown's avatar
      fix compile on Windows for bug25714.c · 5415dcc3
      unknown authored
      ---
      fix compile on Windows for bug25714.c
      
      
      tests/bug25714.c:
        fix compile on Windows
      5415dcc3
    • unknown's avatar
      build bug25714 test app on Windows · 791eee3e
      unknown authored
      791eee3e
    • unknown's avatar
      Merge... · e6b02976
      unknown authored
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
      
      
      BitKeeper/deleted/.del-CMakeLists.txt~5:
        Auto merged
      e6b02976
    • unknown's avatar
      build bug25714 test app on Windows · 4ab0c0cf
      unknown authored
      4ab0c0cf
    • unknown's avatar
      Merge... · 9097da00
      unknown authored
      Merge pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.0
      into  pcg5ppc.xiphis.org:/private/Network/Servers/anubis.xiphis.org/home/antony/work/p2-bug25714.1.merge-5.1
      
      
      
      9097da00
    • unknown's avatar
      post 5.0 to 5.1 merge fixes · 541e40f9
      unknown authored
      541e40f9
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25714.1 · e1b3b931
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25714.1.merge-5.1
      
      
      mysql-test/mysql-test-run.pl:
        Auto merged
      tests/Makefile.am:
        Auto merged
      storage/federated/ha_federated.cc:
        manual merge from 5.0 to 5.1
      e1b3b931
    • unknown's avatar
      Merge xiphis.org:/anubis/antony/work/p2-bug25714.1 · 594d71a4
      unknown authored
      into  xiphis.org:/anubis/antony/work/p2-bug25714.1.merge-5.0
      
      
      594d71a4
    • unknown's avatar
      Bug#25714 · 0f85ae9f
      unknown authored
        "getGeneratedKeys() does not work with FEDERATED table"
        mysql_insert() expected the storage engine to update the row data
        during the write_row() operation with the value of the new auto-
        increment field. The field must be updated when only one row has
        been inserted as mysql_insert() would ignore the thd->last_insert.
        This patch implements HA_STATUS_AUTO support in ha_federated::info()
        and ensures that ha_federated::write_row() does update the row's
        auto-increment value.
        The test case was written in C as the protocol's 'id' value is
        accessible through libmysqlclient and not via SQL statements.
        mysql-test-run.pl was extended to enable running the test binary.
      
      
      mysql-test/mysql-test-run.pl:
        bug25714
          implement support to run C test for bug25714
      sql/ha_federated.cc:
        bug25714
          The storage engine instance property auto_increment_value was not
          being set.
          mysql_insert() requires that the storage engine updates the row with
          the auto-increment value, especially when only inserting one row.
          Implement support for ha_federated::info(HA_STATUS_AUTO)
      tests/Makefile.am:
        bug25714
          build C test for bug
      mysql-test/include/have_bug25714.inc:
        New BitKeeper file ``mysql-test/include/have_bug25714.inc''
      mysql-test/r/federated_bug_25714.result:
        New BitKeeper file ``mysql-test/r/federated_bug_25714.result''
      mysql-test/r/have_bug25714.require:
        New BitKeeper file ``mysql-test/r/have_bug25714.require''
      mysql-test/t/federated_bug_25714.test:
        New BitKeeper file ``mysql-test/t/federated_bug_25714.test''
      tests/bug25714.c:
        New BitKeeper file ``tests/bug25714.c''
      0f85ae9f
  4. 22 Jul, 2007 3 commits
  5. 21 Jul, 2007 5 commits
  6. 20 Jul, 2007 16 commits