1. 07 Jul, 2006 3 commits
    • unknown's avatar
      BUG#13985: Cluster: ndb_mgm "status" command can return incorrect data node status · a610467f
      unknown authored
      - only force HB to data nodes
      - flag for if we broadcast condition on receipt of HB
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Add get_connected_ndb_nodes to check status for connected data nodes only
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        add prototype for get_connected_ndb_nodes
      ndb/src/mgmsrv/Services.cpp:
        only force HB to NDBD nodes
      ndb/src/ndbapi/ClusterMgr.cpp:
        flag to control if we send the condition
      ndb/src/ndbapi/ClusterMgr.hpp:
        flag for if we broadcast condition on receipt of hb
      a610467f
    • unknown's avatar
      BUG#13985 Cluster: ndb_mgm "status" command can return incorrect data node status · 5a8919f2
      unknown authored
      use existing transporter mutex
      
      
      ndb/src/ndbapi/ClusterMgr.cpp:
        just use the transporter facade mutex.
        
        parallel 'show' will get woken up at the same time
      ndb/src/ndbapi/ClusterMgr.hpp:
        remove wait for heartbeat mutex
      5a8919f2
    • unknown's avatar
      BUG#13985 ndb_mgm "status" command can return incorrect data node status · bd015e57
      unknown authored
      better support parallel show commands, hold mutex when touching waitForHBFromNodes
      
      
      ndb/src/ndbapi/ClusterMgr.cpp:
        correctly serialize ::forceHB calls and hold mutex for whole time updating
        waitForHBFromNodes
      bd015e57
  2. 03 Jul, 2006 1 commit
    • unknown's avatar
      BUG#13985 ndb_mgm "status" command can return incorrect data node status · 3cea3705
      unknown authored
      Second half of the fix for this bug.
      
      This patch forces a heartbeat to be sent and will wait (a little while)
      for replies. This way we can get
      
      > all status
      X starting
      Y started
      X started
      >
      
      which is okay as the new status comes after the old status, always.
      There is the slimmest of opportunities to get output like above where only half
      the cluster appears started.
      
      This is about the best we can do with a command line interactive program.
      
      
      ndb/src/mgmsrv/MgmtSrvr.cpp:
        Add updateStatus method to MgmtSrvr.
        
        Used to force an update of node status for the nodes.
      ndb/src/mgmsrv/MgmtSrvr.hpp:
        add prototype for updateStatus(NodeBitmask) method
      ndb/src/mgmsrv/Services.cpp:
        When status is queried, force an update of the status in the mgm server. (i.e. send heartbeats)
      ndb/src/ndbapi/ClusterMgr.cpp:
        new DEBUG_REG define for debugging registration and HB code.
        
        Add ClusterMgr::forceHB(NodeBitmask) which sends a HB signal to each node in
        the bitmask and then waits for a REGCONF from them.
        Will only wait for a total of 1 second, not blocking an end client for too long.
        
        On receipt of HB, clear the nodeId in the waiting for bitmask and signal any
        waiting threads.
      ndb/src/ndbapi/ClusterMgr.hpp:
        Add ::forceHB(NodeBitmask) and associated variables
      3cea3705
  3. 23 May, 2006 1 commit
    • unknown's avatar
      BUG#13985 Cluster: ndb_mgm "status" command can return incorrect data node status · 746fc2f4
      unknown authored
      partial fix for this bug. more info on what the other half of the fix involves
      is in the bug report.
      
      
      ndb/src/mgmclient/CommandInterpreter.cpp:
        partial fix for bug13985
        
        hold a mutex around printing out events
        hold the mutex also around printing out put of 'status' commands.
        
        this means we don't get
        1 started
        2 started
        2 starting
        
        output.
        
        we'll instead get the event before/after the entire status output.
        Due to the nature of the event arriving before status being updated,
        we'll pretty much always see started AFTER starting.
      746fc2f4
  4. 22 May, 2006 1 commit
  5. 21 May, 2006 2 commits
    • unknown's avatar
      Merge bk@192.168.21.1:mysql-5.0 · 07188950
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.mrg
      
      
      07188950
    • unknown's avatar
      ndb - bug#19956 (occurs only in v5.0) · a57c9674
      unknown authored
      
      mysql-test/r/ndb_blob.result:
        bug#19956 : var* pk
      mysql-test/t/ndb_blob.test:
        bug#19956 : var* pk
      ndb/src/ndbapi/NdbDictionaryImpl.hpp:
        bug#19956 - check var* length bytes and zero rest of value if any blob attribute
      ndb/src/ndbapi/NdbOperationSearch.cpp:
        bug#19956 - check var* length bytes and zero rest of value if any blob attribute
      a57c9674
  6. 20 May, 2006 4 commits
  7. 19 May, 2006 6 commits
    • unknown's avatar
      Merge mysql.com:/home/jimw/my/mysql-5.0-1039 · 719bfafc
      unknown authored
      into  mysql.com:/home/jimw/my/mysql-5.0-clean
      
      
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      include/sslopt-longopts.h:
        Resolve conflict
      include/sslopt-vars.h:
        Resolve conflict
      mysql-test/r/variables.result:
        Resolve conflict
      mysql-test/t/variables.test:
        Resolve conflict
      719bfafc
    • unknown's avatar
      Merge msvensson@bk-internal.mysql.com:/home/bk/mysql-5.0 · 8dff422f
      unknown authored
      into  devsrv-b.mysql.com:/users/msvensson/mysql-5.0
      
      
      sql/mysqld.cc:
        Auto merged
      8dff422f
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 891361be
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      891361be
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my41-bug13711 · 5c484b20
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-4.1
      
      
      5c484b20
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/my41-bug13711 · f98e7a9e
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      include/my_pthread.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      f98e7a9e
    • unknown's avatar
      Bug#15869 Cannot shutdown the server - it restarts · 5ceb394f
      unknown authored
       - A segfault occured when the function 'kill_server' called 
         'my_sigset' with signal number 0. 'my_sigset' is a macro which
         uses 'sigaction' to install the signal handler with an invalid
         signal number will on most platforms return EINVAL but yields
         a segfauilt on IRIX 6.5
       - The server crash was detected by mysqld_safe and it was restarted although
         a shutdown was requested. 
       - Semantics of kill_server(0) is not known, leaving it intact
      
      
      include/my_pthread.h:
        Check return value from sigaction with a DBUG_ASSERT
        Also DBUG_ASSERT if signal number 0 is passed
      sql/mysqld.cc:
        Don't call my_sigset if signo is 0
      5ceb394f
  8. 18 May, 2006 7 commits
    • unknown's avatar
      Merge ibabaev@bk-internal.mysql.com:/home/bk/mysql-5.0 · 41e6fb25
      unknown authored
      into  rurik.mysql.com:/home/igor/mysql-5.0
      
      
      41e6fb25
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · 33c439ce
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-2
      
      
      sql/item.cc:
        Auto merged
      sql/item_cmpfunc.cc:
        Auto merged
      mysql-test/r/view.result:
        SCCS merged
      mysql-test/t/view.test:
        SCCS merged
      33c439ce
    • unknown's avatar
      Bug #13975: "same string" + 0 has 2 different results · 573d9e47
      unknown authored
        The 'decimals' member of Item_func was being improperly initialized,
        which resulted in improper results when handling large numeric values.
      
      
      mysql-test/r/func_str.result:
        Add test results
      mysql-test/t/func_str.test:
        Add new regression test
      sql/item_strfunc.h:
        Remove unnecessary reset of decimals in Item_func_conv::fix_length_and_dec().
      573d9e47
    • unknown's avatar
      Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 74183117
      unknown authored
      into moonbone.local:/work/19077-bug-5.0-mysql
      
      
      74183117
    • unknown's avatar
      BUG#13987 Cluster: Loss of data nodes can cause high CPU usage from ndb_mgmd · 3441f235
      unknown authored
      A further reduction in CPU usage by ndb_mgmd with failed data nodes.
      
      
      ndb/src/common/util/socket_io.cpp:
        Use a nonblocking socket to peek at the buffer to know how much to read for socket_readln.
        
        This saves us a lot of syscalls. By a lot, I've observed about halving the CPU
        usage of ndb_mgmd with 1 failed node on a 6 node cluster.
      3441f235
    • unknown's avatar
      Merge rurik.mysql.com:/home/igor/mysql-5.0 · ed5ac749
      unknown authored
      into  rurik.mysql.com:/home/igor/dev/mysql-5.0-2
      
      
      ed5ac749
    • unknown's avatar
      Fixed bug #19816. · 087be9ba
      unknown authored
      This bug was introduced when the patch resolving the
      performance problem 17164 was applied. As a result
      of that modification the not_null_tables attributes
      were calculated incorrectly for constant OR conditions.
      This triggered invalid conversion of outer joins into
      inner joins.
      
      
      mysql-test/r/join_outer.result:
        Added a test case for bug #19816.
      mysql-test/t/join_outer.test:
        Added a test case for bug #19816.
      087be9ba
  9. 17 May, 2006 9 commits
    • unknown's avatar
      Fixed bug#19077: A nested materialized derived table is used before being populated. · 1c6beaee
      unknown authored
      The convert_constant_item() function converts constant items to ints on
      prepare phase to optimize execution speed. In this case it tries to evaluate
      subselect which contains a derived table and is contained in a derived table. 
      All derived tables are filled only after all derived tables are prepared.
      So evaluation of subselect with derived table at the prepare phase will
      return a wrong result.
      
      A new flag with_subselect is added to the Item class. It indicates that
      expression which this item represents is a subselect or contains a subselect.
      It is set to 0 by default. It is set to 1 in the Item_subselect constructor
      for subselects.
      For Item_func and Item_cond derived classes it is set after fixing any argument
      in Item_func::fix_fields() and Item_cond::fix_fields accordingly.
      The convert_constant_item() function now doesn't convert a constant item
      if the with_subselect flag set in it. 
      
      
      mysql-test/t/view.test:
        Added test case for bug#19077: A nested materialized derived table is used before being populated.
      mysql-test/t/subselect.test:
        Added test case for bug#19077: A nested materialized derived table is used before being populated.
      mysql-test/r/view.result:
        Added test case for bug#19077: A nested materialized derived table is used before being populated.
      mysql-test/r/subselect.result:
        Added test case for bug#19077: A nested materialized derived table is used before being populated.
      sql/item_subselect.cc:
        Fixed bug#19077: A nested materialized derived table is used before being populated.
        The Item_subselect class constructor sets new with_subselect flag to 1.
      sql/item_func.cc:
        Fixed bug#19077: A nested materialized derived table is used before being populated.
        
        The Item_func::fix_fields() sets new with_subselect flag from with_subselect flags of its arguments.
      sql/item_cmpfunc.cc:
        Fixed bug#19077: A nested materialized derived table is used before being populated.
        The convert_constant_item() function now doesn't convert a constant item
        with the with_subselect flag set.
        The Item_cond::fix_fields() sets new with_subselect flag from with_subselect flags of its arguments.
      sql/item.cc:
        Fixed bug#19077: A nested materialized derived table is used before being populated.
        Set new with_subselect flag to default value - 0 in the Item constructor.
      sql/item.h:
        Fixed bug#19077: A nested materialized derived table is used before being populated.
        A new flag with_subselect is added to the Item class. It indicates that
        expression which this item represents is a subselect or contains a subselect.
        It is set to 0 by default.
      1c6beaee
    • unknown's avatar
      Merge mysql.com:/Users/kent/mysql/bk/mysql-4.1-new · ce288ebc
      unknown authored
      into mysql.com:/Users/kent/mysql/bk/mysql-5.0-new
      
      
      BitKeeper/deleted/.del-disabled.def:
        Auto merged
      ce288ebc
    • unknown's avatar
    • unknown's avatar
      Include "config.h" (if it exists) in all yaSSL files via their "runtime.hpp". · 8d4cbe39
      unknown authored
      Fixes bug#19040 "yaSSL does not compile on AIX".
      
      
      extra/yassl/taocrypt/include/runtime.hpp:
        Include "config.h" (if it exists) in all yaSSL files. This is needed to ensure the same 
        configure settings are used for yaSSL as for the other modules linked together.
        Example: the settings for "large file" on AIX.
        Fixes bug#19040 "yaSSL does not compile on AIX".
      8d4cbe39
    • unknown's avatar
      Merge mysql.com:/home/hf/work/mysql-4.1.clean · abc6e665
      unknown authored
      into mysql.com:/home/hf/work/mysql-5.0.mrg
      
      
      mysql-test/t/init_connect.test:
        Auto merged
      mysql-test/t/wait_timeout.test:
        Auto merged
      abc6e665
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-5.0 · 5fb23aa3
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug18818/my50-bug18818
      
      
      5fb23aa3
    • unknown's avatar
      Merge bk-internal:/home/bk/mysql-4.1 · 0138267b
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/bug18818/my41-bug18818
      
      
      0138267b
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-4.1 · 76408cc8
      unknown authored
      into  production.mysql.com:/usersnfs/tulin/mysql-4.1
      
      
      76408cc8
    • unknown's avatar
      Fixed bug #19573. · f1efd088
      unknown authored
      The select statement that specified a view could be
      slightly changed when the view was saved in a frm file.
      In particular references to an alias name in the HAVING
      clause could be substituted for the expression named by
      this alias.
      This could result in an error message for a query of
      the form SELECT * FROM <view>. Yet no such message
      appeared when executing the query specifying the view.
      
      
      mysql-test/r/having.result:
        Adjusted results after fixing bug #19573.
      mysql-test/r/view.result:
        Added a test case for bug #19573.
      mysql-test/t/view.test:
        Added a test case for bug #19573.
      f1efd088
  10. 16 May, 2006 6 commits