An error occurred fetching the project authors.
  1. 08 Oct, 2003 1 commit
    • unknown's avatar
      Final push for WL#1098: · a7a7a8ca
      unknown authored
      "Add a column "Timestamp_of_last_master_event_executed" in SHOW SLAVE STATUS".
      Finally this is adding
      - Slave_IO_State (a copy of the State column of SHOW PROCESSLIST for the I/O thread,
      so that the users, most of the time, has enough info with only SHOW SLAVE STATUS).
      - Seconds_behind_master. When the slave connects to the master it does SELECT UNIX_TIMESTAMP()
      on the master, computes the absolute difference between the master's and the slave's clock.
      It records the timestamp of the last event executed by the SQL thread, and does a
      small computation to find the number of seconds by which the slave is late.
      
      
      mysql-test/r/rpl000015.result:
        result update
      mysql-test/r/rpl_empty_master_crash.result:
        result update
      mysql-test/r/rpl_error_ignored_table.result:
        result update
      mysql-test/r/rpl_flush_log_loop.result:
        result update
      mysql-test/r/rpl_loaddata.result:
        result update
      mysql-test/r/rpl_log.result:
        result update
      mysql-test/r/rpl_log_pos.result:
        result update
      mysql-test/r/rpl_max_relay_size.result:
        result update
      mysql-test/r/rpl_redirect.result:
        result update
      mysql-test/r/rpl_replicate_do.result:
        result update
      mysql-test/r/rpl_reset_slave.result:
        result update
      mysql-test/r/rpl_rotate_logs.result:
        result update
      mysql-test/r/rpl_trunc_binlog.result:
        result update
      mysql-test/r/rpl_until.result:
        result update
      mysql-test/t/rpl000015.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_empty_master_crash.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_error_ignored_table.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_flush_log_loop.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_loaddata.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_log.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_log_pos.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_max_relay_size.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_openssl.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_redirect.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_replicate_do.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_reset_slave.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_rotate_logs.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_trunc_binlog.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      mysql-test/t/rpl_until.test:
        update to be independant of the new column Seconds_behind_master in SHOW SLAVE STATUS
      sql/log_event.cc:
        when the SQL thread executes an event, we record its timestamp
      sql/slave.cc:
        in check_master_version() we know read the master's clock, to know the clock difference
        with the slave.
        In show_master_info() we send the state of the I/O thread, and compute the number of
        seconds by which the slave is late.
      sql/slave.h:
        timestamp of the last master's event executed by the SQL thread,
        and difference between the clocks of the master and slave.
      sql/sql_repl.cc:
        clear the Seconds_behind_master column of SHOW SLAVE STATUS when RESET SLAVE or CHANGE MASTER.
      a7a7a8ca
  2. 02 Oct, 2003 1 commit
  3. 01 Oct, 2003 1 commit
  4. 13 Sep, 2003 1 commit
    • unknown's avatar
      Implemented support for START SLAVE UNTIL (WL#868) · 2f8f0a7e
      unknown authored
      include/mysqld_error.h:
        Added error codes for warnings and error messages for START SLAVE UNTIL
      mysql-test/r/rpl000015.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_empty_master_crash.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_flush_log_loop.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_log.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_log_pos.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_redirect.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_replicate_do.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      mysql-test/r/rpl_rotate_logs.result:
        Fixed test because 3 new columns to SHOW SLAVE STATUS output were added
      sql/lex.h:
        Added UNTIL symbol
      sql/log.cc:
        Invalidating until_log_name comparison result if group_relay_log_name is changed
      sql/log_event.cc:
        Invalidating until_log_name comparison result if group_master_log_name is changed
      sql/repl_failsafe.cc:
        Cancel until condition if LOAD MASTER DATA is executed
      sql/share/czech/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/danish/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/dutch/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/english/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/estonian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/french/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/german/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/greek/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/hungarian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/italian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/japanese/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/korean/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/norwegian-ny/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/norwegian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/polish/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/portuguese/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/romanian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/russian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/serbian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/slovak/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/spanish/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/swedish/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/share/ukrainian/errmsg.txt:
        Added error and warning message for START SLAVE UNTIL
      sql/slave.cc:
        Fixed wrong locking order in init_relay_log_pos()
        Added until condition fields to SHOW SLAVE STATUS
        Added checking if UNTIL condition is reached 
        (added proper method, added its invocation, reorganized locking 
        in exec_relay_log_event() and next_event())
      sql/slave.h:
        Members in RELAY_LOG_INFO for storing UNTIL condition. Also 
        methods for for invalidation of cached UNTIL condition comparison
        results
      sql/sql_repl.cc:
        Now honoring UNTIL clause then starting slave thread. Proper 
        errors and warnings.
      sql/sql_yacc.yy:
        Added support for UNTIL clause in START SLAVE. This involved 
        extraction of some of master_defs to separate master_file_def
        non-terminal.
      2f8f0a7e
  5. 11 Sep, 2003 1 commit
    • unknown's avatar
      * Fix for BUG#1248: "LOAD DATA FROM MASTER drops the slave's db unexpectedly". · 69b8b3ff
      unknown authored
      Now LOAD DATA FROM MASTER does not drop the database, instead it only tries to
      create it, and drops/creates table-by-table.
      * replicate_wild_ignore_table='db1.%' is now considered as "ignore the 'db1'
      database as a whole", as it already works for CREATE DATABASE and DROP DATABASE.
      
      
      mysql-test/r/rpl000009.result:
        result update
      mysql-test/t/rpl000009.test:
        test that LOAD DATA FROM MASTER does not drop databases,
        but rather table by table, thus preserving non-replicated tables.
        Test that LOAD DATA FROM MASTER reports the error when a table could not
        be dropped (system's "permission denied" for example).
        Test that LOAD TABLE FROM MASTER reports the error when the table already exists.
      sql/repl_failsafe.cc:
        * replicate_wild_ignore_table='db1.%' is now considered as "ignore the 'db1'
        database as a whole", as it already works for CREATE DATABASE and DROP DATABASE.
        * If a db matches replicate_*_db rules, we don't drop/recreate it because this
        could drop some tables in this db which could be slave-specific. Instead,
        we do a CREATE DATABASE IF EXISTS, and we will drop each table which has
        an equivalent on the master, table-by-table.
      sql/slave.cc:
        New argument to drop the table in create_table_from_dump() 
        (LOAD TABLE/DATA FROM MASTER are the only places where this function is used).
        This is needed because LOAD DATA FROM MASTER does not drop the database anymore.
        The behaviour when the table exists is unchanged: LOAD DATA silently replaces
        the table, LOAD TABLE gives error.
      sql/slave.h:
        new argument to drop the table in fetch_master_table
      sql/sql_parse.cc:
        do not drop the table in LOAD TABLE FROM MASTER (this behaviour is already
        true; but changes in LOAD DATA FROM MASTER made the argument needed).
      69b8b3ff
  6. 01 Sep, 2003 1 commit
    • unknown's avatar
      Implemented replication over SSL · 8a548ffd
      unknown authored
       Added proper options to CHANGE MASTER TO, new fields to SHOW SLAVE STATUS,
       Honoring this parameters during connection to master.
       Introduced new format of master.info file
      
      
      include/mysqld_error.h:
        Added error code for "slave without SSL ignored SSL params warning"
      mysql-test/Makefile.am:
        Copy files required for rpl_openssl test during the make process
      mysql-test/r/rpl000015.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_empty_master_crash.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_flush_log_loop.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_log.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_log_pos.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_redirect.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_replicate_do.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      mysql-test/r/rpl_rotate_logs.result:
        Added fields to SHOW SLAVE STATUS for replication over SSL
      sql/lex.h:
        Added MASTER_SSL lexems for CHANGE MASTER
      sql/mysqld.cc:
        Added --master-ssl-ca parameter. Fixed description of other master-ssl parameters
      sql/repl_failsafe.cc:
        Added SSL support to connect_to_master()
      sql/share/czech/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/danish/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/dutch/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/english/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/estonian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/french/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/german/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/greek/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/hungarian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/italian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/japanese/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/korean/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/norwegian-ny/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/norwegian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/polish/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/portuguese/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/romanian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/russian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/serbian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/slovak/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/spanish/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/swedish/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/share/ukrainian/errmsg.txt:
        Added "slave without SSL ignored SSL params" warning
      sql/slave.cc:
        Introduced new format of master.info file
        Added support of SSL params in master.info and SHOW SLAVE STATUS
        Added support of SSL connections
      sql/slave.h:
        Added SSL parameters to MASTER_INFO
      sql/sql_lex.h:
        Added SSL parameters for CHANGE MASTER TO
      sql/sql_repl.cc:
        Added SSL parameters for CHANGE MASTER TO
      sql/sql_yacc.yy:
        Added SSL parameters for CHANGE MASTER TO
      8a548ffd
  7. 25 Aug, 2003 1 commit
    • unknown's avatar
      comments about mutexes in replication. · 3fdc38d4
      unknown authored
      Don't start the SQL slave thread with SQL_BIG_SELECTS;
      it's better to inhibate max_join_size instead.
      
      
      sql/slave.cc:
        OPTION_BIG_SELECTS does more than ignoring max_join_size (talks to the optimiser),
        just ignore max_join_size.
      sql/slave.h:
        comments
      3fdc38d4
  8. 07 Aug, 2003 1 commit
    • unknown's avatar
      Review of changesets since last pull. · fa1613be
      unknown authored
      (Mostly code cleanups)
      
      
      include/my_sys.h:
        Removed not used define
      myisam/mi_check.c:
        Indentation change
      mysql-test/t/rpl_insert_id.test:
        Add test if server supports innodb
      mysys/mf_format.c:
        Remove QUOTE handling from fn_format()
        (fn_format() should not have anything to do with quoting things)
      sql/log_event.cc:
        Removed some unnecessary casts (by changing functions to use const char *)
        Cleaned up some error messages to make them shorter and (hopefully) more readable.
        Fixed wrong format strings
        Restored 'thd->options' on error.
      sql/mini_client.cc:
        Changed order of include files to remove compilation warning
      sql/mysqld.cc:
        Add proper quoting of service arguments (don't use fn_format)
      sql/slave.cc:
        Simple optimization and cleanup.
        Changed rewrite_db() and print_slave_db_safe() to use const char* to avoid casting of arguments when calling functions.
        Cleanup of some error messages.
      sql/slave.h:
        Changed protypes to use const char *
      sql/sql_acl.cc:
        Simple optimization
      vio/viosslfactories.c:
        Changed order of include files to remove compilation warning
      fa1613be
  9. 04 Aug, 2003 1 commit
    • unknown's avatar
      2 bugfixes: · d8df84aa
      unknown authored
      - Bug #985: "Between RESET SLAVE and START SLAVE, SHOW SLAVE STATUS is wrong."
      Now RESET SLAVE puts correct info in mi->host etc. A new test rpl_reset_slave
      for that.
      - Bug #986: "CHANGE MASTER & START SLAVE do not reset error columns in SHOW
      SLAVE STATUS". Now these reset the errors.
      
      
      mysql-test/r/rpl_loaddata.result:
        result update.
      mysql-test/t/rpl_loaddata.test:
        Test that RESET SLAVE, START SLAVE and CHANGE MASTER all reset 
        Last_slave_error and Last_slave_errno (columns of SHOW SLAVE STATUS).
        We do it in this test because that's one of tests which have 
        an intentional query error on the slave.
      sql/slave.cc:
        As we need TWICE the code to copy command-line options (--master-host etc)
        to mi (we already had it in init_master_info, but we also need it in RESET
        SLAVE to fix bug#985), I make a function of this code.
        And a function to reset Last_slave_error and Last_slave_errno (we need
        it in CHANGE MASTER, RESET SLAVE, and at the start of the SQL thread).
      sql/slave.h:
        declarations for new functions.
      sql/sql_repl.cc:
        copy --master-host etc to mi in RESET SLAVE, so that SHOW SLAVE STATUS
        shows correct information.
      d8df84aa
  10. 24 Jul, 2003 1 commit
    • unknown's avatar
      WL#1036 (print the db in slave error messages). · ab34adf6
      unknown authored
      I extended the task to cleaning error messages, making them look nicer,
      and making the output of SHOW SLAVE STATUS (column Last_error) be as complete
      as what's printed on the .err file;
      previously we would have, for a failure of a replicated LOAD DATA INFILE:
      - in the .err, 2 lines:
      "duplicate entry 2708 for key 1"
      "failed loading SQL_LOAD-5-2-2.info"
      - and in SHOW SLAVE STATUS, only:
      "failed loading SQL_LOAD-5-2-2.info".
      Now SHOW SLAVE STATUS will contain the concatenation of the 2 messages.
      
      
      sql/log_event.cc:
        Print the default database when replication stops because of an error. Previously, we had:
        "error "Duplicate entry 87987 for key 1", query 'insert into t values(87987)'", ie the db
        was not mentioned, making it hard for cases where the same table name is used in
        several databases.
        Lengthened some error messages (for failing replication of LOAD DATA: mention the table
        and the db).
        Changes so that SHOW SLAVE STATUS reports as complete errors as the .err file.
      sql/slave.cc:
        Removed a useless declaration (the rewrite_db() function is already declared in slave.h).
        Added missing ')' in error messages.
        Tried to make error messages look nicer (previously we had
        "do START SLAVE;, error_code=1062"
        now we'll have
        "do START SLAVE; . Error_code=1062".
        This form has been discussed, I agree it's no panacea, but it's still more readable
        like this. To be improved in the future :)
      sql/slave.h:
        declarations.
      ab34adf6
  11. 23 Jul, 2003 1 commit
    • unknown's avatar
      On Feb 4th, 2003, Monty said he would push my patch to print replicate-do-table · dae34fb6
      unknown authored
      and other replicate-*-table options in SHOW SLAVE STATUS.
      Seems like it had not been done, so I push it now:
      there's 4 new columns to SHOW SLAVE STATUS.
      
      
      mysql-test/r/rpl000015.result:
        Result update (more columns)
      mysql-test/r/rpl_empty_master_crash.result:
        Result update (more columns)
      mysql-test/r/rpl_flush_log_loop.result:
        Result update (more columns)
      mysql-test/r/rpl_log.result:
        Result update (more columns)
      mysql-test/r/rpl_log_pos.result:
        Result update (more columns)
      mysql-test/r/rpl_redirect.result:
        Result update (more columns)
      mysql-test/r/rpl_replicate_do.result:
        Result update (more columns)
      mysql-test/r/rpl_rotate_logs.result:
        Result update (more columns)
      mysql-test/t/rpl_replicate_do.test:
        Result update (more columns)
      sql/slave.cc:
        Print replicate_*_table options in SHOW SLAVE STATUS
      sql/slave.h:
        two functions to make a string of replicate_*_table lists.
      dae34fb6
  12. 06 Jul, 2003 1 commit
    • unknown's avatar
      WL#912 (more user control on relay logs): · 27601fc5
      unknown authored
      FLUSH LOGS now rotates relay logs,
      and a new variable max_relay_log_size.
      Plus a very small bit of code cleaning.
      
      
      libmysqld/lib_sql.cc:
        open_log has no default arguments anymore.
      mysql-test/r/rpl_flush_log_loop.result:
        result update now that FLUSH LOGS rotates relay logs.
      mysql-test/r/rpl_log.result:
        result update now that FLUSH LOGS rotates relay logs.
      mysql-test/r/rpl_rotate_logs.result:
        result update now that max_binlog_size is 4096.
      mysql-test/t/rpl_rotate_logs-master.opt:
        now max_binlog_size must be a multiple of 4096 (see change in mysqld.cc)
      sql/log.cc:
        Got rid of default arguments of various MYSQL_LOG methods (the default arguments
        made code reading uneasy).
        Set max_size in ::init().
        New function set_max_size() to set max_size of a MYSQL_LOG on-the-fly.
        More DBUG info.
      sql/mysql_priv.h:
        no defaults in open_log().
        New variables max_relay_log_size.
      sql/mysqld.cc:
        New variable and option max_relay_log_size.
        max_binlog_size and max_relay_log_size are multiples of IO_SIZE.
        No more default arguments for log functions.
      sql/set_var.cc:
        New variable max_relay_log_size.
        If it is 0, then max_binlog_size will apply to relay logs.
        When one of these variables is changed, fix_max_%log_size is called
        to update max_size of the binary and/or relay logs.
      sql/slave.cc:
        New function rotate_relay_log().
      sql/slave.h:
        New function rotate_relay_log().
      sql/sql_class.h:
        New member max_size of MYSQL_LOG (for automatic rotation).
        New method set_max_size() for setting on-the-fly.
      sql/sql_parse.cc:
        Flush the relay log in FLUSH LOGS.
      27601fc5
  13. 04 Jul, 2003 1 commit
    • unknown's avatar
      Status query on killed mysql connection results in segmentation fault (Bug #738) · 2d5d754c
      unknown authored
      Added MAX_PASSWORD_LENGTH. This increased master-slave passwords to 32 bytes (Bug #766)
      Fixed server crash on purge master logs or show master logs when binlog is off. (Bug #733)
      
      
      client/mysql.cc:
        status query on killed mysql connection results in segmentation fault (Bug #738)
      configure.in:
        Portability fix for Unixware
      include/my_global.h:
        Removed wrong patch from previous changeset
      sql/mysql_priv.h:
        Added MAX_PASSWORD_LENGTH. This increased master-slave passwords to 32 bytes
      sql/slave.h:
        Optimized structure
      sql/sql_repl.cc:
        Memory overrun safety fixes (not critical)
        Fixed server crash on purge master logs or show master logs when binlog is off. (Bug #733)
      sql/sql_repl.h:
        Fixed to use right define
      strings/strmake.c:
        Fixed comment
      2d5d754c
  14. 02 Jul, 2003 1 commit
  15. 01 Jul, 2003 1 commit
    • unknown's avatar
      First version of new authentification procedure: now authentification is... · dbb088b0
      unknown authored
      First version of new authentification procedure: now authentification is one-stage (instead of two-stage in 4.1)
      
      For now following tasks have been done:
      - PASSWORD() function was rewritten. PASSWORD() now returns SHA1
        hash_stage2; for new passwords user.password contains '*'hash_stage2; sql_yacc.yy also fixed; 
      
      - password.c: new functions were implemented, old rolled back to 4.0 state
      
      - server code was rewritten to use new authorization algorithm (check_user(), change
        user, and other stuff in sql/sql_parse.cc)
      
      - client code was rewritten to use new authorization algorithm
        (mysql_real_connect, myslq_authenticate in sql-common/client.c)
      
      - now server barks on 45-byte-length 4.1.0 passwords and refuses 4.1.0-style
        authentification. Users with 4.1.0 passwords are blocked (sql/sql_acl.cc)
      
      - mysqladmin.c was fixed to work correctly with new passwords
      
      Tests for 4.0-4.1.1, 4.1.1-4.1.1 (with or without db/password) logons was performed;
      mysqladmin also was tested. Additional check are nevertheless necessary.
      
      
      BitKeeper/etc/ignore:
        Added start_mysqld.sh mysys/main.cc to the ignore list
      client/mysqladmin.c:
        fixed with new password api
      include/mysql.h:
        So as scramble_323 accepts only null-terminated message, two scramble buffs are necessary.
        gotta be fixed
      include/mysql_com.h:
        new constants and password.c api changes
      libmysql/libmysql.c:
        mysql_change_user rewritten to work with new password api
      scripts/mysql_create_system_tables.sh:
        fixed 'Password' column length to 41
      scripts/mysql_fix_privilege_tables.sql:
        fixed 'Password' column length to 41
      sql-common/client.c:
        mysql_real_connect rewritten to support new handshake procedure
      sql/item_strfunc.cc:
        Item_func_password and Item_func_old_password rewritten with new password api
      sql/item_strfunc.h:
        bit commented, numbers replaced with #defined constants
      sql/mysql_priv.h:
        removed unnecessary declaration as now all constants defined is in mysql_com.h
      sql/mysqld.cc:
        scramble initialization moved to sql_parce.cc:check_connection
      sql/password.c:
        All 4.1 functions were rolled back to 4.0 with attempt to save all possible 4.0-4.1 changes.
        Names for 4.0 functions were suffixed with '_323'
        Functions for new handshake were added.
      sql/slave.cc:
        Fixed to new constant; Bug #766 remains to be fixed
      sql/slave.h:
        fixed to new constant; Buf #766 remains to be fixed
      sql/sql_acl.cc:
        rewritten to support new passwords (41 byte-long) and password api
      sql/sql_acl.h:
        ditto
      sql/sql_class.cc:
        initialization for new members added
      sql/sql_class.h:
        same thing as in struct mysql - scramble is used for new family of functions, scramble_323 - for old
      sql/sql_parse.cc:
        check_connections was renamed to check_connection as this name reflects better what this function does
        authorization part of check_connection was rewritten
        check_user was rewritten with new password and acl api
        new function 'authenticate', which optionally re-request scramble from client was added
        fixed some typos
        COM_CHANGE_USER piece of dipsatch_command() was rewritten
      sql/sql_repl.h:
        HASH_PASSWORD_LENGTH replaced with SCRAMBLED_PASSWORD_CHAR_LENGTH
        bug #766 remains
      sql/sql_yacc.yy:
        Two-argument form of PASSWORD() was removed
        PASSWORD() function was fixed with new password api.
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      dbb088b0
  16. 12 Jun, 2003 1 commit
    • unknown's avatar
      See each file's changeset for details. · a921cb31
      unknown authored
      - Comments for future devs.
      - Start_log_event::exec_event() : when we hit it, do a rollback.
      - We don't need LOG_EVENT_FORCED_ROTATE_F.
      - Stop_log_event::exec_event() : when we hit it, we needn't clean anything.
      - Removed LOG_EVENT_TIME_F and LOG_EVENT_FORCED_ROTATE_F.
      - We don't need Stop events in the relay log.
      - Now filtering of server id is done in the I/O thread first.
      
      
      sql/log.cc:
        We don't need LOG_EVENT_FORCED_ROTATE_F
      sql/log_event.cc:
        - Comments for future devs.
        - Start_log_event::exec_event() : when we hit it, do a rollback. If the SQL
        thread was inside a transaction (for example, the master died while writing
        to the binlog, so did not commit (because we write to the binlog before committing),
        so will rollback), it's sensible to rollback. If we're not in a transaction,
        rollback will not hurt (it will do nothing).
        - We don't need LOG_EVENT_FORCED_ROTATE_F.
        - Stop_log_event::exec_event() : when we hit it, we needn't clean anything, because
        each threads has already written some cleaning statements (DROP TEMPORARY TABLE,
        DO RELEASE_LOCK); we still clean in Start_log_event::exec_event() (if 4.x).
      sql/log_event.h:
        - Comments for future devs.
        - Removed LOG_EVENT_TIME_F and LOG_EVENT_FORCED_ROTATE_F.
      sql/slave.cc:
        - We don't need Stop events in the relay log (see changeset's description about
        log_event.cc). So we can make event queuing (writing to the relay log) simpler.
        - Something that was marked TODO: now filtering of server id (if the server id
        of this event is the same as mine ignore it) is done in the I/O thread if
        the master is 4.x (it still also done in the SQL thread whatever the version of
        the master is, for safe upgrades). This saves disk space.
      sql/slave.h:
        We don't need master_info.ignore_stop_event anymore, as we don't write Stop_event
        to the relay log anymore.
      a921cb31
  17. 06 Jun, 2003 1 commit
    • unknown's avatar
      Fix for bug 254 : · a0120344
      unknown authored
      we now make a distinction between if the master is < 3.23.57, 3.23 && >=57, and 4.x
      (before the 2 3.23 were one). This is because in 3.23.57 we have a way to distinguish between
      a Start_log_event written at server startup and one written at FLUSH LOGS, so we
      have a way to know if the slave must drop old temp tables or not.
      Change: mi->old_format was bool, now it's enum (to handle 3 cases). However, functions
      which had 'bool old_format' as an argument have their prototypes unchanged, because
      the old old_format == 0 now corresponds to the enum value BINLOG_FORMAT_CURRENT which
      is equal to 0, so boolean tests are left untouched. The only case were we use mi->old_format
      as an enum instead of casting it implicitly to a bool, is in Start_log_event::exec_event,
      where we want to distinguish between the 3 possible enum values.
      
      
      sql/log_event.cc:
        Fix for bug 254 :
        we now make a distinction between if the master is < 3.23.57, 3.23 && >=57, and 4.x
        (before the 2 3.23 were one), to know if the slave must drop old temp tables or not.
      sql/slave.cc:
        Fix for bug 254 : mi->old_format is now enum.
        An unrelated comment.
      sql/slave.h:
        fix for bug 254 : mi->old_format is now enum.
      a0120344
  18. 04 Jun, 2003 1 commit
  19. 24 Apr, 2003 1 commit
    • unknown's avatar
      Replication: new code to not modify in-memory log positions until the COMMIT · 9f4f19d9
      unknown authored
      is executed, even if the transaction spans on >=2 relay logs (bug #53).
      New variable relay_log_purge =0|1
      New test to verify bug #53
      
      
      sql/log.cc:
        Now we purge a relay log only when we are sure we won't need it,
        i.e. we have executed the final query (if autocommit=1) or the COMMIT.
      sql/log_event.cc:
        Better tracking of the relay log's name and position
        lastly executed, even if we are in a transaction which spans on
        2 or more relay logs.
      sql/mysql_priv.h:
        new option relay_log_purge (the user can now decide himself
        if he wants his relay logs to be automatically purged or not,
        we don't make unsafe guesses like before)
      sql/mysqld.cc:
        new option --innodb (replaces --skip-innodb).
        Useful for the test suite : we have skip-innodb in mysql-test-run,
        but we can ('-opt.info' file) choose to start the server with
        InnoDB for this test only.
        New option --bdb
      sql/repl_failsafe.cc:
        Better tracking of the relay log's name and position
        lastly executed, even if we are in a transaction which spans on
        2 or more relay logs.
      sql/set_var.cc:
        new variable relay_log_purge
      sql/slave.cc:
        Better tracking of the relay log's name and position
        lastly executed, even if we are in a transaction which spans on
        2 or more relay logs.
        Now we purge a relay log only when we are sure we won't need it,
        i.e. we have executed the final query (if autocommit=1) or the COMMIT
      sql/slave.h:
        Better tracking of the relay log's name and position
        lastly executed, even if we are in a transaction which spans on
        2 or more relay logs.
      sql/sql_class.h:
        prototypes change
      sql/sql_parse.cc:
        removed thd argument (was not used in the function's body)
      sql/sql_repl.cc:
        Better tracking of the relay log's name and position
        lastly executed, even if we are in a transaction which spans on
        2 or more relay logs.
        Turn relay_log_purge silently off when someone does CHANGE
        MASTER TO RELAY_LOG_*
      9f4f19d9
  20. 17 Mar, 2003 1 commit
    • unknown's avatar
      New variable rli->ignore_log_space_limit to resolve · 40c0b2c6
      unknown authored
      a deadlock between I/O and SQL threads in replication
      when relay_log_space is too small. This fixes bug #79.
      
      
      sql/log.cc:
        New variable rli->ignore_log_space_limit to resolve
        a deadlock between I/O and SQL threads in replication
        when relay_log_space is too small.
      sql/slave.cc:
        New variable rli->ignore_log_space_limit to resolve
        a deadlock between I/O and SQL threads in replication
        when relay_log_space is too small.
      sql/slave.h:
        New variable rli->ignore_log_space_limit to resolve
        a deadlock between I/O and SQL threads in replication
        when relay_log_space is too small.
      sql/sql_repl.cc:
        New variable rli->ignore_log_space_limit to resolve
        a deadlock between I/O and SQL threads in replication
        when relay_log_space is too small.
      40c0b2c6
  21. 01 Mar, 2003 2 commits
    • unknown's avatar
      Replication: simplification of init_relay_log_pos: always initialize, · 14ea63cd
      unknown authored
      remove variable rli->log_pos_current.
      
      
      sql/slave.cc:
        Simplification of init_relay_log_pos : always initialize,
        remove variable rli->log_pos_current.
      sql/slave.h:
        Simplification of init_relay_log_pos : always initialize,
        remove variable rli->log_pos_current.
      14ea63cd
    • unknown's avatar
      Replication: give the slave I/O thread a higher priority than the slave SQL thread · 0d19df2f
      unknown authored
      so that it has fetched the most from the master's binlog before the master
      accidently dies. SCRUM task #756.
      
      
      sql/slave.cc:
        Replication: give the slave I/O thread a higher priority than the slave SQL thread
        so that it has fetched the most from the master's binlog before the master
        accidently dies.
      sql/slave.h:
        Replication: give the slave I/O thread a higher priority than the slave SQL thread
        so that it has fetched the most from the master's binlog before the master
        accidently dies.
      0d19df2f
  22. 28 Jan, 2003 1 commit
    • unknown's avatar
      Fixes for Netware · 84f81dc5
      unknown authored
      Call pthread_mutex_destroy() on not used mutex.
      Changed comments in .h and .c files from // -> /* */
      Added detection of mutex on which one didn't call pthread_mutex_destroy()
      Fixed bug in create_tmp_field() which causes a memory overrun in queries that uses "ORDER BY constant_expression"
      Added optimisation for ORDER BY NULL
      
      
      BitKeeper/deleted/.del-ChangeLog~dfc92e15bee6fc75:
        Delete: sql/ChangeLog
      BUILD/compile-pentium-valgrind-max:
        Don't use valgrind with safemalloc as this can hide some bugs
      Makefile.am:
        Added platform dirs
      bdb/os/os_handle.c:
        Portability fix
      client/mysql.cc:
        Fixes for Netware.
        Fixed duplicate output when using 'tee'
        Simple optimisations
      client/mysqldump.c:
        Portability fix
      client/mysqltest.c:
        Portability fix
      configure.in:
        Fixes for Netware
      extra/resolveip.c:
        Fixes for Netware
      include/Makefile.am:
        Fixes for Netware
      include/config-win.h:
        Portability fix
      include/my_global.h:
        Fixes for Netware
      include/my_net.h:
        Fixes for Netware
      include/my_pthread.h:
        Fixes for Netware
        Added detection of mutexes that was not destroyed
      include/my_sys.h:
        Fixes for Netware
        Added 'extern' before external functions
      include/mysql.h:
        Fixes for Netware
      innobase/configure.in:
        Fixes for Netware
      innobase/include/os0thread.h:
        Fixes for Netware
      innobase/os/os0sync.c:
        Fixes for Netware
      innobase/os/os0thread.c:
        Fixes for Netware
      innobase/srv/srv0srv.c:
        Fixes for Netware
      innobase/srv/srv0start.c:
        Fixes for Netware
      innobase/sync/sync0sync.c:
        Fixes for Netware
      isam/test3.c:
        Disable test on Netware
      libmysql/Makefile.shared:
        Added my_sleep
      libmysql/get_password.c:
        Fixes for Netware
      libmysql/libmysql.c:
        Fixes for Netware
        Made mysql_once_init() global
      libmysql/manager.c:
        Fixes for Netware
      myisam/mi_test3.c:
        Disable test for netware
      mysql-test/mysql-test-run.sh:
        Give warning if output file contains errors
      mysql-test/r/count_distinct.result:
        More tests
      mysql-test/r/group_by.result:
        Test of ORDER BY NULL
      mysql-test/t/backup.test:
        Fixes for Netware
      mysql-test/t/count_distinct.test:
        More tests
      mysql-test/t/func_crypt.test:
        Fixes for Netware
      mysql-test/t/grant_cache.test:
        Fixes for Netware
      mysql-test/t/group_by.test:
        Tests of ORDER BY NULL
      mysql-test/t/rpl000015.test:
        Fixes for Netware
      mysql-test/t/rpl000017.test:
        Fixes for Netware
      mysql-test/t/rpl_rotate_logs.test:
        Fixes for Netware
      mysys/Makefile.am:
        Added my_sleep.c and my_netware.c
      mysys/charset.c:
        Fixes for Netware
      mysys/default.c:
        Fixes for Netware
      mysys/mf_tempfile.c:
        Fixes for Netware
      mysys/my_clock.c:
        Fixes for Netware
      mysys/my_copy.c:
        Fixes for Netware
      mysys/my_getwd.c:
        Changed function comment from // -> /* */
      mysys/my_init.c:
        Fixes for Netware
      mysys/my_lock.c:
        Fixes for Netware
      mysys/my_messnc.c:
        Fixes for Netware
      mysys/my_os2cond.c:
        Removed comment
      mysys/my_os2dirsrch.c:
        Changed function comment from // -> /* */
        Fixed indentation
      mysys/my_os2dirsrch.h:
        Changed function comment from // -> /* */
        Fixed indentation
      mysys/my_os2file64.c:
        Changed function comment from // -> /* */
        Fixed indentation
      mysys/my_os2mutex.c:
        Changed function comment from // -> /* */
        Fixed indentation
      mysys/my_os2thread.c:
        Changed function comment from // -> /* */
        Fixed indentation
      mysys/my_os2tls.c:
        Changed function comment from // -> /* */
        Fixed indentation
      mysys/my_pthread.c:
        Fixes for Netware
      mysys/my_redel.c:
        Fixes for Netware
      mysys/my_tempnam.c:
        Fixes for Netware
      mysys/my_thr_init.c:
        Remove created mutexes when program ends.
      mysys/mysys_priv.h:
        Cleanup
      mysys/safemalloc.c:
        Prefix error messages with "Error:"
      mysys/thr_alarm.c:
        Destroy internal mutex on end_thr_alarm.
      mysys/thr_mutex.c:
        Added detection of mutex on which one didn't call pthread_mutex_destroy()
      scripts/make_binary_distribution.sh:
        Fixes for Netware
      sql/des_key_file.cc:
        Free mutex at end
      sql/ha_innodb.cc:
        Free mutex at end
      sql/ha_myisam.cc:
        Changed warnings from REPAIR Note:
        (For mysql-test-run)
      sql/hostname.cc:
        Fixes for Netware
      sql/item.h:
        Fixed bug in create_tmp_field() which causes a memory overrun
      sql/item_func.cc:
        Free used mutexes
      sql/item_sum.cc:
        Fixed bug in create_tmp_field() which causes a memory overrun
      sql/log.cc:
        Free used mutexes
      sql/my_lock.c:
        Fixes for Netware
      sql/mysql_priv.h:
        Fixes for Netware
      sql/mysqld.cc:
        Fixes for Netware
        Added Have_crypt
        Properly free mutexes from MYSQL_LOG by calling cleanup
        Free mutex before exit
      sql/repl_failsafe.cc:
        Fixes for Netware
      sql/set_var.cc:
        Added have_crypt
      sql/share/english/errmsg.txt:
        Added version socket and port to stderr log
      sql/slave.cc:
        Remove global MASTER_INFO variable and use instead an allocated variable.
        This allows us to correctly free used mutex.
      sql/slave.h:
        Move constructors and destuctors to slave.cc
        (To make it easier to clear all needed variables)
      sql/sql_base.cc:
        Safety fix
      sql/sql_class.h:
        Portability fixes.
        Added 'cleanup' to log handling to be able to free mutexes.
      sql/sql_insert.cc:
        Fixes for Netware
      mysys/my_sleep.c:
        E
      sql/sql_parse.cc:
        Fixes for Netware
      sql/sql_select.cc:
        Added optimisation for ORDER BY NULL
      sql/sql_select.h:
        Fixed bug in create_tmp_field() which causes a memory overrun
      sql/sql_table.cc:
        Fixed bug in create_tmp_field() which causes a memory overrun
      sql/sql_udf.cc:
        Free mutex on end
      vio/test-ssl.c:
        Simple code cleanup
      vio/test-sslclient.c:
        Simple code cleanup
      vio/test-sslserver.c:
        Simple code cleanup
      vio/viotest-ssl.c:
        Simple code cleanup
      84f81dc5
  23. 25 Jan, 2003 1 commit
    • unknown's avatar
      Added timeout for wait_for_master_pos · db47e4ca
      unknown authored
      Fixed comparision of log-binary name to handle comparison when file name extension wraps from .999 to .1000
      Don't replicate CREATE/DROP DATABASE if wild_xxx_table=database.% is used.
      
      
      mysql-test/r/rpl000009.result:
        Fixed replication test after fixing replication of DROP/CREATE DATABASE
      mysql-test/t/rpl000009.test:
        Fixed replication test after fixing replication of DROP/CREATE DATABASE
      sql/item_create.cc:
        Added timeout for wait_for_master_pos
      sql/item_create.h:
        Added timeout for wait_for_master_pos
      sql/item_func.cc:
        Added timeout for wait_for_master_pos
      sql/item_func.h:
        Added timeout for wait_for_master_pos
      sql/lex.h:
        Added timeout for wait_for_master_pos
      sql/slave.h:
        Added timeout for wait_for_master_pos
        Don't replicate CREATE/DROP DATABASE if wild_xxx_table=database.% is used.
      sql/sql_parse.cc:
        Don't replicate CREATE/DROP DATABASE if wild_xxx_table=database.% is used.
      sql/sql_repl.cc:
        Fixed comparision of log-binary name to handle comparison when file name extension wraps from .999 to .1000
      db47e4ca
  24. 15 Jan, 2003 1 commit
    • unknown's avatar
      SCRUM · 09b79b65
      unknown authored
      embedded library trimming
      
      
      include/my_global.h:
        HAVE_REPLICATION & HAVE_EXTERNAL_CLIENT macro definitions
      libmysqld/lib_sql.cc:
        Protocol:: methods implementation for embedded case
      sql/field.cc:
        geometry type methods implementations
      sql/ha_berkeley.cc:
        set_nfields deletion
      sql/ha_innodb.cc:
        macro changed
      sql/ha_myisam.cc:
        set_nfields deletion
      sql/ha_myisam.h:
        code #ifdef-ed
      sql/item.cc:
        bugfix
      sql/item_func.cc:
        macro changed
      sql/item_strfunc.cc:
        superfluous code deleted
      sql/log.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/log_event.cc:
        #ifdef constructions changed
      sql/log_event.h:
        #ifdef-s changed
      sql/mf_iocache.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/mini_client.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/mysql_priv.h:
        code removation
      sql/mysqld.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/opt_range.cc:
        code trimming
      sql/protocol.cc:
        net_store_data becomes a member of Protocol
      sql/protocol.h:
        changes to make Protocol working in embedded library
      sql/repl_failsafe.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/repl_failsafe.h:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/set_var.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/slave.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/slave.h:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/sql_parse.cc:
        code trimming
      sql/sql_prepare.cc:
        comment added
      sql/sql_repl.cc:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/sql_repl.h:
        HAVE_REPLICATION instead of EMBEDDED_LIBRARY
      sql/sql_show.cc:
        mysql_list_processes to work in embedded library
      sql/sql_table.cc:
        set_nfields deletion
      09b79b65
  25. 16 Dec, 2002 1 commit
    • unknown's avatar
      Big purge about embedded library (scrum) · 632717fd
      unknown authored
      client/mysql.cc:
        #ifdef EMBEDDED_LIBRARY added
      client/mysqltest.c:
        #ifdef EMBEDDED_LIBRARY added
      include/mysql.h:
        MYSQL structure changed for embedded case
      include/mysql_com.h:
        NET structure changed for embedded case
      include/violite.h:
        no need to special vio types
      libmysqld/embedded_priv.h:
        superfluous functions removed
      libmysqld/lib_sql.cc:
        several modifications
      libmysqld/lib_vio.c:
        file should be removed
      libmysqld/libmysqld.c:
        several modifications
      sql/ha_berkeley.cc:
        modification for embedded case
      sql/ha_innodb.cc:
        modifications for embedded case
      sql/ha_myisam.cc:
        modifications for embedded case
      sql/item_func.cc:
        modifications for embedded case
      sql/log.cc:
        #ifdef-ed parts of file which don't work in embedded case
      sql/log_event.cc:
        #ifdef-ed parts of file which don't work in embedded case
      sql/log_event.h:
        #ifdef-ed parts of file which don't work in embedded case
      sql/mf_iocache.cc:
        file doesn't work in embedded case
      sql/mini_client.cc:
        file should be removed from embedded library
      sql/mysqld.cc:
        several modifications
      sql/net_pkg.cc:
        #ifdef-ed functions which can't work in embedded case
      sql/net_serv.cc:
        file doesn't work in embedded case
      sql/repl_failsafe.cc:
        no replication in embedded case
      sql/repl_failsafe.h:
        no replication in embedded case
      sql/set_var.cc:
        #ifdef-ed variables which have no sense in embedded library
      sql/set_var.h:
        #ifdef-ed variables which have no sense in embedded library
      sql/slave.cc:
        no replication in embedded library
      sql/slave.h:
        no replication in embedded library
      sql/sql_acl.cc:
        modifications for embedded case
      sql/sql_cache.cc:
        modifications for embedded case
      sql/sql_class.cc:
        modifications for embedded case
      sql/sql_class.h:
        THD structure modified for embedded case
      sql/sql_db.cc:
        modification for embedded case
      sql/sql_error.cc:
        modification for embedded case
      sql/sql_help.cc:
        modification for embedded case
      sql/sql_load.cc:
        #ifdef-ed code which doesn't work in embedded case
      sql/sql_parse.cc:
        #ifdef-ed code which doesn't work in embedded case
      sql/sql_prepare.cc:
        #ifdef-ed code which doesn't work in embedded case
      sql/sql_repl.cc:
        no replication in embedded library
      sql/sql_repl.h:
        no replication in embedded library
      sql/sql_select.cc:
        query cache don't work now in embedded library
      sql/sql_show.cc:
        modifications for embedded case
      632717fd
  26. 11 Dec, 2002 1 commit
    • unknown's avatar
      Ensure that BEGIN / COMMIT is handled properly if slave dies · 934f5cc4
      unknown authored
      Added syntax support for
      CREATE TABLE foo (a char CHARACTER SET latin1) CHARSET=latin1;
      
      
      Docs/internals.texi:
        Update binary protocol description
      innobase/include/db0err.h:
        Merge from 3.23
      mysql-test/r/insert.result:
        Updated test result from 3.23
      sql/log.cc:
        Fixed bug in replication and log rotation
      sql/log_event.cc:
        Ensure that BEGIN / COMMIT is handled properly if slave dies
      sql/slave.cc:
        Fixed bug in replication and log rotation
      sql/slave.h:
        Ensure that BEGIN / COMMIT is handled properly if slave dies
      sql/sql_analyse.cc:
        Moved usage of res before res is destroyed (by bzero(&s...))
      sql/sql_yacc.yy:
        Added syntax support for
        
        CREATE TABLE foo (a char CHARACTER SET latin1) CHARSET=latin1;
        
        To be able to read MySQL 4.1 dump files.
      934f5cc4
  27. 07 Nov, 2002 1 commit
    • unknown's avatar
      Portability fixes for Fortre C++ 5.0 (on Sun) in 32 and 64 bit modes. · c88b9102
      unknown authored
      client/mysqlbinlog.cc:
        Portability fix
      configure.in:
        Added use of ASFLAGS (For Solaris with Forte 5.0)
      include/my_global.h:
        Portability fix
      include/myisam.h:
        Portability fix
      include/queues.h:
        Portability fix
      innobase/include/ut0ut.h:
        Portability fix
      innobase/log/log0log.c:
        Portability fix
      innobase/rem/rem0cmp.c:
        Portability fix
      innobase/trx/trx0sys.c:
        Portability fix
      isam/pack_isam.c:
        Portability fix
      myisam/ft_boolean_search.c:
        Portability fix
      myisam/mi_dynrec.c:
        Code change to go around bug in Forte 5.0
      myisam/sort.c:
        Portability fix
      mysys/my_aes.c:
        Portability fix
      scripts/Makefile.am:
        Support for ASFLAGS
      scripts/mysqlbug.sh:
        Support for ASFLAGS
      sql/field.cc:
        Portability fix
      sql/filesort.cc:
        Portability fix
      sql/gen_lex_hash.cc:
        Portability fix
      sql/ha_innodb.cc:
        Portability fix
        Changed SHOW INNODB STATUS to return error instead of writing message to log file.
      sql/ha_isammrg.cc:
        Portability fix
      sql/ha_myisam.cc:
        Portability fix
      sql/ha_myisammrg.cc:
        Portability fix
      sql/hash_filo.h:
        Portability fix
      sql/hostname.cc:
        Portability fix
      sql/item_cmpfunc.h:
        Indentation change
      sql/item_func.cc:
        Portability fix
      sql/item_func.h:
        Portability fix
      sql/log.cc:
        Portability fix
      sql/log_event.cc:
        Portability fix
      sql/mysql_priv.h:
        Portability fix
      sql/mysqld.cc:
        Portability fix
        Fixed bug with rpl_recovery_rank command line option on 64 bit systems
      sql/opt_range.cc:
        Portability fix
      sql/repl_failsafe.cc:
        Portability fix
      sql/slave.cc:
        Portability fix
      sql/slave.h:
        Portability fix
      sql/sql_acl.cc:
        Portability fix
      sql/sql_base.cc:
        Portability fix
      sql/sql_cache.cc:
        Portability fix
      sql/sql_cache.h:
        Portability fix
      sql/sql_class.cc:
        Portability fix
      sql/sql_delete.cc:
        Portability fix
      sql/sql_insert.cc:
        Portability fix
      sql/sql_manager.cc:
        Portability fix
      sql/sql_parse.cc:
        Portability fix
      BUILD/compile-solaris-sparc-forte:
        C
      sql/sql_udf.cc:
        Portability fix
      sql/sql_update.cc:
        Portability fix
      strings/Makefile.am:
        Portability fix
      strings/bmove_upp-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/str_test.c:
        Cleanup
      strings/strappend-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/strend-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/strmake-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/strmov-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/strnmov-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/strstr-sparc.s:
        Fix so that this works on 32 and 64 bit sparcs
      strings/strxmov-sparc.s:
        Fixes to make this more portable, but it's still not usable on 64 bit systems :(
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      c88b9102
  28. 29 Oct, 2002 1 commit
  29. 11 Sep, 2002 1 commit
    • unknown's avatar
      Portability fixes. · 8f232cb7
      unknown authored
      Improve mysql-test to be more robust.
      Fix that GRANT doesn't delete SSL options
      Change innobase_flush_log_at_trx_commit to uint.
      Don't rotate logs if we read a rotate log entry from the master.
      
      
      Docs/manual.texi:
        Changelog
      client/mysqlbinlog.cc:
        Handle empty binlogfiles gracefully
      client/mysqltest.c:
        Do a sleep after 'sync_with_master'
        Cleaned up sleep() handling.
        Free all memory on exit
      configure.in:
        Fix for Mac OS 10.2
      include/my_sys.h:
        Added my_strdup_with_length()
      innobase/btr/btr0cur.c:
        Fixed wrong printf()
      libmysql/libmysql.c:
        Added DBUG_PRINT statements.
        Assume that mysql_...send() functions has correct query length.
      mysql-test/mysql-test-run.sh:
        Properly remove log files before starting new tests.
      mysql-test/r/grant.result:
        Update for new test results
      mysql-test/r/innodb.result:
        Update for new test results
      mysql-test/r/myisam.result:
        Update for new test results
      mysql-test/r/rpl_log.result:
        Update for new test results
      mysql-test/r/rpl_rotate_logs.result:
        Update for new test results
      mysql-test/r/variables.result:
        Update for new test results
      mysql-test/t/grant.test:
        Test that GRANT doesn't delete SSL options
      mysql-test/t/myisam.test:
        Test long key usage
      mysql-test/t/rpl_log.test:
        Disable 'show new master'
      mysql-test/t/rpl_mystery22.test:
        Longer sleep for more safety.
      mysql-test/t/rpl_rotate_logs.test:
        More comments
      mysys/my_malloc.c:
        Added my_strdup_with_length()
      mysys/safemalloc.c:
        Added my_strdup_with_length()
      mysys/thr_alarm.c:
        Fix of alarms for windows.
      sql/ha_innodb.cc:
        Change innobase_flush_log_at_trx_commit to uint
      mysql-test/r/rpl_redirect.result:
        Updated test results
      mysql-test/t/rpl_redirect.test:
        Added more tests to improve code coverage.
      sql/ha_innodb.h:
        Change innobase_flush_log_at_trx_commit to uint
      sql/item_func.cc:
        Return GLOBAL and SESSION as part of column names
      sql/log.cc:
        Only write STOP events when server goes down.
      sql/log_event.cc:
        Don't rotate logs if we read a rotate log entry from the master.
      sql/log_event.h:
        Change ident_len to uint (more efficient)
      sql/mysqld.cc:
        Change innobase_flush_log_at_trx_commit to uint
      sql/net_serv.cc:
        More debug output
      sql/repl_failsafe.cc:
        More DEBUG
        Search until we find next position in binary log (and not only =)
      sql/slave.cc:
        More DBUG & comments
        Don't rotate the binary log on master flush logs
      sql/slave.h:
        indentation change
      sql/sql_acl.cc:
        Test that GRANT doesn't delete SSL options
      sql/sql_parse.cc:
        Disable show_new_master.
      sql/sql_repl.cc:
        Chamger show_binlog_events() to use my_error()
      sql/sql_table.cc:
        Fixed check for too long keys in MyISAM
      sql/sql_udf.cc:
        Fix udf handling
      8f232cb7
  30. 24 Aug, 2002 1 commit
    • unknown's avatar
      Give better error from reconnect() · 02f8c163
      unknown authored
      Fixed hang in start_slave_threads() when thread dies quickly.
      
      
      Docs/manual.texi:
        Changelog
      client/mysqltest.c:
        Indentation cleanup
        More DBUG info
      libmysql/libmysql.c:
        More DBUG info
        Give better error from reconnect()
      mysql-test/r/rpl_rotate_logs.result:
        Update results
      mysql-test/t/rpl_log_pos.test:
        Fix for fast machines
      mysql-test/t/rpl_rotate_logs.test:
        Updated test to be more portable
      scripts/mysql_zap.sh:
        Update for MacOSX
      sql/mini_client.cc:
        Better error messages from reconnect.
        Indentation cleanups
      sql/slave.cc:
        Fixed hang in start_slave_threads() when thread dies quickly.
      sql/slave.h:
        Fixed hang in start_slave_threads() when thread dies quickly.
      02f8c163
  31. 23 Aug, 2002 1 commit
    • unknown's avatar
      Changed relay_log_space to ulonglong · 41abdd90
      unknown authored
      Removed compiler warnings.
      
      
      Build-tools/Do-compile:
        Simple cleanup
      include/mysql.h:
        Use #include "" instead of include <>
      mysql-test/t/innodb_handler.test:
        Documented test
        Change to be runnable from mysql
      sql/mini_client.cc:
        Removed dead code
      sql/mysqld.cc:
        Changed relay_log_space to ulonglong
      sql/slave.cc:
        Changed relay_log_space to ulonglong
        Removed dead code
      sql/slave.h:
        Changed relay_log_space to ulonglong
      sql/sql_acl.cc:
        Removed not used variables
      sql/sql_base.cc:
        Removed not used variables
      sql/sql_cache.cc:
        Removed not used variables
      sql/sql_select.cc:
        Removed not used variables
      vio/vio.c:
        Re-order include files to remove compiler warnings
      41abdd90
  32. 22 Aug, 2002 1 commit
    • unknown's avatar
      Fixed bug in wait_for_update() that I had introduced. · e4d5597d
      unknown authored
      Changed option variables to my_bool (to avoid bugs in my_getopt())
      Added new thread specific mutex LOCK_delete to be able to free LOCK_thread_count early.
      Changed usage of LOCK_thread_count -> LOCK_status for statistics variables
      
      
      libmysqld/lib_sql.cc:
        Removed not needed LOCK
      mysql-test/mysql-test-run.sh:
        Log name of running test
      mysql-test/r/rpl_sporadic_master.result:
        Cleaned up test
      mysql-test/t/rpl_sporadic_master.test:
        cleaned up test
      sql/log.cc:
        Cleanup.
        Fixed bug in wait_for_update() that I had introduced.
      sql/mini_client.cc:
        Indentation changes.
      sql/mysql_priv.h:
        Changed option variables to my_bool.
      sql/mysqld.cc:
        Changed option variables to my_bool.
        Removed not used LOCK_server_id
        Minor code cleanups.
      sql/repl_failsafe.cc:
        Minor code cleanups
      sql/slave.cc:
        Minor code cleanups.
        Fixed usage of wait_for_update().
      sql/slave.h:
        Changed option variables to my_bool.
      sql/sql_class.cc:
        Added new thread specific mutex LOCK_delete to be able to free LOCK_thread_count early
      sql/sql_class.h:
        Added new thread specific mutex LOCK_delete to be able to free LOCK_thread_count early
      sql/sql_insert.cc:
        Do broadcast after unlock()
      sql/sql_parse.cc:
        Removed not needed LOCK
        Changed usage of LOCK_thread_count -> LOCK_status for statistics variables
        Changed killing of threads to not lock LOCK_thread_count for long.
      sql/sql_repl.cc:
        Changed options variables to my_bool
        Fixed usage of wait_for_update()
        Fixed loop to kill slaves to not lock LOCK_thread_count for long.
        Code optimization.
      sql/sql_repl.h:
        bool -> my_bool
        Fixed KICK_SLAVE to use LOCK_delete
      e4d5597d
  33. 21 Aug, 2002 1 commit
    • unknown's avatar
      Use our version of RWLOCKS on UNIXWARE 7 · 87f9ad37
      unknown authored
      More DBUG info for replication
      Better error messages from replication
      Fixed bug in replication code when connecting to 'localhost' (time was not released properly)
      Block ALARM signal on Linux for signal handler thread (Fixes problem with running mysqld with --debug)
      Removed warning when setting an AUTO_INCREMENT field to NULL
      
      
      Build-tools/Do-compile:
        Always run test with --warnings during build
      Docs/manual.texi:
        Changelog
      configure.in:
        Use our version of RWLOCKS on UNIXWARE 7
      include/my_pthread.h:
        Use our version of RWLOCKS on UNIXWARE 7
      include/mysql_version.h.in:
        Fixed warning when compiling embedded server
      include/mysqld_error.h:
        New error messages
      libmysql/libmysql.c:
        Give connect error message on reconnect if it fails.
        Fixed possible buffer overflow in expand_error()
        Added error messages for some error conditions.
      mysql-test/mysql-test-run.sh:
        Portability fixes:
        - Search after 'time' in path.
        - Search after mysqld in libexec
        - Remove end / when doing rm -r (fix for BSD)
        Clean up skip_test handling.
      mysql-test/r/rpl_empty_master_crash.result:
        New results
      mysql-test/t/rpl_empty_master_crash.test:
        Extended test
      mysys/mf_iocache.c:
        Remember file position on failed read.
      mysys/mf_iocache2.c:
        Fixed bug in filelength() call.
      mysys/thr_alarm.c:
        Made alarm handling more threadsafe when use with DBUG.
      mysys/thr_mutex.c:
        More debug info
      sql/log_event.cc:
        More DBUG_PRINT statements.
      sql/mini_client.cc:
        Better error reporting on failures.
        Return connect error on reconnect failure (instead of SERVER_GONE_ERROR)
        Fixed critical bug in alarm handling on connect (could leave an alarm event on indefinitely)
      sql/mysql_priv.h:
        Fixed arguments to mysql_binlog_send()
      sql/mysqld.cc:
        Block ALARM signal on Linux for signal handler thread (Fixes problem with running mysqld with --debug)
      sql/net_pkg.cc:
        Removed dead code
      sql/net_serv.cc:
        Ensure that last_errno is set in net_real_write()
      sql/repl_failsafe.cc:
        Code cleanup.
        Better error handling.
      sql/share/czech/errmsg.txt:
        New error messages.
      sql/share/danish/errmsg.txt:
        New error messages.
      sql/share/dutch/errmsg.txt:
        New error messages.
      sql/share/english/errmsg.txt:
        New error messages.
      sql/share/estonian/errmsg.txt:
        New error messages.
      sql/share/french/errmsg.txt:
        New error messages.
      sql/share/german/errmsg.txt:
        New error messages.
      sql/share/greek/errmsg.txt:
        New error messages.
      sql/share/hungarian/errmsg.txt:
        New error messages.
      sql/share/italian/errmsg.txt:
        New error messages.
      sql/share/japanese/errmsg.txt:
        New error messages.
      sql/share/korean/errmsg.txt:
        New error messages.
      sql/share/norwegian-ny/errmsg.txt:
        New error messages.
      sql/share/norwegian/errmsg.txt:
        New error messages.
      sql/share/polish/errmsg.txt:
        New error messages.
      sql/share/portuguese/errmsg.txt:
        New error messages.
      mysql-test/r/rpl_log_pos.result:
        Updated results
      mysql-test/t/rpl_log_pos.test:
        Added 'sleep' commands to make tests repeatable.
      sql/share/romanian/errmsg.txt:
        New error messages.
      sql/share/russian/errmsg.txt:
        New error messages.
      sql/share/slovak/errmsg.txt:
        New error messages.
      sql/share/spanish/errmsg.txt:
        New error messages.
      sql/share/swedish/errmsg.txt:
        New error messages.
      sql/share/ukrainian/errmsg.txt:
        New error messages.
      sql/slave.cc:
        Code optimization and cleanup.
        More DBUG statements.
        Better cleanup if start slave fails.
        Better error messages from 'fetch_master_table'
        Thread safer handling of 'wait_for_pos'
      sql/slave.h:
        Better handling of wait_for_pos
      sql/sql_load.cc:
        Removed warning when setting an AUTO_INCREMENT field to NULL
      sql/sql_parse.cc:
        Fixed calling of function that has changed.
      sql/sql_repl.cc:
        More DBUG statements
        Give a proper error number from mysql_binlog_send() so that we know when we have to abort slaves.
      87f9ad37
  34. 08 Aug, 2002 1 commit
    • unknown's avatar
      Lots of code fixes to the replication code (especially the binary logging and... · f01f4991
      unknown authored
      Lots of code fixes to the replication code (especially the binary logging and index log file handling)
      Fixed bugs in my last changeset that made MySQL hard to compile.
      Added mutex around some data that could cause table cache corruptions when using OPTIMIZE TABLE / REPAIR TABLE or automatic repair of MyISAM tables.
      Added mutex around some data in the slave start/stop code that could cause THD linked list corruptions
      Extended my_chsize() to allow one to specify a filler character.
      Extend vio_blocking to return the old state (This made some usage of this function much simpler)
      Added testing for some functions that they caller have got the required mutexes before calling the function.
      Use setrlimit() to ensure that we can write core file if one specifies --core-file.
      Added --slave-compressed-protocol
      Made 2 the minimum length for ft_min_word_len
      Added variables foreign_key_checks & unique_checks.
      Less logging from replication code (if not started with --log-warnings)
      Changed that SHOW INNODB STATUS requre the SUPER privilege
      More DBUG statements and a lot of new code comments
      
      
      BitKeeper/deleted/.del-rpl_compat.result~c950bc346b12c61a:
        Delete: mysql-test/r/rpl_compat.result
      BitKeeper/deleted/.del-rpl_compat.test~5f6ba955e02aa95f:
        Delete: mysql-test/t/rpl_compat.test
      Docs/manual.texi:
        Updated manual with fixes in this changeset
      client/mysqltest.c:
        Indentation cleanup
        Better error messages for some error conditions.
      include/my_pthread.h:
        Added 'safe_mutex_assert_owner()' to check that the thread really owns the mutex.
      include/my_sys.h:
        Extended my_chsize() to allow one to specify a filler character.
        (For MySQL index logs)
      include/raid.h:
        New my_chsize()
      include/violite.h:
        Extend vio_blocking to return the old state
      innobase/include/dyn0dyn.h:
        Merge with 3.23 (AIX DYN_ARRAY_DATA_SIZE)
      innobase/include/dyn0dyn.ic:
        Merge with 3.23
      isam/create.c:
        Fix for new my_chsize()
      isam/isamchk.c:
        Fix for new my_chsize()
      isam/pack_isam.c:
        Fix for new my_chsize()
      libmysql/manager.c:
        Fix for new vio_blocking()
      libmysqld/lib_sql.cc:
        Fix for new open_log()
      myisam/mi_cache.c:
        Fix typo from previous checking
      myisam/mi_check.c:
        Fix for new my_chsize()
      myisam/mi_create.c:
        Fix for new my_chsize()
      myisam/mi_delete_all.c:
        Fix for new my_chsize()
      myisam/myisampack.c:
        Fix for new my_chsize()
      mysql-test/include/master-slave.inc:
        Better initialization for replication tests
      mysql-test/mysql-test-run.sh:
        Added option --log-warnings
      mysql-test/r/insert.result:
        More tests if INSERT ...(DEFAULT)
      mysql-test/r/rpl000001.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000002.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000003.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000004.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000005.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000006.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000007.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000008.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000009.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000010.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000011.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000012.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000013.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl000014.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_alter.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_empty_master_crash.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_get_lock.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_log.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_magic.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_mystery22.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_skip_error.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/r/rpl_sporadic_master.result:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/insert.test:
        More tests if INSERT ...(DEFAULT)
      mysql-test/t/rpl000001.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000002.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000003.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000004.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000005.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000006.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000007.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000009.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000011.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000013.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl000014.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_alter.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_empty_master_crash.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_get_lock.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_magic.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_mystery22.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_skip_error.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysql-test/t/rpl_sporadic_master.test:
        Clean up tests for new master-slave.inc
        Remove 'use database'
      mysys/mf_iocache.c:
        More debug info
        Force seek after reinit_io_cache()
      mysys/mf_iocache2.c:
        Added my_b_filelength()
      mysys/my_chsize.c:
        Extended my_chsize() to allow one to specify a filler character.
        (For MySQL index logs)
      mysys/raid.cc:
        Extended my_chsize() to allow one to specify a filler character.
        (For MySQL index logs)
      sql/field.h:
        Fix for INSERT ... (DEFAULT)
      sql/ha_berkeley.h:
        Fix for dynamic variables
      sql/ha_innodb.cc:
        Change sprintf() to my_sprintf() to make code portable.
        Fix after sync with 3.23
        (We still need to fix the storage of the replication position in innodb)
      sql/ha_innodb.h:
        Fix for dynamic variables
      sql/handler.cc:
        Remove writting of COMMIT to the binary log.
        (Now done in MYSQL_LOG::write())
      sql/item_func.cc:
        Query_log_event() now always takes query length.
      sql/item_func.h:
        Indentation cleanup
      sql/item_strfunc.h:
        Indentation cleanup
      sql/item_timefunc.h:
        Indentation cleanup
      sql/lock.cc:
        Check that we own critical mutexes.
      sql/log.cc:
        Big code cleanup / rewrite / optimize.
        - The index log file has its own IO_CACHE object.
        - Many functions totally rewritten to make them smaller and faster.
        - New handling of index log files
        - Lots of new comments
      sql/log_event.cc:
        Code cleanup
        New comments
      sql/log_event.h:
        Query_log_event() now always takes query length.
      sql/mini_client.cc:
        Better error messages on reconnect.
        Fixed wrong variable usage from last commit.
      sql/mysql_priv.h:
        New arguments to open_log()
      sql/mysqld.cc:
        Use setrlimit() to ensure that we can write core file if one specifies --core-file
        Added index file name as parameter to openlog().
        Added --slave-compressed-protocol
        Made 2 the minimum length for ft_min_word_len
      sql/net_serv.cc:
        Use new vio_blocking()
        (The vio_blocking() change was done to make this code more readable)
      sql/repl_failsafe.cc:
        Minor code cleanup
      sql/set_var.cc:
        Added variables slave_compressed_protocol, foreign_key_checks & unique_checks.
      sql/set_var.h:
        Generalization
      sql/slave.cc:
        Code cleanup & rewrite.
        Dont call SELECT VERSION() on check_master_version()
        New init_slave() code.
        Ensure that all threads create a THD early.
        Add locks around manipulation of critical structures
        Don't retry a command more than master_retry_count times.
        Write less warnings to the log file (if not started with --log-warnings)
        Faster flush_relay_log_info()
      sql/slave.h:
        More comments
        Added new arguments to some functions.
      sql/sql_acl.cc:
        More DBUG info
        New parameter to Query_log_event()
      sql/sql_base.cc:
        Added some mutex checking.
      sql/sql_cache.cc:
        Less not critical debug info
      sql/sql_class.h:
        Fix for new log handling.
      sql/sql_db.cc:
        Added mutex around remove_db_from_cache()
      sql/sql_delete.cc:
        Added missing parameters to changed functions
      sql/sql_insert.cc:
        Added missing parameters to changed functions
      sql/sql_parse.cc:
        Do an 'end_active_trans()' before 'load_master_data'
        Changed that SHOW INNODB STATUS requre the SUPER privilege
        Added new function parameters to new functions
      sql/sql_rename.cc:
        Added missing parameters to changed functions
      sql/sql_repl.cc:
        Code cleanups / new comments
        Fix for new find_first_log() calling standard.
        More DBUG statements.
        Show binlogs updated to use new IO_CACHE:d index log file.
      sql/sql_repl.h:
        New function arguments
      sql/sql_select.cc:
        Indentation changes
      sql/sql_table.cc:
        Added missing parameters to changed functions
        Added checking of mutex
        Added mutex around critical regions.
      sql/sql_test.cc:
        Don't use THR_ALARM if the configuration doesn't support it.
      sql/sql_update.cc:
        Added missing parameters to changed functions
      sql/table.cc:
        Added missing parameters to changed functions
      vio/vio.c:
        Extend vio_blocking to return the old state
      vio/viosocket.c:
        Extend vio_blocking to return the old state
      vio/viossl.c:
        Extend vio_blocking to return the old state
      f01f4991
  35. 17 Jul, 2002 1 commit
    • unknown's avatar
      Some · 18e0dd1f
      unknown authored
      C++ comments cleanup
      
      
      sql/stacktrace.c:
        C++ comments cleanup
      sql/structs.h:
        C++ comments cleanup
      sql/ha_myisam.h:
        C++ comments cleanup
      include/config-os2.h:
        C++ comments cleanup
      include/sslopt-case.h:
        C++ comments cleanup
      mysys/mf_tempfile.c:
        C++ comments cleanup
      sql/mysql_priv.h:
        C++ comments cleanup
      sql/slave.h:
        C++ comments cleanup
      sql/time.cc:
        C++ comments cleanup
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      18e0dd1f
  36. 22 Jun, 2002 1 commit
    • unknown's avatar
      slave.h, slave.cc: · 23dbcb0f
      unknown authored
        Do not flush the position to master.info file if we have a transaction open
      
      
      sql/slave.cc:
        Do not flush the position to master.info file if we have a transaction open
      sql/slave.h:
        Do not flush the position to master.info file if we have a transaction open
      23dbcb0f
  37. 11 Jun, 2002 1 commit
    • unknown's avatar
      Big code cleanup/review before 4.0.2 release. · 70aa7424
      unknown authored
      (All commit emails since 4.0.1 checked)
      This had to be done now, before the 4.1 tree changes to much, to make it easy to propagate bug fixes to the 4.1 tree.
      
      
      BUILD/SETUP.sh:
        Added -DPEDANTIC_SAFEMALLOC as standard debug option
      Docs/manual.texi:
        Changes for new version.
      client/mysql.cc:
        Fixed default value for rehash
        cleanup
      client/mysqladmin.c:
        Cleanup
      client/mysqlbinlog.cc:
        cleanup
      client/mysqldump.c:
        Cleanup
      client/mysqlmanager-pwgen.c:
        Cleanup
      client/mysqlmanagerc.c:
        Cleanup
      client/mysqltest.c:
        Cleanup
      dbug/dbug.c:
        Cleanup
      extra/resolve_stack_dump.c:
        Cleanup & Simple optimizations
      include/ft_global.h:
        Cleanup
      include/my_alloc.h:
        Cleanup
      include/my_global.h:
        Cleanup
      include/my_sys.h:
        Cleanup
      include/myisam.h:
        Cleanup
      libmysql/libmysql.c:
        Cleanup
      libmysql/manager.c:
        Cleanup
      myisam/ft_boolean_search.c:
        Cleanup
      myisam/ft_dump.c:
        Change strcpy -> strmov
      myisam/ft_eval.c:
        Cleanup
      myisam/ft_nlq_search.c:
        Cleanup
      myisam/ft_test1.c:
        strncpy -> strnmov
      myisam/ft_update.c:
        Cleanup
      myisam/mi_static.c:
        Cleanup
      myisam/mi_test2.c:
        Cleanup
      myisam/mi_write.c:
        Cleanup
      mysys/mf_fn_ext.c:
        Cleanup
      mysys/mf_iocache.c:
        Cleanup
      mysys/mf_iocache2.c:
        Cleanup
      mysys/my_getopt.c:
        Cleanup
      mysys/my_read.c:
        Cleanup
      mysys/my_thr_init.c:
        Cleanup
      mysys/queues.c:
        Cleanup
      mysys/safemalloc.c:
        Cleanup
      sql/field.cc:
        Indentation cleanups
      sql/ha_berkeley.cc:
        Indentation cleanups
      sql/ha_myisam.cc:
        Cleanup
      sql/item.h:
        Indentation cleanups
      sql/item_cmpfunc.cc:
        Indentation cleanups
      sql/item_create.cc:
        cleanup
      sql/item_func.cc:
        Cleanup
      sql/item_func.h:
        Indentation cleanups
      sql/item_strfunc.cc:
        Indentation cleanups
      sql/item_sum.cc:
        Indentation cleanups
      sql/item_timefunc.cc:
        Indentation cleanups
      sql/lock.cc:
        Indentation cleanups
      sql/log.cc:
        Cleanup
        strnmov -> strmake
      sql/log_event.cc:
        Cleanup + optimizations
        Fixed memory leak
        Added missing pthread_mutex_unlock()  (On error condition)
      sql/log_event.h:
        Indentation and comment cleanup
        Merged #ifdef's into common blocks for better readability
      sql/mini_client.cc:
        Indentation cleanup
      sql/mysql_priv.h:
        Cleanup
        Changed int function to bool
      sql/mysqld.cc:
        Indentation and comment cleanup
      sql/net_pkg.cc:
        Indentation cleanup
      sql/net_serv.cc:
        Changed int function -> bool
      sql/nt_servc.cc:
        Cleanup
      sql/opt_range.cc:
        Indentation cleanup
      sql/repl_failsafe.cc:
        Cleanup + simple optimization
        strnmov -> strmake
      sql/slave.cc:
        strnmov -> strmake
        Cleanups
      sql/slave.h:
        Cleanup
      sql/sql_acl.cc:
        Indentation and DBUG_PRINT cleanup
        Changed WITH MAX... to not use =
      sql/sql_base.cc:
        Indentation cleanup
      sql/sql_cache.cc:
        Indentation cleanup
      sql/sql_class.cc:
        Indentation cleanup
      sql/sql_class.h:
        Renamed some struct slots
      sql/sql_delete.cc:
        Indentation cleanup
      sql/sql_handler.cc:
        Indentation cleanup
      sql/sql_insert.cc:
        Use new slot names.
      sql/sql_lex.cc:
        Indentation cleanup
      sql/sql_lex.h:
        Indentation cleanup
      sql/sql_load.cc:
        Indentation cleanup
      sql/sql_parse.cc:
        Indentation cleanup
        Removed not used check from LOCK TABLES
      sql/sql_repl.cc:
        strnmov -> strmake
      sql/sql_repl.h:
        Removed test if file is included (We want to know if it's included twice to avoid this)
      sql/sql_select.cc:
        Indentation cleanup
      sql/sql_show.cc:
        Indentation cleanup
      sql/sql_string.cc:
        Indentation cleanup
      sql/sql_table.cc:
        Indentation cleanup
      sql/sql_union.cc:
        Use renamed struct slot
      sql/sql_update.cc:
        Indentation cleanup
      sql/sql_yacc.yy:
        Removed = after GRANT ... MAX_  to make the syntax uniform
      sql/table.cc:
        Indentation cleanup
      sql/table.h:
        Indentation cleanup
      sql/time.cc:
        Indentation cleanup
      sql/udf_example.cc:
        Indentation cleanup
      sql/unireg.cc:
        strnmov -> strmake
      tests/grant.pl:
        Added test for LOCK TABLES
      tools/mysqlmanager.c:
        Cleanup
        fopen() -> my_fopen()
      vio/viosocket.c:
        DBUG_PRINT cleanups
      vio/viosslfactories.c:
        Indentation cleanup
        Checking of results from malloc()
        Fixed possible memory leak
      BitKeeper/etc/ignore:
        Added scripts/mysql_secure_installation to the ignore list
      BitKeeper/etc/logging_ok:
        Logging to logging@openlogging.org accepted
      70aa7424
  38. 05 Jun, 2002 1 commit
    • unknown's avatar
      removed init_count from IO_CACHE. · 03728196
      unknown authored
      Added missing mutex_unlock to slave replication code.
      
      
      include/my_sys.h:
        removed init_count from IO_CACHE.
        General cleanup.
      innobase/srv/srv0srv.c:
        Initailize slots to avoid purify warnings.
        Removed some compiler warnings.
      mysql-test/mysql-test-run.sh:
        Automatic start of slave under gdb
      mysys/mf_iocache.c:
        removed init_count
      sql/field.cc:
        Cleanup
      sql/log.cc:
        Cleanup
        added open_count variable.
      sql/log_event.cc:
        cleanup
        use is_prefix instead of memcmp()
      sql/repl_failsafe.cc:
        cleanup
      sql/slave.cc:
        cleanup
        use MYSQL_LOG->open_count instead of IO_CACHE->init_count
        Added missing mutex_unlock()
      sql/slave.h:
        cleanup
      sql/sql_class.h:
        cleanup
        Added open_count to MYSQL_LOGL
      sql/sql_parse.cc:
        removed compiler warning
      sql/sql_repl.cc:
        added DBUG_xxx
      sql/unireg.h:
        Added BIN_LOG_HEADER_SIZE
      03728196
  39. 29 May, 2002 1 commit
    • unknown's avatar
      Fixed a bug. · b7529249
      unknown authored
      sql/slave.h:
        Fixed a bug in option handling.
      sql/sql_repl.h:
        Fixed a bug in option handling.
      b7529249