- 05 Sep, 2008 1 commit
-
-
Evgeny Potemkin authored
The check_table_access function initializes per-table grant info and performs access rights check. It wasn't called for SHOW STATUS statement thus left grants info uninitialized. In some cases this led to server crash. In other cases it allowed a user to check for presence/absence of arbitrary values in any tables. Now the check_table_access function is called prior to the statement processing.
-
- 03 Sep, 2008 7 commits
-
-
Mats Kindahl authored
Incremental fixes: updating a comment and fixing a result file.
-
Mats Kindahl authored
The assertion indicates that some data was left in the transaction cache when the server was shut down, which means that a previous statement did not commit or rollback correctly. What happened was that a bug in the rollback of a transactional table caused the transaction cache to be emptied, but not reset. The error can be triggered by having a failing UPDATE or INSERT, on a transactional table, causing an implicit rollback. Fixed by always flushing the pending event to reset the state properly.
-
Andrei Elkin authored
-
Andrei Elkin authored
The replication filtering rules were inappropiately applied when executing BINLOG pseudo-query. The rules are supposed to be active only at times when the slave's sql thread executes an event. Fixed with correcting a condition to call replication rules only if the slave sql thread executes the event.
-
Gleb Shchepa authored
-
Gleb Shchepa authored
-
Gleb Shchepa authored
INSERT .. SELECT .. ON DUPLICATE KEY UPDATE col=DEFAULT In order to get correct values from update fields that belongs to the SELECT part in the INSERT .. SELECT .. ON DUPLICATE KEY UPDATE statement, the server adds referenced fields to the select list. Part of the code that does this transformation is shared between implementations of the DEFAULT(col) function and the DEFAULT keyword (in the col=DEFAULT expression), and an implementation of the DEFAULT keyword is incomplete.
-
- 28 Aug, 2008 3 commits
-
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
-
- 27 Aug, 2008 11 commits
-
-
Gleb Shchepa authored
returns unexpected result If: 1. a table has a not nullable BIT column c1 with a length shorter than 8 bits and some additional not nullable columns c2 etc, and 2. the WHERE clause is like: (c1 = constant) AND c2 ..., the SELECT query returns unexpected result set. The server stores BIT columns in a tricky way to save disk space: if column's bit length is not divisible by 8, the server places reminder bits among the null bits at the start of a record. The rest bytes are stored in the record itself, and Field::ptr points to these rest bytes. However if a bit length of the whole column is less than 8, there are no remaining bytes, and there is nothing to store in the record at its regular place. In this case Field::ptr points to bytes actually occupied by the next column in a record. If both columns (BIT and the next column) are NOT NULL, the Field::eq function incorrectly deduces that this is the same column, so query transformation/equal item elimination code (see build_equal_items_for_cond) may mix these columns and damage conditions containing references to them.
-
Mats Kindahl authored
-
Georgi Kodinov authored
-
Georgi Kodinov authored
When switching to indexed ORDER BY we must be sure to reset the index read flag if we are switching from a covering index to non-covering.
-
Mats Kindahl authored
-
Mats Kindahl authored
-
Evgeny Potemkin authored
used causes server crash. When the loose index scan access method is used values of aggregated functions are precomputed by it. Aggregation of such functions shouldn't be performed in this case and functions should be treated as normal ones. The create_tmp_table function wasn't taking this into account and this led to a crash if a query has MIN/MAX aggregate functions and employs temporary table and loose index scan. Now the JOIN::exec and the create_tmp_table functions treat MIN/MAX aggregate functions as normal ones when the loose index scan is used.
-
Mats Kindahl authored
-
Mats Kindahl authored
-
Mats Kindahl authored
tables open When executing a DROP DATABASE statement in ROW mode and having temporary tables open at the same time, the existance of temporary tables prevent the server from switching back to row mode after temporarily switching to statement mode to handle the logging of the statement. Fixed the problem by removing the code to switch to statement mode and added code to temporarily disable the binary log while dropping the objects in the database.
-
Davi Arnaut authored
-
- 26 Aug, 2008 18 commits
-
-
Davi Arnaut authored
-
Davi Arnaut authored
-
Mattias Jonsson authored
-
Mattias Jonsson authored
post push fix Updated partition_symlink since different error behavior if embedded (or not partitioned)
-
Ramil Kalimullin authored
-
Ramil Kalimullin authored
Typo fixed. No test case as we actually don't use rtree_get_first() and rtree_get_next() at present.
-
Ramil Kalimullin authored
Problem: data consistency check (maximum record length) for a correct MyISAM table with CHECKSUM=1 and ROW_FORMAT=DYNAMIC option may fail due to wrong inner MyISAM parameter. In result we may have the table marked as 'corrupted'. Fix: properly set MyISAM maximum record length parameter.
-
He Zhenxing authored
-
Alexey Botchkov authored
-
Alexey Botchkov authored
-
He Zhenxing authored
-
He Zhenxing authored
-
Alexander Barkov authored
-
Alexey Botchkov authored
-
Alexey Botchkov authored
-
Alexey Botchkov authored
-
Alexey Botchkov authored
-
Alexander Barkov authored
-