1. 23 Sep, 2005 3 commits
    • unknown's avatar
      Some minor fixes revealed as warnings by · ab0d7e2a
      unknown authored
      Intel compiler.
      
      
      client/mysqltest.c:
        Fixed a warning from using reference to a memory area,
        which is outside an object. This is just a minor
        clean-up, not a bug fix.
      server-tools/instance-manager/buffer.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/buffer.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/command.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/command.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/guardian.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/guardian.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_map.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_map.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_options.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/instance_options.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/listener.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/listener.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/mysql_connection.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/mysql_connection.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/options.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/options.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/parse_output.cc:
        Removed unused goto.
      server-tools/instance-manager/thread_registry.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/thread_registry.h:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/user_map.cc:
        Fixed pragma warning for those compilers that do
        not support it.
      server-tools/instance-manager/user_map.h:
        Fixed pragma warning for those compilers that do
        not support it.
      sql/field.cc:
        Fixed a warning about overflow.
      sql/item.h:
        Fixed implicit function declaration warning.
      sql/item_sum.cc:
        Fixed implicit function declaration warning.
      ab0d7e2a
    • unknown's avatar
      Several fixes revelaled by Intel compiler. · ecffc1b8
      unknown authored
      
      cmd-line-utils/readline/complete.c:
        Added a cast.
      dbug/my_main.c:
        Added an include to avoid implicit declaration of
        my_thread_global_init()
      include/my_global.h:
        undef cannot be used on this predefined name.
        Since it is a custom fix for gcc 2.8.0, let's make it only
        effective in that case.
      include/my_sys.h:
        Added a new type, TYPE_NOT_SET.
      myisam/ft_boolean_search.c:
        Added casts.
      myisam/mi_key.c:
        Added cast.
      myisam/mi_open.c:
        Added cast.
        Changed function types.
      myisam/mi_test1.c:
        Added cast.
      myisam/myisamchk.c:
        Added cast.
      myisam/myisamdef.h:
        Changed function type.
      myisam/myisampack.c:
        Added casts.
      myisam/sp_key.c:
        Added cast.
      mysys/mf_iocache.c:
        Fixed invalid use of 0 to info->type. According to comment it
        should not have been set, but in earlier code by setting it
        to 0 would have been same as setting it to READ_CACHE. This
        probably was not desired, potential bug.
      server-tools/instance-manager/instance_options.cc:
        Fixed a typo.
      server-tools/instance-manager/protocol.cc:
        Changed enum to int.
        Changed char to uchar.
        Added casts.
      sql/mysql_priv.h:
        Bit overflow.
      sql/sql_base.cc:
        Removed unused label. The code below label was unused too, because
        there is a return just before.
      sql/sql_parse.cc:
        Removed unneccessary extra argument.
      ecffc1b8
    • unknown's avatar
      Merge baker@bk-internal.mysql.com:/home/bk/mysql-5.0 · abda6dc6
      unknown authored
      into  zim.(none):/home/brian/mysql/fix-5.0
      
      
      sql/handler.cc:
        Auto merged
      abda6dc6
  2. 22 Sep, 2005 19 commits
    • unknown's avatar
      This fixed bug 13369. Note, I dislike goto's as well. · 1d5a9276
      unknown authored
      The alias structure now is a bit more simple and just uses a pointer to replace with the currect name. The giant case statement should go away in the next patch.
      
      
      sql/handler.cc:
        Simplified the code, annd fixed build issue with engines not being compiled.
        I disliek the goto but Serg preferred it over the testing of aliases first :)
      sql/handler.h:
        Removed ht from alias structure.
      1d5a9276
    • unknown's avatar
      Merge mysqldev@production.mysql.com:my/mysql-5.0-release · 38ebb6c6
      unknown authored
      into  mysql.com:/opt/local/work/mysql-5.0-root
      
      
      BitKeeper/etc/ignore:
        auto-union
      include/my_sys.h:
        Auto merged
      mysql-test/r/information_schema.result:
        Auto merged
      mysql-test/t/ctype_ujis.test:
        Auto merged
      sql/ha_federated.cc:
        Auto merged
      sql/handler.cc:
        Auto merged
      sql/item_func.h:
        Auto merged
      sql/log.cc:
        Auto merged
      sql/sp_head.cc:
        Auto merged
      sql/sp_head.h:
        Auto merged
      sql/sql_acl.cc:
        Auto merged
      sql/sql_base.cc:
        Auto merged
      sql/sql_class.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_lex.h:
        Auto merged
      sql/sql_prepare.cc:
        Auto merged
      sql/sql_select.cc:
        Auto merged
      sql/sql_view.cc:
        Auto merged
      sql/table.cc:
        Auto merged
      38ebb6c6
    • unknown's avatar
      Bug #13384 mysqltest, no protocol when script contains only lines with eval · 2fec728e
      unknown authored
      
      client/mysqltest.c:
        Set query_executed also for eval, that results in a query being executed and output is
        likely. Commited once again in 5.0
      2fec728e
    • unknown's avatar
      Fixes needed to build 5.0.13 on Windows: · ac9c1fa3
      unknown authored
      - reflect two "Makefile.am" changes in the respective "VC project" files,
      - correct a typo in a (normally) unused macro parameter.
      
      
      VC++Files/libmysqld/libmysqld.vcproj:
        Reflect a change done by Kostja in the Unix "libmysqld/Makefile.am":
        New file "sql/sql_cursor.cpp" replaces "sql/protocol_cursor.cpp".
      VC++Files/sql/mysqld.vcproj:
        Reflect a change done by Kostja in the Unix "sql/Makefile.am":
        New file "sql/sql_cursor.cpp" replaces "sql/protocol_cursor.cpp".
      sql/ha_federated.cc:
        Correct a typo (matters only if "SAFEMALLOC" is set).
      ac9c1fa3
    • unknown's avatar
      Merge neptunus.(none):/home/msvensson/mysql/bug13164/my50-bug13164 · d2fc3bd4
      unknown authored
      into  neptunus.(none):/home/msvensson/mysql/mysql-5.0
      
      
      d2fc3bd4
    • unknown's avatar
      Bug #13164 yassl: "SSL connection error" on several platforms · 17efbe9f
      unknown authored
       - it's a requirement fo yaSSL that either /dev/urandom or /dev/random is available on the target system.
       - Added a fix that tries to open /dev/random if /dev/urandom is not available.
      
      
      extra/yassl/taocrypt/src/random.cpp:
        Try to open /dev/ranom if /dev/urandom is not available.
      17efbe9f
    • unknown's avatar
      InnoDB: correct two misleading comments · aab7ac88
      unknown authored
      
      innobase/include/data0type.ic:
        Correct the comment of dtype_get_min_size()
      sql/ha_innodb.h:
        Correct the comment of innobase_set_cursor_view()
      aab7ac88
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 240bbb9c
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b11553
      
      
      240bbb9c
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/mysql-5.0 · 12b25c27
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-push
      
      
      12b25c27
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/mysql-4.1 · 6532bfdd
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      mysql-test/r/ndb_alter_table.result:
        Auto merged
      mysql-test/t/ndb_alter_table.test:
        Auto merged
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        Auto merged
      6532bfdd
    • unknown's avatar
      Add testcase for bug#13316 · 8e78ba93
      unknown authored
        ndb big alter table
      
      
      mysql-test/r/ndb_alter_table.result:
        Add testcase for bug#13316
      mysql-test/t/ndb_alter_table.test:
        Add testcase for bug#13316
      8e78ba93
    • unknown's avatar
      Merge rkalimullin@bk-internal.mysql.com:/home/bk/mysql-5.0 · 479ef8f7
      unknown authored
      into  mysql.com:/usr/home/ram/work/5.0.b11553
      
      
      sql/sql_yacc.yy:
        Auto merged
      479ef8f7
    • unknown's avatar
      bug#13316 · 86713962
      unknown authored
        ndb alter table with big dicttabinfo
        send alter_tab_req fragmented as signal can get larger than MAX_MESSAGE_SIZE
      
      
      ndb/src/kernel/blocks/dbdict/Dbdict.cpp:
        DictTabInfo used during alter table can easily becom larger than MAX_MESSAGE_SIZE
          send fragmented instead
      86713962
    • unknown's avatar
      GCC4 build fix · ff50190a
      unknown authored
      
      ndb/src/ndbapi/NdbUtil.hpp:
        gcc4 build fix
      ff50190a
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · 0d603173
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-push
      
      
      0d603173
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/mysql-5.0 · e718b01e
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-push
      
      
      e718b01e
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/mysql-4.1 · c6a5e9a3
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      ndb/src/ndbapi/Ndbinit.cpp:
        Auto merged
      c6a5e9a3
    • unknown's avatar
      ndb - fix gcc4 compile problem · 449fb0b1
      unknown authored
      
      ndb/src/ndbapi/Ndbinit.cpp:
        fix gcc4 compile problem
      449fb0b1
    • unknown's avatar
      Fixed problems found by valgrind · 7d6d4c83
      unknown authored
      Fixed problems in test suite where some test failed
      Fixed access to not initialized memory in federated
      Fixed access to not initialized memory when using BIT fields in internal temporary tables
      
      
      BitKeeper/etc/ignore:
        added libmysqld/sql_cursor.h
      mysql-test/r/information_schema.result:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middlecd
      mysql-test/r/information_schema_inno.result:
        Remove used tables at start
      mysql-test/r/multi_statement.result:
        Remove used tables at start
      mysql-test/r/temp_table.result:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/r/type_bit.result:
        More tests
      mysql-test/t/information_schema.test:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/t/information_schema_inno.test:
        Remove used tables at start
      mysql-test/t/multi_statement.test:
        Remove used tables at start
      mysql-test/t/temp_table.test:
        Change view names to 'v#' to not cause massive conflict with other tests if test dies in the middle
      mysql-test/t/type_bit.test:
        More tests
      mysql-test/valgrind.supp:
        Removed some valgrind warnings that isn't errors
      sql/ha_federated.cc:
        Fixed errors discovered by valgrind:
        - Socket was not initialized
        - share->scheme was deleted while there was still pointer into it from the hash
      sql/item_func.h:
        Remove access to table object from cleanup() as the table object may have been dropped earlier (In case of temporary tables or of close_thread_tables() is run before cleanup())
        This fixed a bug with access to already freed memory
      sql/sql_base.cc:
        Reset variables used by fulltext
      sql/sql_select.cc:
        Fixed various problems with bit fields when used in internal temporary tables.
        Calculate space needed for bit fields correctly (previously we allocated more space than needed for rows in heap/myisam tables)
      7d6d4c83
  3. 21 Sep, 2005 18 commits
    • unknown's avatar
      Manual merge · c64d0fc6
      unknown authored
      
      mysql-test/r/update.result:
        Auto merged
      mysql-test/t/update.test:
        Auto merged
      c64d0fc6
    • unknown's avatar
      A fix and a test case for Bug#6513 "Test Suite: Values inserted by using · 813fc410
      unknown authored
      cursor is interpreted latin1 character and Bug#9819 "Cursors: Mysql Server
      Crash while fetching from table with 5 million records."
      A fix for a possible memory leak when fetching into an SP cursor
      in a long loop.
      The patch uses a common implementation of cursors in the binary protocol and 
      in stored procedures and implements materialized cursors.
      For implementation details, see comments in sql_cursor.cc
      
      
      include/my_sys.h:
        - declaration for multi_alloc_root
      libmysqld/Makefile.am:
        - drop protocol_cursor.cc, add sql_cursor.cc (replaces the old
        implementation of cursors with a new one)
      mysql-test/r/ctype_ujis.result:
        - test results fixed (a test case for Bug#6513)
      mysql-test/r/sp-big.result:
        - test results fixed (a test case for Bug#9819)
      mysql-test/t/ctype_ujis.test:
        Add a test case for Bug#6513 "Test Suite: Values inserted by using cursor is
         interpreted latin1 character"
      mysql-test/t/sp-big.test:
        Add a restricted test case for Bug#9819 "Cursors: Mysql Server Crash
        while fetching from table with 5 million records."
      mysys/my_alloc.c:
        - an implementation of multi_alloc_root; this is largely a copy-paste
          from mulalloc.c, but the function is small and there is no easy way
          to reuse the existing C function.
      sql/Makefile.am:
        - add sql_cursor.h, sql_cursor.cc (a new implementation of stored procedure
        cursors) and drop protocol_cursor.cc (the old one)
      sql/handler.cc:
        - now TABLE object has its mem_root always initialized.
          Adjust the implementation handler::ha_open
      sql/item_subselect.cc:
        - adjust to the changed declaration of st_select_lex_unit::prepare
      sql/protocol.h:
        - drop Protocol_cursor
      sql/sp_head.cc:
        - move juggling with Query_arena::free_list and Item::next to
          sp_eval_func_item, as this is needed in 3 places already.
      sql/sp_head.h:
        - declare a no-op implementation for cleanup_stmt in sp_instr_cpush.
          This method is needed for non-materializing cursors, which are yet not 
          used in stored procedures.
        - declaration for sp_eval_func_item
      sql/sp_rcontext.cc:
        - reimplement sp_cursor using the new implementation of server side cursors.
        - use sp_eval_func_item to assign values of SP variables from the
          row fetched from a cursor. This should fix a possible memory leak in 
          the old implementation of sp_cursor::fetch
      sql/sp_rcontext.h:
        - reimplement sp_cursor using the new implementation of server side cursors.
      sql/sql_class.cc:
        - disable the functionality that closes transient cursors at commit/rollback;
          transient cursors are not used in 5.0, instead we use materialized ones.
          To be enabled in a later version.
      sql/sql_class.h:
        - adjust to the rename Cursor -> Server_side_cursor
        - additional declarations of select_union used in materialized cursors
      sql/sql_derived.cc:
        - reuse bits of tmp table code in UNION, derived tables, and materialized
          cursors
        - cleanup comments
      sql/sql_lex.h:
        - declarations of auxiliary methods used by materialized cursors
        - a cleanup in st_select_lex_unit interface
      sql/sql_list.h:
        - add an array operator new[] to class Sql_alloc
      sql/sql_prepare.cc:
        - split the tight coupling of cursors and prepared statements to reuse 
          the same implementation in stored procedures
        - cleanups of error processing in Prepared_statement::{prepare,execute}
      sql/sql_select.cc:
        - move the implementation of sensitive (non-materializing) cursors to 
          sql_cursor.cc
        - make temporary tables self-contained: the table, its record and fields
          are allocated in TABLE::mem_root. This implementation is not clean
          and resets thd->mem_root several times because of the way create_tmp_table 
          works (many additional things are done inside it).
        - adjust to the changed declaration of st_select_lex_unit::prepare
      sql/sql_select.h:
        - move the declaration of sensitive (non-materializing) cursors to 
          sql_cursor.cc
      sql/sql_union.cc:
        - move pieces of st_select_unit::prepare to select_union and st_table
          methods to be able to reuse code in the implementation of materialized
          cursors
      sql/sql_view.cc:
        - adjust to the changed signature of st_select_lex_unit::prepare
      sql/table.cc:
        - implement auxiliary st_table methods for use with temporary tables
      sql/table.h:
        - add declarations for auxiliary methods of st_table used to work with 
         temporary tables
      tests/mysql_client_test.c:
        - if cursors are materialized, a parallel update of the table used
          in the cursor may go through: update the test.
      sql/sql_cursor.cc:
        New BitKeeper file ``sql/sql_cursor.cc'' -- implementation of server side
        cursors
      sql/sql_cursor.h:
        New BitKeeper file ``sql/sql_cursor.h'' - declarations for
        server side cursors.
      813fc410
    • unknown's avatar
      Fix bug #13180 thd->allow_sum_funcs wasn't reset before query processing. · 1b02a815
      unknown authored
      thd->allow_sum_func was left 'true' after previous statement thus allowing
      sum funcs to be present in conditions.
      
      thd->allow_sum_func should be set to 0 for each query and each prepared
      statement reinitialization. This is done in lex_start() and 
      reset_stmt_for_execute().
      
      
      sql/sql_lex.cc:
        Fix bug#13180 thd->allow_sum_func wasn't reset obefore query processing.
        thd->allow_sum_func is set to 0 in lex_start().
      sql/sql_prepare.cc:
        Fix bug#13180 thd->allow_sum_func wasn't reset obefore query processing.
        thd->allow_sum_func is set to 0 in  reset_stmt_for_execute().
      mysql-test/t/update.test:
        Test case for bug#13180 thd->allow_sum_funcs wasn't reset before query
        processing.
      mysql-test/r/update.result:
        Test case for bug#13180 thd->allow_sum_funcs wasn't reset before query
        processing.
      1b02a815
    • unknown's avatar
      Merge stamagawa@bk-internal.mysql.com:/home/bk/mysql-5.0 · 7f983bf7
      unknown authored
      into  mysql.com:/home/shuichi/apps/mysql/bk/mysql-5.0b
      
      
      configure.in:
        Auto merged
      7f983bf7
    • unknown's avatar
      Merge bk-internal.mysql.com:/home/bk/mysql-5.0 · c54ec386
      unknown authored
      into serg.mylan:/usr/home/serg/Abk/mysql-5.0-merged
      
      
      sql/ha_myisam.cc:
        Auto merged
      sql/handler.h:
        Auto merged
      sql/mysql_priv.h:
        Auto merged
      sql/mysqld.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/slave.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      c54ec386
    • unknown's avatar
      aftermerge fix · 4956432b
      unknown authored
      4956432b
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · 96c8ffdd
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-rollback-comment
      
      
      96c8ffdd
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/mysql-5.0 · 41dd1b81
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-push
      
      
      41dd1b81
    • unknown's avatar
      ndb merge fix · b63df84b
      unknown authored
      b63df84b
    • unknown's avatar
      Merge perch.ndb.mysql.com:/home/jonas/src/mysql-4.1 · cf358493
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Auto merged
      ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Auto merged
      ndb/src/kernel/blocks/dbtup/DbtupTrigger.cpp:
        merge
      cf358493
    • unknown's avatar
      bug#12950 · 3c8a296f
      unknown authored
          ndb backup with charsets and simultanious updates
          make sure that backup _dont_ read xfrm data
      
      
      ndb/src/kernel/blocks/backup/Backup.cpp:
        Backup can do dirty read
      ndb/src/kernel/blocks/dbtup/Dbtup.hpp:
        Fix so that backup dont read xfrm data
      ndb/src/kernel/blocks/dbtup/DbtupTrigger.cpp:
        Fix so that backup dont read xfrm data
      3c8a296f
    • unknown's avatar
      Merge mysql.com:/users/lthalmann/bkroot/mysql-5.0 · 353dd79b
      unknown authored
      into  mysql.com:/users/lthalmann/bk/mysql-5.0-rollback-comment
      
      
      353dd79b
    • unknown's avatar
      sql/item_func.cc · 3f35fce1
      unknown authored
        remove extra ";" after function
      
      
      sql/item_func.cc:
        remove extra ";" after function
      3f35fce1
    • unknown's avatar
    • unknown's avatar
      merged · aa7bc459
      unknown authored
      
      VC++Files/mysys/mysys.dsp:
        Auto merged
      VC++Files/mysys/mysys_ia64.dsp:
        Auto merged
      client/mysql.cc:
        Auto merged
      include/my_sys.h:
        Auto merged
      myisam/mi_check.c:
        Auto merged
      myisam/myisamchk.c:
        Auto merged
      mysql-test/mysql-test-run.pl:
        Auto merged
      mysql-test/r/rpl_multi_delete2.result:
        Auto merged
      mysql-test/t/innodb.test:
        Auto merged
      mysql-test/t/rpl_multi_delete2-slave.opt:
        Auto merged
      mysql-test/t/rpl_multi_delete2.test:
        Auto merged
      sql/ha_myisam.cc:
        Auto merged
      sql/opt_sum.cc:
        Auto merged
      sql/set_var.cc:
        Auto merged
      sql/sql_class.h:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      aa7bc459
    • unknown's avatar
      Merge joreland@bk-internal.mysql.com:/home/bk/mysql-5.0 · 49e641a0
      unknown authored
      into  perch.ndb.mysql.com:/home/jonas/src/mysql-5.0-push
      
      
      sql/mysqld.cc:
        Auto merged
      sql/sql_parse.cc:
        Auto merged
      sql/sql_yacc.yy:
        Auto merged
      49e641a0
    • unknown's avatar
      ndb post merge fixes (show engine ndb status) · 92cc2b80
      unknown authored
      
      sql/ha_ndbcluster.cc:
        ndb post merge fixes
      92cc2b80
    • unknown's avatar
      merged · 56264f9a
      unknown authored
      56264f9a