1. 14 Nov, 2008 2 commits
  2. 13 Nov, 2008 1 commit
    • Sven Sandberg's avatar
      BUG#38350: Many tests don't clean up after themselves on exit. · ca59e88c
      Sven Sandberg authored
      Problem: Many test cases don't clean up after themselves (fail
      to drop tables or fail to reset variables). This implies that:
      (1) check-testcase in the new mtr that currently lives in
      5.1-rpl failed. (2) it may cause unexpected results in
      subsequent tests.
      Fix: make all tests clean up.
      Also: cleaned away unnecessary output in rpl_packet.result
      Also: fixed bug where rpl_log called RESET MASTER with a running
      slave. This is not supposed to work.
      Also: removed unnecessary code from rpl_stm_EE_err2 and made it
      verify that an error occurred.
      Also: removed unnecessary code from rpl_ndb_ctype_ucs2_def.
      
      
      mysql-test/extra/rpl_tests/rpl_loaddata.test:
        Made test clean up after itself.
      mysql-test/extra/rpl_tests/rpl_stm_EE_err2.test:
        Made test clean up after itself.
        Also removed unnecessary save_master_pos.
        Also made test verify that an error occurred.
      mysql-test/extra/rpl_tests/rpl_truncate_helper.test:
        Made test clean up after itself.
      mysql-test/include/query_cache.inc:
        Made test clean up after itself.
      mysql-test/suite/binlog/t/binlog_auto_increment_bug33029.test:
        Made test clean up after itself.
      mysql-test/suite/rpl/t/rpl_alter_db.test:
        Made test clean up after itself.
        Easiest to refactor the test a little, to use an auxiliary database instead of mysql:
        Then we don't need to read the collation at the start of the test and reset it at the
        end of the test. We can just drop the database.
      mysql-test/suite/rpl/t/rpl_drop_db.test:
        Made test clean up after itself.
      mysql-test/suite/rpl/t/rpl_drop_view.test:
        Made test clean up after itself.
      mysql-test/suite/rpl/t/rpl_events.test:
        Made test clean up after itself.
      mysql-test/suite/rpl/t/rpl_idempotency.test:
        Made test clean up after itself.
      mysql-test/suite/rpl/t/rpl_ignore_table.test:
        Made test clean up after itself.
        The existing cleanup code didn't work, because the --replicate-*
        options prevented the "drop table" from being replicated. Moved
        "drop table t4" to a statement of its own.
      mysql-test/suite/rpl/t/rpl_packet.test:
        Made test clean up after itself.
        Also replaced SHOW SLAVE STATUS by query_get_value(SHOW SLAVE STATUS...),
        since only one column of the result was interesting.
      mysql-test/suite/rpl/t/rpl_row_max_relay_size.test:
        Made test clean up after itself.
        Instead of setting binlog format at the beginning of the test, we just
        do 'source include/have_binlog_format_row.inc' like all other tests.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_2other.test:
        Made test clean up after itself.
      mysql-test/suite/rpl_ndb/t/rpl_ndb_ctype_ucs2_def.test:
        Made test clean up after itself.
        Also removed unnecessary 'create table; drop table'
        Also removed unnecessary use of --command
      mysql-test/suite/rpl_ndb/t/rpl_ndb_multi.test:
        Made test clean up after itself.
      mysql-test/t/innodb-autoinc-optimize.test:
        Made test clean up after itself.
      mysql-test/t/innodb.test:
        Made test clean up after itself.
      mysql-test/t/log_tables.test:
        Made test clean up after itself.
      mysql-test/t/mysql_client_test.test:
        Made test clean up after itself.
      mysql-test/t/partition.test:
        Made test clean up after itself.
      mysql-test/t/status.test:
        Made test clean up after itself.
      ca59e88c
  3. 12 Nov, 2008 1 commit
  4. 11 Nov, 2008 1 commit
  5. 10 Nov, 2008 6 commits
  6. 07 Nov, 2008 5 commits
  7. 06 Nov, 2008 17 commits
  8. 05 Nov, 2008 7 commits
    • Mattias Jonsson's avatar
      f8588915
    • Evgeny Potemkin's avatar
      Merged fix for the bug#37870. · 8d75510e
      Evgeny Potemkin authored
      8d75510e
    • Mattias Jonsson's avatar
      merge · 8a544f2a
      Mattias Jonsson authored
      8a544f2a
    • Mattias Jonsson's avatar
      merge · 7c5d066b
      Mattias Jonsson authored
      7c5d066b
    • Evgeny Potemkin's avatar
      Bug#37870: Usage of uninitialized value caused failed assertion. · 3c49cb07
      Evgeny Potemkin authored
      The convert_constant_item function converts a constant to integer using
      field for condition like 'field = a_constant'. In some cases the
      convert_constant_item is called for a subquery when outer select is already
      being executed, so convert_constant_item saves field's value to prevent its
      corruption. For EXPLAIN and at the prepare phase field's value isn't
      initialized yet, thus when convert_constant_item tries to restore saved
      value it fails assertion.
      
      Now the convert_constant_item doesn't save/restore field's value if it's
      haven't been read yet. Outer constant values are always saved.
      
      mysql-test/r/explain.result:
        Added a test case for the bug#37870.
      mysql-test/t/explain.test:
        Added a test case for the bug#37870.
      sql/item_cmpfunc.cc:
        Bug#37870: Usage of uninitialized value caused failed assertion.
        Now the convert_constant_item doesn't save/restore field's value if it's
        haven't been read yet. Outer constant values are always saved.
      3c49cb07
    • Mattias Jonsson's avatar
      merge · 74f678d8
      Mattias Jonsson authored
      74f678d8
    • Mattias Jonsson's avatar
      Bug#40494: MYSQL server crashes on range access with partitioning and · bcd88c9f
      Mattias Jonsson authored
      order by
      
      Problem was that the first index read was unordered,
      and the next was ordered, resulting in use of
      uninitialized data.
      
      Solution was to use the correct variable to see if
      the 'next' call should be ordered or not.
      
      mysql-test/r/partition.result:
        Bug#40494: MYSQL server crashes on range access with
        partitioning and order by
        
        Added test case for the bug.
      mysql-test/t/partition.test:
        Bug#40494: MYSQL server crashes on range access with
        partitioning and order by
        
        Added test case for the bug.
      sql/ha_partition.cc:
        Bug#40494: MYSQL server crashes on range access with
        partitioning and order by
        
        Used the wrong variable to decide to continue with
        ordered or unordered scan.
      bcd88c9f