An error occurred fetching the project authors.
  1. 09 Feb, 2009 1 commit
    • Matthias Leich's avatar
      This belongs to the fix for · 0fab1a85
      Matthias Leich authored
      Bug#42003 tests missing the disconnect of connections <> default
      second slice
      Content:
      1. wait_until_count_sessions.inc
         - One PB run of a test using this routine failed because
           5 seconds timeout were exceeded. Although I have some doubts
           if the assigned timeout was really too small, I increase the
           value to 10. We waste the additional 5 seconds only if the
           tests fails anyway.
         - Print the content of the PROCESSLIST if the poll routine fails
      2. minor improvements of formatting
      3. query_cache_notembedded:
         Activate the wait_until_count_sessions.inc routine which was
         unfortunately forgotten in the changeset before.
      0fab1a85
  2. 05 Feb, 2009 1 commit
    • Matthias Leich's avatar
      2. Slice of fix for Bug#42003 tests missing the disconnect of connections <> default · 41e6a1f8
      Matthias Leich authored
         - If missing: add "disconnect <session>"
         - If physical disconnect of non "default" sessions is not finished
           at test end: add routine which waits till this happened
      + additional improvements
        - remove superfluous files created by the test
        - replace error numbers by error names
        - remove trailing spaces, replace tabs by spaces
        - unify writing of bugs within comments
        - correct comments
        - minor changes of formatting
      Fixed tests:
        backup
        check
        compress
        grant
        information_schema
        multi_update
        overflow
        packet
        query_cache_not_embedded
        sp-threads
        subselect
        synchronization
        timezone_grant
      41e6a1f8
  3. 10 Dec, 2008 1 commit
  4. 17 Nov, 2008 1 commit
    • Alexey Botchkov's avatar
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server. · 1199dfcb
      Alexey Botchkov authored
            GLOBAL STATUS is calculated by studying the list of threads. In the
              embedded server threads were not linked to the internal list, so the
              calculation always returns 0. Fixed by 'linking' the embedded-server
              threads to the same list
      
      per-file comments:
        libmysqld/lib_sql.cc
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          Add newly created 'threads' to the internal thread list.
          Remove them from the list as they're freed.
      
        mysql-test/r/information_schema.result
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          test result
      
        mysql-test/t/information_schema.test
      Bug#34517 SHOW GLOBAL STATUS does not work properly in embedded server.
          test case added
      1199dfcb
  5. 13 Nov, 2008 2 commits
    • Sergey Glukhov's avatar
      Bug#39955 SELECT on INFORMATION_SCHEMA.GLOBAL_VARIABLES takes too long · 53b30523
      Sergey Glukhov authored
      VARIABLE_VALUE field is decreased to 1024 symbols.
      (affected I_S tables: GLOBAL_VARIABLES, SESSION_VARIABLES,
       GLOBAL_STATUS, SESSION_STATUS).
      The only variable which can be longer than 1024 is
      init_connect. The variable will be truncated with warning.
      Additional fix:
      Added where condition filter which speed up queries which
      have where condition with expressions which use VARIABLE_NAME
      field.
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/r/show_check.result:
        result fix
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        VARIABLE_VALUE field is decreased to 1024 symbols.
        (affected I_S tables: GLOBAL_VARIABLES, SESSION_VARIABLES,
         GLOBAL_STATUS, SESSION_STATUS).
        The only variable which can be longer than 1024 is
        init_connect. The variable will be truncated with warning.
        Additional fix:
        Added where condition filter which speed up queries which
        have where condition with expressions which use VARIABLE_NAME
        field.
      53b30523
    • Sergey Glukhov's avatar
      Bug#35789 wrong datatypes for collation and charset columns in EVENTS, ROUTINES, TRIGGERS · 0dff7272
      Sergey Glukhov authored
      changed 'charset', 'collation' field length from 64 to MY_CS_NAME_SIZE(32)
      in tables:
      SCHEMATA, TABLES, COLUMNS, CHARACTER_SETS,
      COLLATIONS, COLLATION_CHARACTER_SET_APPLICABILITY
      
      
      mysql-test/r/create.result:
        result fix
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/r/show_check.result:
        result fix
      mysql-test/suite/funcs_1/r/is_character_sets.result:
        result fix
      mysql-test/suite/funcs_1/r/is_collation_character_set_applicability.result:
        result fix
      mysql-test/suite/funcs_1/r/is_collations.result:
        result fix
      mysql-test/suite/funcs_1/r/is_columns.result:
        result fix
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        result fix
      mysql-test/suite/funcs_1/r/is_routines.result:
        result fix
      mysql-test/suite/funcs_1/r/is_schemata.result:
        result fix
      mysql-test/suite/funcs_1/r/is_tables.result:
        result fix
      sql/sql_show.cc:
        changed 'charset', 'collation' field length from 64 to MY_CS_NAME_SIZE(32)
        in tables:
        SCHEMATA, TABLES, COLUMNS, CHARACTER_SETS,
        COLLATIONS, COLLATION_CHARACTER_SET_APPLICABILITY
        additional fix: ROUTINES.SQL_MODE is changed to be VARCHAR(addon for Bug#29153)
      0dff7272
  6. 09 Oct, 2008 2 commits
    • Sergey Glukhov's avatar
      Bug#29153 SHOW and INFORMATION_SCHEMA commands increment Created_tmp_disk_tables · 169a65aa
      Sergey Glukhov authored
      TRIGGERS.SQL_MODE, EVENTS.SQL_MODE, TRIGGERS.DEFINER:
      field type is changed to VARCHAR.
      
      
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/r/show_check.result:
        result fix
      mysql-test/suite/funcs_1/r/is_columns_is.result:
        result fix
      mysql-test/suite/funcs_1/r/is_events.result:
        result fix
      mysql-test/suite/funcs_1/r/is_triggers.result:
        result fix
      sql/sql_show.cc:
        TRIGGERS.SQL_MODE, EVENTS.SQL_MODE, TRIGGERS.DEFINER:
        field type is changed to VARCHAR.
      169a65aa
    • Sergey Glukhov's avatar
      Bug#38918 selecting from information_schema.columns is disproportionately slow · 95b721e6
      Sergey Glukhov authored
      The problem: table_open_method is not calculated properly if '*' is used in 'select'
      The fix: added table_open_method calculation for such case
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        The problem: table_open_method is not calculated properly if '*' is used in 'select'
        The fix: added table_open_method calculation for such case
      95b721e6
  7. 08 Apr, 2008 1 commit
    • unknown's avatar
      Check warnings in servers error log as part of test case · 2c4ca510
      unknown authored
      BitKeeper/deleted/.del-rpl_bug33931-slave.opt:
        Delete: mysql-test/suite/rpl/t/rpl_bug33931-slave.opt
      mysql-test/include/default_mysqld.cnf:
        Set a default name for "log-bin"
      mysql-test/mysql-test-run.pl:
        Check for warnings in mysqld error log files after each testcase,
        using SQL
      mysql-test/lib/mtr_cases.pm:
        Make mtr_match into a perl module
      mysql-test/lib/mtr_match.pm:
        Make mtr_match into a perl module
      mysql-test/lib/mtr_report.pm:
        Make mtr_match into a perl module
        Print warnings if testcase failed from warnings
      mysql-test/r/information_schema.result:
        Be more selective which databases and tables are select in the queries
      mysql-test/r/mysql_upgrade.result:
        Update result, mysql_upgrade will check _all_ databases
      mysql-test/r/mysqlcheck.result:
        Update result, mysql_upgrade should check _all_ databases
      mysql-test/r/sp-destruct.result:
        Be more selective which databases and tables are select in the queries
      mysql-test/r/sp-error.result:
        Backup and restore mysql.proc table
      mysql-test/r/sp-security.result:
        Be more selective which databases and tables are select in the queries
      mysql-test/r/sp.result:
        Be more selective which databases and tables are select in the queries
      mysql-test/suite/rpl/r/rpl_bug33931.result:
        Move the setting of debug flag into the test file instead of in -slave.opt
        Add supression
      mysql-test/suite/rpl/r/rpl_idempotency.result:
        Add supression
        Add master-slave-end.inc
      mysql-test/suite/rpl/t/rpl_bug33931.test:
        Move the setting of debug flag into the test file instead of in -slave.opt
        Add supression
      mysql-test/suite/rpl/t/rpl_idempotency.test:
        Add supression
        Add master-slave-end.inc
      mysql-test/t/information_schema.test:
        Be more selective which databases and tables are select in the queries
      mysql-test/t/sp-destruct.test:
        Be more selective which databases and tables are select in the queries
      mysql-test/t/sp-error.test:
        Backup and restore mysql.proc table
      mysql-test/t/sp-security.test:
        Be more selective which databases and tables are select in the queries
      mysql-test/t/sp.test:
        Be more selective which databases and tables are select in the queries
      mysql-test/include/check-warnings.test:
        New BitKeeper file ``mysql-test/include/check-warnings.test''
      mysql-test/include/mtr_warnings.sql:
        New BitKeeper file ``mysql-test/include/mtr_warnings.sql''
      2c4ca510
  8. 02 Apr, 2008 1 commit
  9. 25 Mar, 2008 1 commit
    • unknown's avatar
      information_schema.test, information_schema.result: · d62c9e33
      unknown authored
        Minor test case cleanup after bug#34529.
      
      
      mysql-test/r/information_schema.result:
        Minor test case cleanup after bug#34529.
      mysql-test/t/information_schema.test:
        Minor test case cleanup after bug#34529.
      d62c9e33
  10. 19 Mar, 2008 1 commit
    • unknown's avatar
      Bug#34529: Crash on complex Falcon I_S select after ALTER .. PARTITION BY · 3c5894ba
      unknown authored
        
      When swapping out heap I_S tables to disk, this is done after plan refinement.
      Thus, READ_RECORD::file will still point to the (deleted) heap handler at start
      of execution. This causes segmentation fault if join buffering is used and the 
      query is a star query where the result is found to be empty before accessing
      some table. In this case that table has not been initialized (i.e. had its 
      READ_RECORD re-initialized) before the cleanup routine tries to close the handler.
      Fixed by updating READ_RECORD::file when changing handler.
      
      
      mysql-test/r/information_schema.result:
        Bug#34529: Test result.
      mysql-test/t/information_schema.test:
        Bug#34529: Test case.
      sql/sql_show.cc:
        Bug#34529: The fix.
      3c5894ba
  11. 07 Mar, 2008 1 commit
    • unknown's avatar
      BUG#34656 - KILL a query = Assertion failed: m_status == DA_ERROR || · 44df0f6e
      unknown authored
                  m_status == DA_OK
      
      Reading from information_scema.tables or information_schema.columns
      may cause assertion failure in debug builds. This may happen under
      rare circumstances when information_schema fails to get information
      about a table (e.g. when a connection is killed).
      
      This happens because open_normal_and_derived_tables() can return an
      error without setting an error message in THD. But information_schema
      attempts to get an error message from THD unconditionally.
      
      With this fix information_schema attempts to get an error message
      from THD only in case error message is set in THD.
      
      
      mysql-test/r/information_schema.result:
        A test case for BUG#34656.
      mysql-test/t/information_schema.test:
        A test case for BUG#34656.
      sql/item_func.cc:
        Set proc info to "User sleep".
      sql/sql_show.cc:
        open_normal_and_derived_tables() can return an error without
        setting an error message in THD. That means we must access
        error message conditionally, only in case thd->is_error() is
        true.
      44df0f6e
  12. 27 Feb, 2008 1 commit
  13. 22 Feb, 2008 1 commit
    • unknown's avatar
      Fix for Bug#30217: Views: changes in metadata behaviour · a3e83048
      unknown authored
      between 5.0 and 5.1.
        
      The problem was that in the patch for Bug#11986 it was decided
      to store original query in UTF8 encoding for the INFORMATION_SCHEMA.
      This approach however turned out to be quite difficult to implement
      properly. The main problem is to preserve the same IS-output after
      dump/restore.
        
      So, the fix is to rollback to the previous functionality, but also
      to fix it to support multi-character-set-queries properly. The idea
      is to generate INFORMATION_SCHEMA-query from the item-tree after
      parsing view declaration. The IS-query should:
        - be completely in UTF8;
        - not contain character set introducers.
        
      For more information, see WL4052.
      
      
      mysql-test/include/ddl_i18n.check_views.inc:
        Add a test case for Bug#30217.
      mysql-test/r/ddl_i18n_koi8r.result:
        Update result file.
      mysql-test/r/ddl_i18n_utf8.result:
        Update result file.
      mysql-test/r/information_schema.result:
        Update result file.
      mysql-test/r/information_schema_db.result:
        Update result file.
      mysql-test/r/mysqldump.result:
        Update result file.
      mysql-test/r/show_check.result:
        Update result file.
      mysql-test/t/ddl_i18n_koi8r.test:
        Add a test case for Bug#30217.
      mysql-test/t/ddl_i18n_utf8.test:
        Add a test case for Bug#30217.
      mysql-test/t/mysqldump.test:
        Add a test case for Bug#30217.
      sql/ha_ndbcluster.cc:
        Add a parameter to print().
      sql/item.cc:
        1. Add a parameter to print().
        2. Item_string::print():
              - Do not append character set introducer to the text literal
                if we're building a query for INFORMATION_SCHEMA;
              - Convert text literal to UTF8 if we're building a query
                for INFORMATION_SCHEMA.
      sql/item.h:
        Add a parameter to print().
      sql/item_cmpfunc.cc:
        Add a parameter to print().
      sql/item_cmpfunc.h:
        Add a parameter to print().
      sql/item_func.cc:
        Add a parameter to print().
      sql/item_func.h:
        Add a parameter to print().
      sql/item_geofunc.h:
        Add a parameter to print().
      sql/item_row.cc:
        Add a parameter to print().
      sql/item_row.h:
        Add a parameter to print().
      sql/item_strfunc.cc:
        Add a parameter to print().
      sql/item_strfunc.h:
        Add a parameter to print().
      sql/item_subselect.cc:
        Add a parameter to print().
      sql/item_subselect.h:
        Add a parameter to print().
      sql/item_sum.cc:
        Add a parameter to print().
      sql/item_sum.h:
        Add a parameter to print().
      sql/item_timefunc.cc:
        Add a parameter to print().
      sql/item_timefunc.h:
        Add a parameter to print().
      sql/mysql_priv.h:
        Add a parameter to print().
      sql/sp_head.cc:
        Add a parameter to print().
      sql/sql_lex.cc:
        Add a parameter to print().
      sql/sql_lex.h:
        Add a parameter to print().
      sql/sql_parse.cc:
        Add a parameter to print().
      sql/sql_select.cc:
        Add a parameter to print().
      sql/sql_show.cc:
        Add a parameter to print().
      sql/sql_test.cc:
        Add a parameter to print().
      sql/sql_view.cc:
        Build INFORMATION_SCHEMA query from Item-tree.
      sql/sql_yacc.yy:
        Build INFORMATION_SCHEMA query from Item-tree.
      sql/table.h:
        Add a parameter to print().
      a3e83048
  14. 07 Feb, 2008 1 commit
    • unknown's avatar
      Bug#32633 Can not create any routine if SQL_MODE=no_engine_substitution · 1b6b7010
      unknown authored
      The problem is that one can not create a stored routine if sql_mode
      contains NO_ENGINE_SUBSTITUTION or PAD_CHAR_TO_FULL_LENGTH. Also when
      a event is created, the mode is silently lost if sql_mode contains one
      of the aforementioned.  This was happening because the table definitions
      which stored sql_mode values weren't being updated to accept new values
      of sql_mode.
      
      The solution is to update, in a backwards compatible manner, the various
      table definitions (columns) that store the sql_mode value to take into
      account the new possible values. One incompatible change is that if a event
      that is being created can't be stored to the mysql.event table, an error
      will be raised.
      
      The tests case also ensure that new SQL modes will be added to the mysql.proc
      and mysql.event tables, otherwise the tests will fail.
      
      
      mysql-test/r/events_bugs.result:
        Add test case result for Bug#32633
      mysql-test/r/information_schema.result:
        Update the sql_mode column definition.
      mysql-test/r/sp.result:
        Add test case result for Bug#32633
      mysql-test/r/system_mysql_db.result:
        Update the sql_mode column definition.
      mysql-test/t/events_bugs.test:
        Add test case for Bug#32633
      mysql-test/t/sp.test:
        Add test case for Bug#32633
      mysql-test/t/system_mysql_db_fix50117.test:
        Update the sql_mode column definition.
      scripts/mysql_system_tables.sql:
        Update the sql_mode column definition.
      scripts/mysql_system_tables_fix.sql:
        Update the sql_mode column definition.
      sql/event_db_repository.cc:
        Reset and restore SQL modes when storing and loading a
        event from the data dictionary. Also throw out a error
        if a store fails.
      sql/mysqld.cc:
        Add warning to avoid this problem in the future.
      sql-common/my_user.c:
        Truncate length if user name or host name does not fit
        in the buffer.
      sql/sp.cc:
        SQL mode of the thread must not effect data dictionary operations.
      1b6b7010
  15. 30 Jan, 2008 1 commit
    • unknown's avatar
      A fix and a test case for Bug#34166 Server crash in SHOW OPEN TABLES and · 39509d64
      unknown authored
      pre-locking.
      
      The crash was caused by an implicit assumption in check_table_access() that
      table_list parameter is always a part of lex->query_tables.
      
      When iterating over the passed list of tables, check_table_access() used
      to stop only when lex->query_tables_last_not_own was reached. 
      In case of pre-locking, lex->query_tables_last_own is not NULL and points
      to some element of lex->query_tables. When the parameter
      of check_table_access() was not part of lex->query_tables, loop invariant
      could never be violated and a crash would happen when the current table
      pointer would point beyond the end of the provided list.
      
      The fix is to change the signature of check_table_access() to also accept
      a numeric limit of loop iterations, similarly to check_grant(), and 
      supply this limit in all places when we want to check access of tables
      that are outside lex->query_tables, or just want to check access to one table.
      
      
      mysql-test/r/information_schema.result:
        Update test results (Bug#34166).
      mysql-test/t/information_schema.test:
        Add a test case for Bug#34166.
      sql/mysql_priv.h:
        Change signature of check_table_access() to accept a numeric limit
        of tables to check.
      sql/sp_head.cc:
        Update to the new signature of check_table_access().
      sql/sql_acl.cc:
        Improve code clarity: if there is a numeric limit, we should not need
        to look at first_not_own_table.
      sql/sql_base.cc:
        Update to the new signature of check_table_access().
      sql/sql_cache.cc:
        Update to the new signature of check_table_access().
      sql/sql_parse.cc:
        Update to the new signature of check_table_access().
        Change check_table_access() to accept an optional numeric limit of tables
        to check. A crash would happen when check_table_access() was
        passed a list of tables that is not part of lex->query_tables and
        lex->query_tables_last_own was not NULL.
      sql/sql_plugin.cc:
        Update to the new signature of check_table_access().
      sql/sql_prepare.cc:
        Update to the new signature of check_table_access().
      sql/sql_show.cc:
        Update to the new signature of check_table_access().
        Ensure that check_table_access() only checks access to the first
        table in the table list when called from list_open_tables().
        list_open_tables() supplies a table list that is created on stack,
        whereas check_table_access() used to assume that the supplied list is a part
        of thd->lex.
      sql/sql_trigger.cc:
        Update to the new signature of check_table_access().
      sql/sql_view.cc:
        Update to the new signature of check_table_access().
      39509d64
  16. 14 Dec, 2007 1 commit
  17. 04 Dec, 2007 1 commit
  18. 30 Nov, 2007 1 commit
    • unknown's avatar
      Bug#32775 problems with SHOW EVENTS and Information_Schema · ff7e7fcb
      unknown authored
      removed unnecessary privilege checks for I_S schema
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/events.cc:
        There is no events in I_S so we don't need to execute check_access here.
      sql/sql_parse.cc:
        removed unnecessary check
      ff7e7fcb
  19. 13 Nov, 2007 1 commit
    • unknown's avatar
      Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS · b1b1d627
      unknown authored
      command and reported to a client.
      
      The fact that a timestamp field will be set to NO on UPDATE wasn't shown 
      by the SHOW COMMAND and reported to a client through connectors. This led to
      problems in the ODBC connector and might lead to a user confusion.
      
      A new filed flag called ON_UPDATE_NOW_FLAG is added. 
      Constructors of the Field_timestamp set it when a field should be set to NOW
      on UPDATE.
      
      The get_schema_column_record function now reports whether a timestamp field
      will be set to NOW on UPDATE.
      
      
      mysql-test/t/information_schema.test:
        A test case adjusted after fixing the bug#30081.
      mysql-test/r/type_timestamp.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/type_ranges.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/show_check.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_5merge.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_4heap.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_3innodb.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/ps_2myisam.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/metadata.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/log_tables.result:
        Adjusted a test case after fixing bug#30081.
      mysql-test/r/information_schema.result:
        A test case adjusted after fixing the bug#30081.
      mysql-test/r/grant.result:
        Adjusted a test case after fixing bug#30081.
      tests/mysql_client_test.c:
        A test case adjusted after fixing the bug#30081.
      sql/sql_show.cc:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        The get_schema_column_record function now reports whether a timestamp field
        will be set to NOW on UPDATE.
      sql/field.cc:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        Constructors of the Field_timestamp set the ON_UPDATE_NOW_FLAG on a field when
        it should be set to NOW on UPDATE.
      include/mysql_com.h:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        A new filed flag called ON_UPDATE_NOW_FLAG  is added.
      client/mysql.cc:
        Bug#30081: "ON UPDATE CURRENT_TIMESTAMP" wasn't shown by the SHOW FIELDS
        command and reported to a client.
        The fieldflag2str function is adjusted to print the ON_UPDATE_NOW_FLAG.
      b1b1d627
  20. 06 Nov, 2007 1 commit
  21. 02 Nov, 2007 2 commits
    • unknown's avatar
      Fix several merge problems. There are many changes in 5.1 from 5.0 · b01c89ed
      unknown authored
      that affect profiling.
      
      
      mysql-test/r/information_schema.result:
        Merge fixed.  This result moved to a new file.
      sql/sql_parse.cc:
        Include profiling in statistics.
        
        Add hook for SHOW_PROFILE in execution.
      sql/sql_profile.cc:
        Move/add the FEATURE_DISABLED warning to the I_S filling func.
        
        Fix merge, where a new member was added to ST_FIELD_INFO.
        
        orig_sql_command method was removed from Lex structure.
      sql/sql_show.cc:
        Fix merge problem.
      sql/sql_yacc.yy:
        orig_sql_command member removed from Lex structure in 5.1 .
      b01c89ed
    • unknown's avatar
      Bug#31630 debug assert with explain extended select ... from i_s · dacf99b5
      unknown authored
      added 'in_rows' column value for 'describe extended' for the case 
      when 'describe' handles I_S table
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_select.cc:
        added 'in_rows' column value for 'describe extended' for the case 
        when 'describe' handles I_S table
      dacf99b5
  22. 29 Oct, 2007 1 commit
  23. 23 Oct, 2007 1 commit
    • unknown's avatar
      Bug#31633 Information schema = NULL queries crash the server · 565c105c
      unknown authored
      added correct handling of NULL values for lookup fields
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        added correct handling of NULL values for lookup fields
      565c105c
  24. 17 Oct, 2007 3 commits
    • unknown's avatar
      Further clean-up. · 1fc9612c
      unknown authored
      configure.in:
        Change description of profiling option.
      mysql-test/r/information_schema.result:
        Remove community-server-only feature test.  It's already in 
        "variables+c" test.
      1fc9612c
    • unknown's avatar
      Fix result files (BUG#24923). · 3fe4de96
      unknown authored
      3fe4de96
    • unknown's avatar
      Bug#31381 Error in retrieving Data from INFORMATION_SCHEMA · 666efa1c
      unknown authored
      move 'table_collation' field filling outside of if(file) condition
      because this field has 'OPEN_FRM_ONLY' attribute
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_show.cc:
        move 'table_collation' field filling outside of if(file) condition
        because this field has 'OPEN_FRM_ONLY' attribute
      666efa1c
  25. 05 Oct, 2007 1 commit
  26. 04 Oct, 2007 1 commit
    • unknown's avatar
      Bug#30079 A check for "hidden" I_S tables is flawed · 4ae273e3
      unknown authored
      added check for hidden I_S tables for 'show columns|keys' commands
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      sql/sql_parse.cc:
        added check for hidden I_S tables for 'show columns|keys' commands
      4ae273e3
  27. 28 Sep, 2007 2 commits
  28. 20 Sep, 2007 1 commit
    • unknown's avatar
      Bug#27747 database metadata doesn't return sufficient column default info · fac190a2
      unknown authored
      added get_field_default_value() function which obtains default value from the field
      (used in store_create_info() & get_schema_column_record() functions)
      
      
      mysql-test/r/alter_table.result:
        result fix
      mysql-test/r/create.result:
        result fix
      mysql-test/r/ctype_collate.result:
        result fix
      mysql-test/r/ctype_recoding.result:
        result fix
      mysql-test/r/default.result:
        result fix
      mysql-test/r/gis.result:
        result fix
      mysql-test/r/grant.result:
        result fix
      mysql-test/r/information_schema.result:
        result fix
      mysql-test/r/key.result:
        result fix
      mysql-test/r/mysql.result:
        result fix
      mysql-test/r/ps_1general.result:
        result fix
      mysql-test/r/show_check.result:
        result fix
      mysql-test/r/sp.result:
        result fix
      mysql-test/r/type_enum.result:
        result fix
      mysql-test/r/type_ranges.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      fac190a2
  29. 21 Aug, 2007 1 commit
  30. 20 Aug, 2007 1 commit
  31. 09 Aug, 2007 1 commit
    • unknown's avatar
      Bug#30310 wrong result on SELECT * FROM INFORMATION_SCHEMA.SCHEMATA WHERE .. · 4144c032
      unknown authored
      1. added check to fill_schema_schemata() func.
         if we have db lookup value we should check that db exists
      2. added check to get_all_tables() func
         if we have lookup db name or tables name values we shoud check that
         these values are not empty strings
      3. fixed typo
      
      
      mysql-test/r/information_schema.result:
        test result
      mysql-test/t/information_schema.test:
        test case
      4144c032
  32. 02 Aug, 2007 1 commit
    • unknown's avatar
      WL#3732 Information schema optimization · 82d28fad
      unknown authored
      client/mysqldump.c:
        table type compare is changed to case insensitive
      mysql-test/r/information_schema.result:
        test result
      mysql-test/r/information_schema_db.result:
        result fix
      mysql-test/suite/ndb/r/ndb_alter_table.result:
        result fix
      mysql-test/suite/ndb/r/ndb_temporary.result:
        result fix
      mysql-test/t/information_schema.test:
        test case
      sql/ha_ndbcluster.cc:
        char* variables are changed to LEX_STRING
      sql/ha_ndbcluster.h:
        char* variables are changed to LEX_STRING
      sql/ha_ndbcluster_binlog.cc:
        char* variables are changed to LEX_STRING
      sql/handler.cc:
        char* variables are changed to LEX_STRING
      sql/handler.h:
        char* variables are changed to LEX_STRING
      sql/sql_base.cc:
        Modified functions which are used during open table process
        according to table opening method and requested_object.
      sql/sql_select.cc:
        Add support for I_S tables into select_describe() function
      sql/sql_show.cc:
        1. Added initialization of 'open_method' to 'st_field_info' structs.
        2. Added initialization of 'i_s_requested_object' to 'ST_SCHEMA_TABLE' structs.
        3. New function which calculates database name and table name values 
           from 'where' condition if it's possible
           void get_lookup_field_values(THD *thd, COND *cond, TABLE_LIST *table,
                                        LOOKUP_FIELD_VALUES *lookup_field_vals);
        4. New function which set table open method
           setup_table_open_method(TABLE_LIST *tables,
                                   ST_SCHEMA_TABLE *schema_table,
                                   enum enum_schema_tables schema_table_idx)
        5. New function
           int make_db_list(THD *thd, List<LEX_STRING> *files,
                            LOOKUP_FIELD_VALUES *lookup_field_vals,
                            bool *with_i_schema)
        6. New function
           int make_table_name_list(THD *thd, List<LEX_STRING> *files, LEX *lex,
                                    LOOKUP_FIELD_VALUES *lookup_field_vals,
                                    bool with_i_schema, LEX_STRING *db_name)
        7. Modified 'get_all_tables' function according to new schema(see wl#3732).
      sql/sql_show.h:
        char* variables are changed to LEX_STRING
      sql/table.cc:
        Modified functions which are used during open table process
        according to table opening method and requested_object.
      sql/table.h:
        1. added new constants(open_method)
        #define SKIP_OPEN_TABLE 0
        #define OPEN_FRM_ONLY   1
        #define OPEN_FULL_TABLE 2
            
        2. Added new field 'open_method' into struct st_field_info;
           uint open_method;
            
        3. Added new field into ST_SCHEMA_TABLE struct
           uint i_s_requested_object;  /* the object we need to open(TABLE | VIEW) */.
        4. Added new field to TABLE_LIST struct.
           uint i_s_requested_object;
           This field is set from ST_SCHEMA_TABLE.i_s_requested_object
           for processed table before opening.
            
        5. Added new fields to TABLE_LIST struct, used for 'explain select' for I_S table
           bool has_db_lookup_value;
           bool has_table_lookup_value;
           uint table_open_method;
      sql/unireg.h:
        added new constants
      82d28fad
  33. 11 Jul, 2007 1 commit
    • unknown's avatar
      A fix and a test case for Bug#25859 ALTER DATABASE works w/o parameters. · 0bc3e69f
      unknown authored
      Fix the parser to make the database options not optional.
      
      
      mysql-test/r/information_schema.result:
        Update results (Bug#25859)
      mysql-test/t/information_schema.test:
        Add a test case for Bug#25859 "ALTER DATABASE works w/o parameters"
      sql/sql_yacc.yy:
        Fix Bug#25859 ALTER DATABASE works w/o parameters - require
        parameters in the parser.
      0bc3e69f
  34. 02 Jul, 2007 1 commit
    • unknown's avatar
      Merge fix-up. · ae5c3bf8
      unknown authored
      BitKeeper/deleted/.del-create_manifest.js:
        Delete: win/create_manifest.js
      BitKeeper/deleted/.del-mysql_manifest.cmake:
        Delete: win/mysql_manifest.cmake
      mysql-test/r/information_schema.result:
        Move the test down.
      ae5c3bf8