1. 02 Dec, 2003 1 commit
    • unknown's avatar
      There is no reason that Intvar_log_event's constructor calls Log_event::Log_event() · b9418600
      unknown authored
      instead of Log_event::Log_event(THD*, ...) when the event is built in the master
      to be written in the binlog.
      Rand_log_event already used the good constructor, so there really is no reason
      for Intvar_log_event to be an exception.
      This fixes a test failure of last night (which appeared after I removed a useless
      e.server_id=thd->server_id in log.cc; in fact this line was not useless because
      it hid the bad constructor).
      Replication tests pass, with Valgrind too.
      
      
      sql/log_event.h:
        There is no reason that Intvar_log_event's constructor calls Log_event::Log_event()
        instead of Log_event::Log_event(THD*, ...) when the event is built in the master
        to be written in the binlog.
        Rand_log_event already used the good constructor, so there really is no reason
        for Intvar_log_event to be an exception.
        This fixes a test failure of last night (which appeared after I removed a useless
        e.server_id=thd->server_id in log.cc; in fact this line was not useless because
        it hid the bad constructor).
      b9418600
  2. 01 Dec, 2003 2 commits
  3. 28 Nov, 2003 7 commits
  4. 27 Nov, 2003 3 commits
  5. 26 Nov, 2003 2 commits
  6. 25 Nov, 2003 3 commits
  7. 24 Nov, 2003 3 commits
    • unknown's avatar
      - Rephrased two option help texts to not start with "use the ..." as this · 534ea968
      unknown authored
         confuses RPM's Perl module dependency checking (it adds a bogus
         requirement to "Perl(the)", as "use" is a Perl keyword). (BUG#1931)
      
      
      scripts/mysqlaccess.sh:
         - Rephrased option help text so it does not start with "use" as this 
           confuses RPM's Perl module dependency checking (it adds a bogus
           requirement to "Perl(the)", as "use" is a Perl keyword). (BUG#1931)
      sql-bench/bench-init.pl.sh:
         - Rephrased option help text so it does not start with "use" as this 
           confuses RPM's Perl module dependency checking (it adds a bogus
           requirement to "Perl(the)", as "use" is a Perl keyword). (BUG#1931)
      534ea968
    • unknown's avatar
      Merge mysql.com:/space/my/mysql-4.0 · cbf2558b
      unknown authored
      into mysql.com:/space/my/mysql-4.0-build
      
      
      cbf2558b
    • unknown's avatar
      Fixed Bug#1907, option of type GET_BOOL with arg type OPT_ARG · 5281f34e
      unknown authored
      did not call get_one_option().
      
      
      5281f34e
  8. 23 Nov, 2003 1 commit
  9. 21 Nov, 2003 1 commit
  10. 20 Nov, 2003 6 commits
  11. 19 Nov, 2003 3 commits
  12. 18 Nov, 2003 3 commits
    • unknown's avatar
      Bug#1826, HANDLER+ALTER TABLE=crash (unfortunately, it cannot be tested in mysql-test suite) · a36145a8
      unknown authored
      more user variable tests
      
      
      mysql-test/r/user_var.result:
        more user variable tests (just to have this behaviour written down somewhere)
      mysql-test/t/user_var.test:
        more user variable tests (just to have this behaviour written down somewhere)
      sql/sql_handler.cc:
        Bug#1826, HANDLER+ALTER TABLE=crash
        (unfortunately, it cannot be tested in mysql-test suite)
      a36145a8
    • unknown's avatar
      Merge gbichot@bk-internal.mysql.com:/home/bk/mysql-4.0 · 40c951a0
      unknown authored
      into mysql.com:/home/mysql_src/mysql-4.0
      
      
      40c951a0
    • unknown's avatar
      Fix for BUG#1870 · 80649ee8
      unknown authored
          "CHANGE MASTER makes SQL thread restart from coordinates of I/O thread".
          So, in CHANGE MASTER:
          when it seems reasonable that the user did not want to discontinue
          its replication (i.e. when he is not specifying host or port or master_log_file
          or master_log_pos; this will be documented), set the coordinates of the
          I/O thread to those of the SQL thread. This way, the SQL thread will see
          no discontinuity in the relay log (i.e. will skip no events), because
          the I/O thread will fill the brand new relay log with the events which
          are just after the position where the SQL thread had stopped
          (before CHANGE MASTER was issued).
          And a new test for this bug.
      
      
      mysql-test/r/rpl_loaddata.result:
        Now, after CHANGE MASTER the coordinates of the I/O thread are the last ones of the SQL thread, so result update.
      sql/sql_repl.cc:
        Fix for BUG#1870
        "CHANGE MASTER makes SQL thread restart from coordinates of I/O thread".
        So, in CHANGE MASTER:
        when it seems reasonable that the user did not want to discontinue
        its replication (i.e. when he is not specifying host or port or master_log_file
        or master_log_pos; this will be documented), set the coordinates of the
        I/O thread to those of the SQL thread. This way, the SQL thread will see
        no discontinuity in the relay log (i.e. will skip no events), because
        the I/O thread will fill the brand new relay log with the events which
        are just after the position where the SQL thread had stopped
        (before CHANGE MASTER was issued).
      80649ee8
  13. 17 Nov, 2003 5 commits